Re: RFR: JDK-8326853 Missing @since tags for Charset related methods added in Java 10 [v7]

2024-03-19 Thread Justin Lu
On Tue, 19 Mar 2024 17:05:50 GMT, Nizar Benalla wrote: >> src/java.base/share/classes/java/nio/channels/Channels.java line 2: >> >>> 1: /* >>> 2: * Copyright (c) 2000, 2023, 2024, Oracle and/or its affiliates. All >>> rights reserved. >> >> Thanks for updating, but needs a little adjustment.

Re: RFR: JDK-8326853 Missing @since tags for Charset related methods added in Java 10 [v7]

2024-03-19 Thread Nizar Benalla
On Tue, 19 Mar 2024 16:13:49 GMT, Justin Lu wrote: >> Nizar Benalla has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update the latter years for the Oracle copyrights > > src/java.base/share/classes/java/nio/channels/Channels.java line

Re: RFR: JDK-8326853 Missing @since tags for Charset related methods added in Java 10 [v7]

2024-03-19 Thread Justin Lu
On Tue, 19 Mar 2024 10:54:41 GMT, Nizar Benalla wrote: >> # Issue >> - JDK-8326853 Incorrect @\since Tags for Charset Related Methods Added in >> JDK 10 >> >> I changed the @\since tags to better accurately show when the methods and >> constructors were introduced. > > Nizar Benalla has

Re: RFR: JDK-8326853 Missing @since tags for Charset related methods added in Java 10 [v7]

2024-03-19 Thread Nizar Benalla
> # Issue > - JDK-8326853 Incorrect @\since Tags for Charset Related Methods Added in JDK > 10 > > I changed the @\since tags to better accurately show when the methods and > constructors were introduced. Nizar Benalla has updated the pull request incrementally with one additional commit