Re: curl websockets

2021-06-23 Thread Dan Fandrich via curl-library
On Thu, Jun 24, 2021 at 12:03:41AM +0200, Daniel Stenberg via curl-library wrote: > Even if I having been educated in this thread have realized that the > curl_easy_recv and curl_easy_send calls won't work for this as-is, so we > should therefore probably consider adding special-purpose websocket

Re: curl websockets

2021-06-23 Thread Daniel Stenberg via curl-library
On Wed, 23 Jun 2021, Weston Schmidt via curl-library wrote: You bring up an interesting point that I don't have a good answer for - how should the easy interface work? I struggled with it when working on the curlws code & decided to avoid it in favor of the multi api. If there is a good

Re: curl websockets

2021-06-23 Thread Weston Schmidt via curl-library
> There’d be want, IMO, for interfaces that differentiate sending/receiving > full messages versus per-frame. (And, of course, sending text versus binary, > *maybe* flexibly enough to accommodate potential new message types were that > ever to happen.) And callbacks for multi-mode? This makes

Re: curl websockets

2021-06-23 Thread Tomalak Geret'kal via curl-library
On 23/06/2021 20:23, Weston Schmidt wrote: > Support for ws(s):// appears to depend on both the client and server > handling the scheme. I'd imagine if we chose some reasonable defaults > like wss:// implies websocket and provide the ability to request that > an https:// be handled as a websocket

Re: curl websockets

2021-06-23 Thread Weston Schmidt via curl-library
Support for ws(s):// appears to depend on both the client and server handling the scheme. I'd imagine if we chose some reasonable defaults like wss:// implies websocket and provide the ability to request that an https:// be handled as a websocket via a CURLOPT that might make it easy to use. Wes

Re: curl websockets

2021-06-23 Thread Daniel F via curl-library
W dniu 2021-06-23 17:59, Felipe Gasper via curl-library napisał(a): On Jun 23, 2021, at 11:23 AM, Daniel Stenberg via curl-library wrote: On Tue, 22 Jun 2021, Weston Schmidt via curl-library wrote: I'm interested in feedback or suggestions for what/how to define a good websocket API that

Re: curl websockets

2021-06-23 Thread Felipe Gasper via curl-library
> On Jun 23, 2021, at 11:23 AM, Daniel Stenberg via curl-library > wrote: > > On Tue, 22 Jun 2021, Weston Schmidt via curl-library wrote: > >> I'm interested in feedback or suggestions for what/how to define a good >> websocket API that complements libcurl. > > My very simple idea on how it

Re: curl websockets

2021-06-23 Thread Tomalak Geret'kal via curl-library
On 23/06/2021 16:38, Henrik Holst via curl-library wrote: > Would it not be better to use the normal URI used for > Websockets which are "ws(s)://" instead of the http(s) or > am I missing something? Yes, this. Cheers ---

Re: curl websockets

2021-06-23 Thread Tomalak Geret'kal via curl-library
On 23/06/2021 16:23, Daniel Stenberg via curl-library wrote: > On Tue, 22 Jun 2021, Weston Schmidt via curl-library wrote: > >> I'm interested in feedback or suggestions for what/how to >> define a good websocket API that complements libcurl. > > My very simple idea on how it could be added to the

Re: curl websockets

2021-06-23 Thread Henrik Holst via curl-library
Would it not be better to use the normal URI used for Websockets which are "ws(s)://" instead of the http(s) or am I missing something? /HH Den ons 23 juni 2021 kl 17:28 skrev Daniel Stenberg via curl-library < curl-library@cool.haxx.se>: > On Tue, 22 Jun 2021, Weston Schmidt via curl-library

Re: curl websockets

2021-06-23 Thread Daniel Stenberg via curl-library
On Tue, 22 Jun 2021, Weston Schmidt via curl-library wrote: I'm interested in feedback or suggestions for what/how to define a good websocket API that complements libcurl. My very simple idea on how it could be added to the API: 1. We add another value to set CURLOPT_CONNECT_ONLY to (2). If

Re: libcurl hangs in curl_multi_cleanup

2021-06-23 Thread Daniel Stenberg via curl-library
On Wed, 23 Jun 2021, firefo...@interia.pl wrote: So, since 215db086e0 test660 ensures wrong behavior of libcurl. Since we try to have tests for *everything* curl can do, so the fact that we verify bugs is what is *supposed* to happen. Until we realize it is a bug, it isn't a bug and then it

Re: libcurl hangs in curl_multi_cleanup

2021-06-23 Thread FirefoxOS--- via curl-library
Dnia 2021-06-10, o godz. 17:48:26 Daniel Stenberg napisał(a): > On Thu, 10 Jun 2021, Firefox OS wrote: > > > The story is the same as 2 years ago > > You perceive it as the same, I do not. The previous issue was > reproduced with and then verified with test 660 and that test case > still

feature freeze for 7.78.0

2021-06-23 Thread Daniel Stenberg via curl-library
Hello friends! The door is now officially closed for new features for the next release. Now we just merge bug-fixes until July 21 when we intend to ship the next curl release. Happy hunting! -- / daniel.haxx.se | Commercial curl support up to 24x7 is available! | Private help, bug

Re: libcurl hangs in curl_multi_cleanup

2021-06-23 Thread Daniel Stenberg via curl-library
On Tue, 22 Jun 2021, FirefoxOS via curl-library wrote: Thanks for creating a test case. I've now made a PR that I believe fixes this issue: https://github.com/curl/curl/pull/7288 ... and the test 677 is included there and reproduces the bug before this fix. -- / daniel.haxx.se |