Bug#458742: lintian: Please test for valid filenames for run-parts
Package: lintian Version: 1.23.41 Severity: wishlist In tomcat5.5 we have the problem that a script in /etc/cron.daily is not executed because the script name contained a .. Then run-parts ignores that file. It would be nice if lintian could check this dir (and others) for sich files and give a warning/error. Cheers, Michael -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.22-3-vserver-amd64 (SMP w/4 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages lintian depends on: ii binutils2.18.1~cvs20071027-2 The GNU assembler, linker and bina ii diffstat1.45-2 produces graph of changes introduc ii dpkg-dev1.14.14 package building tools for Debian ii file4.21-4 Determines file type using magic ii gettext 0.17-2 GNU Internationalization utilities ii intltool-debian 0.35.0+20060710.1Help i18n of RFC822 compliant conf ii libparse-debianchan 1.1.1-1 parse Debian changelogs and output ii liburi-perl 1.35.dfsg.1-1Manipulates and accesses URI strin ii man-db 2.5.0-4 on-line manual pager ii perl [libdigest-md5 5.8.8-12 Larry Wall's Practical Extraction lintian recommends no packages. -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
www.ringtones-now.com.ar
Please see this site in Subject
Bug#458785: [checks/fields] *-dbg packages should not have empty dependencies
Package: lintian Version: 1.23.41 Severity: wishlist *-dbg packages should depend on the package for which they're providing debugging symbols, generally with an (= ${binary:Version) dependency, to ensure consistency between the debugging symbols and the package. -- System Information: Debian Release: lenny/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.22-3-686 (SMP w/1 CPU core) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages lintian depends on: ii binutils2.18.1~cvs20071027-1 The GNU assembler, linker and bina ii diffstat1.45-2 produces graph of changes introduc ii dpkg-dev1.14.14 package building tools for Debian ii file4.21-3 Determines file type using magic ii gettext 0.16.1-2 GNU Internationalization utilities ii intltool-debian 0.35.0+20060710.1Help i18n of RFC822 compliant conf ii libparse-debianchan 1.1.1-1 parse Debian changelogs and output ii liburi-perl 1.35.dfsg.1-1Manipulates and accesses URI strin ii man-db 2.5.0-4 on-line manual pager ii perl [libdigest-md5 5.8.8-12 Larry Wall's Practical Extraction lintian recommends no packages. -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r1083 - in trunk: debian reporting reporting/templates
Author: rra Date: 2008-01-03 01:04:10 +0100 (Thu, 03 Jan 2008) New Revision: 1083 Added: trunk/reporting/lintian.css trunk/reporting/templates/ trunk/reporting/templates/clean.tmpl trunk/reporting/templates/index.tmpl trunk/reporting/templates/maintainer.tmpl trunk/reporting/templates/maintainers.tmpl trunk/reporting/templates/packages.tmpl trunk/reporting/templates/tag.tmpl trunk/reporting/templates/tags.tmpl Modified: trunk/debian/changelog trunk/debian/control trunk/debian/copyright trunk/reporting/html_reports Log: * debian/control: + [RA] Suggest libtext-template-perl, needed for HTML reporting. * reporting/html_reports: + [RA] Rewritten. - Include info, experimental, and overridden tags in the tag pages. - Generate a second report for each maintainer showing all tags. - Correctly handle multiple different maintainer strings with the same e-mail address. - Correctly report the version number of a binary package when it differs from the source package. (Closes: #458036) - Formatting changes (hopefully improvements) to the web pages. - New template-driven system for easier revision of the HTML. * reporting/lintian.css: + [RA] New minimal style sheet for the HTML reports. * reporting/templates/*: + [RA] New Text::Template page templates for the HTML reports. Modified: trunk/debian/changelog === --- trunk/debian/changelog 2007-12-18 20:58:27 UTC (rev 1082) +++ trunk/debian/changelog 2008-01-03 00:04:10 UTC (rev 1083) @@ -2,14 +2,32 @@ * checks/control-file{.desc,}: + [RA] Include the package name in stronger-dependency-implies-weaker. + + * debian/control: ++ [RA] Suggest libtext-template-perl, needed for HTML reporting. * lib/Dep.pm: + [RA] Allow substvars instead of package names so that dependency checks against the source debian/control file don't treat all substvars as equivalent. Thanks, Julien Cristau. (Closes: #456802) - -- Russ Allbery [EMAIL PROTECTED] Tue, 18 Dec 2007 12:58:17 -0800 + * reporting/html_reports: ++ [RA] Rewritten. + - Include info, experimental, and overridden tags in the tag pages. + - Generate a second report for each maintainer showing all tags. + - Correctly handle multiple different maintainer strings with the +same e-mail address. + - Correctly report the version number of a binary package when it +differs from the source package. (Closes: #458036) + - Formatting changes (hopefully improvements) to the web pages. + - New template-driven system for easier revision of the HTML. + * reporting/lintian.css: ++ [RA] New minimal style sheet for the HTML reports. + * reporting/templates/*: ++ [RA] New Text::Template page templates for the HTML reports. + -- Russ Allbery [EMAIL PROTECTED] Wed, 02 Jan 2008 16:01:02 -0800 + lintian (1.23.41) unstable; urgency=low The it would be lovely if there were an actual desktop file standard Modified: trunk/debian/control === --- trunk/debian/control2007-12-18 20:58:27 UTC (rev 1082) +++ trunk/debian/control2008-01-03 00:04:10 UTC (rev 1083) @@ -14,7 +14,7 @@ Depends: perl, libdigest-md5-perl | perl ( 5.8), dpkg-dev (= 1.13.17), file, binutils, diffstat (= 1.27-1), man-db (= 2.3.20-1), gettext (= 0.16), intltool-debian, libparse-debianchangelog-perl (= 0.6), liburi-perl -Suggests: binutils-multiarch +Suggests: binutils-multiarch, libtext-template-perl Description: Debian package checker Lintian dissects Debian packages and reports bugs and policy violations. It contains automated checks for many aspects of Debian Modified: trunk/debian/copyright === --- trunk/debian/copyright 2007-12-18 20:58:27 UTC (rev 1082) +++ trunk/debian/copyright 2008-01-03 00:04:10 UTC (rev 1083) @@ -30,6 +30,7 @@ Portions Copyright (C) 2004 Jeroen van Wolffelaar Portions Copyright (C) 2005 René van Bevern Portions Copyright (C) 2006 Adeodato Simó +Portions Copyright (C) 2007, 2008 Russ Allbery This program is free software; you may redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -41,8 +42,8 @@ fitness for a particular purpose. See the GNU General Public License for more details. -A copy of the GNU General Public License is available as -/usr/share/common-licenses/GPL in the Debian GNU/Linux distribution +A copy of the GNU General Public License version 2 is available as +/usr/share/common-licenses/GPL-2 in the Debian GNU/Linux distribution or on the World Wide Web at http://www.gnu.org/copyleft/gpl.html. You can also obtain it by writing to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. Modified:
lintian: r1084 - trunk/debian
Author: rra Date: 2008-01-03 01:04:41 +0100 (Thu, 03 Jan 2008) New Revision: 1084 Modified: trunk/debian/changelog Log: Add missing changelog entries from the last commit. Modified: trunk/debian/changelog === --- trunk/debian/changelog 2008-01-03 00:04:10 UTC (rev 1083) +++ trunk/debian/changelog 2008-01-03 00:04:41 UTC (rev 1084) @@ -5,6 +5,9 @@ * debian/control: + [RA] Suggest libtext-template-perl, needed for HTML reporting. + * debian/copyright: ++ [RA] Add my copyright statement. ++ [RA] Reference GPL-2, not the GPL symlink, reflecting our license. * lib/Dep.pm: + [RA] Allow substvars instead of package names so that dependency -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r1083
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r1083 by rra tag 458036 + pending Bug#458036: lintian.debian.org shows warnings about wrong version There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
New lintian pages available for testing
I have finished testing my new version of lintian's html_reports script and have put up the pages it generates in a temporary location for people to look at. Please take a look at: http://lintian.debian.org/reports-testing/ and let me know what's broken. Some notes: * The HTML is intentionally very minimalistic. I want to get the basic functionality working and then will post a general call for volunteers to redo the templates to match whatever people consider to be a Debian web page style these days. I'm slow and not very good at doing such things, so I did something simple and structural and will try to find a volunteer to tackle the HTML. * The HTML pages are now templatized (using Text::Template). The core of many of the pages is still generated by some not-horribly-pleasant Perl embedded in the templates, but all of the transformation from data to HTML should now be in the templates so that someone can modify them independent of the main script. (In the long run, this will also permit Debian derivatives to put up their own themed pages, although I wouldn't recommend this yet since the script and the interface are likely to be in flux for a while.) * These pages were generated manually and won't refresh daily like the regular lintian reports. New features present in this version: * There are tag pages for every tag, including experimental (although we have none of those at present) and info tags. The page for a tag shows the overridden tags as well as those that aren't. * The tag index also gives a count of how many packages have overridden that tag. * There are two reports for each maintainer. The one under maintainer, matching the existing URL scheme, shows errors and warnings as before. The one under full shows all tags, including info and overridden tags. The tag index links to the full page, and the maintainer index links to both. * If a binary package has a different version from the source package, that's shown with a separate heading, allowing one to quickly see when lintian tags may linger due to slow builds on i386, or when a package has been rebuilt with a binNMU. Bug fixes in this version: * Multiple maintainers with the same e-mail address will have all their packages listed together on one page, rather than having the last maintainer seen overwrite the report of the previous maintainers. This particularly affects packaging teams, since our packaging teams have a regrettable tendency to use many different variations of the team name in their packages. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#458074: lintian: detect template README.Debian
Joerg Jaspert [EMAIL PROTECTED] writes: Package: lintian Severity: normal Hi would be nice if lintian would Warn if Readme.Debian is the template From dh-make. Just looking for the string possible notes regarding this package - if none, delete this file should do the trick. There was a test for this, but it required that the whole file match exactly the dh-make template. I've now relaxed that to just look for that particular phrase. Similar warnings can be given for .ex files if its not done yet (not sure there) Yup, have that. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r1085 - in trunk: checks debian testset
Author: rra Date: 2008-01-03 02:37:35 +0100 (Thu, 03 Jan 2008) New Revision: 1085 Modified: trunk/checks/debian-readme trunk/checks/debian-readme.desc trunk/debian/changelog trunk/testset/tags.dh-test Log: * checks/debian-readme{.desc,}: + Combine readme-debian-{is,contains}-debmake-template and be less particular about the exact formatting of the dh-make template. Triggering off the template text is enough and matches linda. Thanks, Joerg Jaspert. (Closes: #458074) Modified: trunk/checks/debian-readme === --- trunk/checks/debian-readme 2008-01-03 00:04:41 UTC (rev 1084) +++ trunk/checks/debian-readme 2008-01-03 01:37:35 UTC (rev 1085) @@ -38,16 +38,12 @@ close(IN); } -$template = -.* for DEBIAN\n . --+\n\n . -(Comments regarding the Package|So far nothing to say\.| . -possible notes regarding this package - if none, delete this file . -)\n\n . -.*.*,.*\n; -if ($readme =~ m/$template/iom) { -tag(readme-debian-is-debmake-template); -} elsif ($readme =~ m/^So far nothing to say/m) { +my @template = +('Comments regarding the Package', + 'So far nothing to say', + 'possible notes regarding this package - if none, delete this file'); +my $regex = join ('|', @template); +if ($readme =~ m/$regex/io) { tag(readme-debian-contains-debmake-template); } elsif ($readme =~ m/^\s*-- [^]*[^ [EMAIL PROTECTED]/m) { tag(readme-debian-contains-debmake-default-email-address); @@ -58,3 +54,9 @@ } 1; + +# Local Variables: +# indent-tabs-mode: nil +# cperl-indent-level: 4 +# End: +# vim: syntax=perl sw=4 sts=4 ts=4 et shiftround Modified: trunk/checks/debian-readme.desc === --- trunk/checks/debian-readme.desc 2008-01-03 00:04:41 UTC (rev 1084) +++ trunk/checks/debian-readme.desc 2008-01-03 01:37:35 UTC (rev 1085) @@ -4,20 +4,20 @@ Type: binary Unpack-Level: 1 Needs-Info: debian-readme -Info: This script looks at the README.Debian file installed by the - package (if any) to see if it is the debmake template. +Info: This script checks the README.Debian file for various problems. -Tag: readme-debian-is-debmake-template -Type: warning -Info: The README.Debian file installed by this package is merely the - template provided by deb-make or dh_make, and contains no information. - If there is nothing useful to say there, then the file is best removed. - Tag: readme-debian-contains-debmake-template Type: warning -Info: The README.Debian file installed by this package contains the - deb-make default phrase So far nothing to say. If there is nothing - to say in the file, then it is best removed. +Info: The README.Debian file installed by this package contains one of the + template phrases from the README.Debian provided by deb-make or dh_make: + . + Comments regarding the package + So far nothing to say + lt;possible notes regarding this package - if none, delete this filegt; + . + If there is real information in the file, please delete any generic + template phrases. If there is nothing to say in the file, it is best + removed. Tag: readme-debian-contains-debmake-default-email-address Type: warning Modified: trunk/debian/changelog === --- trunk/debian/changelog 2008-01-03 00:04:41 UTC (rev 1084) +++ trunk/debian/changelog 2008-01-03 01:37:35 UTC (rev 1085) @@ -2,6 +2,11 @@ * checks/control-file{.desc,}: + [RA] Include the package name in stronger-dependency-implies-weaker. + * checks/debian-readme{.desc,}: ++ Combine readme-debian-{is,contains}-debmake-template and be less + particular about the exact formatting of the dh-make template. + Triggering off the template text is enough and matches linda. + Thanks, Joerg Jaspert. (Closes: #458074) * debian/control: + [RA] Suggest libtext-template-perl, needed for HTML reporting. Modified: trunk/testset/tags.dh-test === --- trunk/testset/tags.dh-test 2008-01-03 00:04:41 UTC (rev 1084) +++ trunk/testset/tags.dh-test 2008-01-03 01:37:35 UTC (rev 1085) @@ -9,5 +9,5 @@ W: dh-test source: out-of-date-standards-version 3.6.2 (current is 3.7.3) W: dh-test source: package-uses-deprecated-debhelper-compat-version 3 W: dh-test: new-package-should-close-itp-bug -W: dh-test: readme-debian-is-debmake-template +W: dh-test: readme-debian-contains-debmake-template W: dh-test: wrong-bug-number-in-closes l3:# -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r1085
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r1085 by rra tag 458074 + pending Bug#458074: lintian: detect template README.Debian There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r1086 - in trunk: checks debian frontend testset
Author: rra Date: 2008-01-03 02:51:15 +0100 (Thu, 03 Jan 2008) New Revision: 1086 Modified: trunk/checks/files.desc trunk/debian/changelog trunk/frontend/lintian trunk/testset/runtests Log: * debian/files.desc: + [RA] Remove a stray variable from the config-file-reserved tag. * frontend/lintian: + [RA] Allow + and . in tag names in overrides. Thanks, Stefan Fritsch. (Closes: #454790) * testset/runtests: + [RA] Test tags for valid characters. Modified: trunk/checks/files.desc === --- trunk/checks/files.desc 2008-01-03 01:37:35 UTC (rev 1085) +++ trunk/checks/files.desc 2008-01-03 01:51:15 UTC (rev 1086) @@ -77,7 +77,7 @@ paths. Ref: policy 11.8.7 -Tag: config-file-reserved $file +Tag: config-file-reserved Type: error Info: This file is reserved by a specific package. Please email the maintainer of the package in question if you have questions. Modified: trunk/debian/changelog === --- trunk/debian/changelog 2008-01-03 01:37:35 UTC (rev 1085) +++ trunk/debian/changelog 2008-01-03 01:51:15 UTC (rev 1086) @@ -7,12 +7,18 @@ particular about the exact formatting of the dh-make template. Triggering off the template text is enough and matches linda. Thanks, Joerg Jaspert. (Closes: #458074) + * debian/files.desc: ++ [RA] Remove a stray variable from the config-file-reserved tag. * debian/control: + [RA] Suggest libtext-template-perl, needed for HTML reporting. * debian/copyright: + [RA] Add my copyright statement. + [RA] Reference GPL-2, not the GPL symlink, reflecting our license. + + * frontend/lintian: ++ [RA] Allow + and . in tag names in overrides. Thanks, Stefan + Fritsch. (Closes: #454790) * lib/Dep.pm: + [RA] Allow substvars instead of package names so that dependency @@ -34,6 +40,9 @@ * reporting/templates/*: + [RA] New Text::Template page templates for the HTML reports. + * testset/runtests: ++ [RA] Test tags for valid characters. + -- Russ Allbery [EMAIL PROTECTED] Wed, 02 Jan 2008 16:01:02 -0800 lintian (1.23.41) unstable; urgency=low Modified: trunk/frontend/lintian === --- trunk/frontend/lintian 2008-01-03 01:37:35 UTC (rev 1085) +++ trunk/frontend/lintian 2008-01-03 01:51:15 UTC (rev 1086) @@ -1290,7 +1290,7 @@ s/\s+/ /go; my $override = $_; $override =~ s/^\Q$pkg\E( \Q$long_type\E)?: //; -if ($override eq '' or $override !~ /^[\w0-9-]+(\s+.*)?$/) { +if ($override eq '' or $override !~ /^[\w0-9.+-]+(\s+.*)?$/) { tag ('malformed-override', $_); } else { Tags::add_override($override); Modified: trunk/testset/runtests === --- trunk/testset/runtests 2008-01-03 01:37:35 UTC (rev 1085) +++ trunk/testset/runtests 2008-01-03 01:51:15 UTC (rev 1086) @@ -134,6 +134,10 @@ for my $i (read_dpkg_control($desc_file)) { $desc_file =~ s#.*/##; if (exists $i-{'tag'}) { + if ($i-{'tag'} !~ /^[\w0-9.+-]+$/) { + print E: test-tag-has-invalid-characters $i-{'tag'} + . in $desc_file\n; + } if (not exists $i-{'info'}) { print E: test-has-no-info $i-{'tag'} in $desc_file\n; $testok = 0; @@ -321,4 +325,8 @@ return $errcode == 0; } +# Local Variables: +# indent-tabs-mode: t +# cperl-indent-level: 4 +# End: # vim: ts=8 sw=4 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r1086
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r1086 by rra tag 454790 + pending Bug#454790: lintian: bogus malformed-override warnings or documentation wrong There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r1087 - trunk/debian
Author: rra Date: 2008-01-03 03:54:35 +0100 (Thu, 03 Jan 2008) New Revision: 1087 Modified: trunk/debian/changelog Log: Fix file name in changelog. Modified: trunk/debian/changelog === --- trunk/debian/changelog 2008-01-03 01:51:15 UTC (rev 1086) +++ trunk/debian/changelog 2008-01-03 02:54:35 UTC (rev 1087) @@ -7,7 +7,7 @@ particular about the exact formatting of the dh-make template. Triggering off the template text is enough and matches linda. Thanks, Joerg Jaspert. (Closes: #458074) - * debian/files.desc: + * checks/files.desc: + [RA] Remove a stray variable from the config-file-reserved tag. * debian/control: -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r1088 - in trunk: checks debian testset testset/libbaz/debian testset/non-us/debian
Author: rra Date: 2008-01-03 03:56:27 +0100 (Thu, 03 Jan 2008) New Revision: 1088 Added: trunk/testset/libbaz/debian/lib.symbols Modified: trunk/checks/shared-libs trunk/checks/shared-libs.desc trunk/debian/changelog trunk/testset/libbaz/debian/changelog trunk/testset/libbaz/debian/lib.shlibs trunk/testset/libbaz/debian/rules trunk/testset/non-us/debian/rules trunk/testset/tags.libbaz trunk/testset/tags.non-us Log: * checks/shared-libs{.desc,}: + [RA] New check for version numbers in symbol files. Based on a patch from Raphael Hertzog. (Closes: #457067) Modified: trunk/checks/shared-libs === --- trunk/checks/shared-libs2008-01-03 02:54:35 UTC (rev 1087) +++ trunk/checks/shared-libs2008-01-03 02:56:27 UTC (rev 1088) @@ -291,6 +291,12 @@ } # 4th step: check shlibs control file +my $version; +if (open (VERSION, '', 'fields/version')) { +$version = VERSION; +close VERSION; +chomp $version; +} @shlibs = keys %SONAME; if ($#shlibs == -1) { # no shared libraries included in package, thus shlibs control file should @@ -365,13 +371,7 @@ # # Deduplicate the list of dependencies before warning so that we don't # dupliate warnings. - my $provides = $pkg; - if (open (VERSION, '', 'fields/version')) { - my $version = VERSION; - close VERSION; - chomp $version; - $provides .= (= $version); - } + my $provides = $pkg . ( = $version); if (open (PROVIDES, '', 'fields/provides')) { my $line = PROVIDES; close PROVIDES; @@ -389,7 +389,47 @@ } } -# 5th step: check pre- and post- control files +# 5th step: check symbols control file +if (open(IN, '', 'control/symbols')) { +my $version_wo_rev = $version; +$version_wo_rev =~ s/^(.+)-([^-]+)$/$1/; +my ($full_version_count, $full_version_sym) = (0, undef); +my ($debian_revision_count, $debian_revision_sym) = (0, undef); +while (IN) { + next if not /^\s+(\S+)\s(\S+)(?:\s(\d+))?/; + my ($sym, $v, $dep_order) = ($1, $2, $3); + if (($v eq $version) and ($version =~ /-/)) { + $full_version_sym ||= $sym; + $full_version_count++; + } + if (($v =~ /-/) and (not $v =~ /~$/) and ($v ne $version_wo_rev)) { + $debian_revision_sym ||= $sym; + $debian_revision_count++; + } +} +close IN; +if ($full_version_count) { + $full_version_count--; + my $others = ''; + if ($full_version_count 0) { + $others = and $full_version_count others; + } + tag symbols-file-contains-current-version-with-debian-revision, + on symbol $full_version_sym$others +} +if ($debian_revision_count) { + $debian_revision_count--; + my $others = ''; + if ($debian_revision_count 0) { + $others = and $debian_revision_count others; + } + tag symbols-file-contains-debian-revision, + on symbol $debian_revision_sym$others; +} +} + + +# 6th step: check pre- and post- control files if (-f $preinst) { local $_ = slurp_entire_file($preinst); if (/^[^\#]*\bldconfig\b/m) { @@ -464,4 +504,8 @@ 1; +# Local Variables: +# indent-tabs-mode: t +# cperl-indent-level: 4 +# End: # vim: syntax=perl sw=4 ts=8 Modified: trunk/checks/shared-libs.desc === --- trunk/checks/shared-libs.desc 2008-01-03 02:54:35 UTC (rev 1087) +++ trunk/checks/shared-libs.desc 2008-01-03 02:56:27 UTC (rev 1088) @@ -207,3 +207,26 @@ from assembler files which don't define a proper .note.GNU-stack section. +Tag: symbols-file-contains-current-version-with-debian-revision +Type: error +Info: Debian revisions should be stripped from versions in symbols files. + Not doing so leads to dependencies unsatisfiable by backports (1.0-1~bpo + lt;lt; 1.0-1 while 1.0-1~bpo gt;= 1.0). If the debian revision can't + be stripped because the symbol really appearead between two specific + Debian revisions, you should postfix the version with a single ~ + (example: 1.0-3~ if the symbol appeared in 1.0-3). + . + This problem normally means that the symbols were added automatically by + dpkg-gensymbols. dpkg-gensymbols uses the full version number for the + dependency associated to any new symbol that it detects. The maintainer + must update the ttdebian/lt;packagegt;.symbols/tt file by adding + the new symbols with the corresponding upstream version. + +Tag: symbols-file-contains-debian-revision +Type: warning +Info: Debian revisions should be stripped from versions in symbols files. + Not doing so leads to dependencies unsatisfiable by backports (1.0-1~bpo + lt;lt; 1.0-1 while 1.0-1~bpo gt;= 1.0). If the debian revision can't + be stripped because the symbol really appearead between two specific + Debian revisions,
Bug#457067: Patch for symbols support
Raphael Hertzog [EMAIL PROTECTED] writes: Attached is a patch adding support for the checks that I requested. I'd appreciate if it could be integrated quickly. Some review is welcome. It worked quite well on the test package that I used: http://ftp.debian.org/debian/pool/main/t/tokyocabinet/libtokyocabinet1_1.1.4-1_i386.deb Thanks, committed. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r1090
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r1090 by rra tag 457523 + pending Bug#457523: 'dpatch-index-references-non-existant-patch' false positives with multiple patches per line in 00list Tags were: patch Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r1092 - in trunk: checks debian
Author: rra Date: 2008-01-03 05:30:43 +0100 (Thu, 03 Jan 2008) New Revision: 1092 Modified: trunk/checks/control-file.desc trunk/debian/changelog Log: + [RA] Fix stronger-dependency-implies-weaker description cut and paste error. Thanks, Rafael Laboissiere. (Closes: #456405) Modified: trunk/checks/control-file.desc === --- trunk/checks/control-file.desc 2008-01-03 04:28:21 UTC (rev 1091) +++ trunk/checks/control-file.desc 2008-01-03 04:30:43 UTC (rev 1092) @@ -70,7 +70,7 @@ stronger dependency field implies one of the dependencies in a weaker dependency field. In other words, the Depends field of the package requires that one of the packages listed in Recommends or Suggests be - installed, or a package is listed in Recommends as well as Recommends. + installed, or a package is listed in Recommends as well as Suggests. . Current versions of dpkg-gencontrol will silently fix this problem by removing the weaker dependency, but it may indicate a more subtle bug Modified: trunk/debian/changelog === --- trunk/debian/changelog 2008-01-03 04:28:21 UTC (rev 1091) +++ trunk/debian/changelog 2008-01-03 04:30:43 UTC (rev 1092) @@ -2,6 +2,8 @@ * checks/control-file{.desc,}: + [RA] Include the package name in stronger-dependency-implies-weaker. ++ [RA] Fix stronger-dependency-implies-weaker description cut and + paste error. Thanks, Rafael Laboissiere. (Closes: #456405) * checks/debian-readme{.desc,}: + Combine readme-debian-{is,contains}-debmake-template and be less particular about the exact formatting of the dh-make template. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r1092
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r1092 by rra tag 456405 + pending Bug#456405: lintian: Typo in stronger-dependency-implies-weaker Info Tags were: patch Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r1091
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r1091 by rra tag 456582 + pending Bug#456582: Please check for GNOME not being spelt capitalised in package descriptions There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r1093 - in trunk: checks debian testset/manpages/debian
Author: rra Date: 2008-01-03 05:39:27 +0100 (Thu, 03 Jan 2008) New Revision: 1093 Modified: trunk/checks/changelog-file trunk/checks/changelog-file.desc trunk/debian/changelog trunk/testset/manpages/debian/changelog Log: * checks/changelog-file{.desc,}: + [RA] Don't spell-check lines that include the word spelling. Thanks, Andreas Hoenen. (Closes: #456515) Modified: trunk/checks/changelog-file === --- trunk/checks/changelog-file 2008-01-03 04:30:43 UTC (rev 1092) +++ trunk/checks/changelog-file 2008-01-03 04:39:27 UTC (rev 1093) @@ -316,13 +316,17 @@ while ($changes =~ /(closes\s*(?:bug)?\#?\s?\d{6,})[^\w]/ig) { tag possible-missing-colon-in-closes, $1 if $1; } -spelling_check('spelling-error-in-changelog', $changes); my @lines = split ('\n', $changes); for my $i (0 .. $#lines) { if (length ($lines[$i]) 80 $lines[$i] =~ /\s/) { tag 'debian-changelog-line-too-long', line . ($i + 1); } } + +# Strip out all lines that contain the word spelling to avoid false +# positives on changelog entries for spelling fixes. +$changes =~ s/^.*spelling.*\n//gm; +spelling_check('spelling-error-in-changelog', $changes); } # read the changelog itself Modified: trunk/checks/changelog-file.desc === --- trunk/checks/changelog-file.desc2008-01-03 04:30:43 UTC (rev 1092) +++ trunk/checks/changelog-file.desc2008-01-03 04:39:27 UTC (rev 1093) @@ -199,6 +199,10 @@ Info: Lintian found a spelling error in the latest entry of the Debian changelog. Lintian has a list of common misspellings that it looks for. It does not have a dictionary like a spelling checker does. + . + When writing a changelog entry for a spelling fix that includes the + misspelling, ensure the word spelling is on the same line as the + misspelled word to avoid triggering this warning. Tag: spelling-error-in-news-debian Type: warning Modified: trunk/debian/changelog === --- trunk/debian/changelog 2008-01-03 04:30:43 UTC (rev 1092) +++ trunk/debian/changelog 2008-01-03 04:39:27 UTC (rev 1093) @@ -1,5 +1,8 @@ lintian (1.23.42) UNRELEASED; urgency=low + * checks/changelog-file{.desc,}: ++ [RA] Don't spell-check lines that include the word spelling. + Thanks, Andreas Hoenen. (Closes: #456515) * checks/control-file{.desc,}: + [RA] Include the package name in stronger-dependency-implies-weaker. + [RA] Fix stronger-dependency-implies-weaker description cut and Modified: trunk/testset/manpages/debian/changelog === --- trunk/testset/manpages/debian/changelog 2008-01-03 04:30:43 UTC (rev 1092) +++ trunk/testset/manpages/debian/changelog 2008-01-03 04:39:27 UTC (rev 1093) @@ -4,6 +4,7 @@ * debian/rules: + Fix a little bug creating a file named 755 in the source dir. + Add a new binary with no english manpage. + * Sample changelog fixing spelling: publically - publicly -- Marc 'HE' Brockschmidt [EMAIL PROTECTED] Sat, 18 Dec 2004 13:32:29 +0100 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#457501: lintian: quilt needed in clean target
Bernd Zeimetz [EMAIL PROTECTED] writes: lintian already will allow (and even require) quilt to be in Build-Depends because of this. This looks like a specific problem with lintian's understanding of this package, but cython doesn't appear to be in the archive, so I can't check what's going on with it. It just went trough new ftp://ftp.de.debian.org/debian/pool/main/c/cython/ I finally had a chance to look at this, and the problem was that Lintian didn't correctly handle double-colon rules. (It thought the rule was clean: instead of clean and hence didn't notice that quilt was called from clean.) This will be fixed in the next version. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r1093
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r1093 by rra tag 456515 + pending Bug#456515: lintian: Undesirable spelling warning on changelog entries describing spelling fixes There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r1095
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r1095 by rra tag 457219 + pending Bug#457219: Please add lua to the list of known interpreters There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r1095 - in trunk: checks debian
Author: rra Date: 2008-01-03 05:50:40 +0100 (Thu, 03 Jan 2008) New Revision: 1095 Modified: trunk/checks/scripts trunk/debian/changelog Log: * checks/scripts: + [RA] Add lua40 and lua5.1. Thanks, Enrico Tassi. (Closes: #457219) Modified: trunk/checks/scripts === --- trunk/checks/scripts2008-01-03 04:46:24 UTC (rev 1094) +++ trunk/checks/scripts2008-01-03 04:50:40 UTC (rev 1095) @@ -60,7 +60,9 @@ 'kforth' = '/usr/bin/kforth', 'ksh' = '/bin/ksh', 'lefty' = '/usr/bin/lefty', + 'lua40' = '/usr/bin/lua40', 'lua50' = '/usr/bin/lua50', + 'lua5.1' = '/usr/bin/lua5.1', 'magicfilter' = '/usr/sbin/magicfilter', 'make' = '/usr/bin/make', 'mawk' = '/usr/bin/mawk', @@ -144,7 +146,9 @@ 'kforth' = 'kforth', 'ksh' = 'pdksh', 'lefty' = 'graphviz', + 'lua40' = 'lua40', 'lua50' = 'lua50', + 'lua5.1' = 'lua5.1', 'magicfilter' = 'magicfilter', 'make' = 'make | build-essential', 'mawk' = 'mawk', @@ -706,4 +710,8 @@ 1; +# Local Variables: +# indent-tabs-mode: t +# cperl-indent-level: 4 +# End: # vim: syntax=perl ts=8 sw=4 Modified: trunk/debian/changelog === --- trunk/debian/changelog 2008-01-03 04:46:24 UTC (rev 1094) +++ trunk/debian/changelog 2008-01-03 04:50:40 UTC (rev 1095) @@ -31,6 +31,8 @@ * checks/patch-systems: + [RA] dpatch permits multiple patches to be listed on the same line of 00list. Patch by Chris Lamb. (Closes: #457523) + * checks/scripts: ++ [RA] Add lua40 and lua5.1. Thanks, Enrico Tassi. (Closes: #457219) * checks/shared-libs{.desc,}: + [RA] New check for version numbers in symbol files. Based on a patch from Raphael Hertzog. (Closes: #457067) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r1094
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r1094 by rra tag 457501 + pending Bug#457501: lintian: quilt needed in clean target There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#456318: lintian: rpath check for games should include games dir
Bas Wijnen [EMAIL PROTECTED] writes: FHS chapter 4, at the end of the paragraph on Specific options in /usr/share, says: Similarly, a /usr/lib/games hierarchy may be used in addition to the /usr/share/games hierarchy if the distributor wishes to place some game data there. Neither policy nor developers' reference say anything about this, but I think most games choose to use both /usr/share/games and /usr/lib/games for game data. The good thing about this is that it makes it very easy to do things to all games at once (exclude them from backups, for example). The more that I look at this, the more that I think this isn't a good idea. FHS doesn't say anything about shared libraries, only game data, which doesn't really sound like shared libraries to me. Putting shared libraries in additional places in the system is tricky and raises the possibility of conflicts between different shared libraries. And putting shared libraries in a location that isn't in ld.so.conf requires setting an rpath, which has potentially bad interactions with multiarch support. That there's nothing in Policy about this is definitely a problem given how often issues about setting rpath come up. I think we need to add something to the binaries section on how to handle rpath. I'm going to open a Policy bug on this and block this bug on that one. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: retitle 456318 to [checks/binaries] allow /usr/lib/games rpath for games binaries ...
Processing commands for [EMAIL PROTECTED]: # Automatically generated email from bts, devscripts version 2.10.11 retitle 456318 [checks/binaries] allow /usr/lib/games rpath for games binaries Bug#456318: lintian: rpath check for games should include games dir Changed Bug title to `[checks/binaries] allow /usr/lib/games rpath for games binaries' from `lintian: rpath check for games should include games dir'. severity 456318 wishlist Bug#456318: [checks/binaries] allow /usr/lib/games rpath for games binaries Severity set to `wishlist' from `normal' End of message, stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: block 456318 with 458824
Processing commands for [EMAIL PROTECTED]: # Automatically generated email from bts, devscripts version 2.10.11 block 456318 with 458824 Bug#458824: better specification for when rpath is permitted is needed Bug#456318: [checks/binaries] allow /usr/lib/games rpath for games binaries Was not blocked by any bugs. Blocking bugs of 456318 added: 458824 End of message, stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r1096 - in trunk: debian frontend lib man
Author: rra Date: 2008-01-03 07:02:44 +0100 (Thu, 03 Jan 2008) New Revision: 1096 Modified: trunk/debian/changelog trunk/frontend/lintian trunk/frontend/lintian-info trunk/lib/Tags.pm trunk/man/lintian.1 Log: + [RA] Check that the argument to --color is valid. + [RA] Warn about no package arguments unless --setup-lab or --remove-lab are given. Thanks, Damyan Ivanov. (Closes: #455732) + [RA] Add support for HTML coloring. (Closes: #458376) * frontend/lintian-info: + [RA] Allow for HTML color tags. * lib/Tags.pm: + [RA] Add support for HTML coloring. * man/lintian.1: + [RA] Document the --color=html option. Modified: trunk/debian/changelog === --- trunk/debian/changelog 2008-01-03 04:50:40 UTC (rev 1095) +++ trunk/debian/changelog 2008-01-03 06:02:44 UTC (rev 1096) @@ -46,7 +46,13 @@ * frontend/lintian: + [RA] Allow + and . in tag names in overrides. Thanks, Stefan Fritsch. (Closes: #454790) - ++ [RA] Check that the argument to --color is valid. ++ [RA] Warn about no package arguments unless --setup-lab or + --remove-lab are given. Thanks, Damyan Ivanov. (Closes: #455732) ++ [RA] Add support for HTML coloring. (Closes: #458376) + * frontend/lintian-info: ++ [RA] Allow for HTML color tags. + * lib/Dep.pm: + [RA] Allow substvars instead of package names so that dependency checks against the source debian/control file don't treat all @@ -58,7 +64,12 @@ where we're more sure of the contents. + [RA] Expand the picky capitalization checks to catch Debian, GNOME, KDE, and Linux. (Closes: #456582) + * lib/Tags.pm: ++ [RA] Add support for HTML coloring. + * man/lintian.1: ++ [RA] Document the --color=html option. + * reporting/html_reports: + [RA] Rewritten. - Include info, experimental, and overridden tags in the tag pages. Modified: trunk/frontend/lintian === --- trunk/frontend/lintian 2008-01-03 04:50:40 UTC (rev 1095) +++ trunk/frontend/lintian 2008-01-03 06:02:44 UTC (rev 1096) @@ -103,11 +103,6 @@ # reset locale definition (necessary for tar) $ENV{'LC_ALL'} = 'C'; -# check for arguments -if ($#ARGV == -1) { -syntax(); -} - # }}} # {{{ Process Command Line @@ -319,9 +314,19 @@ undef $packages_file; } +# check permitted values for --color +if ($color and $color !~ /^(never|always|auto|html)$/) { +die invalid argument to --color: $color\n; +} + # check specified action $action = 'check' if not $action; +# check for arguments +if ($action =~ /^(check|unpack|remove)$/ and $#ARGV == -1) { +syntax(); +} + # }}} # {{{ Setup Configuration @@ -1638,4 +1643,8 @@ } # }}} +# Local Variables: +# indent-tabs-mode: t +# cperl-indent-level: 4 +# End: # vim: sw=4 ts=8 noet fdm=marker Modified: trunk/frontend/lintian-info === --- trunk/frontend/lintian-info 2008-01-03 04:50:40 UTC (rev 1095) +++ trunk/frontend/lintian-info 2008-01-03 06:02:44 UTC (rev 1096) @@ -68,11 +68,13 @@ # Otherwise, read input files or STDIN, watch for tags, and add descriptions # whenever we see one, can, and haven't already explained that tag. Strip off -# color sequences. +# color and HTML sequences. while () { print; chomp; -s/\e[[\d;]*m//g; +s/\e[\[\d;]*m//g; +s/span style=\[^\]+\//g; +s,/span,,g; my $tag; my ($type, $pkg, @pieces) = split(/:\s+/); @@ -89,3 +91,9 @@ } exit 0; + +# Local Variables: +# indent-tabs-mode: t +# cperl-indent-level: 4 +# End: +# vim: syntax=perl sw=4 ts=8 Modified: trunk/lib/Tags.pm === --- trunk/lib/Tags.pm 2008-01-03 04:50:40 UTC (rev 1095) +++ trunk/lib/Tags.pm 2008-01-03 06:02:44 UTC (rev 1096) @@ -266,6 +266,12 @@ return \%stats; } +# Color tags with HTML. Takes the tag and the color name. +sub colored_html { +my ($tag, $color) = @_; +return qq(span style=color: $color$tag/span); +} + sub print_tag { my ( $pkg_info, $tag_info, $information ) = @_; @@ -281,6 +287,8 @@ my $output = $code: $pkg_info-{pkg}$type: ; if ($color eq 'always' || ($color eq 'auto' -t STDOUT)) { $output .= colored($tag_info-{tag}, $sev_to_color[$severity]); +} elsif ($color eq 'html') { +$output .= colored_html($tag_info-{tag}, $sev_to_color[$severity]); } else { $output .= $tag_info-{tag}; } @@ -345,4 +353,8 @@ 1; +# Local Variables: +# indent-tabs-mode: t +# cperl-indent-level: 4 +# End: # vim: ts=4 sw=4 noet Modified: trunk/man/lintian.1 === --- trunk/man/lintian.1 2008-01-03 04:50:40 UTC (rev 1095) +++ trunk/man/lintian.1 2008-01-03 06:02:44 UTC (rev 1096) @@ -158,11 +158,12 @@ Output tags that
lintian: r1098 - in trunk: checks debian testset/cdbs-test/debian
Author: rra Date: 2008-01-03 07:10:08 +0100 (Thu, 03 Jan 2008) New Revision: 1098 Modified: trunk/checks/changelog-file trunk/debian/changelog trunk/testset/cdbs-test/debian/changelog Log: + [RA] Allow long no-whitespace lines even when spaces or bullets precede the text. Modified: trunk/checks/changelog-file === --- trunk/checks/changelog-file 2008-01-03 06:05:25 UTC (rev 1097) +++ trunk/checks/changelog-file 2008-01-03 06:10:08 UTC (rev 1098) @@ -318,7 +318,7 @@ } my @lines = split ('\n', $changes); for my $i (0 .. $#lines) { -if (length ($lines[$i]) 80 $lines[$i] =~ /\s/) { +if (length ($lines[$i]) 80 $lines[$i] !~ /^[\s.o*+-]*\S+$/) { tag 'debian-changelog-line-too-long', line . ($i + 1); } } Modified: trunk/debian/changelog === --- trunk/debian/changelog 2008-01-03 06:05:25 UTC (rev 1097) +++ trunk/debian/changelog 2008-01-03 06:10:08 UTC (rev 1098) @@ -3,6 +3,8 @@ * checks/changelog-file{.desc,}: + [RA] Don't spell-check lines that include the word spelling. Thanks, Andreas Hoenen. (Closes: #456515) ++ [RA] Allow long no-whitespace lines even when spaces or bullets + precede the text. * checks/common_data.pm: + [RA] Remove the obsolete base section. (Policy change pending). * checks/control-file{.desc,}: Modified: trunk/testset/cdbs-test/debian/changelog === --- trunk/testset/cdbs-test/debian/changelog2008-01-03 06:05:25 UTC (rev 1097) +++ trunk/testset/cdbs-test/debian/changelog2008-01-03 06:10:08 UTC (rev 1098) @@ -1,6 +1,8 @@ cdbs-test (1-1~bpo40+1) unstable; urgency=low * Backport, but for some reason I go on and on for longer than 80 columns thus making the entry annoying to read. + * this-is-a-really-long-dpatch-name-that-contains-the-entire-bug-report-in-the-file-name.dpatch: +- New. -- Russ Allbery [EMAIL PROTECTED] Wed, 05 Dec 2007 17:23:59 -0800 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: Indent coding style for lintian
Frank Lichtenheld [EMAIL PROTECTED] writes: I'm also more on the tab side of this argument although I have to confess I normally use the default emacs indentation which is a mixture of tabs and spaces. As long as it is documented feel free to use whatever you like for new code. I've been adding settings for vim and Emacs to each file as I touch them that enforce the tab/space style already prevelant in that file, and using the ones I sent earlier for new code. A manual revision is probably long-overdue. Adding a contributing section there that includes the coding style is probably the best place for it in the long run. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: retitle 457513 to [frontend/lintian] suppress N: tag about override count
Processing commands for [EMAIL PROTECTED]: # Automatically generated email from bts, devscripts version 2.10.11 retitle 457513 [frontend/lintian] suppress N: tag about override count Bug#457513: N: - lintian too noisy Changed Bug title to `[frontend/lintian] suppress N: tag about override count' from `N: - lintian too noisy'. End of message, stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r1096
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r1096 by rra tag 455732 + pending Bug#455732: Emits no error when options are given, but no files to work on There were no tags set. Tags added: pending tag 458376 + pending Bug#458376: lintian: html color There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r1099 - in trunk: checks debian testset
Author: rra Date: 2008-01-03 07:44:20 +0100 (Thu, 03 Jan 2008) New Revision: 1099 Modified: trunk/checks/init.d trunk/checks/init.d.desc trunk/debian/changelog trunk/testset/tags.scripts Log: * checks/init.d{.desc,}: + [RA] Warn of init scripts that list S in their Default-Stop LSB keyword. Thanks, Petter Reinholdtsen. (Closes: #458596) Modified: trunk/checks/init.d === --- trunk/checks/init.d 2008-01-03 06:10:08 UTC (rev 1098) +++ trunk/checks/init.d 2008-01-03 06:44:20 UTC (rev 1099) @@ -226,6 +226,9 @@ if ($start{$runlevel}) { tag init.d-script-has-conflicting-start-stop, /etc/init.d/$_ $runlevel; } + if ($runlevel =~ /[sS]/) { + tag init-d-script-stops-in-s-runlevel, /etc/init.d/$_; + } } else { tag init.d-script-has-bad-stop-runlevel, /etc/init.d/$_ $runlevel; } @@ -255,4 +258,8 @@ 1; +# Local Variables: +# indent-tabs-mode: t +# cperl-indent-level: 4 +# End: # vim: syntax=perl ts=8 Modified: trunk/checks/init.d.desc === --- trunk/checks/init.d.desc2008-01-03 06:10:08 UTC (rev 1098) +++ trunk/checks/init.d.desc2008-01-03 06:44:20 UTC (rev 1099) @@ -147,7 +147,7 @@ Ref: http://wiki.debian.org/LSBInitScripts Info: The given runlevel specified in the Default-Stop keyword of the LSB keyword section of this tt/etc/init.d/tt script isn't one of the - recognized standard runlevels (S, 0, 1, 2, 3, 4, 5, and 6). + recognized standard runlevels (0, 1, 2, 3, 4, 5, and 6). Tag: init.d-script-has-conflicting-start-stop Type: warning @@ -157,3 +157,11 @@ tt/etc/init.d/tt script. Since it doesn't make sense to both start and stop a service in the same runlevel, there is probably an error in one or the other of these keywords. + +Tag: init-d-script-stops-in-s-runlevel +Type: warning +Info: This tt/etc/init.d/tt script specifies the S runlevel in + Default-Stop in its LSB keyword section. The S runlevel is not a real + runlevel and is only used during boot. There is no way to switch to it + and hence no use for stop scripts for it, so S should be removed from + Default-Stop. Modified: trunk/debian/changelog === --- trunk/debian/changelog 2008-01-03 06:10:08 UTC (rev 1098) +++ trunk/debian/changelog 2008-01-03 06:44:20 UTC (rev 1099) @@ -24,6 +24,9 @@ match debian/rules. (Closes: #457501) * checks/files.desc: + [RA] Remove a stray variable from the config-file-reserved tag. + * checks/init.d{.desc,}: ++ [RA] Warn of init scripts that list S in their Default-Stop LSB + keyword. Thanks, Petter Reinholdtsen. (Closes: #458596) * checks/menu-format.desc: + [RA] Fix non-wm-module-in-wm-modules-menu-section pluralization to match the check and reword the long description to be hopefully Modified: trunk/testset/tags.scripts === --- trunk/testset/tags.scripts 2008-01-03 06:10:08 UTC (rev 1098) +++ trunk/testset/tags.scripts 2008-01-03 06:44:20 UTC (rev 1099) @@ -44,6 +44,8 @@ W: scripts: executable-is-not-world-readable usr/bin/perl-bizarre-2 0750 != 0755 W: scripts: executable-is-not-world-readable usr/bin/suidperlfoo2 4751 W: scripts: executable-not-elf-or-script ./usr/bin/perl-bizarre-3 +W: scripts: init-d-script-stops-in-s-runlevel /etc/init.d/lsb-broken +W: scripts: init-d-script-stops-in-s-runlevel /etc/init.d/skeleton W: scripts: init.d-script-has-bad-lsb-line /etc/init.d/lsb-broken:4 W: scripts: init.d-script-has-bad-lsb-line /etc/init.d/lsb-broken:9 W: scripts: init.d-script-has-bad-stop-runlevel /etc/init.d/lsb-broken X -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#457513: N: - lintian too noisy
On Thursday 03 January 2008, Russ Allbery wrote: When I add a override, I do not want to be bugged with it. This setting might be reasonable when there is just 1 binary package - but most of my packages produces many binary packages, most got some kind of lintian override, so now it is quite some information. ...this is itself a problem. Why do most of your packages have some sort of lintian override? What tags are you having to override that this would be true? Very few of my packages need lintian overrides. Most of the overridesis related to putting different sonames in same package. At least when packaging kde, this quite often makes sense. Another group is due to weird upstream using of libraries called libkdeinit_*.so. And a thirg group is a app having a shared library currently only used by that app and stuffed in the same package as the app. kdebase for example: $ grep ^Package debian/control | wc --lines 35 $ ls debian/*.lintian | wc --lines 14 Having 14 packages in the same source package adding one or more lintian override is making N: actually quite verbose. I'll mail debian-devel about this. Probably a nice idea. /Sune -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#458831: lintian: extra-license-file detects non-license files
Package: lintian Version: 1.23.41 Severity: normal kdelibs-data contains a bunch of docbook snippets used to point to licenses for different licenses and languages. Such one: cat /usr/share/apps/ksgmltools2/customization/en-GB/entities/underArtisticLicense.docbook paraThis program is licensed under the terms of the ulink url=common/artistic-license.htmlArtistic License/ulink./para Currently overridden in kdelibs-data, but I guess it is some kind of bug in lintian. $ grep extra-license-file debian/kdelibs-data.lintian | wc --lines 120 /Sune -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (200, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.20-1-vserver-k7 (SMP w/1 CPU core) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash Versions of packages lintian depends on: ii binutils2.18.1~cvs20071027-1 The GNU assembler, linker and bina ii diffstat1.45-2 produces graph of changes introduc ii dpkg-dev1.14.14 package building tools for Debian ii file4.21-4 Determines file type using magic ii gettext 0.17-2 GNU Internationalization utilities ii intltool-debian 0.35.0+20060710.1Help i18n of RFC822 compliant conf ii libparse-debianchan 1.1.1-1 parse Debian changelogs and output ii liburi-perl 1.35.dfsg.1-1Manipulates and accesses URI strin ii man-db 2.5.0-4 on-line manual pager ii perl [libdigest-md5 5.8.8-12 Larry Wall's Practical Extraction lintian recommends no packages. -- debconf-show failed -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r1100 - in trunk: checks debian testset
Author: rra Date: 2008-01-03 08:18:11 +0100 (Thu, 03 Jan 2008) New Revision: 1100 Modified: trunk/checks/files trunk/debian/changelog trunk/testset/tags.filenames Log: * checks/files: + [RA] Ignore zero-length files in /usr/share/doc/examples. Modified: trunk/checks/files === --- trunk/checks/files 2008-01-03 06:44:20 UTC (rev 1099) +++ trunk/checks/files 2008-01-03 07:18:11 UTC (rev 1100) @@ -213,9 +213,8 @@ # zero byte file in /usr/share/doc/ if ($size == 0 and $perm =~ m,^-, and not $is_hard_link{$file}) { - # exception: __init__.py files are empty tagging files (see - # bug #215234) - unless ($file =~ m,^usr/share/doc/([^/]+/)?examples/(.+/)?__init__\.py$,) { + # exception: examples may contain empty files for various reasons + unless ($file =~ m,^usr/share/doc/([^/]+/)?examples/,) { tag zero-byte-file-in-doc-directory, $file; } } @@ -872,4 +871,8 @@ 1; +# Local Variables: +# indent-tabs-mode: t +# cperl-indent-level: 4 +# End: # vim: syntax=perl ts=8 sw=4 Modified: trunk/debian/changelog === --- trunk/debian/changelog 2008-01-03 06:44:20 UTC (rev 1099) +++ trunk/debian/changelog 2008-01-03 07:18:11 UTC (rev 1100) @@ -22,6 +22,8 @@ * checks/fields: + [RA] Handle double-colon rules when checking that build dependencies match debian/rules. (Closes: #457501) + * checks/files: ++ [RA] Ignore zero-length files in /usr/share/doc/examples. * checks/files.desc: + [RA] Remove a stray variable from the config-file-reserved tag. * checks/init.d{.desc,}: Modified: trunk/testset/tags.filenames === --- trunk/testset/tags.filenames2008-01-03 06:44:20 UTC (rev 1099) +++ trunk/testset/tags.filenames2008-01-03 07:18:11 UTC (rev 1100) @@ -106,7 +106,6 @@ W: filenames: wrong-name-for-debian-news-file usr/share/doc/filenames/news.debian.gz W: filenames: zero-byte-file-in-doc-directory usr/share/doc/filenames/NEWS.Debian W: filenames: zero-byte-file-in-doc-directory usr/share/doc/filenames/README.macosx -W: filenames: zero-byte-file-in-doc-directory usr/share/doc/filenames/examples/very_interesting_example W: filenames: zero-byte-file-in-doc-directory usr/share/doc/filenames/examples/very_interesting_example2.gz W: filenames: zero-byte-file-in-doc-directory usr/share/doc/filenames/news.debian.gz W: more-filename-games: binary-without-manpage usr/bin/another-test-game -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r1101 - in trunk: checks debian
Author: rra Date: 2008-01-03 08:21:56 +0100 (Thu, 03 Jan 2008) New Revision: 1101 Modified: trunk/checks/files trunk/debian/changelog Log: + [RA] The underFooLicense.docbook files from KDE are not license files. Thanks, Sune Vuorela. (Closes: #458831) Modified: trunk/checks/files === --- trunk/checks/files 2008-01-03 07:18:11 UTC (rev 1100) +++ trunk/checks/files 2008-01-03 07:21:56 UTC (rev 1101) @@ -533,11 +533,12 @@ # those are likely to just be simply pictures. # # DTD files are excluded at the request of the Mozilla suite - # maintainers. Zope products include license files for runtime - # display. + # maintainers. Zope products include license files for runtime + # display. underXXXlicense.docbook files are from KDE. and not $file =~ m/\.(el|c|h|py|cc|pl|pm|html|php|rb|xpm|png|jpe?g|gif|svg|dtd)$/ -and not $file =~ m,^usr/share/zope/Products/.*\.(dtml|pt|cpt)$, -and not defined $link) { + and not $file =~ m,^usr/share/zope/Products/.*\.(dtml|pt|cpt)$, + and not $file =~ m,/under\S+License\.docbook$, + and not defined $link) { tag extra-license-file, $file; } Modified: trunk/debian/changelog === --- trunk/debian/changelog 2008-01-03 07:18:11 UTC (rev 1100) +++ trunk/debian/changelog 2008-01-03 07:21:56 UTC (rev 1101) @@ -24,6 +24,8 @@ match debian/rules. (Closes: #457501) * checks/files: + [RA] Ignore zero-length files in /usr/share/doc/examples. ++ [RA] The underFooLicense.docbook files from KDE are not license + files. Thanks, Sune Vuorela. (Closes: #458831) * checks/files.desc: + [RA] Remove a stray variable from the config-file-reserved tag. * checks/init.d{.desc,}: -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: New lintian pages available for testing
Hi Russ, On Thursday 3 January 2008 01:16, Russ Allbery wrote: http://lintian.debian.org/reports-testing/ This looks good in general, it's a clear improvement over what we have. * The HTML pages are now templatized (using Text::Template). The core of many of the pages is still generated by some not-horribly-pleasant Perl embedded in the templates, but all of the transformation from data to HTML should now be in the templates so that someone can modify them independent of the main script. Great. Would this include the capability to wrap different tag severities in different HTML-tags so each could get their own CSS class? * There are two reports for each maintainer. The one under maintainer, matching the existing URL scheme, shows errors and warnings as before. The one under full shows all tags, including info and overridden tags. The tag index links to the full page, and the maintainer index links to both. I was thinking that this could be better implemented by generating one page per maintainer with all tags, and that I and O are hidden elements by default. A link on the page would then just toggle the visibility of that CSS class (just like the legend at the top of the DDPO). The advantage is less output to generate and no need to reload a page between toggles. A possible drawback could be that the E/W pages get a larger filesize. Are there significantly more I+O tags so that the 'full' pages are getting very large? thanks, Thijs pgpRL95sr8IsS.pgp Description: PGP signature
Bug#458831: lintian: extra-license-file detects non-license files
Sune Vuorela [EMAIL PROTECTED] writes: Package: lintian Version: 1.23.41 Severity: normal kdelibs-data contains a bunch of docbook snippets used to point to licenses for different licenses and languages. Such one: cat /usr/share/apps/ksgmltools2/customization/en-GB/entities/underArtisticLicense.docbook paraThis program is licensed under the terms of the ulink url=common/artistic-license.htmlArtistic License/ulink./para Currently overridden in kdelibs-data, but I guess it is some kind of bug in lintian. $ grep extra-license-file debian/kdelibs-data.lintian | wc --lines 120 Indeed. Thanks, I cleared up all the docbook stuff for the next release. I'm not sure what to do with these, since they really are extra copies of the licenses without any useful change (unlike the *.html versions): W: kdelibs-data: extra-license-file usr/share/doc/kde/HTML/en/common/fdl-license W: kdelibs-data: extra-license-file usr/share/doc/kde/HTML/en/common/gpl-license W: kdelibs-data: extra-license-file usr/share/doc/kde/HTML/en/common/lgpl-license You could make them symlinks to common-licenses. That's probably what I'd do. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Processed: Lintian bugs fixed in revision r1101
Processing commands for [EMAIL PROTECTED]: package lintian Ignoring bugs not assigned to: lintian # Fixed in r1101 by rra tag 458831 + pending Bug#458831: lintian: extra-license-file detects non-license files There were no tags set. Tags added: pending thanks Stopping processing here. Please contact me if you need assistance. Debian bug tracking system administrator (administrator, Debian Bugs database) -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
lintian: r1102 - in trunk: debian frontend man
Author: rra Date: 2008-01-03 08:59:16 +0100 (Thu, 03 Jan 2008) New Revision: 1102 Modified: trunk/debian/changelog trunk/frontend/lintian-info trunk/man/lintian-info.1 Log: + [RA] Add -a to annotate an override file. * man/lintian-info.1: + [RA] Document the --annotate option. Modified: trunk/debian/changelog === --- trunk/debian/changelog 2008-01-03 07:21:56 UTC (rev 1101) +++ trunk/debian/changelog 2008-01-03 07:59:16 UTC (rev 1102) @@ -63,6 +63,7 @@ + [RA] Add support for HTML coloring. (Closes: #458376) * frontend/lintian-info: + [RA] Allow for HTML color tags. ++ [RA] Add -a to annotate an override file. * lib/Dep.pm: + [RA] Allow substvars instead of package names so that dependency @@ -80,6 +81,8 @@ * man/lintian.1: + [RA] Document the --color=html option. + * man/lintian-info.1: ++ [RA] Document the --annotate option. * reporting/html_reports: + [RA] Rewritten. Modified: trunk/frontend/lintian-info === --- trunk/frontend/lintian-info 2008-01-03 07:21:56 UTC (rev 1101) +++ trunk/frontend/lintian-info 2008-01-03 07:59:16 UTC (rev 1102) @@ -42,9 +42,9 @@ my %tag_info = %{read_tag_info()}; -my ($tags); +my ($annotate, $tags); Getopt::Long::config('bundling', 'no_getopt_compat', 'no_auto_abbrev'); -GetOptions('tags|t' = \$tags) +GetOptions('annotate|a' = \$annotate, 'tags|t' = \$tags) or die(error parsing options\n); # If tag mode was specified, read the arguments as tags and display the @@ -72,14 +72,19 @@ while () { print; chomp; +next if /^\s*$/; s/\e[\[\d;]*m//g; s/span style=\[^\]+\//g; s,/span,,g; -my $tag; -my ($type, $pkg, @pieces) = split(/:\s+/); -if (defined $type and $type =~ m/^[OEWIX]$/) { - $tag = shift @pieces; +my ($type, $pkg); +my @pieces = split(/:\s+/); +if ($annotate) { +$type = shift @pieces if ($pieces[0] =~ /^\w$/); +$pkg = shift @pieces if ($pieces[0] =~ /^\S+( (binary|udeb))?$/); +} +if ($annotate or (defined $type and $type =~ m/^[OEWIX]$/)) { + my $tag = shift @pieces; next if not defined $tag; ($tag) = split(/\s+/, $tag, 2); Modified: trunk/man/lintian-info.1 === --- trunk/man/lintian-info.12008-01-03 07:21:56 UTC (rev 1101) +++ trunk/man/lintian-info.12008-01-03 07:59:16 UTC (rev 1102) @@ -24,7 +24,7 @@ .SH SYNOPSIS .B lintian-info -.RI [ log-file ] +.RI [ log-file ... ] \... .B lintian-info \-\-tags @@ -35,10 +35,11 @@ .PP The .B lintian-info -command either parses the output of the +command parses the output of the .B lintian command and gives verbose information about the listed Lintian error -tags or (if given the +tags, parses a Lintian override file and gives verbose information about +the tags included, or (if given the .BR \-t or \-\-tags option) explains a given tag or tags. .sp @@ -59,6 +60,12 @@ .SH OPTIONS .TP +.BR \-a , \-\-annotate +Read from standard input or any files specified on the command line and +search the input for lines formatted like Lintian override entries. For +each one that was found, display verbose information about that tag. + +.TP .BR \-t , \-\-tags Rather than treating them as log file names, treat any command-line options as tag names and display the descriptions of each tag. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]