Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

2020-05-17 Thread Stamatis Zampetakis
Hello, Thanks for driving this Haisheng! I was checking the differences between RC0 and RC1: https://github.com/apache/calcite/compare/calcite-1.23.0-rc0...calcite-1.23.0-rc1 and the change for CALCITE-3997 [1] seems a bit risky for this stage of the release, thus I would like to invite more

Re: [DISCUSS] DDL parsing, and relationship between "server" and "babel" modules

2020-05-17 Thread Stamatis Zampetakis
Hello, I prefer a bit more the alternative of putting all DDL classes into "core". When people talk about an SQL parser usually they mean the complete beast (DQL, DDL, DML). Personally, I wouldn't be surprised to find DDL in "core", especially since DML is already in. The dependency from

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

2020-05-17 Thread Enrico Olivelli
+1 (non binding) Local tests passes on Linux (Fedora 31) + JDK14 Checksums and signatures looks good. All tests are passing on HerdDB. Thank you very much Haisheng ! Enrico Il giorno sab 16 mag 2020 alle ore 23:21 Anton Haidai < anton.hai...@gmail.com> ha scritto: > Hello, > > Local Calcite