Hello, Thanks for driving this Haisheng!
I was checking the differences between RC0 and RC1: https://github.com/apache/calcite/compare/calcite-1.23.0-rc0...calcite-1.23.0-rc1 and the change for CALCITE-3997 [1] seems a bit risky for this stage of the release, thus I would like to invite more people to have a look. If there are things to be discussed let's do it under the respective JIRA. I will continue testing and vote later on. Best, Stamatis [1] https://github.com/apache/calcite/commit/7be30db36d449e0a7fcc76b7d4647e141f4bc72d On Sun, May 17, 2020 at 1:45 PM Enrico Olivelli <eolive...@gmail.com> wrote: > +1 (non binding) > Local tests passes on Linux (Fedora 31) + JDK14 > Checksums and signatures looks good. > > All tests are passing on HerdDB. > Thank you very much Haisheng ! > > Enrico > > Il giorno sab 16 mag 2020 alle ore 23:21 Anton Haidai < > anton.hai...@gmail.com> ha scritto: > > > Hello, > > > > Local Calcite build with tests enabled on Linux: *OK* > > Calcite-based system (Zoomdata) test suite: *OK* > > > > Vote: > > +1 (non-binding) > > > > On Sat, May 16, 2020 at 7:02 AM Haisheng Yuan <hy...@apache.org> wrote: > > > > > Hi all, > > > > > > I have created a build for Apache Calcite 1.23.0, release > > > candidate 1. > > > > > > Thanks to everyone who has contributed to this release. > > > > > > You can read the release notes here: > > > > > > > > > https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md > > > > > > The commit to be voted upon: > > > > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > > > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > > > > Tag: > > > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1 > > > > > > The artifacts to be voted on are located here: > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1 > > > (revision 39622) > > > > > > The hashes of the artifacts are as follows: > > > > > > > > > 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46 > > > *apache-calcite-1.23.0-src.tar.gz > > > > > > A staged Maven repository is available for review at: > > > > > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/ > > > > > > Release artifacts are signed with the following key: > > > https://dist.apache.org/repos/dist/release/calcite/KEYS > > > > > > N.B. > > > To create the jars and test Apache Calcite: "./gradlew build". > > > > > > If you do not have a Java environment available, you can run the tests > > > using docker. To do so, install docker and docker-compose, then run > > > "docker-compose run test" from the root of the directory. > > > > > > Please vote on releasing this package as Apache Calcite 1.23.0. > > > > > > The vote is open for the next 72 hours and passes if a majority of at > > > least three +1 PMC votes are cast. > > > > > > [ ] +1 Release this package as Apache Calcite 1.23.0 > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > > [ ] -1 Do not release this package because... > > > > > > > > > Here is my vote: > > > > > > +1 (binding) > > > > > > Thanks, > > > Haisheng Yuan > > > > > > > > > -- > > Best regards, > > Anton. > > >
