Re: [RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-22 Thread Andrei Sereda
Thank you, Fancis. I have marked 1.25 as released in JIRA On Sat, Aug 22, 2020 at 7:28 PM Francis Chuang wrote: > Hey Andrei, > > I added the 1.25.0 release to the reporting tool. > I also added you to the administrator role in jira. Can you see if you > can mark 1.25.0 as released? > >

Re: [RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-22 Thread Francis Chuang
Hey Andrei, I added the 1.25.0 release to the reporting tool. I also added you to the administrator role in jira. Can you see if you can mark 1.25.0 as released? Francis On 23/08/2020 8:29 am, Andrei Sereda wrote: There are two things to be done by PMCs (unfortunately I can't due to

Re: [RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-22 Thread Andrei Sereda
There are two things to be done by PMCs (unfortunately I can't due to restricted access): 1. Add release date 2020-08-22 for 1.25 to Apache Report Helper [1] 2. Mark version 1.25 as released in JIRA [2]. Release date 2020-08-22 If someone has access to those systems please help me finalize 1.25

Re: [RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-22 Thread Michael Mior
Thanks Andrei! -- Michael Mior mm...@apache.org Le sam. 22 août 2020 à 15:08, Andrei Sereda a écrit : > > INFRA-20681 was resolved. > > I have published the artifacts to SVN dist area. > > Will update static site and send an announcement shortly. > > On Fri, Aug 21, 2020 at 5:37 PM Andrei

Re: [RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-22 Thread Andrei Sereda
INFRA-20681 was resolved. I have published the artifacts to SVN dist area. Will update static site and send an announcement shortly. On Fri, Aug 21, 2020 at 5:37 PM Andrei Sereda wrote: > Hello, > > I'm still waiting for INFRA-20681 [1] to be resolved to publish 1.25.0 > artifacts to SVN. If

Re: [RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-21 Thread Andrei Sereda
Hello, I'm still waiting for INFRA-20681 [1] to be resolved to publish 1.25.0 artifacts to SVN. If some of you know different channels to speed up the resolution please let me know. [1] https://issues.apache.org/jira/browse/INFRA-20681 On Sun, Aug 16, 2020 at 12:58 PM Andrei Sereda wrote: >

Re: [RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-15 Thread Julian Hyde
You can "git push origin calcite-1.25.0-rc0:master" and then re-open master. I don't think there's any reason to wait. Since the release vote has passed, we know that 68b02dfd4 is going to end up on master. And we don't mind if people make intervening commits before you tweak the release notes or

Re: [RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-15 Thread Andrei Sereda
> is there any reason to keep master branch closed? I didn't want to make master branch too out of sync with 1.25.0 release. Unfortunately I was not yet given permissions for SVN dist repository which prevents me from finalizing the release. That being said, keeping master frozen for too long is

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-13 Thread Julian Hyde
Since the release vote has passed, Andrei as release manager can declare the master branch open for commits. Publishing the artifacts and making the release announcement can go on in parallel. > On Aug 13, 2020, at 3:37 PM, Andrei Sereda wrote: > > Hi Haisheng, > > Thanks for your reply. >

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-13 Thread Andrei Sereda
Hi Haisheng, Thanks for your reply. There is a parallel discussion [1] about letting committers have write access to SVN dist repository. Seems like most people are on the same page (ie +1). If approved, I should be able to finalize the release soon myself. Andrei. [1]

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-13 Thread Haisheng Yuan
Hi Andrei, Let's unblock the release as soon as possible. I can help publish the artifact. Can you cat build/stagingRepositories/nexus.txt and send me the content in your local repo? Thanks, Haisheng On 2020/08/13 14:47:05, Andrei Sereda wrote: > It can also be configured per project. > >

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-13 Thread Andrei Sereda
It can also be configured per project. > Do you know if SVN access can be configured per project ? > Yes it can, if the PMC agrees to it, the dist area can be opened up to all project committers - a few PMCs have done this. On Thu, Aug 13, 2020 at 10:43 AM Andrei Sereda wrote: > Inquired with

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-13 Thread Andrei Sereda
Inquired with INFRA-20681 seems like only PMCs can commit to dist SVN: > Are committers (which are not PMCs) allowed to commit to SVN dist repo ? > ..., nope, by default its PMC members only On Thu, Aug 13, 2020 at 9:27 AM Andrei Sereda

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-13 Thread Andrei Sereda
Can someone from PMC pls publish the release ? Or maybe contact INFRA about svn permissions for committers vs PMCs ? I would like to avoid blocking calcite development for too long. On Wed, Aug 12, 2020 at 11:33 PM Chunwei Lei wrote: > > Once this release is done, we should consider whether

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-12 Thread Chunwei Lei
> Once this release is done, we should consider whether we should give committers write access to SVN to avoid these issues in the future. I am not sure if this is possible or if this is just the way ASF's infra is set up, but it's worth a look. I cannot agree more. Thank you for pointing out,

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-12 Thread Francis Chuang
Can someone please push the release artifacts for Andrei? I believe this is the same issue we had with the last release, where the RM is not a PMC member and doesn't have write access to SVN [1]. Once this release is done, we should consider whether we should give committers write access to

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-12 Thread Andrei Sereda
Thanks, Stamatis. All seems to be working now. On Wed, Aug 12, 2020 at 6:36 PM Stamatis Zampetakis wrote: > Hi Andrei, > > I uploaded your key to the file. Please check. > > Normally you don't need to be in the PMC to have access to the svn repo. > I don't know what went wrong and you were not

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-12 Thread Stamatis Zampetakis
Hi Andrei, I uploaded your key to the file. Please check. Normally you don't need to be in the PMC to have access to the svn repo. I don't know what went wrong and you were not able to push it through. Best, Stamatis On Thu, Aug 13, 2020 at 1:24 AM Andrei Sereda wrote: > Hello, > > Can

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-12 Thread Andrei Sereda
Hello, Can somebody from PMC pls upload my public GPG key to KEYS ? I don't have permissions for that svn repo. I've sent an email to priv...@calcite.apache.org. Thanks, Andrei. On Tue, Aug 11, 2020 at 1:17 PM Andrei Sereda wrote: >

[RESULT] [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-12 Thread Andrei Sereda
Thanks to everyone who has tested the release candidate and given their comments and votes. The tally is as follows. 4 binding +1s: * Francis Chuang * Michael Mior * Haisheng Yuan * Julian Hyde 7 non-binding +1s: * Enrico Olivelli * Rui Wang * chunwei * Ruben Q L * Anton Haidai * xzh

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-11 Thread Andrei Sereda
Hi All, I plan to close the vote tomorrow (Aug 12th). If you still want to validate RC0 please do so before Wednesday. Regards, Andrei. On Tue, Aug 11, 2020 at 1:13 PM Andrei Sereda wrote: > Thanks, Julian, for the hint. I'll update the KEYS file. > > On Tue, Aug 11, 2020 at 11:59 AM Julian

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-11 Thread Andrei Sereda
Thanks, Julian, for the hint. I'll update the KEYS file. On Tue, Aug 11, 2020 at 11:59 AM Julian Hyde wrote: > Andrei, > > Your key’s signature appears in KEYS because you signed Stamatis’s key. > But your key isn’t actually defined in the file. After I imported the file, > your key was still

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-11 Thread Julian Hyde
Andrei, Your key’s signature appears in KEYS because you signed Stamatis’s key. But your key isn’t actually defined in the file. After I imported the file, your key was still ‘unknown’ according to gpg. Julian > On Aug 11, 2020, at 8:04 AM, Andrei Sereda wrote: > >  >> >> * Andrei, I

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-11 Thread Andrei Sereda
> * Andrei, I don’t think your key is in KEYS. Be sure to add it before the release announcement. I see my signing key in KEYS $ curl -s https://dist.apache.org/repos/dist/release/calcite/KEYS | grep sereda sig C41CFDDFED34C028 2019-08-19 Andrei Sereda (CODE SIGNING KEY) <

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-11 Thread Julian Hyde
+1 (binding) Checked keys, hashes, LICENSE, NOTICE, README; compiled and ran tests on Ubuntu/JDK 14; ran RAT. * Andrei, I don’t think your key is in KEYS. Be sure to add it before the release announcement. * There are several files in the source distro that are not in git: an empty ‘arrow’

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-11 Thread Stamatis Zampetakis
If I remember well the site preview is not implemented so it is normal that links are broken. I don't know if this has changed recently but if not I think we should remove the site preview links from the draft email to avoid confusion. Best, Stamatis On Mon, Aug 10, 2020 at 8:08 PM Andrei Sereda

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-10 Thread Andrei Sereda
Yes I'm aware that for some reason site artifact wasn't built / uploaded. Meanwhile here are the release notes: https://github.com/apache/calcite/blob/calcite-1.25.0-rc0/site/_docs/history.md I'll double-check the build script / instructions, maybe I have missed something. On Mon, Aug 10, 2020

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-10 Thread Haisheng Yuan
+1 (binding) Environment: Mac OS X 10.15.1 , JDK 1.8.0_162 - Ran unit tests (./gradlew build), OK - Checked release notes, CALCITE-4156, CALCITE-4022 CALCITE-4115 CALCITE-4129 CALCITE-4111 are not part of Build and test suite changes, those can be updated after release. - Haisheng On

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-10 Thread Michael Mior
+1 (binding) Checked hash and compiled and ran tests. I will note though that all links in the email to https://apache.github.io/calcite-site-preview/ are broken. -- Michael Mior mm...@apache.org Le sam. 8 août 2020 à 23:22, Andrei Sereda a écrit : > > Hi all, > > I have created a build for

回复: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-10 Thread 953396112
+1 (non binding) Local Calcite build with tests enabled on MacOs: Ok Calcite-based system test suite: Ok MacOs (Catalina 10.15.6) Java version(1.8.0_191) xzh --原始邮件-- 发件人:

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-10 Thread Anton Haidai
Hello, Local Calcite build with tests enabled on Linux: *OK* Calcite-based system (Zoomdata) test suite: *OK* Vote: +1 (non-binding) On Mon, Aug 10, 2020 at 11:09 AM Ruben Q L wrote: > +1 (non binding) > - Local Calcite build with tests (Windows10 + JDK8): OK > - Calcite-based application

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-10 Thread Ruben Q L
+1 (non binding) - Local Calcite build with tests (Windows10 + JDK8): OK - Calcite-based application test suite: OK Le lun. 10 août 2020 à 07:13, chunwei a écrit : > +1 (non-binding). > > - run tests locally: ok > - verify the commit hash in git tag: ok > - check sha512: ok > > Environment: >

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-10 Thread chunwei
+1 (non-binding). - run tests locally: ok - verify the commit hash in git tag: ok - check sha512: ok Environment: - java version 1.8.0_151 - MacOS Mojave 10.14.6 BTW, It shows 404 when I open https://apache.github.io/calcite-site-preview/docs/history.html. On Mon, Aug 10, 2020 at 9:47 AM Rui

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-09 Thread Rui Wang
> I'm happy to change release notes to better reflect 1.25.0 changes. I > presume it can be done after the vote ? Absolutely! It does not affect current vote. -Rui On Sun, Aug 9, 2020 at 4:55 PM Andrei Sereda wrote: > > one thing can be fixed after vote: CALCITE-4114 does not belong to >

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-09 Thread Francis Chuang
Thanks for making this release available for voting, Andrei! Verified GPG Signature - OK Verified SHA512 - OK Ran tests per HOWTO (./gradlew check) - OK Quickly skimmed release notes (https://github.com/apache/calcite/blob/calcite-1.25.0-rc0/site/_docs/history.md) - OK Spotted checked a few

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-09 Thread Rui Wang
+1 (non-binding) platform: ubuntu16 + java8 run tests locally on: ok verify the commit hash in git tag: ok check sha512: ok verify signature by gpg: ok one thing can be fixed after vote: CALCITE-4114 does not belong to "breaking changes" in the release note. That change happened in core/test

Re: [VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-09 Thread Enrico Olivelli
+1 (non binding) run tests locally on Fedora + JDK14 run tests of HerdDB just by switching from 1.24 without any change Enrico Il giorno dom 9 ago 2020 alle ore 05:22 Andrei Sereda ha scritto: > Hi all, > > I have created a build for Apache Calcite 1.25.0, release > candidate 0. > > Thanks to

[VOTE] Release apache-calcite-1.25.0 (release candidate 0)

2020-08-08 Thread Andrei Sereda
Hi all, I have created a build for Apache Calcite 1.25.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://apache.github.io/calcite-site-preview/docs/history.html The commit to be voted upon: