Re: CI passed error tests

2019-12-13 Thread XING JIN
Thanks a lot, Stamatis~ I will run slow tests from my local. Best, Jin 在 2019年12月14日星期六,Stamatis Zampetakis 写道: > Hi Jin, > > If the test run fine locally at your machine (e.g., ./gradlew testSlow) > then they should be fine in the CI. > Labels are only available for committers yes! > > Best,

Re: CI passed error tests

2019-12-13 Thread Stamatis Zampetakis
Hi Jin, If the test run fine locally at your machine (e.g., ./gradlew testSlow) then they should be fine in the CI. Labels are only available for committers yes! Best, Stamatis On Fri, Dec 13, 2019 at 4:52 PM XING JIN wrote: > Thanks a lot Ruben ~ > I'm working on "[CALCITE-3478] Restructure

Re: CI passed error tests

2019-12-13 Thread XING JIN
Thanks a lot Ruben ~ I'm working on "[CALCITE-3478] Restructure tests for materialized views" ( https://github.com/apache/calcite/pull/1560) , which contains "slow tests". But I'm not sure how to add the label to PR. Is it only available for committers ? BTW, It's great if someone can help review

Re: CI passed error tests

2019-12-13 Thread Ruben Q L
Hi Jin, this is the expected behavior: slow tests are not executed by default in PR CI. If you want slow tests to be executed in your PR, you need to explicitly add the label "slow-tests-needed", as specified by [1]. You can see a PR example with this label here [2]. Best regards, Ruben [1]

CI passed error tests

2019-12-12 Thread XING JIN
Hi guys, I made a PR and run continuous integration tests. [1] A error test contained in the PR and tagged with @slowTest. The tests should be failed but CI passed by mistake. I doubt our current CI is not running with 'testSlow' configuration. Isn't it ? I'm not sure if I should create a JIRA.