Thanks Arvid for the feedback! I think merging the giant commit after cutting
1.14 release branch would be a good idea.
Since no one has objections in the discussion, I’d like to move a step forward
and raise a vote on the migration. Looking forward to having JUnit 5 in the
1.14 release cycle!
Thanks Arvid for the feedback! I think merging the giant commit after cutting
1.14 release branch would be a good idea.
Since no one has objections in the discussion, I’d like to move a step forward
and raise a vote on the migration. Looking forward to having JUnit 5 in the
1.14 release cycle!
Hi Qingsheng,
I like the idea of enforcing JUnit5 tests with checkstyle. I'm assuming
JUnit4 will bleed from time to time into the test classpath.
Obviously, we can only do that after all tests are migrated and we are
confident that no small change would require a contributor to do the
migration
Thanks for wrapping things up and effort on the migration Arvid!
I’m +1 for the migration plan.
To summarize the migration path proposed by Arvid:
1. Remove JUnit 4 dependency and introduce junit5-vintage-engine in the project
(all existing cases will still work)
2. Rewrite JUnit 4 rules in
Sorry for following up so late. A while ago, I spiked a junit 5 migration.
To recap: here is the migration plan.
0. (There is a way to use JUnit4 + 5 at the same time in a project - you'd
> use a specific JUnit4 runner to execute JUnit5. I'd like to skip this
> step as it would slow down
>From a user perspective it would be nice if it is possible to use
Junit 5 also for integration tests using MiniClusterWithClientResource
[1].
I would be happy to help you with the migration of a few modules, if
you need a hand with it.
Regards,
Jörn
[1]
Thanks for joining the discussion Qingsheng. In general, I am not opposed
to upgrading our testing library to JUnit 5. Also, the idea of starting
with individual modules and do it incrementally sounds reasonable.
However, before starting to do it like this, the community should agree
that we want
Hi forks,
I’d like to resume the discussion on migrating to JUnit 5. I’ve been working on
a connector testing framework and recently have an exploration on JUnit 5. I
think some features are very helpful for the development of the testing
framework:
• Extensions
JUnit 5 introduces a new
+1 for the migration
(I agree with Dawid, for me the most important benefit is better support of
parameterized tests).
Regards,
Roman
On Mon, Nov 30, 2020 at 9:42 PM Arvid Heise wrote:
> Hi Till,
>
> immediate benefit would be mostly nested tests for a better test structure
> and new
Hi Till,
immediate benefit would be mostly nested tests for a better test structure
and new parameterized tests for less clutter (often test functionality is
split into parameterized test and non-parameterized test because of JUnit4
limitation). Additionally, having Java8 lambdas to perform
Hi all,
Just wanted to express my support for the idea. I did miss certain
features of JUnit 5 already, an important one being much better support
for parameterized tests.
Best,
Dawid
On 30/11/2020 13:50, Arvid Heise wrote:
> Hi Chesnay,
>
> The vintage runner supports the old annotations, so
Doing a few required changes swiftly and then porting the remaining tests
bit by bit sounds like an approachable plan. However, it will still cost us
some effort I guess. What exactly would be the benefit of this change other
than streamlining a few things? Are there things which we cannot do at
Hi Chesnay,
The vintage runner supports the old annotations, so we don't have to change
them in the first step.
The only thing that we need to change are all rules that do not extend
ExternalResource (e.g., TestWatcher used in TestLogger). This change needs
to be done swiftly as this affects the
I presume we cannot do the migration module-wise due to shared test
utilities that rely on JUnit interfaces?
On 11/30/2020 1:30 PM, Chesnay Schepler wrote:
Is it feasible that 2 people can do the migration within a short
time-frame (say, a week)?
Must the migration of a test be done in one go,
Is it feasible that 2 people can do the migration within a short
time-frame (say, a week)?
Must the migration of a test be done in one go, or can we for example
first rename all the Before/After annotations and then to the rest?
Are there any issues with other test dependencies (i.e., hamcrest,
Dear devs,
I'd like to start a discussion to migrate to a higher JUnit version.
The main motivations are:
- Making full use of Java 8 Lambdas for writing easier to read tests and a
better performing way of composing failure messages.
- Improved test structures with nested and dynamic tests.
-
16 matches
Mail list logo
