[RESULT][VOTE] Release 1.19.0, release candidate #2

2024-03-14 Thread Lincoln Lee
Hi everyone, I'm happy to announce that we have unanimously approved this release. There are 24 approving votes, 4 of which are binding: - Xintong Song (binding) - Jean-Baptiste Onofré (non binding) - Ahmed Hamdy (non binding) - Samrat Deb (non binding) - Jeyhun Karimov (non binding) -

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-14 Thread Jiabao Sun
;> recently in a specific CI setup (GHA with AdaptiveScheduler). > >> There > >>>> is no > >>>>>>> hint in the git history indicating that it's caused by some newly > >>>>>>> introduced change. That is why I wouldn't make FLINK-34227 a > >> reason > >>>> to > >

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-14 Thread Leonard Xu
ovided in subsequent patch >>>>>>> releases. >>>>>>> >>>>>>> Matthias >>>>>>> >>>>>>> [1] https://issues.apache.org/jira/browse/FLINK-34227 >>>>>>> >>>>

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-14 Thread Jing Ge
https://issues.apache.org/jira/browse/FLINK-34227 > > > > > > > > > > > > > > On Thu, Mar 14, 2024 at 8:49 AM Jane Chan > qingyue@gmail.com > > > > wrote: > > > > > > > > > > > > > > > Hi Yun, Jing, Martijn and Lincoln, > > > > > > > >

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-14 Thread Sergey Nuyanzin
> > > > > > > appropriate. I want to ensure that the actions align with the > > > current > > > > > > > release process and do not disrupt the ongoing preparations. > > > > > > > > > > > > > > [1] htt

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-14 Thread Martijn Visser
apache/flink/pull/24492 > > > > > > > > > > > > Best, > > > > > > Jane > > > > > > > > > > > > On Thu, Mar 14, 2024 at 1:33 PM Yun Tang myas...@live.com wrote: > > > > > > > > > > > > &

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-14 Thread gongzhongqiang
; > > > > > > Best, > > > > > Jane > > > > > > > > > > On Thu, Mar 14, 2024 at 1:33 PM Yun Tang myas...@live.com wrote: > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > * &g

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-14 Thread Ferenc Csaky
se note PR > > > > > * > > > > > Reviewed the web announcement PR > > > > > * > > > > > Start a standalone cluster to submit the state machine example, which > > > > > works well. > > > > > * > > > > >

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-14 Thread Jane Chan
it the state machine example, which > > > > works well. > > > > * > > > > Checked the pre-built jars are generated via JDK8 > > > > * > > > > Verified the process profiler works well after setting > > > > rest.profiling.enabled: tr

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-14 Thread Lincoln Lee
e example, which >> > > works well. >> > > * >> > > Checked the pre-built jars are generated via JDK8 >> > > * >> > > Verified the process profiler works well after setting >> > > rest.profiling.enabled: true >> > >

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-14 Thread Lincoln Lee
the process profiler works well after setting > > > rest.profiling.enabled: true > > > > > > Best > > > Yun Tang > > > > > > > > > From: Qingsheng Ren > > > Sent: Wednesday, March 13, 2024 12:45

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-14 Thread Matthias Pohl
e state machine example, which > > works well. > > * > > Checked the pre-built jars are generated via JDK8 > > * > > Verified the process profiler works well after setting > > rest.profiling.enabled: true > > > > Best > > Yun Tang > > >

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-14 Thread Jane Chan
_ > From: Qingsheng Ren > Sent: Wednesday, March 13, 2024 12:45 > To: dev@flink.apache.org > Subject: Re: [VOTE] Release 1.19.0, release candidate #2 > > +1 (binding) > > - Verified signature and checksum > - Verified no binary in source > - Bu

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-13 Thread Yun Tang
profiler works well after setting rest.profiling.enabled: true Best Yun Tang From: Qingsheng Ren Sent: Wednesday, March 13, 2024 12:45 To: dev@flink.apache.org Subject: Re: [VOTE] Release 1.19.0, release candidate #2 +1 (binding) - Verified signature

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-12 Thread Qingsheng Ren
+1 (binding) - Verified signature and checksum - Verified no binary in source - Built from source - Tested reading and writing Kafka with SQL client and Kafka connector 3.1.0 - Verified source code tag - Reviewed release note - Reviewed web PR Thanks to all release managers and contributors for

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-12 Thread Matthias Pohl
I want to share an update on FLINK-34227 [1]: It's still not clear what's causing the test instability. So far, we agreed in today's release sync [2] that it's not considered a blocker because it is observed in 1.18 nightly builds and it only appears in the GitHub Actions workflow. But I still

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-12 Thread Benchao Li
+1 (non-binding) - checked signature and checksum: OK - checkout copyright year in notice file: OK - diffed source distribution with tag, make sure there is no unexpected files: OK - build from source : OK - start a local cluster, played with jdbc connector: OK weijie guo 于2024年3月12日周二 16:55写道:

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-12 Thread weijie guo
+1 (non-binding) - Verified signature and checksum - Verified source distribution does not contains binaries - Build from source code and submit a word-count job successfully Best regards, Weijie Jane Chan 于2024年3月12日周二 16:38写道: > +1 (non-binding) > > - Verify that the source distributions

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-12 Thread Rui Fan
+1 (non-binding) - Verified signature - Verified checksum - Built source code successfully - Reviewed the release PR and some comments are updated Best, Rui On Tue, Mar 12, 2024 at 4:08 PM Xuannan Su wrote: > +1 (non-binding) > > - Verified signature and checksum > - Verified that source

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-12 Thread Jane Chan
+1 (non-binding) - Verify that the source distributions do not contain any binaries; - Build the source distribution to ensure all source files have Apache headers; - Verify checksum and GPG signatures; Best, Jane On Tue, Mar 12, 2024 at 4:08 PM Xuannan Su wrote: > +1 (non-binding) > > -

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-12 Thread Xuannan Su
+1 (non-binding) - Verified signature and checksum - Verified that source distribution does not contain binaries - Built from source code successfully - Reviewed the release announcement PR Best regards, Xuannan On Tue, Mar 12, 2024 at 2:18 PM Hang Ruan wrote: > > +1 (non-binding) > > -

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-12 Thread Hang Ruan
+1 (non-binding) - Verified signatures and checksums - Verified that source does not contain binaries - Build source code successfully - Reviewed the release note and left a comment Best, Hang Feng Jin 于2024年3月12日周二 11:23写道: > +1 (non-binding) > > - Verified signatures and checksums > -

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-11 Thread Feng Jin
+1 (non-binding) - Verified signatures and checksums - Verified that source does not contain binaries - Build source code successfully - Run a simple sql query successfully Best, Feng Jin On Tue, Mar 12, 2024 at 11:09 AM Ron liu wrote: > +1 (non binding) > > quickly verified: > - verified

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-11 Thread Ron liu
+1 (non binding) quickly verified: - verified that source distribution does not contain binaries - verified checksums - built source code successfully Best, Ron Jeyhun Karimov 于2024年3月12日周二 01:00写道: > +1 (non binding) > > - verified that source distribution does not contain binaries > -

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-11 Thread Yanfei Lei
+1 (non-binding) - Signature and checksum are OK - Source dist doesn't contain unexpected binaries - Build from source successfully, `SocketWindowWordCount` worked well Hangxiang Yu 于2024年3月12日周二 09:59写道: > > +1 (non-binding) > > - Verified signatures and checksums > - Reviewed Web PR > -

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-11 Thread Hangxiang Yu
+1 (non-binding) - Verified signatures and checksums - Reviewed Web PR - Built from source successfully - Ran a wordcount job which worked well On Tue, Mar 12, 2024 at 1:00 AM Jeyhun Karimov wrote: > +1 (non binding) > > - verified that source distribution does not contain binaries > -

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-11 Thread Jeyhun Karimov
+1 (non binding) - verified that source distribution does not contain binaries - verified signatures and checksums - built source code successfully Regards, Jeyhun On Mon, Mar 11, 2024 at 3:08 PM Samrat Deb wrote: > +1 (non binding) > > - verified signatures and checksums > - ASF headers are

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-11 Thread Samrat Deb
+1 (non binding) - verified signatures and checksums - ASF headers are present in all expected file - No unexpected binaries files found in the source - Build successful locally - tested basic word count example Bests, Samrat On Mon, 11 Mar 2024 at 7:33 PM, Ahmed Hamdy wrote: > Hi Lincoln

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-11 Thread Ahmed Hamdy
Hi Lincoln +1 (non-binding) from me - Verified Checksums & Signatures - Verified Source dists don't contain binaries - Built source successfully - reviewed web PR Best Regards Ahmed Hamdy On Mon, 11 Mar 2024 at 15:18, Lincoln Lee wrote: > Hi Robin, > > Thanks for helping verifying the

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-11 Thread Lincoln Lee
Hi Robin, Thanks for helping verifying the release note[1], FLINK-14879 should not have been included, after confirming this I moved all unresolved non-blocker issues left over from 1.19.0 to 1.20.0 and reconfigured the release note [1]. Best, Lincoln Lee [1]

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-11 Thread Robin Moffatt
Looking at the release notes [1] it lists `DESCRIBE DATABASE` (FLINK-14879) and `DESCRIBE CATALOG` (FLINK-14690). When I try these in 1.19 RC2 the behaviour is as in 1.18.1, i.e. it is not supported: ``` [INFO] Execute statement succeed. Flink SQL> show catalogs; +-+ |catalog

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-11 Thread Jean-Baptiste Onofré
+1 (non binding) I quickly checked: - signatures and checksums are OK - ASF headers are present in all expected file - No unexpected binaries files found in the source distribution - Build OK on the tag Thanks ! Regards JB On Thu, Mar 7, 2024 at 11:00 AM Lincoln Lee wrote: > > Hi everyone, > >

Re: [VOTE] Release 1.19.0, release candidate #2

2024-03-11 Thread Xintong Song
+1 (binding) - verified signature and checksum - verified that source distribution does not contain binaries - built from source and played with example jobs, everything looks fine - reviewed the release announcement PR Best, Xintong On Thu, Mar 7, 2024 at 6:01 PM Lincoln Lee wrote: > Hi

[VOTE] Release 1.19.0, release candidate #2

2024-03-07 Thread Lincoln Lee
Hi everyone, Please review and vote on the release candidate #2 for the version 1.19.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1],