Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-20 Thread Andy Seaborne
On 19/08/15 16:23, Qihong Lin wrote: Hi Andy, I've committed the code according to your suggestion. The server side only runs QueryExecutionBase::execConstructQuads(). I've also hacked QueryEngineHTTP to test the conneg of execConstructTriples() and execConstructQuads(). For

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-18 Thread Qihong Lin
Hi Andy, Thank for your comments! I can understand your idea of A/ B/ C/. But there'a problem in practice. In brief: For A/, at the server side, always call QueryExecutionBase::execConstructDataset() For B/, the problem is, there're overlaps between DEF.rdfOffer and DEF.quadsOffer, e.g. TriX,

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-18 Thread Andy Seaborne
On 18/08/15 08:44, Qihong Lin wrote: Hi Andy, Thank for your comments! I can understand your idea of A/ B/ C/. But there'a problem in practice. In brief: For A/, at the server side, always call QueryExecutionBase::execConstructDataset() For B/, the problem is, there're overlaps between

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-17 Thread Andy Seaborne
Thanks for the clarification. I had made a combined version to start testing and hopefully it's a close approximation of the intended deliverables. [ Ying - how's your testing going? ] A few things about the pull requests so far: 0/ More tests in TestQuery in Fuseki: For example, this

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-17 Thread Qihong Lin
Hi Andy, Let me clarify PR 89 and PR 91: PR 89: confidencesun/jena/master - apache/jena/master confidencesun/jena/master contains the commits of the 1st half part of the project. It only involves jena/arq. PR 91: confidencesun/jena/JENA-491 - apache/jena/JENA-491-construct-quad

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-17 Thread Andy Seaborne
I've pushed PR91 to the JENA-491-construct-quads branch. Let's consider the is working baseline for code. Andy

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-17 Thread Andy Seaborne
On 17/08/15 16:10, Andy Seaborne wrote: I've pushed PR91 to the JENA-491-construct-quads branch. Let's consider the is working baseline for code. ^^ this as the Andy

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-16 Thread Andy Seaborne
Hi - there are some problems with PR 91. PR 91 contains changes to jena-arq as well as jena-fuseki-core. Does PR 91 replace PR 89 or does PR 91 contain some out-of-date update now in PR 89? Or something else? ( Line 1 of PR 91 as a diff is: diff --git a/jena-arq/Grammar/arq.jj

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-15 Thread Ying Jiang
Hi, The doc is actually construct-quad.mdtext. In another easy way, You can just compose it offline, and send it to us for review. I can help you commit the mdtext file into svn finally. Best regards, Ying Jiang On Sat, Aug 15, 2015 at 5:21 PM, Qihong Lin confidence@gmail.com wrote: Hi,

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-15 Thread Qihong Lin
Hi, Please check my updates of the 3 tasks blow: 1) jena/arq: in master branch (to be merged first) In PR 89, I added some more tests in TestAPI and TS_Script. The bug of construct quad projection on exeConstructTriples() has been fixed, with the tests of 4 cases (commit 03a321f). 2)

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-12 Thread Qihong Lin
Hi Andy, I can not find the branch of JENA-491-construct-quads in Jena git repository: https://github.com/apache/jena/branches regards, Qihong On Tue, Aug 11, 2015 at 4:12 PM, Andy Seaborne a...@apache.org wrote: On 11/08/15 03:35, Ying Jiang wrote: Hi Qihong, You may have received the

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-12 Thread Andy Seaborne
On 12/08/15 08:16, Qihong Lin wrote: Hi Andy, I can not find the branch of JENA-491-construct-quads in Jena git repository: https://github.com/apache/jena/branches regards, Qihong I don't know how branches propagate to github - maybe they need something on them, maybe it's stuck. But

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-12 Thread Qihong Lin
Hi Andy, I've got the idea of projection. The bug has been fixed. I'll deliver more tests. Thanks! Qihong On Tue, Aug 11, 2015 at 4:52 PM, Andy Seaborne a...@apache.org wrote: On 11/08/15 09:11, Qihong Lin wrote: hi Andy, I'll further enrich the test data and add JUnit tests in TestAPI for

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-11 Thread Andy Seaborne
On 11/08/15 09:11, Qihong Lin wrote: hi Andy, I'll further enrich the test data and add JUnit tests in TestAPI for better coverage. I'm thinking of the problem you mentioned. In fact, there're 2 types of query strings: a) Query String without Construct Quad, e.g. CONSTRUCT { ?s ?p ?o } WHERE {

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-11 Thread Qihong Lin
hi Andy, I'll further enrich the test data and add JUnit tests in TestAPI for better coverage. I'm thinking of the problem you mentioned. In fact, there're 2 types of query strings: a) Query String without Construct Quad, e.g. CONSTRUCT { ?s ?p ?o } WHERE { ?s ?p ?o }; b) Query String with

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-11 Thread Andy Seaborne
On 11/08/15 03:35, Ying Jiang wrote: Hi Qihong, You may have received the reminder email from Google that the final evaluation of the GSoC project is approaching. The soft deadline is 17 August, with the hard one on 21 August. It means there're only 2 weeks left for your remaining work. The

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-10 Thread Ying Jiang
Hi Qihong, You may have received the reminder email from Google that the final evaluation of the GSoC project is approaching. The soft deadline is 17 August, with the hard one on 21 August. It means there're only 2 weeks left for your remaining work. The tests of arq need improving, as Andy

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-10 Thread Qihong Lin
Hi, I've enriched the syntax tests with short form and default graph cases. For execution tests, I add the test support in QueryTest for construct quad with the scripts files and data files in TRIG (see jena-arq/testing/ARQ/Construct/*.trig). I think construct quad should be part of the

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-06 Thread Andy Seaborne
Hi - looking better - I see the syntax tests I provided. Does that set of tests cover all cases of the new syntax? Next, we need execution tests for ARQ. There will need to be execute tests in jena-arq as well. These can be Junit tests in java and do not need to be external script files. This

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-05 Thread Qihong Lin
Hi, I've fixed the bugs related to syntax checks. Please see my latest commits. Here're the output of the syntax files through qparse (you can also run ExampleConstructQuads.java to get the results). Are these with the expected behaviors, especially for syntax-quad-construct-07.arq?

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-08-01 Thread Ying Jiang
Hi Qihong, I re-checked the code you commited. Most of the hashCode issues for arq.qparse that Andy pointed out are due to the incorrect serialization of the Template. The code can only deal with the quads with the same graph node, for which it may not always be the case in practcial terms.

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-07-30 Thread Andy Seaborne
Output of * each examnple syntax file (the queries are nonsense in practcial terms!) * running arq.qparse on the file * notes on what seems to be going on Andy File: syntax-quad-construct-01.arq PREFIX : http://example/ CONSTRUCT { GRAPH :g { :s :p :o } } WHERE {} Output

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-07-30 Thread Andy Seaborne
-archives.apache.org/mod_mbox/jena-dev/201507.mbox/%3C559EF342.3010806%40apache.org%3E Andy -- Forwarded message -- From: Qihong Lin confidence@gmail.com Date: Tue, Jul 21, 2015 at 9:25 AM Subject: Fwd: Final Deliveries of GSoC Project (JENA-491) To: Ying Jiang jpz6311

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-07-29 Thread Qihong Lin
Subject: Fwd: Final Deliveries of GSoC Project (JENA-491) To: Ying Jiang jpz6311...@gmail.com Hi, Dr. Jiang, How can I have the commit access to the svn server? I also tried the Improve this Page, which asked for user/password. The documentation seems to be wiki style. It's better to have

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-07-28 Thread Ying Jiang
. The patch approach is not so convenient. regards, Qihong -- Forwarded message -- From: Bruno P. Kinoshita ki...@apache.org Date: Sun, Jul 19, 2015 at 5:52 AM Subject: Re: Final Deliveries of GSoC Project (JENA-491) To: dev@jena.apache.org dev@jena.apache.org For 1

Re: Fwd: Final Deliveries of GSoC Project (JENA-491)

2015-07-21 Thread Andy Seaborne
://mail-archives.apache.org/mod_mbox/jena-dev/201507.mbox/%3C559EF342.3010806%40apache.org%3E Andy -- Forwarded message -- From: Qihong Lin confidence@gmail.com Date: Tue, Jul 21, 2015 at 9:25 AM Subject: Fwd: Final Deliveries of GSoC Project (JENA-491) To: Ying Jiang

Re: Final Deliveries of GSoC Project (JENA-491)

2015-07-19 Thread Andy Seaborne
Qihong, I hope the exams have gone well. All of the tasks include delivery and it is this aspect we need to concentrate on now. There needs to be: 1. Code and grammar changes 2. Tests 3. Pull requests 4. Documentation I've looked through

Re: Final Deliveries of GSoC Project (JENA-491)

2015-07-18 Thread Bruno P. Kinoshita
6:17 AM Subject: Re: Final Deliveries of GSoC Project (JENA-491) Hi, I've been taking some course exams for the last week. The current project status is ahead of plan. I'll continue the project next week after the exams. For 1), how to commit the documentation in Jena website? regards

Re: Final Deliveries of GSoC Project (JENA-491)

2015-07-18 Thread Qihong Lin
Hi, I've been taking some course exams for the last week. The current project status is ahead of plan. I'll continue the project next week after the exams. For 1), how to commit the documentation in Jena website? regards, Qihong On Wed, Jul 15, 2015 at 5:43 PM, Ying Jiang jpz6311...@gmail.com