Re: [DISCUSS] KIP-1039: Disable automatic topic creation for MirrorMaker2 consumers

2024-04-30 Thread Chris Egerton
Hi Aaron, Thanks for publishing this KIP after the feedback on your PR. I'm generally in favor but have a few questions: 1) Is the consumer mentioned in the KIP the one constructed by the MirrorSourceConnector for polling replicated records from the source cluster? If yes, are there any other

Re: [DISCUSS] KIP-1039: Disable automatic topic creation for MirrorMaker2 consumers

2024-04-19 Thread aaron ai
Hi Omnia, Thanks for your feedback! Yes, another approach could be to disable this option manually. IMHO, it's hard to envision a scenario where enabling it would be necessary. BTW, I've already added this part into the KIP. On Fri, Apr 19, 2024 at 6:18 PM Omnia Ibrahim wrote: > Hi Aaron, >

Re: [DISCUSS] KIP-1039: Disable automatic topic creation for MirrorMaker2 consumers

2024-04-19 Thread Omnia Ibrahim
Hi Aaron, You mentioned that there is no public interface changes however changing the default value of a config should be considered as a public change. You can check other KIP where we changed the default config value for a reference. Can you please list what is the impact of changing the

[DISCUSS] KIP-1039: Disable automatic topic creation for MirrorMaker2 consumers

2024-04-19 Thread aaron ai
Hi all, Here is the KIP-1039: Disable automatic topic creation for MirrorMaker2 consumers < https://cwiki.apache.org/confluence/display/KAFKA/KIP-1039%3A+Disable+automatic+topic+creation+for+MirrorMaker2+consumers > Looking forward to your feedback! Best regards, Aaron