Thanks for the KIP. LGTM.
I believe you can start a vote.
-Matthias
On 6/26/23 11:25 AM, Lucia Cerchie wrote:
Thanks for asking for clarification, Sophie; that gives me guidance on
improving the KIP! Here's the updated version, including the JIRA link:
Thanks for asking for clarification, Sophie; that gives me guidance on
improving the KIP! Here's the updated version, including the JIRA link:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-941%3A+Range+queries+to+accept+null+lower+and+upper+bounds
On Thu, Jun 22, 2023 at 12:57 PM Sophie
Hey Lucia, thanks for the KIP! Just some minor notes:
I'm in favor of the proposal overall, at least I think so -- for someone
not intimately familiar with the new IQ API and *RangeQuery* class, the KIP
was a bit difficult to follow along and I had to read in between the lines
to figure out what
Thanks Kirk and John for the valuable feedback!
John, I'll update the KIP to reflect that nuance you mention -- yes it is
just about making the withRange method more permissive. Thanks for the
testing file as well, I'll be sure to write my test cases there.
On Wed, Jun 21, 2023 at 10:50 AM Kirk
Hi John/Lucia,
Thanks for the feedback!
Of course I only noticed the private-ness of the RangeQuery constructor moments
after sending my email ¯\_(ツ)_/¯
Just to be clear, I’m happy with the proposed change as it conforms to Postel’s
Law ;) Apologies that it was worded tersely.
Thanks,
Kirk
Hi all,
Thanks for the KIP, Lucia! This is a nice change.
To Kirk's question (1), the example is a bit misleading. The typical
case that would ease user pain is specifically using "null" to indicate
an open-ended range, especially since null is not a valid key.
I could additionally see an
Hi Lucia,
One question:
1. Since the proposed implementation change for withRange() method uses
Optional.ofNullable() (which only catches nulls and not blank/whitespace
strings), wouldn’t users still need to have code like that in the example?
2. Why don't users create RangeQuery objects
Hi Lucia,
Thanks for the KIP!
The KIP wasn’t in the email and I didn’t see it on the main KIP directory. Here
it is:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-941%3A+Range+queries+to+accept+null+lower+and+upper+bounds
Can the KIP be added to the main KIP page
Hi everyone,
I'd like to discuss KIP-941, which will change the behavior of range
queries to make it easier for users to execute full range scans when using
interactive queries with upper and lower bounds from query parameters in
web client requests.
I much appreciate your input!
Lucia Cerchie
