Re: [VOTE] KIP-1000: List Client Metrics Configuration Resources

2023-11-20 Thread Andrew Schofield
The voting for this KIP is now complete. +3 binding (Jun, Jason, Matthias) +2 non-binding (Doğuşcan, Apoorv) Thanks, Andrew > On 20 Nov 2023, at 21:42, Jason Gustafson wrote: > > +1 Thanks for the KIP! > > On Mon, Nov 20, 2023 at 9:31 AM Jun Rao wrote: > >> Hi, Andrew, >> >> Thanks for the

Re: [VOTE] KIP-1000: List Client Metrics Configuration Resources

2023-11-20 Thread Matthias J. Sax
+1 (binding) On 11/20/23 1:42 PM, Jason Gustafson wrote: +1 Thanks for the KIP! On Mon, Nov 20, 2023 at 9:31 AM Jun Rao wrote: Hi, Andrew, Thanks for the KIP. +1 Jun On Thu, Nov 16, 2023 at 9:12 AM Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: Hi Apoorv, Thanks for your

Re: [VOTE] KIP-1000: List Client Metrics Configuration Resources

2023-11-20 Thread Jason Gustafson
+1 Thanks for the KIP! On Mon, Nov 20, 2023 at 9:31 AM Jun Rao wrote: > Hi, Andrew, > > Thanks for the KIP. +1 > > Jun > > On Thu, Nov 16, 2023 at 9:12 AM Andrew Schofield < > andrew_schofield_j...@outlook.com> wrote: > > > Hi Apoorv, > > Thanks for your vote. > > > > Initially, I put support

Re: [VOTE] KIP-1000: List Client Metrics Configuration Resources

2023-11-20 Thread Jun Rao
Hi, Andrew, Thanks for the KIP. +1 Jun On Thu, Nov 16, 2023 at 9:12 AM Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Hi Apoorv, > Thanks for your vote. > > Initially, I put support for zkBroker in order to be able to control the > error response in this case. > I have

Re: [VOTE] KIP-1000: List Client Metrics Configuration Resources

2023-11-16 Thread Andrew Schofield
Hi Apoorv, Thanks for your vote. Initially, I put support for zkBroker in order to be able to control the error response in this case. I have validated the error handling for this RPC on a ZK cluster in which the RPC is not supported, and the error is entirely understandable. Consequently, I

Re: [VOTE] KIP-1000: List Client Metrics Configuration Resources

2023-11-16 Thread Apoorv Mittal
Thanks a lot for writing the KIP Andrew. This is much required to list all configured client metrics resources. I have one minor question related to the zkBroker listener in the new RPC. As the client-metrics resource is not supported in Zookeeper mode hence shouldn't we disallow

Re: [VOTE] KIP-1000: List Client Metrics Configuration Resources

2023-11-16 Thread Doğuşcan Namal
Thanks for the brief KIP Andrew. Having discussed the details in KIP-714, I see this is a natural follow up to that. +1(non-binding) On Wed, 15 Nov 2023 at 15:23, Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Hi, > I’d like to start the voting for KIP-1000: List Client Metrics

[VOTE] KIP-1000: List Client Metrics Configuration Resources

2023-11-15 Thread Andrew Schofield
Hi, I’d like to start the voting for KIP-1000: List Client Metrics Configuration Resources. https://cwiki.apache.org/confluence/display/KAFKA/KIP-1000%3A+List+Client+Metrics+Configuration+Resources Thanks, Andrew