Re: [VOTE] KIP-1031: Control offset translation in MirrorSourceConnector

2024-04-24 Thread Omnia Ibrahim
Thanks Igor, I’ll conclude the vote with 3 binding votes from Mickael Maison, Chris Egerton and Igor Soarez. Thanks everyone > On 24 Apr 2024, at 15:11, Igor Soarez wrote: > > Hi Omnia, > > Thanks for your answers, and I see you've updated the KIP so thanks for the > changes too. > > +1

Re: [VOTE] KIP-1031: Control offset translation in MirrorSourceConnector

2024-04-24 Thread Igor Soarez
Hi Omnia, Thanks for your answers, and I see you've updated the KIP so thanks for the changes too. +1 (binding), thanks for the KIP -- Igor

Re: [VOTE] KIP-1031: Control offset translation in MirrorSourceConnector

2024-04-24 Thread Omnia Ibrahim
I updated the KIP as well to briefly explain how offset.lag.max would help latency. Please let me know if the KIP now looks better? > On 24 Apr 2024, at 11:49, Omnia Ibrahim wrote: > > Thanks Igor for the suggestions. I updated the KIP with some of them. > >> s/recored's offset/recorded

Re: [VOTE] KIP-1031: Control offset translation in MirrorSourceConnector

2024-04-24 Thread Omnia Ibrahim
Thanks Igor for the suggestions. I updated the KIP with some of them. > s/recored's offset/recorded offsets I actually mean record’s offset and not recorded offset. MirrorSourceConnector store the offset of the committed record on the destination cluster in an internal topic. > 12. The use

Re: [VOTE] KIP-1031: Control offset translation in MirrorSourceConnector

2024-04-20 Thread Igor Soarez
Hi Omnia, Thanks for this KIP. 11. These seem to me to be small misspellings, please double-check: s/MM2 main features/MM2's main features s/syncing consumer group offset/syncing consumer group offsets s/relays/relies s/recored's offset/recorded offsets s/clusters without need for/clusters

Re: [VOTE] KIP-1031: Control offset translation in MirrorSourceConnector

2024-04-17 Thread Omnia Ibrahim
Thanks Chris and Mickael for the votes. Can I please get one last +1 binding vote please? Thanks Omnia > On 12 Apr 2024, at 13:21, Chris Egerton wrote: > > +1 (binding), thanks Omnia! > > On Fri, Apr 12, 2024, 03:46 Mickael Maison wrote: > >> Hi Omnia, >> >> +1 (binding), thanks for the

Re: [VOTE] KIP-1031: Control offset translation in MirrorSourceConnector

2024-04-12 Thread Chris Egerton
+1 (binding), thanks Omnia! On Fri, Apr 12, 2024, 03:46 Mickael Maison wrote: > Hi Omnia, > > +1 (binding), thanks for the KIP! > > Mickael > > On Fri, Apr 12, 2024 at 9:01 AM Omnia Ibrahim > wrote: > > > > Hi everyone, I would like to start a voting thread for KIP-1031: Control > offset

Re: [VOTE] KIP-1031: Control offset translation in MirrorSourceConnector

2024-04-12 Thread Mickael Maison
Hi Omnia, +1 (binding), thanks for the KIP! Mickael On Fri, Apr 12, 2024 at 9:01 AM Omnia Ibrahim wrote: > > Hi everyone, I would like to start a voting thread for KIP-1031: Control > offset translation in MirrorSourceConnector >

[VOTE] KIP-1031: Control offset translation in MirrorSourceConnector

2024-04-12 Thread Omnia Ibrahim
Hi everyone, I would like to start a voting thread for KIP-1031: Control offset translation in MirrorSourceConnector https://cwiki.apache.org/confluence/display/KAFKA/KIP-1031%3A+Control+offset+translation+in+MirrorSourceConnector For comments or feedback please check the discussion thread here