Re: [VOTE] KIP-995: Allow users to specify initial offsets while creating connectors

Thanks Folks, Renamed the field to `offsets_status`. And now that we have 3 binding votes, I will update the KIP status to `accepted` . Thanks again for all the valuable feedback. Ashwin On Wed, Mar 6, 2024 at 2:42 PM Chris Egerton wrote: > Hi Yash, > > Thanks for the follow-up, I like the

Re: [VOTE] KIP-995: Allow users to specify initial offsets while creating connectors

Hi Yash, Thanks for the follow-up, I like the benefits it's yielded. I too think "offsets_status" would be a better name for the response field. @Ashwin--thoughts? Cheers, Chris On Wed, Mar 6, 2024, 03:08 Ashwin wrote: > Thanks Yash, > > Yes , I think we can use

Re: [VOTE] KIP-995: Allow users to specify initial offsets while creating connectors

Thanks Yash, Yes , I think we can use @JsonInclude(JsonInclude.Include.NON_NULL) to exclude “initial_offsets_response” from the create response if offset is not specified. I’ll close the voting this week , if there are no further comments. Thanks for voting, everyone! Ashwin On Tue, Mar 5,

Re: [VOTE] KIP-995: Allow users to specify initial offsets while creating connectors

Hi Chris, I followed up with Ashwin offline and I believe he wanted to take a closer look at the `ConnectorInfoWithInitialOffsetsResponse` stuff he mentioned in the previous email and whether or not that'll be required (alternatively using some Jackson JSON tricks). However, that's an

Re: [VOTE] KIP-995: Allow users to specify initial offsets while creating connectors

Hi all, Wanted to bump this and see if it looks good enough for a third vote. Yash, any thoughts? Cheers, Chris On Mon, Jan 29, 2024 at 2:55 AM Ashwin wrote: > Thanks for reviewing this KIP, Yash. > > Could you please elaborate on the cleanup steps? For instance, if we > > encounter an

Re: [VOTE] KIP-995: Allow users to specify initial offsets while creating connectors

Thanks for reviewing this KIP, Yash. Could you please elaborate on the cleanup steps? For instance, if we > encounter an error after wiping existing offsets but before writing the new > offsets, there's not really any good way to "revert" the wiped offsets. > It's definitely extremely unlikely

Re: [VOTE] KIP-995: Allow users to specify initial offsets while creating connectors

Hi Ashwin, Thanks for the KIP. > If Connect runtime encounters an error in any of these steps, > it will cleanup (if required) and return an error response Could you please elaborate on the cleanup steps? For instance, if we encounter an error after wiping existing offsets but before writing

Re: [VOTE] KIP-995: Allow users to specify initial offsets while creating connectors

Hi All , Can I please get one more binding vote, so that the KIP is approved ? Thanks for the votes Chris and Mickael ! - Ashwin On Thu, Jan 11, 2024 at 3:55 PM Mickael Maison wrote: > Hi Ashwin, > > +1 (binding), thanks for the KIP > > Mickael > > On Tue, Jan 9, 2024 at 4:54 PM Chris

Re: [VOTE] KIP-995: Allow users to specify initial offsets while creating connectors

Hi Ashwin, +1 (binding), thanks for the KIP Mickael On Tue, Jan 9, 2024 at 4:54 PM Chris Egerton wrote: > > Thanks for the KIP! +1 (binding) > > On Mon, Jan 8, 2024 at 9:35 AM Ashwin wrote: > > > Hi All, > > > > I would like to start a vote on KIP-995. > > > > > >

Re: [VOTE] KIP-995: Allow users to specify initial offsets while creating connectors

Thanks for the KIP! +1 (binding) On Mon, Jan 8, 2024 at 9:35 AM Ashwin wrote: > Hi All, > > I would like to start a vote on KIP-995. > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-995%3A+Allow+users+to+specify+initial+offsets+while+creating+connectors > > Discussion thread - >

[VOTE] KIP-995: Allow users to specify initial offsets while creating connectors

Hi All, I would like to start a vote on KIP-995. https://cwiki.apache.org/confluence/display/KAFKA/KIP-995%3A+Allow+users+to+specify+initial+offsets+while+creating+connectors Discussion thread - https://lists.apache.org/thread/msorbr63scglf4484yq764v7klsj7c4j Thanks! Ashwin