Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-25 Thread Luke Chen
Hi Jose, Sounds good to me. Let's have further discussion in JIRA/PR, and target to v3.6.1/v3.7.0. Thanks. Luke On Tue, Sep 26, 2023 at 1:35 AM José Armando García Sancio wrote: > On Sat, Sep 23, 2023 at 3:08 AM Luke Chen wrote: > > > > Hi Satish, > > > > I found the current KRaft

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-25 Thread José Armando García Sancio
On Sat, Sep 23, 2023 at 3:08 AM Luke Chen wrote: > > Hi Satish, > > I found the current KRaft implementation will have "split brain" issue when > network partition happens, which will cause inconsistent metadata returned > from the controller. > Filed KAFKA-15489

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-25 Thread Satish Duggana
Thanks Luke for reporting the High CVE issue. Ismael also confirmed that High CVEs are generally considered as release blockers. Agree with all that we should consider this CVE as a release blocker. We will include other CVE also with the next RC. ~Satish. On Mon, 25 Sept 2023 at 03:04, Luke

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-25 Thread Luke Chen
Hi Divij, About the system tests, it's me helping Satish working on it since our team has internal jenkins pipeline for it. Here's the result: https://drive.google.com/drive/folders/1S2XYd79f6_AeWj9f9qEkliRg7JtL04AC?usp=sharing I'm mainly focusing on the failed tests. For kraft_upgrade_test,

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-25 Thread Divij Vaidya
Correction: posted the wrong JIRA in my previous email. Instead of https://issues.apache.org/jira/browse/KAFKA-15001, please consider this https://issues.apache.org/jira/browse/KAFKA-15487 -- Divij Vaidya On Mon, Sep 25, 2023 at 10:04 AM Divij Vaidya wrote: > > Hi Satish > > 1. I agree with

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-25 Thread Divij Vaidya
Hi Satish 1. I agree with Luke. It's a "high" severity vulnerability and we should create another RC with the upgraded Snappy version. If we create another RC, we should also fix a different CVE resported in https://issues.apache.org/jira/browse/KAFKA-15001 2. I was hoping you could post the

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-25 Thread Luke Chen
Hi Satish, Snappy-java published a new vulnerability that will cause OOM error in the server. Kafka is also impacted by this vulnerability since it's like CVE-2023-34455

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-25 Thread Satish Duggana
Thanks to everyone who voted for this release. We have 2 +1 PMC votes and 3 +1 non-binding votes. We are past the deadline. Please try RC1 and send your vote to this email thread. Thanks, Satish. On Sun, 24 Sept 2023 at 13:23, Justine Olshan wrote: > > Hi Satish, > > I've done the following:

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-24 Thread Justine Olshan
Hi Satish, I've done the following: - Verified signature - Built from Java 17/Scala 2.13 and Java 8/Scala 2.11 - Run unit + integration tests - Ran a shorter Trogdor transactional-produce-bench on a single broker cluster (KRaft and ZK) to verify transactional workloads worked reasonably Minor

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-24 Thread Federico Valeri
Hi Satish, I did the following to verify the release: - Verified signature and checksum - Built from source with Java 17 and Scala 2.13 - Ran all unit and integration tests - Spot checked release notes and documentation - Ran a custom client using staging artifacts on a 3-nodes cluster - Tested

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-24 Thread Luke Chen
Hi Satish, I verified with: 1. Ran quick start in KRaft for scala 2.12 artifact 2. Making sure the checksum are correct 3. Browsing release notes, documents, javadocs, protocols. I filed KAFKA-15491 for log output improvement while testing

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-23 Thread Ismael Juma
Given that this is not a regression and there have been no reports for over a year, I think it's ok for this to land in 3.6.1. Ismael On Sat, Sep 23, 2023 at 9:32 AM Satish Duggana wrote: > Thanks Luke for reporting KRaft issue[1]. > > I am not sure whether it is a release blocker for 3.6.0.

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-23 Thread Satish Duggana
Thanks Luke for reporting KRaft issue[1]. I am not sure whether it is a release blocker for 3.6.0. Need input from other KRaft experts also to finalize the decision. Even if we adopt a fix, do not we need to bake it for some time before it is pushed to production to avoid any regressions as this

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-23 Thread Luke Chen
Hi Satish, I found the current KRaft implementation will have "split brain" issue when network partition happens, which will cause inconsistent metadata returned from the controller. Filed KAFKA-15489 for this issue, and PR

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-21 Thread Josep Prat
Hi Satish, I ran the following validation steps: - Built from source with Java 11 and Scala 2.13 - Verified Signatures and hashes of the artifacts generated - Navigated through Javadoc including links to JDK classes - Run the unit tests - Run integration tests - Run the quickstart in KRaft and

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-20 Thread Satish Duggana
Thanks Greg for verifying the release including the earlier blocker(KAFKA-15473) verification. ~Satish. On Wed, 20 Sept 2023 at 22:30, Greg Harris wrote: > Hi all, > > I verified the functionality of KIP-898 and the recent fix for > KAFKA-15473 with the following steps: > > 1. I started a

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-20 Thread Satish Duggana
Hi Divij, Thanks for calling out documentation issues. Some of them are being addressed in the existing documentation PRs. We will keep addressing the remaining documentation issues by making respective changes in kafka-site repo for 3.6.0 release. I think documentation is important but I do not

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-20 Thread Gary Russell
My apologies; both classes are in the server-common...-test jar. Both issues can be closed. From: Gary Russell Sent: Wednesday, September 20, 2023 3:56 PM To: us...@kafka.apache.org ; dev Subject: Re: [kafka-clients] [VOTE] 3.6.0 RC1 I have lowered the priority

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-20 Thread Gary Russell
://issues.apache.org/jira/browse/KAFKA-15092 From: Gary Russell Sent: Wednesday, September 20, 2023 3:36 PM To: us...@kafka.apache.org ; dev Subject: Re: [kafka-clients] [VOTE] 3.6.0 RC1 This is a blocker for me [1]. https://issues.apache.org/jira/browse/KAFKA-15482

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-20 Thread Gary Russell
This is a blocker for me [1]. https://issues.apache.org/jira/browse/KAFKA-15482 From: Greg Harris Sent: Wednesday, September 20, 2023 12:45 PM To: us...@kafka.apache.org Cc: dev ; kafka-clie...@googlegroups.com Subject: Re: [kafka-clients] [VOTE] 3.6.0 RC1

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-20 Thread Greg Harris
Hi all, I verified the functionality of KIP-898 and the recent fix for KAFKA-15473 with the following steps: 1. I started a 3.5.1 broker, and a 3.5.1 worker with most (>400) publicly available plugins installed 2. I captured the output of /connector-plugins 3. I upgraded the worker to 3.6.0-rc1

Re: [kafka-clients] [VOTE] 3.6.0 RC1

2023-09-20 Thread Divij Vaidya
Hey Satish My comments about documentation misses from RC0 vote thread [1] are still not addressed (such as missing metric documentation, formatting problems etc). Could you please mention why we shouldn't consider them as blockers to make RC1 as the final release? [1]