---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26755/#review59679
---
Ship it!
Minor points that I can fix on check-in.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26755/
---
(Updated Oct. 29, 2014, 5:57 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26755/#review58831
---
Can we add a unit test as well?
- Joel Koshy
On Oct. 28, 2014,
On Oct. 25, 2014, 7:52 a.m., Joel Koshy wrote:
Joel, thanks a lot for the review! Some comments on your comments.
On Oct. 25, 2014, 7:52 a.m., Joel Koshy wrote:
core/src/main/scala/kafka/utils/ByteBoundedBlockingQueue.scala, line 18
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26755/
---
(Updated Oct. 27, 2014, 6:47 a.m.)
Review request for kafka.
Bugs:
On Oct. 25, 2014, 7:52 a.m., Joel Koshy wrote:
core/src/main/scala/kafka/utils/ByteBoundedBlockingQueue.scala, line 109
https://reviews.apache.org/r/26755/diff/3/?file=722245#file722245line109
getAndDecrement(sizeFunction.get(e))
Jiangjie Qin wrote:
It seems
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26755/#review58725
---
Another thing I forgot to mention in the earlier review: we
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26755/
---
(Updated Oct. 28, 2014, 1:34 a.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26755/#review58497
---
core/src/main/scala/kafka/utils/ByteBoundedBlockingQueue.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26755/
---
Review request for kafka.
Bugs: KAFKA-1706
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26755/
---
(Updated Oct. 15, 2014, 4:26 p.m.)
Review request for kafka.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26755/
---
(Updated Oct. 15, 2014, 4:28 p.m.)
Review request for kafka.
Bugs:
12 matches
Mail list logo