Re: Review Request 31369: Patch for KAFKA-1982

2015-04-18 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review80607 --- There seems to be a bunch of checkstyle failures. Could you address

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-17 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/ --- (Updated April 17, 2015, 9:49 p.m.) Review request for kafka. Bugs:

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-17 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/ --- (Updated April 17, 2015, 10:09 p.m.) Review request for kafka. Bugs:

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-17 Thread Ashish Singh
On April 7, 2015, 10:41 p.m., Jun Rao wrote: Sorry for the late review. A few more comments below. Done! - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review77523

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-17 Thread Ashish Singh
On March 25, 2015, 4:48 p.m., Mayuresh Gharat wrote: Thanks for the review. Addressed your comment. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review77747

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-17 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review80555 --- Thanks for the patch. A few more minor comments.

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-17 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/ --- (Updated April 18, 2015, midnight) Review request for kafka. Bugs:

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-17 Thread Ashish Singh
On April 17, 2015, 11:05 p.m., Jun Rao wrote: Thanks for the patch. A few more minor comments. Jun thanks for the review again. Addressed your comments. - Ashish --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 31369: Patch for KAFKA-1982

2015-04-07 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review77523 --- Sorry for the late review. A few more comments below.

Re: Review Request 31369: Patch for KAFKA-1982

2015-03-06 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review75529 --- Ship it! Thats a really sweet producer example :) LGTM. - Gwen

Re: Review Request 31369: Patch for KAFKA-1982

2015-03-03 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/ --- (Updated March 4, 2015, 1:51 a.m.) Review request for kafka. Bugs:

Re: Review Request 31369: Patch for KAFKA-1982

2015-03-03 Thread Ashish Singh
On March 3, 2015, 5:42 a.m., Jun Rao wrote: Thanks for the review Jun! Addressed your concerns. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review74895

Re: Review Request 31369: Patch for KAFKA-1982

2015-03-03 Thread Ashish Singh
On Feb. 27, 2015, 7:29 p.m., Gwen Shapira wrote: Thanks for the patch, Ashish. Its shaping up to be a very useful example. Two comments: 1. I think the ser/de should be part of the example and not in common, I'm not sure integer ser/de is useful enough to be distributed with Kafka

Re: Review Request 31369: Patch for KAFKA-1982

2015-03-02 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review74895 ---

Re: Review Request 31369: Patch for KAFKA-1982

2015-03-02 Thread Jun Rao
On Feb. 27, 2015, 7:29 p.m., Gwen Shapira wrote: Thanks for the patch, Ashish. Its shaping up to be a very useful example. Two comments: 1. I think the ser/de should be part of the example and not in common, I'm not sure integer ser/de is useful enough to be distributed with Kafka

Re: Review Request 31369: Patch for KAFKA-1982

2015-02-27 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/ --- (Updated Feb. 27, 2015, 7:08 p.m.) Review request for kafka. Bugs:

Re: Review Request 31369: Patch for KAFKA-1982

2015-02-27 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review74553 --- Thanks for the patch, Ashish. Its shaping up to be a very useful

Re: Review Request 31369: Patch for KAFKA-1982

2015-02-27 Thread Ashish Singh
On Feb. 26, 2015, 10:27 p.m., Jun Rao wrote: examples/src/main/java/kafka/examples/Consumer.java, line 62 https://reviews.apache.org/r/31369/diff/4/?file=875219#file875219line62 It would be useful to print out the key as well. Added On Feb. 26, 2015, 10:27 p.m., Jun Rao wrote:

Review Request 31369: Patch for KAFKA-1982

2015-02-24 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/ --- Review request for kafka. Bugs: KAFKA-1982

Re: Review Request 31369: Patch for KAFKA-1982

2015-02-24 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/ --- (Updated Feb. 24, 2015, 6:35 p.m.) Review request for kafka. Bugs:

Re: Review Request 31369: Patch for KAFKA-1982

2015-02-24 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/ --- (Updated Feb. 25, 2015, 4:48 a.m.) Review request for kafka. Bugs:

Re: Review Request 31369: Patch for KAFKA-1982

2015-02-24 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/ --- (Updated Feb. 25, 2015, 4:45 a.m.) Review request for kafka. Bugs: