Re: [ovs-dev] [PATCH RFC v1] ovn: add SLAAC support for IPv6

2016-07-28 Thread Ben Pfaff
On Wed, Jul 27, 2016 at 04:02:11PM +0800, Zong Kai LI wrote: > This patch introduces(from north to south): > - OVN NB DB: > * mtu(integer) column for Logical_Switch, used by Router Advertisement >(RA) message MTU option. > * slaac(bool) column for Logical_Router_Port to specify the IPv6

Re: [ovs-dev] [PATCH v5 05/16] conntrack: Periodically delete expired connections.

2016-07-28 Thread Daniele Di Proietto
On 27/07/2016 21:13, "Joe Stringer" wrote: >On 27 July 2016 at 19:01, Daniele Di Proietto wrote: >> >> >> >> >> >> On 27/07/2016 17:14, "Joe Stringer" wrote: >> >>>On 26 July 2016 at 17:58, Daniele Di Proietto

[ovs-dev] [PATCH 2/2] ovn: fix lrouter flows building issue when easy SNAT configured

2016-07-28 Thread Dongjun
The lrouter drop the traffic to it's own port IPs unless the IPs are configured for SNAT. Now these flows are still built. Signed-off-by: Dongjun --- ovn/northd/ovn-northd.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) mode change 100644 => 100755

[ovs-dev] [PATCH 1/2] ovn:add easy SNAT test case

2016-07-28 Thread Dongjun
Signed-off-by: Dongjun --- tests/system-ovn.at | 106 +++- 1 file changed, 105 insertions(+), 1 deletion(-) mode change 100644 => 100755 tests/system-ovn.at diff --git a/tests/system-ovn.at b/tests/system-ovn.at old mode 100644

Re: [ovs-dev] tests: Add new pmd test for pmd-rxq-affinity.

2016-07-28 Thread Ilya Maximets
Thanks for making this. Acked-by: Ilya Maximets On 27.07.2016 23:12, Daniele Di Proietto wrote: > This tests that the newly introduced pmd-rxq-affinity option works as > intended, at least for a single port. > > Signed-off-by: Daniele Di Proietto

Re: [ovs-dev] [PATCH v5 00/16] Userspace (DPDK) connection tracker

2016-07-28 Thread Ilya Maximets
I guess, you pushed some development version of this patch set. There is strange commit there: commit 6c54734ed27bc22975d7035a6bd5f32a412335a0 Author: Daniele Di Proietto Date: Wed Jul 27 18:32:15 2016 -0700 XXX Improve comment. Best regards, Ilya Maximets.

Re: [ovs-dev] [PATCH] ovs-numa: fixed cmask parse with 0x prefix

2016-07-28 Thread Shen, Wei1
Thanks for the reply. The INSTALL.DPDK.md has those “0x” prefix used as example 212 * dpdk-lcore-mask 213 Specifies the CPU cores on which dpdk lcore threads should be spawned and 214 expects hex string (eg '0x123'). so I think either we make those documents compliant or make the

[ovs-dev] [PATCH v2] ovs-numa: fixed cmask parse with 0x prefix

2016-07-28 Thread Wei Shen
Fixed a minor bug that would print out a confusing warning about core mask, "ovs_numa|WARN|Invalid cpu mask: x", when dpdl-lcore-mask has 0x prefix, e.g. 0x123, which is the convention used in INSTALL.DPDK.md. Signed-off-by: Wei Shen --- lib/ovs-numa.c | 5 + 1 file

Re: [ovs-dev] [PATCH v5 00/16] Userspace (DPDK) connection tracker

2016-07-28 Thread Ilya Maximets
Sorry. TO: Daniele Di Proietto On 28.07.2016 09:27, Ilya Maximets wrote: > I guess, you pushed some development version of this patch set. > > There is strange commit there: > > commit 6c54734ed27bc22975d7035a6bd5f32a412335a0 > Author: Daniele Di Proietto

Re: [ovs-dev] [PATCH v5 00/16] Userspace (DPDK) connection tracker

2016-07-28 Thread Daniele Di Proietto
Thanks for the reviews, I pushed this to master except for the system tests part. On 26/07/2016 17:58, "Daniele Di Proietto" wrote: >This series aims to implement the ct() action for the dpif-netdev datapath. >The bulk of the code is in the new conntrack module: it

[ovs-dev] [PATCH 2/2] ovn: fix lrouter flows building issue when easy SNAT configured

2016-07-28 Thread Dongjun
The lrouter drop the traffic to it's own port IPs unless the IPs are configured for SNAT. Now these flows are still built. Signed-off-by: Dongjun --- ovn/northd/ovn-northd.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) mode change 100644 => 100755

[ovs-dev] [PATCH 1/2] ovn:add easy SNAT test case

2016-07-28 Thread Dongjun
Signed-off-by: Dongjun --- tests/system-ovn.at | 106 +++- 1 file changed, 105 insertions(+), 1 deletion(-) mode change 100644 => 100755 tests/system-ovn.at diff --git a/tests/system-ovn.at b/tests/system-ovn.at old mode 100644

Re: [ovs-dev] [PATCH v6 1/2] Check and allocate free qdisc queue id for ports with qos parameters

2016-07-28 Thread Babu Shanmugam
On Thursday 28 July 2016 01:48 AM, Ben Pfaff wrote: On Wed, Jul 20, 2016 at 08:02:03PM +0530,bscha...@redhat.com wrote: >ovn-northd processes the list of Port_Bindings and hashes the list of >queues per chassis. When it finds a port with qos_parameters and without >a queue_id, it allocates a

Re: [ovs-dev] [PATCH] ovn-controller: Persist desired conntrack groups.

2016-07-28 Thread Ben Pfaff
On Wed, Jul 27, 2016 at 04:23:07AM +, Ryan Moats wrote: > [1] indicates that with incremental processing of logical flows > desired conntrack groups are not being persisted. This patch > adds this capability, with the side effect of adding a ds_copy > method that this capability leverages. >

Re: [ovs-dev] [PATCH] netdev-dpdk: Add Flow Control support.

2016-07-28 Thread Chandran, Sugesh
Hi Bhanu and Daniele, Thank you for your time to review the patch, Please find my answers inline prefix with [Sugesh] Regards _Sugesh From: Daniele Di Proietto [mailto:diproiet...@ovn.org] Sent: Thursday, July 28, 2016 1:38 AM To: Chandran, Sugesh ; Bodireddy,

Re: [ovs-dev] [PATCH 1/2] ovn:add easy SNAT test case

2016-07-28 Thread Guru Shetty
On 27 July 2016 at 23:30, Dongjun wrote: > Signed-off-by: Dongjun > Usually, we have a test with the corresponding code change. Can you have a look at https://www.mail-archive.com/dev@openvswitch.org/msg66099.html and see whether you are happy with the

[ovs-dev] Scanned image from cop...@openvswitch.com

2016-07-28 Thread copier@
Reply to: cop...@openvswitch.com Device Name: cop...@openvswitch.com Device Model: MX-2310U File Format: Microsoft Office Word Resolution: 200dpi x 200dpi Attached file is scanned image in Microsoft Office Word format. Use Microsoft Office Word to view the document.

Re: [ovs-dev] [PATCH 2/2] rhel: Allow openvswitch to get parent information

2016-07-28 Thread Flavio Leitner
Adding William since he is the author of commit 484371776e On Wed, Jul 27, 2016 at 01:54:45PM -0700, Joe Stringer wrote: > On 26 July 2016 at 14:10, Flavio Leitner wrote: > > On Tue, Jul 26, 2016 at 12:57:07PM -0700, Joe Stringer wrote: > >> As far as I can follow, this

Re: [ovs-dev] [PATCH 1/2] ovn:add easy SNAT test case

2016-07-28 Thread Dong Jun
Yes, this test case fail currently and success with the modification. If there is another same test case, ignore this patch is OK. On 2016/7/28 21:31, Guru Shetty wrote: On 27 July 2016 at 23:30, Dongjun > wrote: Signed-off-by: Dongjun

[ovs-dev] Scanned image from cop...@openvswitch.com

2016-07-28 Thread copier@
Reply to: cop...@openvswitch.com Device Name: cop...@openvswitch.com Device Model: MX-2310U File Format: Microsoft Office Word Resolution: 200dpi x 200dpi Attached file is scanned image in Microsoft Office Word format. Use Microsoft Office Word to view the document.

Re: [ovs-dev] [PATCH] doc: Update INSTALL.Docker.md to reflect it's focus on OVN

2016-07-28 Thread Guru Shetty
On 27 July 2016 at 10:40, Kyle Mestery wrote: > While reading this document, the title stood out to me as not > accurate. The title indicates it will discuss how to use > Open vSwitch with Docker, but in reality, it's about using > Open Virtual Networking with Docker. > >

Re: [ovs-dev] [PATCH v2 1/3] utilities/ovs-ctl.in: Allow non-monitoring daemons

2016-07-28 Thread Flavio Leitner
On Wed, Jul 27, 2016 at 01:21:58PM -0700, Ben Pfaff wrote: > On Mon, Jul 25, 2016 at 02:03:51PM -0400, Aaron Conole wrote: > > This commit allows the ovs-ctl command to spawn daemons without the > > internal process monitor. This is useful when integrating with, > > ex. systemd, which provides

Re: [ovs-dev] [PATCH] datapath-windows: Add Windows thread atomic APIs for x64 binaries.

2016-07-28 Thread Paul Boca
Hi guys! Indeed there is a problem using ovs-atomic-msvc.h on x64 build. I made a mistake and didn't recompiled, so the change from headers was ignored when built the UM components. I will take a look and will send a patch when it works. Regards, Paul > -Original Message- > From: dev

[ovs-dev] Scanned image from cop...@openvswitch.com

2016-07-28 Thread copier@
Reply to: cop...@openvswitch.com Device Name: cop...@openvswitch.com Device Model: MX-2310U File Format: Microsoft Office Word Resolution: 200dpi x 200dpi Attached file is scanned image in Microsoft Office Word format. Use Microsoft Office Word to view the document.

Re: [ovs-dev] [PATCH] ovn: Rename "gateway" to "l3gateway".

2016-07-28 Thread Guru Shetty
On 26 July 2016 at 13:49, Russell Bryant wrote: > When L3 gateway support was added, it introduced a port type called > "gateway" and a corresponding option called "gateway-chassis". Since > that time, we also have an L2 gateway port type called "l2gateway" and a >

Re: [ovs-dev] [PATCH RFC v3 1/1] netdev-dpdk: Add support for DPDK 16.07

2016-07-28 Thread Loftus, Ciara
> > Thanks for the patch. > I have another concern with this.  If we're still going to rely on RCU to > protect > the vhost device (and as pointed out by Ilya, I think we should) we need to > use RCU-like semantics on the vid array index. I'm not sure a boolean flag is > going to be enough. >

[ovs-dev] [PATCH v2] ovn-controller: Persist desired conntrack groups.

2016-07-28 Thread Ryan Moats
With incremental processing of logical flows desired conntrack groups are not being persisted. This patch adds this capability, with the side effect of adding a ds_clone method that this capability leverages. Signed-off-by: Ryan Moats Reported-by: Guru Shetty

Re: [ovs-dev] [PATCH] ovn-controller: Persist desired conntrack groups.

2016-07-28 Thread Ryan Moats
Ben Pfaff wrote on 07/28/2016 01:02:47 AM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 07/28/2016 01:03 AM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Persist desired > conntrack groups. > > On Wed, Jul 27, 2016 at

Re: [ovs-dev] [PATCH v2 1/4] windows: Add internal switch port per OVS bridge

2016-07-28 Thread Paul Boca
Thanks for changes! Acked-by: Paul Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean > Sent: Tuesday, July 26, 2016 6:44 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH v2 1/4] windows: Add

Re: [ovs-dev] [PATCH v2 4/4] datapath-windows: Fix VPORT when it is allocated by OVS

2016-07-28 Thread Paul Boca
Acked-by: Paul Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean > Sent: Tuesday, July 26, 2016 6:45 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH v2 4/4] datapath-windows: Fix VPORT when it is >

[ovs-dev] [PATCH monitor_cond V11] ovn: implementation of conditional monitoring usage

2016-07-28 Thread Liran Schour
Conditional monitor of: Port_Binding, Logical_Flow, Multicast_Group MAC_Binding tables. As a result ovn-controller will be notified only about records belongs to a datapath that is being served by this hypervisor. Performance evaluation: OVN is the main candidate for conditional monitoring usage.

[ovs-dev] [PATCH] INSTALL.DPDK-ADVANCED: Add vhost multiqueue loopback testcase.

2016-07-28 Thread Bhanuprakash Bodireddy
Add steps for loopback test using vhost-user configured with multiqueue doing packet forwarding in kernel. Signed-off-by: Bhanuprakash Bodireddy --- INSTALL.DPDK-ADVANCED.md | 86 1 file changed, 86 insertions(+)

Re: [ovs-dev] [PATCH v2 2/4] datapath-windows: Add multiple switch internal ports

2016-07-28 Thread Paul Boca
Acked-by: Paul Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean > Sent: Tuesday, July 26, 2016 6:47 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH v2 2/4] datapath-windows: Add multiple switch >

Re: [ovs-dev] [PATCH v2 3/4] windows: document multiple NIC support setup

2016-07-28 Thread Paul Boca
Acked-by: Paul Boca > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean > Sent: Tuesday, July 26, 2016 6:45 PM > To: dev@openvswitch.org > Subject: [ovs-dev] [PATCH v2 3/4] windows: document multiple NIC support >

[ovs-dev] [PATCH] ovn-controller: Add datapath-type in chassis:external_ids

2016-07-28 Thread Numan Siddique
This patch reads the external_ids:datapath-type value from the Open_vSwitch table if defined and sets it in the external_ids:datapath-type of Chassis table. This will provide hints to the CMS or clients monitoring OVN SB DB to determine the datapath type (DPDK or non-DPDK) configured and take

[ovs-dev] [PATCH v2] netdev-dpdk: Add Flow Control support.

2016-07-28 Thread Sugesh Chandran
Add support for flow-control(mac control frame) to DPDK enabled physical port types. By default, the flow-control is OFF on both rx and tx side. The flow control can be enabled/disabled either when adding a port to OVS or at run time. For eg: To enable flow control support at tx side while adding

Re: [ovs-dev] [PATCH 1/2] ovn:add easy SNAT test case

2016-07-28 Thread Guru Shetty
On 28 July 2016 at 06:55, Dong Jun wrote: > Yes, this test case fail currently and success with the modification. > If there is another same test case, ignore this patch is OK. > Thank you for the test. I applied the linked patch by Chandra as it was already reviewed and

[ovs-dev] [PATCH RFC] netdev-dpdk: fix memory leak

2016-07-28 Thread Mark Kavanagh
DPDK v16.07 introduces the ability to free memzones. Up until this point, DPDK memory pools created in OVS could not be destroyed, thus incurring a memory leak. Leverage the DPDK v16.07 rte_mempool API to free DPDK mempools when their associated reference count reaches 0 (this indicates that the

Re: [ovs-dev] [PATCH v3] ovn: Allow SNAT traffic destined to router ip

2016-07-28 Thread Guru Shetty
On 18 July 2016 at 09:57, Chandra S Vejendla wrote: > When router ip is used as SNAT IP, traffic destined to router > ip should not be dropped > > Fixes: 4685e523695c ("ovn: Support multiple addresses on a single logical > router port.") > Signed-off-by: Chandra Sekhar

Re: [ovs-dev] [PATCH 1/2] ovn:add easy SNAT test case

2016-07-28 Thread Guru Shetty
On 28 July 2016 at 07:48, Guru Shetty wrote: > > > On 28 July 2016 at 06:55, Dong Jun wrote: > >> Yes, this test case fail currently and success with the modification. >> If there is another same test case, ignore this patch is OK. >> > > Thank you for the test.

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Add Flow Control support.

2016-07-28 Thread Bodireddy, Bhanuprakash
>-Original Message- >From: Chandran, Sugesh >Sent: Thursday, July 28, 2016 4:30 PM >To: diproiet...@ovn.org; Bodireddy, Bhanuprakash >; dev@openvswitch.org >Cc: Chandran, Sugesh >Subject: [PATCH v2] netdev-dpdk: Add Flow Control

Re: [ovs-dev] [PATCH v5] netdev-dpdk: Set pmd thread priority

2016-07-28 Thread Bodireddy, Bhanuprakash
>-Original Message- >From: Daniele Di Proietto [mailto:diproiet...@ovn.org] >Sent: Wednesday, July 27, 2016 10:10 PM >To: Kavanagh, Mark B >Cc: Bodireddy, Bhanuprakash ; >dev@openvswitch.org >Subject: Re: [PATCH v5] netdev-dpdk:

Re: [ovs-dev] Mea culpa - rewound master branch

2016-07-28 Thread Flavio Leitner
On Wed, Jul 27, 2016 at 11:49:18AM -0700, Ben Pfaff wrote: > Some time ago this morning, I accidentally pushed several patches that > were still under review to master. I've force-pushed a correction to > the branch. My apologies--I hope that this does not screw up anyone's > development process

Re: [ovs-dev] [PATCH v4] Windows: Local named pipe implementation

2016-07-28 Thread Guru Shetty
On 26 July 2016 at 12:57, Alin Serdean wrote: > Currently in the case of command line arguments punix/unix, on Windows > we create a file, write a TCP port number to connect. This is a security > concern. > > This patch adds support for the command line arguments

[ovs-dev] [PATCH v2] route-table: flush addresses list when route table is reset

2016-07-28 Thread Thadeu Lima de Souza Cascardo
When the route table is reset, the addresses list may be out of date, as we race for the many netlink socket notifications. A quick fix for this is flushing the addresses list, before dumping the routes and gathering source addresses for them. That way, instead of using invalid source addresses

Re: [ovs-dev] Mea culpa - rewound master branch

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 12:49:37PM -0300, Flavio Leitner wrote: > On Wed, Jul 27, 2016 at 11:49:18AM -0700, Ben Pfaff wrote: > > Some time ago this morning, I accidentally pushed several patches that > > were still under review to master. I've force-pushed a correction to > > the branch. My

Re: [ovs-dev] [PATCH] ovn-controller: Add datapath-type in chassis:external_ids

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 08:05:20PM +0530, Numan Siddique wrote: > This patch reads the external_ids:datapath-type value from the > Open_vSwitch table if defined and sets it in the external_ids:datapath-type > of Chassis table. What sets external_ids:datapath-type? It isn't documented anywhere.

Re: [ovs-dev] [PATCH 1/2] ovs-router: ignore IPv6 source addresses for IPv4 routes

2016-07-28 Thread Thadeu Lima de Souza Cascardo
On Wed, Jul 27, 2016 at 01:49:39PM -0700, Ben Pfaff wrote: > On Sun, Jul 24, 2016 at 01:07:26PM -0300, Thadeu Lima de Souza Cascardo wrote: > > Though this should not happen when we have another address on the device > > that is > > IPv4 mapped, we should prevent adding a routing entry to IPv4

[ovs-dev] [PATCH v3 1/5] netdev-dpdk: Remove dpdkvhostcuse ports

2016-07-28 Thread Ciara Loftus
This commit removes the 'dpdkvhostcuse' port type from the userspace datapath. vhost-cuse ports are quickly becoming obsolete as the vhost-user port type begins to support a greater feature-set thanks to the addition of things like vhost-user multiqueue and potential upcoming features like

[ovs-dev] [PATCH v3 3/5] netdev-dpdk: Add vHost User PMD

2016-07-28 Thread Ciara Loftus
DPDK 16.04 introduces the vHost PMD which allows 'dpdkvhostuser' ports to be controlled by the librte_ether API, like physical 'dpdk' ports and IVSHM 'dpdkr' ports. This commit integrates this PMD into OVS and removes direct calls to the librte_vhost DPDK library. This commit removes extended

[ovs-dev] [PATCH v3 4/5] netdev-dpdk: Add vhost-user 'get_features' & 'get_status' functions

2016-07-28 Thread Ciara Loftus
Implementations for the netdev functions 'get_features' and 'get_status' are now available for vhost-user thanks to the addition of the vHost PMD. Signed-off-by: Ciara Loftus --- lib/netdev-dpdk.c | 23 +-- 1 file changed, 13 insertions(+), 10

[ovs-dev] [PATCH v3 0/5] Remove vHost Cuse and Add vHost User PMD

2016-07-28 Thread Ciara Loftus
Previous: http://openvswitch.org/pipermail/dev/2016-July/076245.html The patchset combines two previously independent sets: 1. netdev-dpdk: Remove dpdkvhostcuse ports (v1) http://openvswitch.org/pipermail/dev/2016-July/074696.html 2. vHost PMD (v3)

Re: [ovs-dev] [PATCH v5 00/16] Userspace (DPDK) connection tracker

2016-07-28 Thread Joe Stringer
On 27 July 2016 at 23:27, Ilya Maximets wrote: > I guess, you pushed some development version of this patch set. > > There is strange commit there: > > commit 6c54734ed27bc22975d7035a6bd5f32a412335a0 > Author: Daniele Di Proietto > Date: Wed Jul

Re: [ovs-dev] Mea culpa - rewound master branch

2016-07-28 Thread Flavio Leitner
On Thu, Jul 28, 2016 at 09:32:54AM -0700, Ben Pfaff wrote: > On Thu, Jul 28, 2016 at 12:49:37PM -0300, Flavio Leitner wrote: > > On Wed, Jul 27, 2016 at 11:49:18AM -0700, Ben Pfaff wrote: > > > Some time ago this morning, I accidentally pushed several patches that > > > were still under review to

Re: [ovs-dev] [PATCH] system-ovn.at: Fix ICMP conntrack output.

2016-07-28 Thread Joe Stringer
On 28 July 2016 at 10:48, Joe Stringer wrote: > Recent changes to the dump-conntrack command provide more info > (type,code), but the system-ovn tests weren't updated for this. > Update the tests. > > Signed-off-by: Joe Stringer I'm aware of two other failures in

[ovs-dev] [PATCH 0/5] check-kernel: add 802.1ad tests

2016-07-28 Thread Eric Garver
This series adds 6 test cases to the "check-kernel" make target for 802.1ad. It is meant as a counterpart to the 802.1ad work currently going on and being discussed on the dev list. User space support for 802.1ad is being worked on by Xiao Liang (based on Thomas F Herbert's work). Kernel support

[ovs-dev] [PATCH 3/5] check-kernel: 802.1ad: Add conntrack ping tests for CVLANs.

2016-07-28 Thread Eric Garver
Signed-off-by: Eric Garver --- tests/system-traffic.at | 106 1 file changed, 106 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 4f72292e5490..817eca1d5fea 100644 --- a/tests/system-traffic.at +++

[ovs-dev] [PATCH 2/5] check-kernel: 802.1ad: Add datapath ping tests for CVLANs.

2016-07-28 Thread Eric Garver
Signed-off-by: Eric Garver --- tests/system-traffic.at | 63 + 1 file changed, 63 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 1cdc2d2e0f4e..4f72292e5490 100644 --- a/tests/system-traffic.at +++

[ovs-dev] [PATCH 4/5] check-kernel: 802.1ad: Add push/pop test case.

2016-07-28 Thread Eric Garver
Test case to push and pop outer 802.1ad tag between two "customer" bridges. Signed-off-by: Eric Garver --- tests/system-traffic.at | 54 + 1 file changed, 54 insertions(+) diff --git a/tests/system-traffic.at

[ovs-dev] [PATCH 1/5] check-kernel: Add macros to check for and test 802.1ad.

2016-07-28 Thread Eric Garver
Add macros OVS_CHECK_8021AD(), ADD_SVLAN() and ADD_CVLAN(). Signed-off-by: Eric Garver --- tests/system-common-macros.at | 29 - 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at

Re: [ovs-dev] [PATCH v5 00/16] Userspace (DPDK) connection tracker

2016-07-28 Thread Daniele Di Proietto
I pushed the intended version except that I forgot to squash that commit with the previous one. Sorry about this On 28/07/2016 00:40, "Ilya Maximets" wrote: >Sorry. >TO: Daniele Di Proietto > >On 28.07.2016 09:27, Ilya Maximets wrote: >> I

Re: [ovs-dev] [PATCH 2/2] ovs-dev.py: Update for python3.

2016-07-28 Thread Russell Bryant
On Mon, May 16, 2016 at 5:56 PM, Joe Stringer wrote: > Adapt to python-2.6+, including support for 3. > > Signed-off-by: Joe Stringer > Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list

Re: [ovs-dev] [PATCH] ovn-controller: Add datapath-type in chassis:external_ids

2016-07-28 Thread Russell Bryant
On Thu, Jul 28, 2016 at 1:40 PM, Numan Siddique wrote: > On Thu, Jul 28, 2016 at 10:28 PM, Ben Pfaff wrote: > > > On Thu, Jul 28, 2016 at 08:05:20PM +0530, Numan Siddique wrote: > > > This patch reads the external_ids:datapath-type value from the > > >

Re: [ovs-dev] [PATCH v5 00/16] Userspace (DPDK) connection tracker

2016-07-28 Thread Joe Stringer
Congrats! This has been a while coming:) On 27 July 2016 at 23:17, Daniele Di Proietto wrote: > Thanks for the reviews, I pushed this to master except for the system tests > part. > > > > On 26/07/2016 17:58, "Daniele Di Proietto" wrote: > >>This

[ovs-dev] [PATCH] system-ovn.at: Fix ICMP conntrack output.

2016-07-28 Thread Joe Stringer
Recent changes to the dump-conntrack command provide more info (type,code), but the system-ovn tests weren't updated for this. Update the tests. Signed-off-by: Joe Stringer --- tests/system-ovn.at | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[ovs-dev] [PATCH 5/5] check-kernel: 802.1ad: Add dot1q-tunnel test case.

2016-07-28 Thread Eric Garver
Test case for dot1q-tunnel between two "customer" bridges. Signed-off-by: Eric Garver --- tests/system-traffic.at | 45 + 1 file changed, 45 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index

Re: [ovs-dev] Mea culpa - rewound master branch

2016-07-28 Thread Daniele Di Proietto
2016-07-28 10:52 GMT-07:00 Flavio Leitner : > On Thu, Jul 28, 2016 at 09:32:54AM -0700, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 12:49:37PM -0300, Flavio Leitner wrote: > > > On Wed, Jul 27, 2016 at 11:49:18AM -0700, Ben Pfaff wrote: > > > > Some time ago this morning, I

[ovs-dev] [PATCH] ovn-controller: Clean up cases that lead to duplicate OF flows.

2016-07-28 Thread Ryan Moats
In physical_run, there are multiple places where OF flows can be produced each cycle. Because the desired flow table may not have been completely cleared first, remove flows created during previous runs before creating new flows. This avoid collisions. Signed-off-by: Ryan Moats

Re: [ovs-dev] [PATCH] ovn-controller: Add datapath-type in chassis:external_ids

2016-07-28 Thread Numan Siddique
On Thu, Jul 28, 2016 at 10:28 PM, Ben Pfaff wrote: > On Thu, Jul 28, 2016 at 08:05:20PM +0530, Numan Siddique wrote: > > This patch reads the external_ids:datapath-type value from the > > Open_vSwitch table if defined and sets it in the > external_ids:datapath-type > > of Chassis

Re: [ovs-dev] [PATCH 2/2] ovs-dev.py: Update for python3.

2016-07-28 Thread Joe Stringer
On 28 July 2016 at 11:02, Russell Bryant wrote: > > > On Mon, May 16, 2016 at 5:56 PM, Joe Stringer wrote: >> >> Adapt to python-2.6+, including support for 3. >> >> Signed-off-by: Joe Stringer > > > Acked-by: Russell Bryant Thanks

Re: [ovs-dev] [PATCH v4] ovn-northd, tests: Adding IPAM to ovn-northd.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 01:29:42PM -0700, Guru Shetty wrote: > On 28 July 2016 at 11:37, Ben Pfaff wrote: > > > On Wed, Jul 27, 2016 at 11:28:24AM -0700, Nimay Desai wrote: > > > Added an IPv4 and MAC addresses management system to ovn-northd. When a > > logical > > > switch's

Re: [ovs-dev] [PATCH] ovn-controller: Remove flows created for now deleted SB database rows.

2016-07-28 Thread Ryan Moats
Ben Pfaff wrote on 07/28/2016 04:23:57 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 07/28/2016 04:24 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Remove flows created > for now deleted SB database rows. > > On Thu,

[ovs-dev] [PATCH 1/2] rhel: Prioritize our vport-foo modules in depmod.

2016-07-28 Thread Joe Stringer
We've done the same for openvswitch.ko previously, but we really should be doing this for vport modules as well; otherwise, depmod may try to pair upstream vport modules with the out-of-tree openvswitch module (leading to depmod warnings on package install, and failure to load the module at

[ovs-dev] [PATCH 2/2] fedora: Prioritize OVS modules in weak-updates.

2016-07-28 Thread Joe Stringer
Out-of-tree modules are installed into the kernel's "extra" modules directory for the version that kmod-openvswitch is compiled against. For all other kernels on the system at install time, a symlink is created in the "weak-updates" directory. This provides a path for the same kernel module to be

[ovs-dev] [PATCH 2/2] README: add referente to DPDK installation

2016-07-28 Thread Mauricio Vasquez B
there was not any reference to the DPDK installation in the main README file. Signed-off-by: Mauricio Vasquez B --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 13a132a..cf53437 100644 --- a/README.md +++

Re: [ovs-dev] [PATCH] ovn-controller: squelch expected duplicate flow warnings

2016-07-28 Thread Ben Pfaff
On Wed, Jul 27, 2016 at 09:13:56PM -0500, Ryan Moats wrote: > > > Ben Pfaff wrote on 07/27/2016 03:53:56 PM: > > > From: Ben Pfaff > > To: Guru Shetty > > Cc: Ryan Moats/Omaha/IBM@IBMUS, ovs dev > > Date: 07/27/2016 03:54 PM > >

Re: [ovs-dev] [PATCH] ovn-controller: squelch expected duplicate flow warnings

2016-07-28 Thread Ryan Moats
Ben Pfaff wrote on 07/28/2016 04:28:31 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev , Guru Shetty > Date: 07/28/2016 04:29 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: squelch expected > duplicate

Re: [ovs-dev] [PATCH 1/2] rhel: Fix ifup-ovs to delete ports first.

2016-07-28 Thread Joe Stringer
On 25 July 2016 at 18:16, Flavio Leitner wrote: > When ifdown isn't executed (system didn't shut down properly), > ports remain in the openvswitch's database. In that case, an > inconsitency is left behind when the ifcfg was modified because > ovs-vsctl won't do anything to

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Add Flow Control support.

2016-07-28 Thread Chandran, Sugesh
Thank you Bhanu for reviewing and testing it. Regards _Sugesh > -Original Message- > From: Bodireddy, Bhanuprakash > Sent: Thursday, July 28, 2016 4:54 PM > To: Chandran, Sugesh ; diproiet...@ovn.org; > dev@openvswitch.org > Subject: RE: [PATCH v2]

[ovs-dev] [PATCH 1/2] README: add missing reference to INSTALL.SELinux.md

2016-07-28 Thread Mauricio Vasquez B
Signed-off-by: Mauricio Vasquez B --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 69c4912..13a132a 100644 --- a/README.md +++ b/README.md @@ -120,6 +120,7 @@ b...@openvswitch.org

Re: [ovs-dev] [PATCH v2] ovn-controller: Persist desired conntrack groups.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 02:18:45PM +, Ryan Moats wrote: > With incremental processing of logical flows desired conntrack groups > are not being persisted. This patch adds this capability, with the > side effect of adding a ds_clone method that this capability leverages. > > Signed-off-by:

[ovs-dev] [PATCH] ovn-controller: Remove old values from local_ids.

2016-07-28 Thread Russell Bryant
local_ids is supposed to be the set of interface iface-id values from this chassis that correspond to OVN logical ports. We use this for detecting when an interface has been removed as well as if child-ports should be bound to this chassis. Old values were not being removed from local_ids. The

Re: [ovs-dev] [PATCH] ovn-controller: Remove flows created for now deleted SB database rows.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 07:54:30PM +, Ryan Moats wrote: > Ensure that rows created for deleted port binding and > multicast group rows are cleared when doing full processing. > > Signed-off-by: Ryan Moats I'm choosing to overlook storing UUIDs as strings in a set of

[ovs-dev] [PATCH v3] ovn-controller: Persist desired conntrack groups.

2016-07-28 Thread Ryan Moats
With incremental processing of logical flows desired conntrack groups are not being persisted. This patch adds this capability, with the side effect of adding a ds_clone method that this capability leverages. Signed-off-by: Ryan Moats Reported-by: Guru Shetty

Re: [ovs-dev] [PATCH v1] Enable manager_option configuation for NB and SB

2016-07-28 Thread Amitabha Biswas
Hi Ben, No there is no advantage for having a separate database, we can incorporate a Manager Table into the Northbound and Southbound database. This was an initial hack (with minimal code and schema change) to verify the efficacy of disabling the probe timer on our cloud setups and get some

Re: [ovs-dev] [PATCH v1] Enable manager_option configuation for NB and SB

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 01:14:37PM -0700, Amitabha Biswas wrote: > So v2 of this patch will contain Manager Table in the NB and SB > database. Does that sounds reasonable? Yes, that sounds OK to me. ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH v2 1/4] netdev-dpdk: Remove dpdkvhostcuse ports

2016-07-28 Thread Flavio Leitner
On Tue, Jul 26, 2016 at 05:12:51PM +0100, Ciara Loftus wrote: > This commit removes the 'dpdkvhostcuse' port type from the userspace > datapath. vhost-cuse ports are quickly becoming obsolete as the > vhost-user port type begins to support a greater feature-set thanks to > the addition of things

Re: [ovs-dev] [PATCH] ovn-controller: Remove old values from local_ids.

2016-07-28 Thread Ryan Moats
"dev" wrote on 07/28/2016 04:22:41 PM: > From: Russell Bryant > To: dev@openvswitch.org > Date: 07/28/2016 04:23 PM > Subject: [ovs-dev] [PATCH] ovn-controller: Remove old values from local_ids. > Sent by: "dev" > >

Re: [ovs-dev] [PATCH v2] ovn-controller: Persist desired conntrack groups.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 05:10:56PM -0500, Ryan Moats wrote: > Ben Pfaff wrote on 07/28/2016 04:06:09 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS, Gurucharan Shetty > > Cc: dev@openvswitch.org > > Date: 07/28/2016 04:06 PM > > Subject:

Re: [ovs-dev] [PATCH v4] ovn-northd, tests: Adding IPAM to ovn-northd.

2016-07-28 Thread Guru Shetty
On 28 July 2016 at 11:37, Ben Pfaff wrote: > On Wed, Jul 27, 2016 at 11:28:24AM -0700, Nimay Desai wrote: > > Added an IPv4 and MAC addresses management system to ovn-northd. When a > logical > > switch's other_config:subnet field is set, logical ports attached to that > > switch

Re: [ovs-dev] [PATCH 2/2] README: add referente to DPDK installation

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 10:49:26PM +0200, Mauricio Vasquez B wrote: > there was not any reference to the DPDK installation in the main README file. > > Signed-off-by: Mauricio Vasquez B Both applied, thanks!

Re: [ovs-dev] [PATCH] ovn-northd: create patch ports when necessary.

2016-07-28 Thread Ryan Moats
"dev" wrote on 07/27/2016 09:47:47 PM: > From: nickcooper-zhangtonghao > To: Ben Pfaff > Cc: dev@openvswitch.org > Date: 07/27/2016 09:48 PM > Subject: Re: [ovs-dev] [PATCH] ovn-northd: create patch ports when

Re: [ovs-dev] [PATCH 2/5] ovn: Make two end-to-end tests more reliable.

2016-07-28 Thread Ryan Moats
"dev" wrote on 07/27/2016 02:03:22 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 07/27/2016 02:03 AM > Subject: [ovs-dev] [PATCH 2/5] ovn: Make two end-to-end tests more reliable. > Sent by: "dev"

Re: [ovs-dev] [PATCH v3] ovn-controller: Persist desired conntrack groups.

2016-07-28 Thread Flaviof
On Thu, Jul 28, 2016 at 5:17 PM, Ryan Moats wrote: > With incremental processing of logical flows desired conntrack groups > are not being persisted. This patch adds this capability, with the > side effect of adding a ds_clone method that this capability leverages. > >

[ovs-dev] [PATCH v2 00/26] Support groups in bundles.

2016-07-28 Thread Jarno Rajahalme
This series adds group support for OpenFlow bundles, and reduces the memory footprint of bundled messages. To make groups in bundles useful we need to make groups versioned, so that atomic bundles are supported, which in turn requires RCU to be used for group's memory management. We also need

[ovs-dev] [PATCH v2 03/26] ofproto: Take group references only when needed.

2016-07-28 Thread Jarno Rajahalme
Avoid unnecessary references when RCU protection suffices. This makes group lookup memory management more like flow lookup memory management. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c | 22 +- ofproto/ofproto-dpif.c | 6 --

Re: [ovs-dev] [PATCH v5 13/16] system-tests: Run conntrack tests with userspace.

2016-07-28 Thread Daniele Di Proietto
On 27/07/2016 14:18, "Ben Pfaff" wrote: >On Wed, Jul 27, 2016 at 01:51:00PM -0700, Jesse Gross wrote: >> On Wed, Jul 27, 2016 at 1:40 PM, Daniele Di Proietto >> wrote: >> > On 27/07/2016 13:12, "Joe Stringer" wrote: >> > >> >>On 26 July

Re: [ovs-dev] [PATCH 4/5] tests: Remove most packet-forwarding related"sleep"s from OVN tests.

2016-07-28 Thread Ryan Moats
"dev" wrote on 07/27/2016 02:03:24 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 07/27/2016 02:04 AM > Subject: [ovs-dev] [PATCH 4/5] tests: Remove most packet-forwarding > related "sleep"s from OVN tests. >

Re: [ovs-dev] [PATCH 1/5] tests: Define trim_zeros in only one place.

2016-07-28 Thread Flaviof
On Wed, Jul 27, 2016 at 2:03 AM, Ben Pfaff wrote: > Defining trim_zeros in a common place allows us to skip defining it in > every test that needs it. > > Signed-off-by: Ben Pfaff > Acked-by: Flavio Fernandes > --- > tests/ovn.at | 61 >

[ovs-dev] [PATCH] ovn: Add second ACL stage

2016-07-28 Thread Mickey Spiegel
From: Mickey Spiegel This patch adds a second logical switch ingress ACL stage, and correspondingly a second logical switch egress ACL stage. This allows for more than one ACL-based feature to be applied in the ingress and egress logical switch pipelines. The features

  1   2   >