[ovs-dev] Chinese Router/TV-BOX exporter

2016-03-10 Thread Daniel Wang
Dear, We are Chinese router and TV-box exporting group company in Shanghai, China. Welcome your inquiry, and welcome to visit our factory,thanks. B.RGS./Daniel Forever 8 Global Group H.T. Industry & Trading Co., Ltd. Addess:Shanghai City, China. Skype: forever8group Whatsapp: +86 13818517308

[ovs-dev] Chinese Router/TV-BOX exporter

2016-03-10 Thread Daniel Wang
Dear, We are Chinese router and TV-box exporting group company in Shanghai, China. Welcome your inquiry, and welcome to visit our factory,thanks. B.RGS./Daniel Forever 8 Global GroupH.T. Industry & Trading Co., Ltd.Addess:Shanghai City, China.Skype: forever8groupWhatsapp: +86

Re: [ovs-dev] [PATCH 2/3] Enable some existing OVN BUM tests

2016-03-10 Thread Darrell Ball
On 3/10/16, 5:24 PM, "Ben Pfaff" wrote: >On Thu, Mar 03, 2016 at 07:08:01PM +, Darrell Ball wrote: >> >--- a/tests/ovn.at >> >+++ b/tests/ovn.at >> >@@ -870,10 +870,8 @@ for s in 1 2 3; do >> > done >> > >> > # Broadcast and multicast. >> >-# xxx

Re: [ovs-dev] [PATCH v2] Document how to match any packet with a VLAN header.

2016-03-10 Thread Ben Pfaff
Thanks, applied to master. On Thu, Mar 10, 2016 at 06:02:38PM -0800, Justin Pettit wrote: > Now you can tell people RTFM! > > Acked-by: Justin Pettit > > --Justin > > > > On Mar 10, 2016, at 5:46 PM, Ben Pfaff wrote: > > > > This one is actually useful, I

Re: [ovs-dev] [Partial-Update-Map-Columns 0/7] Add Initial code for Partia-map-columns funtionality

2016-03-10 Thread Ben Pfaff
I understand the intention now. The key seems to be your final paragraph: Using different structures and logic to handle map operations, instead of trying to force the current structures (like 'old' and 'new' datums in the row) to handle then, ensures that map operations won't

Re: [ovs-dev] [Fix branch-2.4 travis builds] travis: Use container infrastructure.

2016-03-10 Thread Andy Zhou
On Thu, Mar 10, 2016 at 5:54 PM, Ben Pfaff wrote: > On Thu, Mar 10, 2016 at 04:09:54PM -0800, Andy Zhou wrote: > > On Thu, Mar 10, 2016 at 3:11 PM, Daniele Di Proietto < > diproiet...@vmware.com > > > wrote: > > > On 09/03/2016 19:55, "dev on behalf of Joe Stringer" > > >

Re: [ovs-dev] [Fix branch-2.4 travis builds] travis: Use container infrastructure.

2016-03-10 Thread Andy Zhou
On Thu, Mar 10, 2016 at 3:11 PM, Daniele Di Proietto wrote: > Thanks for fixing this > > On 09/03/2016 19:55, "dev on behalf of Joe Stringer" > wrote: > > >Hi Andy, thanks for fixing this. > > > >On 9 March 2016 at

Re: [ovs-dev] [PATCH] ovsdb-server: Add Json cache count to memory/show

2016-03-10 Thread Andy Zhou
On Thu, Mar 10, 2016 at 5:50 PM, Ben Pfaff wrote: > On Tue, Mar 08, 2016 at 11:54:45AM -0800, Andy Zhou wrote: > > Add the size of json cache to the data reported by ovsdb-server appctl > > "memory/show" command. > > > > Signed-off-by: Andy Zhou > > Acked-by: Ben

Re: [ovs-dev] [PATCH 2/6] netdev-linux: Fix netdev ipv6 notification

2016-03-10 Thread pravin shelar
On Thu, Mar 10, 2016 at 4:11 PM, Ben Pfaff wrote: > On Wed, Mar 09, 2016 at 04:40:41PM -0800, Pravin B Shelar wrote: >> Listen to RTNLGRP_IPV6_IFINFO to get IPv6 address change >> notification. >> >> Signed-off-by: Pravin B Shelar > > Acked-by: Ben Pfaff

Re: [ovs-dev] RFCv2: OVN database options

2016-03-10 Thread Han Zhou
On Thu, Mar 10, 2016 at 5:45 PM, Ben Pfaff wrote: > > On Thu, Mar 10, 2016 at 05:31:18PM -0800, Ben Pfaff wrote: > > I have been considering this as a minimum interesting scale. It's hard > > for me to know what the interesting scale range is. I am really happy > > to hear what is

Re: [ovs-dev] [PATCH 5/6] ovs-router: Do not allow routes over loopback device.

2016-03-10 Thread pravin shelar
On Thu, Mar 10, 2016 at 5:04 PM, Ben Pfaff wrote: > On Wed, Mar 09, 2016 at 04:40:44PM -0800, Pravin B Shelar wrote: >> This just avoid unnecessary routes in the ovs-router. >> >> Signed-off-by: Pravin B Shelar > > This adds three more test failures: > >

Re: [ovs-dev] [PATCH 3/6] lib: Fix compose nd

2016-03-10 Thread pravin shelar
On Thu, Mar 10, 2016 at 4:18 PM, Ben Pfaff wrote: > On Wed, Mar 09, 2016 at 04:40:42PM -0800, Pravin B Shelar wrote: >> Following patch fixes number of issues with compose nd, like >> setting ip packet header, set ICMP opt-len, checksum. >> >> Signed-off-by: Pravin B Shelar

Re: [ovs-dev] [PATCH v2 net-next] ovs: allow nl 'flow set' to use ufid without flow key

2016-03-10 Thread pravin shelar
On Thu, Mar 10, 2016 at 8:14 AM, Samuel Gauthier wrote: > When we want to change a flow using netlink, we have to identify it to > be able to perform a lookup. Both the flow key and unique flow ID > (ufid) are valid identifiers, but we always have to specify the flow >

Re: [ovs-dev] [PATCH v2] Document how to match any packet with a VLAN header.

2016-03-10 Thread Justin Pettit
Now you can tell people RTFM! Acked-by: Justin Pettit --Justin > On Mar 10, 2016, at 5:46 PM, Ben Pfaff wrote: > > This one is actually useful, I don't know how I omitted it whenever I wrote > this documentation. > > Signed-off-by: Ben Pfaff >

Re: [ovs-dev] [PATCH v5 4/5] ovn: Implement basic ARP support for L3 logical routers.

2016-03-10 Thread Justin Pettit
> On Feb 19, 2016, at 4:40 PM, Ben Pfaff wrote: > > > --- a/ovn/TODO > +++ b/ovn/TODO > @@ -4,18 +4,11 @@ > > ** New OVN logical actions > > > +*** rate_limit > > TCP/IP stacks typically limit the rate at which ARPs are sent, e.g. to > one per second for a given target. We

Re: [ovs-dev] [Fix branch-2.4 travis builds] travis: Use container infrastructure.

2016-03-10 Thread Ben Pfaff
On Thu, Mar 10, 2016 at 04:09:54PM -0800, Andy Zhou wrote: > On Thu, Mar 10, 2016 at 3:11 PM, Daniele Di Proietto > wrote: > > On 09/03/2016 19:55, "dev on behalf of Joe Stringer" > > wrote: > > >> + -

Re: [ovs-dev] [PATCH] ovsdb-server: Add Json cache count to memory/show

2016-03-10 Thread Ben Pfaff
On Tue, Mar 08, 2016 at 11:54:45AM -0800, Andy Zhou wrote: > Add the size of json cache to the data reported by ovsdb-server appctl > "memory/show" command. > > Signed-off-by: Andy Zhou Acked-by: Ben Pfaff ___ dev mailing

[ovs-dev] [PATCH v2] Document how to match any packet with a VLAN header.

2016-03-10 Thread Ben Pfaff
This one is actually useful, I don't know how I omitted it whenever I wrote this documentation. Signed-off-by: Ben Pfaff --- Supersedes http://openvswitch.org/pipermail/dev/2016-March/067562.html DESIGN.md| 4 utilities/ovs-ofctl.8.in | 5 - 2 files

Re: [ovs-dev] RFCv2: OVN database options

2016-03-10 Thread Ben Pfaff
On Thu, Mar 10, 2016 at 05:31:18PM -0800, Ben Pfaff wrote: > I have been considering this as a minimum interesting scale. It's hard > for me to know what the interesting scale range is. I am really happy > to hear what is important to you? That ? was supposed to be an ! > Can you tell me about

[ovs-dev] [PATCH] DESIGN: Document another VLAN matching variant.

2016-03-10 Thread Ben Pfaff
This one is actually useful, I don't know how I omitted it whenever I made this chart. Signed-off-by: Ben Pfaff --- DESIGN.md | 4 1 file changed, 4 insertions(+) diff --git a/DESIGN.md b/DESIGN.md index 6865d47..a330312 100644 --- a/DESIGN.md +++ b/DESIGN.md @@ -426,6

Re: [ovs-dev] [PATCH v2 net-next] ovs: allow nl 'flow set' to use ufid without flow key

2016-03-10 Thread Simon Horman
On Thu, Mar 10, 2016 at 05:14:59PM +0100, Samuel Gauthier wrote: > When we want to change a flow using netlink, we have to identify it to > be able to perform a lookup. Both the flow key and unique flow ID > (ufid) are valid identifiers, but we always have to specify the flow > key in the netlink

Re: [ovs-dev] RFCv2: OVN database options

2016-03-10 Thread Ben Pfaff
On Thu, Mar 10, 2016 at 05:20:06PM -0800, Han Zhou wrote: > On Thu, Mar 10, 2016 at 4:01 PM, Ben Pfaff wrote: > > > > Beyond supporting this usage model, the basic requirements for the OVN > > use case are: > > > > - Size: 20 MB to 100 MB of data (estimated database size to hold

Re: [ovs-dev] [PATCH 2/3] Enable some existing OVN BUM tests

2016-03-10 Thread Ben Pfaff
On Thu, Mar 03, 2016 at 07:08:01PM +, Darrell Ball wrote: > >--- a/tests/ovn.at > >+++ b/tests/ovn.at > >@@ -870,10 +870,8 @@ for s in 1 2 3; do > > done > > > > # Broadcast and multicast. > >-# xxx ovn-controller-vtep doesn't handle multicast traffic that is > >-# xxx sourced

Re: [ovs-dev] RFCv2: OVN database options

2016-03-10 Thread Han Zhou
I replied to the older version, repost it here: On Thu, Mar 10, 2016 at 4:01 PM, Ben Pfaff wrote: > > Beyond supporting this usage model, the basic requirements for the OVN > use case are: > > - Size: 20 MB to 100 MB of data (estimated database size to hold > data for our

Re: [ovs-dev] [PATCH v4 1/6] datapath-windows: Added recirculation support.

2016-03-10 Thread Ben Pfaff
On Thu, Mar 10, 2016 at 12:32:02PM +, Alin Serdean wrote: > I just updated the patch with the comments. I looked over the whole patch > yesterday and indeed we should pass the source port and search for it when we > are queuing packets to the userspace. > > Also the key and layers should be

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Han Zhou
On Wed, Mar 9, 2016 at 11:11 PM, Ben Pfaff wrote: > > Beyond supporting this usage model, the basic requirements for the OVN > use case are: > > - Size: 20 MB to 100 MB of data (estimated database size to hold > data for our target scale of 1,000 hypervisors and 20,000 >

Re: [ovs-dev] [PATCH] Set reason before sending continuation packet-in to the controller

2016-03-10 Thread Ben Pfaff
On Wed, Mar 09, 2016 at 09:05:03PM +0530, Numan Siddique wrote: > Signed-Off-by: Numan Siddique Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [RFC] OVN northbound address sets

2016-03-10 Thread Ben Pfaff
On Wed, Mar 09, 2016 at 04:12:07PM -0500, Russell Bryant wrote: > > One use case for OVN ACLs includes matching on a set of IP addresses. A > simple example: > > inport == "lport1" && ip.src == {10.0.0.1, 10.0.0.3, 10.0.7} > > This is only 3 addresses, but it could easily be hundreds of

Re: [ovs-dev] [PATCH 4/6] tunneling: Handle multiple ip address for given device.

2016-03-10 Thread Ben Pfaff
On Wed, Mar 09, 2016 at 04:40:43PM -0800, Pravin B Shelar wrote: > From: Pravin B Shelar > > Device can have multiple IP address but netdev_get_in4/6() > returns only one configured IPv6 address. Following > patch fixes it. > OVS router is also updated to return source ip

Re: [ovs-dev] [PATCH] INSTALL.DPDK: remove issue with QEMU v2.4.0 and dpdkvhostuser

2016-03-10 Thread Daniele Di Proietto
On 09/03/2016 06:03, "Mauricio Vasquez B" wrote: >The patch mentioned in the commit e73b7508fb58 ("INSTALL.DPDK: Mention >issue with QEMU v2.4.0 & dpdkvhostuser") is present in DPDK v2.2.0, >then this issue is not valid anymore. > >Signed-off-by:

Re: [ovs-dev] [PATCH] netdev-dpdk: fix mbuf leaks

2016-03-10 Thread Daniele Di Proietto
Thanks for clarifying, I've back ported this up to branch-2.4 On 09/03/2016 17:46, "Yuanhan Liu" wrote: >On Thu, Mar 10, 2016 at 01:33:03AM +, Daniele Di Proietto wrote: >> Thanks for the patch! >> >> Were you able to hit this bug in your setup or did you just

Re: [ovs-dev] Mac OS X?

2016-03-10 Thread Ben Pfaff
Well, if anyone is willing to put in some time now, it will probably save effort in the future... On Fri, Mar 11, 2016 at 09:32:52AM +0900, Dan Mihai Dumitriu wrote: > Oooh, that would be great to make work. I'm so lazy, to start VMs when > doing dev and light testing. :) > > On Fri, Mar 11,

Re: [ovs-dev] [PATCH 5/6] ovs-router: Do not allow routes over loopback device.

2016-03-10 Thread Ben Pfaff
On Wed, Mar 09, 2016 at 04:40:44PM -0800, Pravin B Shelar wrote: > This just avoid unnecessary routes in the ovs-router. > > Signed-off-by: Pravin B Shelar This also raises confusion on whether errors should be positive or negative.

Re: [ovs-dev] [PATCH 4/6] tunneling: Handle multiple ip address for given device.

2016-03-10 Thread Ben Pfaff
On Wed, Mar 09, 2016 at 04:40:43PM -0800, Pravin B Shelar wrote: > From: Pravin B Shelar > > Device can have multiple IP address but netdev_get_in4/6() > returns only one configured IPv6 address. Following > patch fixes it. > OVS router is also updated to return source ip

Re: [ovs-dev] Mac OS X?

2016-03-10 Thread Lance Richardson
After fixing a couple of trivial compilation issues, I stopped at one that's probably less trivial: libtool: compile: clang -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -I/opt/local/include -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat-security

Re: [ovs-dev] Mac OS X?

2016-03-10 Thread Dan Mihai Dumitriu
Oooh, that would be great to make work. I'm so lazy, to start VMs when doing dev and light testing. :) On Fri, Mar 11, 2016 at 9:20 AM, Russell Bryant wrote: > On Thu, Mar 10, 2016 at 5:43 PM, Ben Pfaff wrote: > > > Has anyone tried building OVS on Mac OS X? If

Re: [ovs-dev] Mac OS X?

2016-03-10 Thread Russell Bryant
On Thu, Mar 10, 2016 at 5:43 PM, Ben Pfaff wrote: > Has anyone tried building OVS on Mac OS X? If it built there, then we > could enable OS X builds on travis, which would give us some BSD-style > operating system test coverage. > > I don't have a Mac so I can't test this myself.

Re: [ovs-dev] [PATCH 3/6] lib: Fix compose nd

2016-03-10 Thread Ben Pfaff
On Wed, Mar 09, 2016 at 04:40:42PM -0800, Pravin B Shelar wrote: > Following patch fixes number of issues with compose nd, like > setting ip packet header, set ICMP opt-len, checksum. > > Signed-off-by: Pravin B Shelar sparse says: ../lib/packets.c:1332:45: warning:

Re: [ovs-dev] [PATCH 2/6] netdev-linux: Fix netdev ipv6 notification

2016-03-10 Thread Ben Pfaff
On Wed, Mar 09, 2016 at 04:40:41PM -0800, Pravin B Shelar wrote: > Listen to RTNLGRP_IPV6_IFINFO to get IPv6 address change > notification. > > Signed-off-by: Pravin B Shelar Acked-by: Ben Pfaff ___ dev mailing list

Re: [ovs-dev] [Fix branch-2.4 travis builds] travis: Use container infrastructure.

2016-03-10 Thread Andy Zhou
On Thu, Mar 10, 2016 at 3:11 PM, Daniele Di Proietto wrote: > Thanks for fixing this > > On 09/03/2016 19:55, "dev on behalf of Joe Stringer" > wrote: > > >Hi Andy, thanks for fixing this. > > > >On 9 March 2016 at

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: NUMA Aware vHost

2016-03-10 Thread Ben Pfaff
On Thu, Mar 10, 2016 at 11:24:36PM +, Daniele Di Proietto wrote: > ovs-numa reads the CPUs and NUMA nodes configuration from sysfs. > It is only used to decide how to set the affinity of pmd threads. > > This new code just needs get_mempolicy() from libnuma: it is used > to get the NUMA node

[ovs-dev] RFCv2: OVN database options

2016-03-10 Thread Ben Pfaff
This is revised slightly from the first version. I added PostgreSQL and MariaDB and revised the entry on Zookeeper, and probably made a few other revisions I've forgotten. Requirements OVN uses two databases, the "northbound" and "southbound" databases, in a somewhat idiosyncratic

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Ben Pfaff
On Thu, Mar 10, 2016 at 07:11:55PM +0100, Ivan Kelly wrote: > > - Zookeeper. The ZK model is similar to etc so it may have > > similar issues. Also, ZK makes the transaction log available, > > for use by observer nodes to scale out reads, and this may be > > another way for

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Ben Pfaff
On Thu, Mar 10, 2016 at 12:52:43PM -0500, Russell Bryant wrote: > On Thu, Mar 10, 2016 at 2:11 AM, Ben Pfaff wrote: > > > Database txn ACID consist trk HA OSC Py format > > - --- --- --- --- --- --- --- -- > > ActorDByes

Re: [ovs-dev] [PATCH nf-next v10 8/8] openvswitch: Interface with NAT.

2016-03-10 Thread Joe Stringer
On 11 March 2016 at 07:54, Jarno Rajahalme wrote: > Extend OVS conntrack interface to cover NAT. New nested > OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. > A bare OVS_CT_ATTR_NAT only mangles existing and expected connections. > If OVS_NAT_ATTR_SRC or

Re: [ovs-dev] [Fix branch-2.4 travis builds] travis: Use container infrastructure.

2016-03-10 Thread Daniele Di Proietto
Thanks for fixing this On 09/03/2016 19:55, "dev on behalf of Joe Stringer" wrote: >Hi Andy, thanks for fixing this. > >On 9 March 2016 at 18:05, Andy Zhou wrote: >> From: Daniele Di Proietto > >As a

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: NUMA Aware vHost

2016-03-10 Thread Daniele Di Proietto
ovs-numa reads the CPUs and NUMA nodes configuration from sysfs. It is only used to decide how to set the affinity of pmd threads. This new code just needs get_mempolicy() from libnuma: it is used to get the NUMA node of a virtual address and it is simply a wrapper to a system call. Want do you

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Ben Pfaff
On Thu, Mar 10, 2016 at 01:14:41PM -0600, Ryan Moats wrote: > Do we want to be *in* the DB business? I think the answer is no, > which means we should be doing the work to *not* be in the DB business > - refactoring the IDL to allow different DBs to be attached while > ensuring that the

[ovs-dev] Mac OS X?

2016-03-10 Thread Ben Pfaff
Has anyone tried building OVS on Mac OS X? If it built there, then we could enable OS X builds on travis, which would give us some BSD-style operating system test coverage. I don't have a Mac so I can't test this myself. Thanks, Ben. ___ dev mailing

Re: [ovs-dev] [PATCH 1/6] smap: bsd: Fix compilation error.

2016-03-10 Thread Ben Pfaff
On Wed, Mar 09, 2016 at 04:40:40PM -0800, Pravin B Shelar wrote: > I saw following error while testing this series. > ---8<--- > In file included from lib/smap.c:16: > ./lib/smap.h:75:56: warning: declaration of 'struct in6_addr' will not be > visible outside of this function [-Wvisibility] >

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: NUMA Aware vHost

2016-03-10 Thread Ben Pfaff
How does this numa library relate to lib/ovs-numa.[ch]? On Thu, Mar 10, 2016 at 01:22:42AM +, Daniele Di Proietto wrote: > Thanks for the patch, I'll put this in the use case list for > my series if I need to resend it! > > It would be nice to get the numa socket information without >

Re: [ovs-dev] [PATCH] lib/ovs-thread: make use of the pthread_attr object

2016-03-10 Thread Andy Zhou
On Thu, Mar 10, 2016 at 2:30 PM, Ben Pfaff wrote: > Andy, can you transform the reference into a Fixes: tag? > Good point. Will do. > > Thanks, > > Ben. > > On Thu, Mar 10, 2016 at 02:14:03PM -0800, Andy Zhou wrote: > > LGTM, Acked-by: Andy Zhou > > > > I will

Re: [ovs-dev] [PATCH] lib/ovs-thread: make use of the pthread_attr object

2016-03-10 Thread Ben Pfaff
Andy, can you transform the reference into a Fixes: tag? Thanks, Ben. On Thu, Mar 10, 2016 at 02:14:03PM -0800, Andy Zhou wrote: > LGTM, Acked-by: Andy Zhou > > I will push it later today. Thanks. > > On Thu, Mar 10, 2016 at 8:37 AM, Alexandru Ardelean

Re: [ovs-dev] [PATCH nf-next v10 7/8] openvswitch: Delay conntrack helper call for new connections.

2016-03-10 Thread Jarno Rajahalme
Thanks for the reviews, Joe! Now we have acks for the patches 3-8, but not for 1 and 2 that touch netfilter proper. Who could review those? Jarno > On Mar 10, 2016, at 2:01 PM, Joe Stringer wrote: > > On 11 March 2016 at 07:54, Jarno Rajahalme wrote: >> There

Re: [ovs-dev] [PATCH] lib/ovs-thread: make use of the pthread_attr object

2016-03-10 Thread Andy Zhou
LGTM, Acked-by: Andy Zhou I will push it later today. Thanks. On Thu, Mar 10, 2016 at 8:37 AM, Alexandru Ardelean wrote: > Referencing this commit: >8147cec9ee8feea9440cf79365709ddc32ff57d5 > > My bad for not noticing this earlier. > I only got to

Re: [ovs-dev] [PATCH nf-next v10 7/8] openvswitch: Delay conntrack helper call for new connections.

2016-03-10 Thread Joe Stringer
On 11 March 2016 at 07:54, Jarno Rajahalme wrote: > There is no need to help connections that are not confirmed, so we can > delay helping new connections to the time when they are confirmed. > This change is needed for NAT support, and having this as a separate > patch will make

Re: [ovs-dev] [PATCH nf-next v10 3/8] openvswitch: Add commentary to conntrack.c

2016-03-10 Thread Joe Stringer
On 11 March 2016 at 07:54, Jarno Rajahalme wrote: > This makes the code easier to understand and the following patches > more focused. > > Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer ___ dev

[ovs-dev] [PATCH] openvswitch: add support for kernel 4.4

2016-03-10 Thread Alexandru Ardelean
Maybe not the cleanest patch/approach to add support for kernel 4.4, but it works. Will do more tests later. Signed-off-by: Alexandru Ardelean --- acinclude.m4 |4 +-- datapath/actions.c |8

[ovs-dev] [PATCH] lib/ovs-thread: make use of the pthread_attr object

2016-03-10 Thread Alexandru Ardelean
Referencing this commit: 8147cec9ee8feea9440cf79365709ddc32ff57d5 My bad for not noticing this earlier. I only got to try the OVS upstream patch just now and noticed this. We're still using an older version of OVS internally, so this slipped by. I was wondering why the crash was still

Re: [ovs-dev] [RFC] OVN northbound address sets

2016-03-10 Thread Amitabha Biswas
It’s a great idea. From an OpenStack point of view, this will make NB ACL transaction sets O(1) instead of O(N) when combined with the delta ACL computation patch that is currently under review. I agree with Ryan’s SB extension. Since Address_Set will be a new table, the conditional_monitor

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Ryan Moats
"dev" wrote on 03/10/2016 01:11:09 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Date: 03/10/2016 01:31 AM > Subject: [ovs-dev] RFC: OVN database options > Sent by: "dev" > > Requirements > > > OVN uses

Re: [ovs-dev] Does Openvswitch has support for flow metering

2016-03-10 Thread Ben Pfaff
On Thu, Mar 10, 2016 at 04:40:28PM +, ravali.bu...@wipro.com wrote: > I am trying to work on flow metering in OVS. Can you please let me > know if this feature is available in OVS or not? This is a FAQ. ### Q: Does Open vSwitch support OpenFlow meters? A: Since version 2.0, Open vSwitch has

[ovs-dev] [PATCH nf-next v10 8/8] openvswitch: Interface with NAT.

2016-03-10 Thread Jarno Rajahalme
Extend OVS conntrack interface to cover NAT. New nested OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. A bare OVS_CT_ATTR_NAT only mangles existing and expected connections. If OVS_NAT_ATTR_SRC or OVS_NAT_ATTR_DST is included within the nested attributes, new

[ovs-dev] [PATCH nf-next v10 7/8] openvswitch: Delay conntrack helper call for new connections.

2016-03-10 Thread Jarno Rajahalme
There is no need to help connections that are not confirmed, so we can delay helping new connections to the time when they are confirmed. This change is needed for NAT support, and having this as a separate patch will make the following NAT patch a bit easier to review. Signed-off-by: Jarno

Re: [ovs-dev] [PATCH nf-next v9 8/8] openvswitch: Interface with NAT.

2016-03-10 Thread Jarno Rajahalme
Thanks for the reviews Joe! Comments below. > On Mar 9, 2016, at 7:47 PM, Joe Stringer wrote: > > Hi Jarno, > > Thanks for working on this. Mostly just a few style things around #ifdefs > below. > > On 9 March 2016 at 15:10, Jarno Rajahalme wrote: >> Extend OVS

[ovs-dev] [PATCH nf-next v10 6/8] openvswitch: Handle NF_REPEAT in conntrack action.

2016-03-10 Thread Jarno Rajahalme
Repeat the nf_conntrack_in() call when it returns NF_REPEAT. This avoids dropping a SYN packet re-opening an existing TCP connection. Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer --- net/openvswitch/conntrack.c | 10 -- 1 file changed, 8

[ovs-dev] [PATCH nf-next v10 3/8] openvswitch: Add commentary to conntrack.c

2016-03-10 Thread Jarno Rajahalme
This makes the code easier to understand and the following patches more focused. Signed-off-by: Jarno Rajahalme --- net/openvswitch/conntrack.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/net/openvswitch/conntrack.c

[ovs-dev] [PATCH nf-next v10 4/8] openvswitch: Update the CT state key only after nf_conntrack_in().

2016-03-10 Thread Jarno Rajahalme
Only a successful nf_conntrack_in() call can effect a connection state change, so it suffices to update the key only after the nf_conntrack_in() returns. This change is needed for the later NAT patches. Signed-off-by: Jarno Rajahalme Acked-by: Joe Stringer ---

[ovs-dev] [PATCH nf-next v10 5/8] openvswitch: Find existing conntrack entry after upcall.

2016-03-10 Thread Jarno Rajahalme
Add a new function ovs_ct_find_existing() to find an existing conntrack entry for which this packet was already applied to. This is only to be called when there is evidence that the packet was already tracked and committed, but we lost the ct reference due to an userspace upcall.

[ovs-dev] [PATCH nf-next v10 2/8] netfilter: Allow calling into nat helper without skb_dst.

2016-03-10 Thread Jarno Rajahalme
NAT checksum recalculation code assumes existence of skb_dst, which becomes a problem for a later patch in the series ("openvswitch: Interface with NAT."). Simplify this by removing the check on skb_dst, as the checksum will be dealt with later in the stack. Suggested-by: Pravin Shelar

[ovs-dev] [PATCH nf-next v10 0/8] openvswitch: NAT support

2016-03-10 Thread Jarno Rajahalme
This series adds NAT support to openvswitch kernel module. A few changes are needed to the netfilter code to facilitate this (patches 1-2/8). Patches 3-7 make the openvswitch kernel module ready for the patch 8 that adds the NAT support by calling into netfilter NAT code from the openvswitch

[ovs-dev] [PATCH nf-next v10 1/8] netfilter: Remove IP_CT_NEW_REPLY definition.

2016-03-10 Thread Jarno Rajahalme
Remove the definition of IP_CT_NEW_REPLY from the kernel as it does not make sense. This allows the definition of IP_CT_NUMBER to be simplified as well. Signed-off-by: Jarno Rajahalme --- include/uapi/linux/netfilter/nf_conntrack_common.h | 12 +---

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Ben Pfaff
On Fri, Mar 11, 2016 at 12:55:54AM +0900, Dan Mihai Dumitriu wrote: > The NB DB does need HA and ACID transactions, but it has few clients, so > it's probably not a very hard problem - could even use BDB with log > shipping - >

Re: [ovs-dev] [PATCH nf-next v9 8/8] openvswitch: Interface with NAT.

2016-03-10 Thread Jarno Rajahalme
> On Mar 10, 2016, at 4:00 AM, Thomas Graf wrote: > > On 03/09/16 at 07:47pm, Joe Stringer wrote: >> On 9 March 2016 at 15:10, Jarno Rajahalme wrote: >>> Extend OVS conntrack interface to cover NAT. New nested >>> OVS_CT_ATTR_NAT attribute may be used to include

Re: [ovs-dev] [PATCH nf-next v8 1/8] netfilter: Remove IP_CT_NEW_REPLY definition.

2016-03-10 Thread Jarno Rajahalme
Thanks for pointing this out, v10, which hope is the final version, will have the cover letter back. Jarno > On Mar 10, 2016, at 1:16 AM, Or Gerlitz wrote: > > On Wed, Mar 9, 2016 at 2:24 AM, Jarno Rajahalme wrote: >> Remove the definition of

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Ben Pfaff
On Fri, Mar 11, 2016 at 12:43:19AM +0900, Dan Mihai Dumitriu wrote: > Another thing to add to the protocol would be per table versioning, so that > when a client gets disconnected, if it happens to reconnect to another > server in the cluster, it can exchange table versions and resync, coming up >

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Ben Pfaff
On Thu, Mar 10, 2016 at 04:15:13PM +0200, Liran Schour wrote: > I'd like to raise the following issues for discussion: > > 1. That the client side is abstracted from the specific choice of > server-side database by using a db-abstraction layer on the client side. > We already have some kind of

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Ivan Kelly
> - Zookeeper. The ZK model is similar to etc so it may have > similar issues. Also, ZK makes the transaction log available, > for use by observer nodes to scale out reads, and this may be > another way for the clients to track table changes. Not quite. It does make the log

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Ben Pfaff
On Thu, Mar 10, 2016 at 11:26:29AM +0100, Ivan Kelly wrote: > > - Zookeeper. The issues here are similar to those for etcd. > > Also, Zookeeper transactions don't seem to be isolated. > Zookeeper transactions can be isolated depending on what level of > isolation you need. > A setData

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Russell Bryant
On Thu, Mar 10, 2016 at 2:11 AM, Ben Pfaff wrote: > Database txn ACID consist trk HA OSC Py format > - --- --- --- --- --- --- --- -- > ActorDByes ACID strong NO yes yes yes yes sql > Aerospike yes

[ovs-dev] Does Openvswitch has support for flow metering

2016-03-10 Thread ravali.burra
Hi Team, I am trying to work on flow metering in OVS. Can you please let me know if this feature is available in OVS or not? Thanks in Advance Regards Ravali The information contained in this electronic message and any attachments to this message are intended for the exclusive use of the

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Dan Mihai Dumitriu
On Fri, Mar 11, 2016 at 12:55 AM, Dan Mihai Dumitriu wrote: > Great writeup Ben. > > The NB DB does need HA and ACID transactions, but it has few clients, so > it's probably not a very hard problem - could even use BDB with log > shipping - >

[ovs-dev] [PATCH v2 net-next] ovs: allow nl 'flow set' to use ufid without flow key

2016-03-10 Thread Samuel Gauthier
When we want to change a flow using netlink, we have to identify it to be able to perform a lookup. Both the flow key and unique flow ID (ufid) are valid identifiers, but we always have to specify the flow key in the netlink message. When both attributes are there, the ufid is used. The flow key

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Dan Mihai Dumitriu
Great writeup Ben. The NB DB does need HA and ACID transactions, but it has few clients, so it's probably not a very hard problem - could even use BDB with log shipping - http://www.oracle.com/technetwork/database/database-technologies/berkeleydb/overview/index-085366.html . However, one more

[ovs-dev] [PATCH v5 1/6] datapath-windows: Added recirculation support.

2016-03-10 Thread Alin Serdean
Recirculation support for the OVS extension. Tested using PING and iperf with Driver Verifier enabled. Signed-off-by: Sorin Vinturis Co-authored-by: Alin Gabriel Serdean Reported-by: Sorin Vinturis

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Dan Mihai Dumitriu
These are great points Liran. These points are also very closely related to one another. I agree that the SB DB could be entirely in memory - of course, for high availability of course it should be replicated. As a bonus, replication of an in-memory data structure is easier than of a durable data

[ovs-dev] Delivery reports about your e-mail

2016-03-10 Thread MAILER-DAEMON
The message was not delivered due to the following reason: Your message could not be delivered because the destination computer was not reachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Liran Schour
I'd like to raise the following issues for discussion: 1. That the client side is abstracted from the specific choice of server-side database by using a db-abstraction layer on the client side. We already have some kind of an abstraction layer in the code: ovsdb-idl. Maybe we can start from

[ovs-dev] [PATCH] datapath-windows: Fix OVS_KEY_ATTR_ICMPV6 support

2016-03-10 Thread Alin Serdean
This patch applies the conversions needed for the ICMPv6 type and code. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Flow.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/datapath-windows/ovsext/Flow.c

[ovs-dev] [PATCH] datapath-windows: Add OVS_KEY_ATTR_ICMP support

2016-03-10 Thread Alin Serdean
Revisit the mapping of an IPv4 key to netlink key and add the according transformation. Also add support for OVS_KEY_ATTR_ICMP to the windows datapath. Signed-off-by: Alin Gabriel Serdean --- datapath-windows/ovsext/Flow.c | 16 +++- 1 file changed,

[ovs-dev] [PATCH v2] datapath-windows: Pause switch state on PnP event

2016-03-10 Thread Alin Serdean
A PnP(plug and play) event will be triggered before trying to disable the extension. We could use this PnP event to prepare for detaching the datapath. This patch sets the switch into a paused state so no more net buffers are queued. Also clean some commentaries. Signed-off-by: Alin Gabriel

Re: [ovs-dev] [PATCH v2 3/3] ovn: Apply ACL changes to existing connections.

2016-03-10 Thread Russell Bryant
On Thu, Mar 10, 2016 at 2:21 AM, Han Zhou wrote: > > Acked-by: Han Zhou > > Thanks for the testing and reviews! I added your ACKs to the commits. I'm going to hold off from pushing this as I know Justin wanted to review this, as well. -- Russell Bryant

Re: [ovs-dev] [RFC] OVN northbound address sets

2016-03-10 Thread Russell Bryant
On Thu, Mar 10, 2016 at 1:45 AM, Han Zhou wrote: > This is a great idea!! Just like what ipset has helped for iptables. > Thanks for the feedback. Yes, ipset was what inspired the idea. :-) > And I agree with the "additional step" (as pointed out by Ryan) that we > should

Re: [ovs-dev] [PATCH v2] datapath-windows: Support for IPv6 in TCP segmentation

2016-03-10 Thread Alin Serdean
Acked-by: Alin Gabriel Serdean > -Mesaj original- > De la: dev [mailto:dev-boun...@openvswitch.org] În numele Sairam > Venugopal > Trimis: Monday, February 29, 2016 9:42 PM > Către: dev@openvswitch.org > Subiect: [ovs-dev] [PATCH v2] datapath-windows:

Re: [ovs-dev] [PATCH v4 1/6] datapath-windows: Added recirculation support.

2016-03-10 Thread Alin Serdean
I just updated the patch with the comments. I looked over the whole patch yesterday and indeed we should pass the source port and search for it when we are queuing packets to the userspace. Also the key and layers should be updated when the recirc action is implied. I'll update the patch and

Re: [ovs-dev] [PATCH nf-next v9 8/8] openvswitch: Interface with NAT.

2016-03-10 Thread Thomas Graf
On 03/09/16 at 07:47pm, Joe Stringer wrote: > On 9 March 2016 at 15:10, Jarno Rajahalme wrote: > > Extend OVS conntrack interface to cover NAT. New nested > > OVS_CT_ATTR_NAT attribute may be used to include NAT with a CT action. > > A bare OVS_CT_ATTR_NAT only mangles existing

Re: [ovs-dev] RFC: OVN database options

2016-03-10 Thread Ivan Kelly
> - Zookeeper. The issues here are similar to those for etcd. > Also, Zookeeper transactions don't seem to be isolated. Zookeeper transactions can be isolated depending on what level of isolation you need. A setData on a node operation can contain a version, so that it fails if that

Re: [ovs-dev] [PATCH nf-next v8 1/8] netfilter: Remove IP_CT_NEW_REPLY definition.

2016-03-10 Thread Or Gerlitz
On Wed, Mar 9, 2016 at 2:24 AM, Jarno Rajahalme wrote: > Remove the definition of IP_CT_NEW_REPLY from the kernel as it does > not make sense. This allows the definition of IP_CT_NUMBER to be > simplified as well. I just realized that after V7 you stopped sending cover letter