Re: [ovs-dev] [PATCH] encaps: Fix potential null pointer dereferences.

On Wed, Jul 20, 2016 at 02:55:19PM -0700, Ben Pfaff wrote: > Found by inspection. > > Signed-off-by: Ben Pfaff I found another one, in patch.c, so I sent a v2: http://openvswitch.org/pipermail/dev/2016-July/075785.html ___ dev

[ovs-dev] [PATCH v2] ovn-controller: Fix potential null pointer dereferences.

Found by inspection. Signed-off-by: Ben Pfaff --- v1->v2: Found another one to fix. ovn/controller/encaps.c | 11 --- ovn/controller/patch.c | 2 +- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/ovn/controller/encaps.c b/ovn/controller/encaps.c index

[ovs-dev] [PATCH v6] ovn-northd: Add logical flows to support native DHCPv4

OVN implements a native DHCPv4 support which caters to the common use case of providing an IP address to a booting instance by providing stateless replies to DHCPv4 requests based on statically configured address mappings. To do this it allows a short list of DHCPv4 options to be configured and

[ovs-dev] Payment Confirmation

- This mail is in HTML. Some elements may be ommited in plain text. - Good Day , Attached is the payment acknowledgement from our valued customer to you. Will Burton Accountant Orient Exchange Co. (L.L.C.) Mohd. Obaid Al Mulla Building, Shop No. 4, Street No 18, Community 119 Next To Twin

Re: [ovs-dev] [RFC PATCH v2 12/13] Commit push_eth/pop_eth flow action to data plane

It's clear enough, thanks a lot, Jan But http://openvswitch.org/pipermail/dev/2016-May/071657.html also mentioned recirculate will result in 35% performance degradation, for SFC use case, this is really a serious issue, how do you think we can alleviate this very efficiently? I think the

[ovs-dev] [PATCH] test: change replication test to use unix domain socket

The ovsdb replication feature is not specific to the ovsdb socket types. Switching the tests to use Unix domain socket simplifies the tests. Signed-off-by: Andy Zhou Although they don't make any difference in my local testing, travis tests are less likely to report

Re: [ovs-dev] [PATCH v6 1/1] ovn: Apply ACL changes to existing connections.

> On Jul 20, 2016, at 2:26 PM, Russell Bryant wrote: > > After some help rebasing and re-testing from Babu Shanmugam, I went through > this again, addressed comments, and applied this to master. Great! Glad to see it finally merged. Thanks for being patient with me.

Re: [ovs-dev] [PATCH v3] [OVN-northd] Rename nbs/nbr port names tonbsp/nbrp

> On Jul 20, 2016, at 7:25 AM, Hui Kang wrote: > > "dev" wrote on 07/19/2016 04:15:56 PM: > > > From: Justin Pettit > > To: Hui Kang > > Cc: dev@openvswitch.org > > Date: 07/19/2016 04:16 PM > > Subject:

Re: [ovs-dev] [PATCH] FAQ: Answer another question.

I thought you were just surprised to see one of your patches reviewed quickly. --Justin > On Jul 20, 2016, at 4:09 PM, Ben Pfaff wrote: > > This isn't the kind of review I'm used to. Are you impersonating Mork > with a speech impediment, or is there more to it? > > On Wed, Jul

Re: [ovs-dev] [PATCH] FAQ: Answer another question.

This isn't the kind of review I'm used to. Are you impersonating Mork with a speech impediment, or is there more to it? On Wed, Jul 20, 2016 at 04:05:18PM -0700, Justin Pettit wrote: > NACK! NACK! NACK! > > > On Jul 20, 2016, at 4:04 PM, Ben Pfaff wrote: > > > > Signed-off-by:

Re: [ovs-dev] [PATCH] FAQ: Answer another question.

NACK! NACK! NACK! > On Jul 20, 2016, at 4:04 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > --- > FAQ.md | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/FAQ.md b/FAQ.md > index 063bd70..7f72b5c 100644 > --- a/FAQ.md > +++ b/FAQ.md > @@ -118,6

[ovs-dev] [PATCH] FAQ: Answer another question.

Signed-off-by: Ben Pfaff --- FAQ.md | 7 +++ 1 file changed, 7 insertions(+) diff --git a/FAQ.md b/FAQ.md index 063bd70..7f72b5c 100644 --- a/FAQ.md +++ b/FAQ.md @@ -118,6 +118,13 @@ A: Starting in OVS 2.4, we switched the default ports to the cannot, all the programs

[ovs-dev] [PATCH] encaps: Fix potential null pointer dereferences.

Found by inspection. Signed-off-by: Ben Pfaff --- ovn/controller/encaps.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/ovn/controller/encaps.c b/ovn/controller/encaps.c index 03ec732..977cc3a 100644 --- a/ovn/controller/encaps.c +++

Re: [ovs-dev] [PATCH v6 1/1] ovn: Apply ACL changes to existing connections.

On Thu, Jul 7, 2016 at 1:13 PM, Justin Pettit wrote: > > > On Jun 30, 2016, at 10:14 PM, Russell Bryant wrote: > > > > diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml > > index 260cc14..d2bddcb 100644 > > --- a/ovn/northd/ovn-northd.8.xml

[ovs-dev] [PATCH 3/3] Red Hat Systemd Integration

This commit builds upon some of the recent ovs-ctl changes to build a more integrated systemd setup. A new service (ovs-vswitchd) is added to track the ovs-vswitchd, and ovsdb-server service is reserved for the ovsdb-server daemon. The systemd scripts still use ovs-ctl to actually initialize the

[ovs-dev] [PATCH 0/3] redhat: Improve the systemd integration

These patches make adjustments to the way systemd is done so that we have: * one daemon started per service * services which correspond to actual daemon names * a single 'dummy' service to start all at once * some convenient information to poll from systemd. These have been tested on Fedora 23

[ovs-dev] [PATCH 1/3] utilities/ovs-ctl.in: Allow non-monitoring daemons

This commit allows the ovs-ctl command to spawn daemons without the internal process monitor. This is useful when integrating with, ex. systemd, which provides its own monitoring facilities. Signed-off-by: Aaron Conole Acked-by: Ben Pfaff Acked-by: Flavio

[ovs-dev] [PATCH 2/3] rhel/ovsdb-server.service: Rename the nonetwork service

Currently, openvswitch.service calls out to start openvswitch-nonetwork.service. However, openvswitch-nonetwork.service will be called ovsdb-server, so that it is a bit more reflective of the dependencies. This commit does make the file a bit of a misnomer as currently the ovsdb-server SERVICE

[ovs-dev] [PATCH] datapath: Fix vxlan local traffic.

vxlan driver has bypass for local vxlan traffic, but that depends on information about all VNIs on local system in vxlan driver. This is not available in case of LWT. Therefore following patch disable encap bypass for LWT vxlan traffic. Reported-by: Jakub Libosvar

Re: [ovs-dev] [PATCH] ovn: Add datapth of gateway port tolocal_datapaths

On Mon, Jul 18, 2016 at 11:22 AM, Ryan Moats wrote: > "dev" wrote on 07/18/2016 07:50:06 AM: > > > From: Chandra Sekhar Vejendla/San Jose/IBM@IBMUS > > To: dev@openvswitch.org > > Date: 07/18/2016 07:50 AM > > Subject: [ovs-dev] [PATCH] ovn: Add

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

On Wed, Jul 20, 2016 at 03:48:08PM -0400, Russell Bryant wrote: > On Wed, Jul 20, 2016 at 12:30 PM, Ben Pfaff wrote: > > > On Wed, Jul 20, 2016 at 10:00:22AM -0400, Russell Bryant wrote: > > > On Tue, Jul 19, 2016 at 1:58 PM, Ben Pfaff wrote: > > > > > > > This

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

On Wed, Jul 20, 2016 at 12:30 PM, Ben Pfaff wrote: > On Wed, Jul 20, 2016 at 10:00:22AM -0400, Russell Bryant wrote: > > On Tue, Jul 19, 2016 at 1:58 PM, Ben Pfaff wrote: > > > > > This document has two different kinds of text: > > > > > >- The first sections of

[ovs-dev] Bug#831924: openvswitch: FTBFS with dpkg-buildpackage -A: cp: cannot create regular file 'debian/openvswitch-switch/usr/share/openvswitch/switch/default.template': No such file or directory

Source: openvswitch Version: 2.5.1~pre+git20160626-2 Severity: important Tags: stretch sid User: debian...@lists.debian.org Usertags: qa-ftbfs-20160720 qa-ftbfs qa-indep Justification: FTBFS on amd64 Hi, During a rebuild of all packages in sid, your package failed to build on amd64

[ovs-dev] Scanned image from cop...@openvswitch.com

Reply to: cop...@openvswitch.com Device Name: cop...@openvswitch.com Device Model: MX-2310U File Format: Microsoft Office Word Resolution: 200dpi x 200dpi Attached file is scanned image in Microsoft Office Word format. Use Microsoft Office Word to view the document.

Re: [ovs-dev] [PATCH] Add support for 802.1ad (QinQ tunneling)

Sorry for the late reply. I missed this sub-thread somehow. On Thu, Jul 14, 2016 at 09:38:09AM +0800, Xiao Liang wrote: > As far as I know, Eric and Tom are working on the kernel patch set and > would submit a new version to net-next. Kernel patches usually go to > netdev first and then

Re: [ovs-dev] Considering the possibility of integrating DPDK generic classifier APIs in OVS.

> > On Wed, Jul 20, 2016 at 6:43 PM, Gray, Mark D > wrote: > > [Gray, Mark D] I think we should focus on one or two use cases rather > > than a general offload like you discuss below. A general offload > > involves a huge amount of code churn and there are a lot of

Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support

On Tue, Jul 19, 2016 at 5:02 PM, Simon Horman wrote: > On Mon, Jul 18, 2016 at 03:34:52PM -0700, pravin shelar wrote: >> On Sun, Jul 17, 2016 at 9:50 PM, Simon Horman >> wrote: >> > [CC Jiri Benc for portion regarding GRE] >> > >> > Hi

Re: [ovs-dev] Considering the possibility of integrating DPDK generic classifier APIs in OVS.

On Wed, Jul 20, 2016 at 6:43 PM, Gray, Mark D wrote: > [Gray, Mark D] I think we should focus on one or two use cases rather than > a general offload like you discuss below. A general offload involves a huge > amount of code > churn and there are a lot of difficulties,

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

On Wed, Jul 20, 2016 at 5:06 PM, Paul Quinn (paulq) wrote: > >> On Jul 14, 2016, at 11:39 AM, Jesse Gross wrote: >> >> On Wed, Jul 13, 2016 at 10:44 PM, Elzur, Uri wrote: >>> +1 on starting w MD Type = 1 >>> >>> Not sure I understand the

Re: [ovs-dev] Considering the possibility of integrating DPDK generic classifier APIs in OVS.

> Hi Dev Team, > > I submitted a RFC patch few months ago to optimize the tunneling > performance in OVS-DPDK (specifically VxLAN performance) using Intel > Fortville Flow director feature. More details about the patch can be found > below. > >

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

On Wed, Jul 20, 2016 at 10:00:22AM -0400, Russell Bryant wrote: > On Tue, Jul 19, 2016 at 1:58 PM, Ben Pfaff wrote: > > > This document has two different kinds of text: > > > >- The first sections of the document, "Release Strategy" and "Release > > Numbering", describe

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

At the end of my initial long response (http://openvswitch.org/pipermail/dev/2016-July/075115.html) I had included an example for how the OF pipeline could be programmed if the NSH fields are treated as packet header match fields and not metadata fields. As you say, the interesting case is how

[ovs-dev] [PATCH v3 2/3] lib/chutil: Add chmod and chown for opened files

This commit extends the chutil library by providing a set of helpers which operate on files already opened by the process. The implementation provided only works with linux systems, but any system which provides a system call mechanism to do this (such as FreeBSD), could be used. The linux

[ovs-dev] [PATCH v3 1/3] chutil: introduce a new change-utils lib

It will be useful in the future to be able to set ownership and permissions on files which Open vSwitch creates. Allowing the specification of such ownership and permissions using the standard user:group, uog+-rwxs, and numerical forms commonly associated with those actions. This patch introduces

[ovs-dev] [PATCH v3 0/3] vhost-user: Add the ability to control ownership/permissions

Currently, when using Open vSwitch with DPDK and qemu guests, the recommended method for joining the guests is via the dpdkvhostuser interface. This interface uses Unix Domain sockets to communicate. When these sockets are created, they inherit the permissions and ownership from the vswitchd

Re: [ovs-dev] [PATCH v2 0/2] vhost-user: Add the ability to control ownership/permissions

Aaron Conole writes: > Currently, when using Open vSwitch with DPDK and qemu guests, the recommended > method for joining the guests is via the dpdkvhostuser interface. This > interface uses Unix Domain sockets to communicate. When these sockets are > created, they inherit

[ovs-dev] Mail System Error - Returned Mail

The message could not be delivered ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v3 3/3] netdev-dpdk: Support user-defined socket attribs

Currently, when dpdkvhostuser devices are created, they inherit whatever the running umask and uid/gid of the vswitchd process. This leads to difficulties when using vhost_user consumers (such as qemu). This patch introduces two new database entries, 'vhost-sock-owner' to set the ownership, and

Re: [ovs-dev] [RFC PATCH v2 12/13] Commit push_eth/pop_eth flow action to data plane

Hi Yi, Recirculation is implicitly triggered by calling ctx_trigger_freeze(ctx) at the end of the composition phase of an action. The example for this is pop_mpls, but unfortunately it is a bit hidden there because the invocation of ctx_trigger_freeze(ctx) is deferred in order to avoid

Re: [ovs-dev] [RFC PATCH v2 00/13] Add Network Service Header Support

> On Jul 14, 2016, at 11:39 AM, Jesse Gross wrote: > > On Wed, Jul 13, 2016 at 10:44 PM, Elzur, Uri wrote: >> +1 on starting w MD Type = 1 >> >> Not sure I understand the concern expressed with " implementations that >> don't implement TLVs will become

[ovs-dev] [PATCH v6 1/2] Check and allocate free qdisc queue id for ports with qos parameters

ovn-northd processes the list of Port_Bindings and hashes the list of queues per chassis. When it finds a port with qos_parameters and without a queue_id, it allocates a free queue for the chassis that this port belongs. The queue_id information is stored in the options field of Port_binding

[ovs-dev] [PATCH v6 2/2] DSCP marking on packets egressing VIF interface

ovn-northd sets 'ip.dscp' to the DSCP value Signed-off-by: Babu Shanmugam Acked-by: Ben Pfaff --- ovn/controller/lflow.c | 2 +- ovn/northd/ovn-northd.c | 4 ovn/ovn-nb.xml | 6 ++ ovn/ovn-sb.xml | 5 + 4 files changed, 16

[ovs-dev] [PATCH v6 0/2] ovn: QOS updates with DSCP support

From: Babu Shanmugam v5->v6: - Rebased to the latest master - Avoid updating the qos column of port record when txn is NULL Babu Shanmugam (2): Check and allocate free qdisc queue id for ports with qos parameters DSCP marking on packets egressing VIF interface

Re: [ovs-dev] [PATCH v3] [OVN-northd] Rename nbs/nbr port names tonbsp/nbrp

"dev" wrote on 07/19/2016 04:15:56 PM: > From: Justin Pettit > To: Hui Kang > Cc: dev@openvswitch.org > Date: 07/19/2016 04:16 PM > Subject: Re: [ovs-dev] [PATCH v3] [OVN-northd] Rename nbs/nbr port > names to nbsp/nbrp >

Re: [ovs-dev] [PATCH] release-process.md: Document OVS release process and propose a schedule.

On Tue, Jul 19, 2016 at 1:58 PM, Ben Pfaff wrote: > This document has two different kinds of text: > >- The first sections of the document, "Release Strategy" and "Release > Numbering", describe what we've already been doing for most of the > history of Open vSwitch.

Re: [ovs-dev] [PATCH v2] ovsdb: Expose vhost-user socket directory in ovsdb

Hi sorry for the delay Replies inline. > -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Monday, July 11, 2016 6:44 PM > To: Mooney, Sean K > Cc: Flavio Leitner ; dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH

[ovs-dev] Scanned image from cop...@openvswitch.com

Reply to: cop...@openvswitch.com Device Name: cop...@openvswitch.com Device Model: MX-2310U File Format: Microsoft Office Word Resolution: 200dpi x 200dpi Attached file is scanned image in Microsoft Office Word format. Use Microsoft Office Word to view the document.

[ovs-dev] Returned mail: see transcript for details

This message was not delivered due to the following reason: Your message was not delivered because the destination server was not reachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely there

[ovs-dev] Scanned image from cop...@openvswitch.com

Reply to: cop...@openvswitch.com Device Name: cop...@openvswitch.com Device Model: MX-2310U File Format: Microsoft Office Word Resolution: 200dpi x 200dpi Attached file is scanned image in Microsoft Office Word format. Use Microsoft Office Word to view the document.

[ovs-dev] [PATCH v2] ovn: the implementation of icmp4 reject actions.

Hi Ryan, Thank you for your advice. The controller will drop the icmp4 packet whose eth.src or eth.dst is broadcast/multicast address and the type of icmp4 is “destination unreachable”. That may reduce the broadcast storm attack(e.g. icmp flood, dhcp flood). I write the rate limiting of icmp4

Re: [ovs-dev] [ovn-ipv6 06/26] ovn: Renumber logical field registers to the newly extended registers.

On Wed, Jul 20, 2016 at 4:50 AM, Justin Pettit wrote: > >> On Jul 13, 2016, at 3:19 AM, Zong Kai Li wrote: >> >> Hi, Justin. I tried your patches one by one. P1~P5 are OK. >> But something wrong seems happened to P6. >> In my OpenStack integrated environment,

Re: [ovs-dev] [PATCH] packets: Fix in6_is_lla() on systems without s6_addr32 defined.

> On Jul 19, 2016, at 11:39 PM, Ben Pfaff wrote: > > On Tue, Jul 19, 2016 at 11:04:20PM -0700, Justin Pettit wrote: >> Reported-by: Ben Pfaff >> Signed-off-by: Justin Pettit > > Might add a Fixes: header. Done. > Acked-by: Ben Pfaff

[ovs-dev] proposed OVS release schedule (was: [PATCH] release-process.md: Document OVS release process and propose a schedule.)

Perhaps the title buried the lead. My main goal for this patch is to propose a new regular release schedule for OVS. Any comments? Thanks, Ben. On Tue, Jul 19, 2016 at 10:58:08AM -0700, Ben Pfaff wrote: > This document has two different kinds of text: > >- The first sections of the

Re: [ovs-dev] [PATCH] packets: Fix in6_is_lla() on systems without s6_addr32 defined.

On Tue, Jul 19, 2016 at 11:04:20PM -0700, Justin Pettit wrote: > Reported-by: Ben Pfaff > Signed-off-by: Justin Pettit Might add a Fixes: header. Acked-by: Ben Pfaff ___ dev mailing list

[ovs-dev] [PATCH] packets: Fix in6_is_lla() on systems without s6_addr32 defined.

Reported-by: Ben Pfaff Signed-off-by: Justin Pettit --- lib/packets.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/packets.h b/lib/packets.h index 8f11e2c..5fd1e51 100644 --- a/lib/packets.h +++ b/lib/packets.h @@ -987,8 +987,9 @@