Re: [ovs-dev] [PATCH 5/5] ovsdb-idl: Wake up ovsdb_idl_loop when a transaction commits.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 10:24:43PM -0500, Ryan Moats wrote: > "dev" wrote on 07/27/2016 02:03:25 AM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 07/27/2016 02:04 AM > > Subject: [ovs-dev] [PATCH 5/5]

Re: [ovs-dev] [PATCH v5] JSON serialization via Python's json lib

2016-07-28 Thread Ben Pfaff
On Mon, Jul 25, 2016 at 06:55:49PM -0500, Terry Wilson wrote: > Sigh. And of course I had libopenvswitch installed on the system as > well and removing it breaks building the extensions with the above > patch. This is the kind of thing that would be much easier if the > Python lib was its own

Re: [ovs-dev] [PATCH v2] tests: Ignore proxy configuration.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 05:29:44PM -0700, Jarno Rajahalme wrote: > As any proxy configuration may ruin kernel testsuite tests, it is > better to ignore all proxy configuration. > > Suggested-by: Ben Pfaff > Signed-off-by: Jarno Rajahalme Acked-by: Ben Pfaff

Re: [ovs-dev] [PATCH 2/4] tests: Remove trim_zeros() from ovn tests.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 07:58:04PM -0700, Daniele Di Proietto wrote: > trim_zeros() is not necessary anymore, since now we don't pad packets in > the userspace datapath. > > Signed-off-by: Daniele Di Proietto Oops, I just committed a patch that made a change related to

Re: [ovs-dev] [PATCH 1/4] netdev-*: Do not use dp_packet_pad() in recv() functions.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 07:58:03PM -0700, Daniele Di Proietto wrote: > All the netdevs used by dpif-netdev (except for netdev-dpdk) have a > dp_packet_pad() call in the receive function, probably because the > userspace datapath couldn't handle properly short packets. > > This doesn't appear to

Re: [ovs-dev] [PATCH 3/5] ovn-nbctl: Add "sync" command to wait for previous changes to take effect.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 10:10:57PM -0500, Ryan Moats wrote: > "dev" wrote on 07/27/2016 02:03:23 AM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 07/27/2016 02:04 AM > > Subject: [ovs-dev] [PATCH 3/5]

Re: [ovs-dev] [PATCH 4/5] tests: Remove most packet-forwarding related"sleep"s from OVN tests.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 10:44:45PM -0500, Flaviof wrote: > On Thu, Jul 28, 2016 at 10:16 PM, Ryan Moats wrote: > > > "dev" wrote on 07/27/2016 02:03:24 AM: > > > > > From: Ben Pfaff > > > To: dev@openvswitch.org > > > Cc: Ben Pfaff

[ovs-dev] Reference:

2016-07-28 Thread British Lottery Payment Review Panel
        Attention: Recipient, We have enclosed the IRREVOCABLE PAYMENT ORDER for your perusal. Your co-operation is essential to this demand. Truly, Rosemary Clark(Information Department)British Lottery Payment Review Commission  

[ovs-dev] [PATCH] ovn: Add second ACL stage

2016-07-28 Thread Mickey Spiegel
From: Mickey Spiegel This patch adds a second logical switch ingress ACL stage, and correspondingly a second logical switch egress ACL stage. This allows for more than one ACL-based feature to be applied in the ingress and egress logical switch pipelines. The features

Re: [ovs-dev] [PATCH 2/5] ovn: Make two end-to-end tests more reliable.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 10:02:53PM -0500, Ryan Moats wrote: > "dev" wrote on 07/27/2016 02:03:22 AM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 07/27/2016 02:03 AM > > Subject: [ovs-dev] [PATCH 2/5]

Re: [ovs-dev] [PATCH 1/5] tests: Define trim_zeros in only one place.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 09:56:09PM -0500, Ryan Moats wrote: > "dev" wrote on 07/27/2016 02:03:21 AM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 07/27/2016 02:03 AM > > Subject: [ovs-dev] [PATCH 1/5]

Re: [ovs-dev] [PATCH v3] ovn-controller: Persist desired conntrack groups.

2016-07-28 Thread Flaviof
On Thu, Jul 28, 2016 at 5:17 PM, Ryan Moats wrote: > With incremental processing of logical flows desired conntrack groups > are not being persisted. This patch adds this capability, with the > side effect of adding a ds_clone method that this capability leverages. > >

Re: [ovs-dev] [PATCH 3/5] ovn-nbctl: Add "sync" command to wait for previous changes to take effect.

2016-07-28 Thread Ryan Moats
"dev" wrote on 07/27/2016 02:03:23 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 07/27/2016 02:04 AM > Subject: [ovs-dev] [PATCH 3/5] ovn-nbctl: Add "sync" command to wait > for previous changes to take effect.

Re: [ovs-dev] [PATCH 1/5] tests: Define trim_zeros in only one place.

2016-07-28 Thread Flaviof
On Wed, Jul 27, 2016 at 2:03 AM, Ben Pfaff wrote: > Defining trim_zeros in a common place allows us to skip defining it in > every test that needs it. > > Signed-off-by: Ben Pfaff > Acked-by: Flavio Fernandes > --- > tests/ovn.at | 61 >

Re: [ovs-dev] [PATCH 4/5] tests: Remove most packet-forwarding related"sleep"s from OVN tests.

2016-07-28 Thread Flaviof
On Thu, Jul 28, 2016 at 10:16 PM, Ryan Moats wrote: > "dev" wrote on 07/27/2016 02:03:24 AM: > > > From: Ben Pfaff > > To: dev@openvswitch.org > > Cc: Ben Pfaff > > Date: 07/27/2016 02:04 AM > > Subject: [ovs-dev]

Re: [ovs-dev] [PATCH 2/5] ovn: Make two end-to-end tests more reliable.

2016-07-28 Thread Ryan Moats
"dev" wrote on 07/27/2016 02:03:22 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 07/27/2016 02:03 AM > Subject: [ovs-dev] [PATCH 2/5] ovn: Make two end-to-end tests more reliable. > Sent by: "dev"

Re: [ovs-dev] [PATCH 4/5] tests: Remove most packet-forwarding related"sleep"s from OVN tests.

2016-07-28 Thread Ryan Moats
"dev" wrote on 07/27/2016 02:03:24 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 07/27/2016 02:04 AM > Subject: [ovs-dev] [PATCH 4/5] tests: Remove most packet-forwarding > related "sleep"s from OVN tests. >

Re: [ovs-dev] [PATCH 5/5] ovsdb-idl: Wake up ovsdb_idl_loop when a transaction commits.

2016-07-28 Thread Ryan Moats
"dev" wrote on 07/27/2016 02:03:25 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 07/27/2016 02:04 AM > Subject: [ovs-dev] [PATCH 5/5] ovsdb-idl: Wake up ovsdb_idl_loop > when a transaction commits. > Sent by:

Re: [ovs-dev] [PATCH] ovn-northd: create patch ports when necessary.

2016-07-28 Thread nickcooper-zhangtonghao
I only consider the OVN without CMS. Your tips may sound great. > On Jul 29, 2016, at 10:48 AM, Ryan Moats wrote: > > "dev" wrote on 07/27/2016 09:47:47 PM: > > > From: nickcooper-zhangtonghao > > To:

Re: [ovs-dev] [PATCH v5 13/16] system-tests: Run conntrack tests with userspace.

2016-07-28 Thread Daniele Di Proietto
On 27/07/2016 14:18, "Ben Pfaff" wrote: >On Wed, Jul 27, 2016 at 01:51:00PM -0700, Jesse Gross wrote: >> On Wed, Jul 27, 2016 at 1:40 PM, Daniele Di Proietto >> wrote: >> > On 27/07/2016 13:12, "Joe Stringer" wrote: >> > >> >>On 26 July

[ovs-dev] [PATCH 4/4] system-tests: Add ping through conntrack test.

2016-07-28 Thread Daniele Di Proietto
Signed-off-by: Daniele Di Proietto Acked-by: Joe Stringer --- tests/system-traffic.at | 84 + 1 file changed, 84 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index

[ovs-dev] [PATCH 2/4] tests: Remove trim_zeros() from ovn tests.

2016-07-28 Thread Daniele Di Proietto
trim_zeros() is not necessary anymore, since now we don't pad packets in the userspace datapath. Signed-off-by: Daniele Di Proietto --- tests/ovn.at | 135 +++ 1 file changed, 43 insertions(+), 92 deletions(-) diff

[ovs-dev] [PATCH 3/4] system-tests: Run conntrack tests with userspace.

2016-07-28 Thread Daniele Di Proietto
The userspace connection tracker doesn't support ALGs, frag reassembly or NAT yet, so skip those tests. Also, connection tracking state input from a local port is not possible in userspace. Finally, the userspace datapath checks for the IPv4 header checksum, so fix those in the hardcoded

Re: [ovs-dev] [PATCH 1/5] tests: Define trim_zeros in only one place.

2016-07-28 Thread Ryan Moats
"dev" wrote on 07/27/2016 02:03:21 AM: > From: Ben Pfaff > To: dev@openvswitch.org > Cc: Ben Pfaff > Date: 07/27/2016 02:03 AM > Subject: [ovs-dev] [PATCH 1/5] tests: Define trim_zeros in only one place. > Sent by: "dev"

Re: [ovs-dev] [PATCH] ovn-northd: create patch ports when necessary.

2016-07-28 Thread Ryan Moats
"dev" wrote on 07/27/2016 09:47:47 PM: > From: nickcooper-zhangtonghao > To: Ben Pfaff > Cc: dev@openvswitch.org > Date: 07/27/2016 09:48 PM > Subject: Re: [ovs-dev] [PATCH] ovn-northd: create patch ports when

[ovs-dev] HI

2016-07-28 Thread Automatic Email Delivery Software
Dear user of openvswitch.org, Your e-mail account has been used to send a large amount of spam during the last week. Probably, your computer was compromised and now contains a hidden proxy server. We recommend that you follow our instruction in order to keep your computer safe. Have a nice

Re: [ovs-dev] [PATCH] ovn-controller: Remove old values from local_ids.

2016-07-28 Thread Russell Bryant
On Thu, Jul 28, 2016 at 6:13 PM, Ryan Moats wrote: > "dev" wrote on 07/28/2016 04:22:41 PM: > > > From: Russell Bryant > > To: dev@openvswitch.org > > Date: 07/28/2016 04:23 PM > > Subject: [ovs-dev] [PATCH] ovn-controller:

Re: [ovs-dev] [PATCH 1/2] ovn:add easy SNAT test case

2016-07-28 Thread Dong Jun
Thanks, it's really more realistic. On 2016/7/28 22:53, Guru Shetty wrote: On 28 July 2016 at 07:48, Guru Shetty > wrote: On 28 July 2016 at 06:55, Dong Jun > wrote: Yes, this test case fail

Re: [ovs-dev] [PATCH 01/13] lib: Separate versioning to its own module.

2016-07-28 Thread Jarno Rajahalme
> On Jul 26, 2016, at 11:08 AM, Ben Pfaff wrote: > > On Fri, Jul 15, 2016 at 03:19:07AM -0700, Jarno Rajahalme wrote: >> Separate rule versioning to lib/versions.h to make it easier to use >> versioning for other data types. >> >> Signed-off-by: Jarno Rajahalme >

[ovs-dev] [PATCH v2 26/26] ofproto: Reduce bundle memory use.

2016-07-28 Thread Jarno Rajahalme
Instead of storing the (big) struct ofputil_flow_mod, create the new rule and/or create the rule criteria for matching at bundle message insert time. These can be uninitialized right after the start phase during the commit, which may also reduce the total memory needed during the bundle commit.

[ovs-dev] [PATCH v2 25/26] ofproto: Add 'command' to ofproto_flow_mod.

2016-07-28 Thread Jarno Rajahalme
This helps releasing ofputil_flow_mod earlier in a later patch. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-provider.h | 1 + ofproto/ofproto.c | 9 + 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/ofproto/ofproto-provider.h

[ovs-dev] [PATCH v2 24/26] ofproto: Add 'modify_cookie' to ofproto_flow_mod.

2016-07-28 Thread Jarno Rajahalme
ofproto internally modifies 'modify_cookie' field, and adding a replica to ofproto_flow_mod allows the ofputil_flow_mod argument to be changed to a const. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif.c | 27 +-- ofproto/ofproto-provider.h |

[ovs-dev] [PATCH v2 23/26] ofproto: Reduce dependency on ofputil_flow_mod after rule has been created.

2016-07-28 Thread Jarno Rajahalme
One step towards the goal of removing the ofputil_flow_mod from the bundle message. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-provider.h | 7 + ofproto/ofproto.c | 68 ++ 2 files changed, 45 insertions(+), 30

[ovs-dev] [PATCH v2 21/26] ofproto: Support group mods in bundles.

2016-07-28 Thread Jarno Rajahalme
Allow adding group mods in OpenFlow bundles. Group mods are executed atomically with any flow mods in the same bundle. Mods are executed in order, so that groups appearing in flow actions need to be inserted in to the bundle before the dependent flow mods. ovs-ofctl is enhanced to allow the

[ovs-dev] [PATCH v2 22/26] ofp-util: remove flow mod's delete_reason.

2016-07-28 Thread Jarno Rajahalme
We can use the rule's removed_reason instead. Signed-off-by: Jarno Rajahalme --- include/openvswitch/ofp-util.h | 3 --- lib/learn.c| 1 - lib/ofp-parse.c| 1 - lib/ofp-util.c | 4 ofproto/ofproto-dpif.c | 1 -

[ovs-dev] [PATCH v2 16/26] meta-flow: Clean up masking with prerequisities checking.

2016-07-28 Thread Jarno Rajahalme
Change mf_are_prereqs_ok() take a flow_wildcards pointer, so that the wildcards can be set at the same time as the prerequisiteis are checked. This makes it easier to write more obviously correct code. Remove the functions mf_mask_field_and_prereqs() and mf_mask_field_and_prereqs__(), and make

[ovs-dev] [PATCH v2 15/26] meta-flow: Add mf_mask_field_masked().

2016-07-28 Thread Jarno Rajahalme
Having a masked version allows generating better wildcarding. Signed-off-by: Jarno Rajahalme --- include/openvswitch/meta-flow.h | 4 +++- include/openvswitch/ofp-parse.h | 4 ++-- lib/dpctl.c | 4 ++-- lib/meta-flow.c | 37

[ovs-dev] [PATCH v2 13/26] ofproto-dpif: Always forward 'used' from the old_rule.

2016-07-28 Thread Jarno Rajahalme
Use new rule's flags to determine whether stats should be forwarded from the old, modified rule to the new rule. This captures the fact that prior to OpenFlow 1.2, which defines the reset counts flag, the reset counts semantics was assumed by default. However, in that case the reset counts flag

[ovs-dev] [PATCH v2 12/26] vconn: Better bundle error management.

2016-07-28 Thread Jarno Rajahalme
It is possible that a bundle add message fails, but the following commit succeeds, since the message was not added to the bundle. Make ovs-ofctl fail also in these cases. Also, the commit should not be sent if any of the bundled messages failed. To make sure all the errors are received before

[ovs-dev] [PATCH v2 18/26] ofp-util: Do not free() field that is not allocated.

2016-07-28 Thread Jarno Rajahalme
Group properties field array is not dynamically allocated, so it should not be freed. This has not been a problem, as this function has not been called by anyone so far, but following patch will. Signed-off-by: Jarno Rajahalme --- lib/ofp-util.c | 1 - 1 file changed, 1

[ovs-dev] [PATCH v2 17/26] ofproto-dpif-xlate: Hash only fields specified for 'hash' selection method.

2016-07-28 Thread Jarno Rajahalme
The mask for non-present fields in struct field_array is always zero, so hashing a prerequisite field that was not also specified for the "hash" selection method boiled down to hashing a all-zeroes value and unwildcarding the prerequisite field. Now that mf_are_prereqs_ok() already takes care of

[ovs-dev] [PATCH v2 19/26] ofproto: Use ofputil_uninit_group_mod().

2016-07-28 Thread Jarno Rajahalme
Use ofputil_uninit_group_mod() instead of ofputil_bucket_list_destroy(). Currently these have the same effect, but this will change in a following patch. Signed-off-by: Jarno Rajahalme --- lib/ofp-parse.c | 6 +++--- lib/ofp-print.c | 4 ++-- ofproto/ofproto.c

[ovs-dev] [PATCH v2 20/26] meta-flow: Compact struct field_array.

2016-07-28 Thread Jarno Rajahalme
struct field_array is included in each ofgroup, but the current implementation is very sparse, using more than 20kb of data. Also loop over 1-bits instead of each and every MF type to make processing faster. Signed-off-by: Jarno Rajahalme --- include/openvswitch/meta-flow.h | 6

[ovs-dev] [PATCH v2 14/26] meta-flow: Add byte access to struct mf_value.

2016-07-28 Thread Jarno Rajahalme
This allows reducing pointer casting when individual bytes of mf_value are accessed. First users are in the following patches. Signed-off-by: Jarno Rajahalme --- include/openvswitch/meta-flow.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/openvswitch/meta-flow.h

[ovs-dev] [PATCH v2 11/26] vconn: Update length of bundled messages.

2016-07-28 Thread Jarno Rajahalme
Variable length messages need their length updated before they can be added to the bundle. Message length updating after encoding is sometimes done by the encoding function, but always latest when the message is sent out. As an OpenFlow message is added to a bundle add message, it will not be

[ovs-dev] [PATCH v2 05/26] ofproto: Use ofproto_mutex for groups and keep track of referring flows.

2016-07-28 Thread Jarno Rajahalme
Adding groups support for bundles is simpler if also groups are modified under ofproto_mutex. Eliminate the search for rules when deleting a group so that we will not keep the mutex for too long. Signed-off-by: Jarno Rajahalme --- include/openvswitch/ofp-actions.h | 40 +++

[ovs-dev] [PATCH v2 08/26] ofproto: Report flow mods also from bundles.

2016-07-28 Thread Jarno Rajahalme
Flow mod stats get skewed if they are not reported from bundles. Move reporting to ofproto_flow_mod_finish() so that it will be done in all cases. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git

[ovs-dev] [PATCH v2 06/26] ofproto: Add generic ofproto_collection.

2016-07-28 Thread Jarno Rajahalme
Define rule_collection in terms of a new ofproto_collection. This makes it easier to add other types of collections later. This patch makes no functional changes. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-provider.h | 112 ++--- ofproto/ofproto.c

[ovs-dev] [PATCH v2 10/26] ofproto: Make groups versioned.

2016-07-28 Thread Jarno Rajahalme
This is a prepatory step for adding group mod support for bundles in a following patch. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c | 5 +- ofproto/ofproto-dpif.c | 4 +- ofproto/ofproto-dpif.h | 3 +- ofproto/ofproto-provider.h | 11 +++-

[ovs-dev] [PATCH v2 09/26] ofproto: refactor group mods.

2016-07-28 Thread Jarno Rajahalme
This changes ofproto providers modify_group() to never fail. Separating major refactoring to a separate patch should make following patches easier to review. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif.c | 4 +- ofproto/ofproto-provider.h | 27 +++-

[ovs-dev] [PATCH v2 07/26] ofproto: Generalize flow_mod_requester.

2016-07-28 Thread Jarno Rajahalme
Group mods also need a 'requester', so rename 'flow_mod_requester' as 'openflow_mod_requester'. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto.c | 50 -- 1 file changed, 24 insertions(+), 26 deletions(-) diff --git

[ovs-dev] [PATCH v2 04/26] ofproto: Make flow handling more symmetric.

2016-07-28 Thread Jarno Rajahalme
Remove flow from ofproto data structures in the 'start' phase, even if we may need to add them back in 'revert' phase. This makes bundled group mods easier, as a group delete may also delete flows, and we need the referring flows to be updated in the 'start' phase so that we will not have stale

[ovs-dev] [PATCH v2 02/26] ofproto: Lockless group lookups.

2016-07-28 Thread Jarno Rajahalme
Make groups RCU protected and make group lookups lockless. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c | 22 +++--- ofproto/ofproto-dpif.c | 27 +++ ofproto/ofproto-dpif.h | 7 +- ofproto/ofproto-provider.h | 12 ++-- ofproto/ofproto.c

[ovs-dev] [PATCH v2 01/26] lib: Separate versioning to its own module.

2016-07-28 Thread Jarno Rajahalme
Separate rule versioning to lib/versions.h to make it easier to use versioning for other data types. Signed-off-by: Jarno Rajahalme --- lib/automake.mk | 1 + lib/classifier-private.h | 31 +-- lib/classifier.c | 45

[ovs-dev] [PATCH v2 03/26] ofproto: Take group references only when needed.

2016-07-28 Thread Jarno Rajahalme
Avoid unnecessary references when RCU protection suffices. This makes group lookup memory management more like flow lookup memory management. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif-xlate.c | 22 +- ofproto/ofproto-dpif.c | 6 --

[ovs-dev] [PATCH v2 00/26] Support groups in bundles.

2016-07-28 Thread Jarno Rajahalme
This series adds group support for OpenFlow bundles, and reduces the memory footprint of bundled messages. To make groups in bundles useful we need to make groups versioned, so that atomic bundles are supported, which in turn requires RCU to be used for group's memory management. We also need

[ovs-dev] [PATCH v2] tests: Ignore proxy configuration.

2016-07-28 Thread Jarno Rajahalme
As any proxy configuration may ruin kernel testsuite tests, it is better to ignore all proxy configuration. Suggested-by: Ben Pfaff Signed-off-by: Jarno Rajahalme --- tests/atlocal.in| 10 ++ tests/system-traffic.at | 8 2 files changed,

[ovs-dev] [PATCH 2/2] fedora: Prioritize OVS modules in weak-updates.

2016-07-28 Thread Joe Stringer
Out-of-tree modules are installed into the kernel's "extra" modules directory for the version that kmod-openvswitch is compiled against. For all other kernels on the system at install time, a symlink is created in the "weak-updates" directory. This provides a path for the same kernel module to be

[ovs-dev] [PATCH 1/2] rhel: Prioritize our vport-foo modules in depmod.

2016-07-28 Thread Joe Stringer
We've done the same for openvswitch.ko previously, but we really should be doing this for vport modules as well; otherwise, depmod may try to pair upstream vport modules with the out-of-tree openvswitch module (leading to depmod warnings on package install, and failure to load the module at

[ovs-dev] [PATCH v3] ovn-controller: Persist desired conntrack groups.

2016-07-28 Thread Ryan Moats
With incremental processing of logical flows desired conntrack groups are not being persisted. This patch adds this capability, with the side effect of adding a ds_clone method that this capability leverages. Signed-off-by: Ryan Moats Reported-by: Guru Shetty

Re: [ovs-dev] [PATCH] ovn-controller: Remove old values from local_ids.

2016-07-28 Thread Ryan Moats
"dev" wrote on 07/28/2016 04:22:41 PM: > From: Russell Bryant > To: dev@openvswitch.org > Date: 07/28/2016 04:23 PM > Subject: [ovs-dev] [PATCH] ovn-controller: Remove old values from local_ids. > Sent by: "dev" > >

Re: [ovs-dev] [PATCH v2] ovn-controller: Persist desired conntrack groups.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 05:10:56PM -0500, Ryan Moats wrote: > Ben Pfaff wrote on 07/28/2016 04:06:09 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS, Gurucharan Shetty > > Cc: dev@openvswitch.org > > Date: 07/28/2016 04:06 PM > > Subject:

Re: [ovs-dev] [PATCH] ovn-controller: squelch expected duplicate flow warnings

2016-07-28 Thread Ryan Moats
Ben Pfaff wrote on 07/28/2016 04:28:31 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev , Guru Shetty > Date: 07/28/2016 04:29 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: squelch expected > duplicate

Re: [ovs-dev] [PATCH] ovn-controller: Remove flows created for now deleted SB database rows.

2016-07-28 Thread Ryan Moats
Ben Pfaff wrote on 07/28/2016 04:23:57 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 07/28/2016 04:24 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Remove flows created > for now deleted SB database rows. > > On Thu,

Re: [ovs-dev] [PATCH v2] ovn-controller: Persist desired conntrack groups.

2016-07-28 Thread Ryan Moats
Ben Pfaff wrote on 07/28/2016 04:06:09 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS, Gurucharan Shetty > Cc: dev@openvswitch.org > Date: 07/28/2016 04:06 PM > Subject: Re: [ovs-dev] [PATCH v2] ovn-controller: Persist desired > conntrack

Re: [ovs-dev] [PATCH] ovn-controller: squelch expected duplicate flow warnings

2016-07-28 Thread Ben Pfaff
On Wed, Jul 27, 2016 at 09:13:56PM -0500, Ryan Moats wrote: > > > Ben Pfaff wrote on 07/27/2016 03:53:56 PM: > > > From: Ben Pfaff > > To: Guru Shetty > > Cc: Ryan Moats/Omaha/IBM@IBMUS, ovs dev > > Date: 07/27/2016 03:54 PM > >

Re: [ovs-dev] [PATCH v2 1/4] netdev-dpdk: Remove dpdkvhostcuse ports

2016-07-28 Thread Flavio Leitner
On Tue, Jul 26, 2016 at 05:12:51PM +0100, Ciara Loftus wrote: > This commit removes the 'dpdkvhostcuse' port type from the userspace > datapath. vhost-cuse ports are quickly becoming obsolete as the > vhost-user port type begins to support a greater feature-set thanks to > the addition of things

Re: [ovs-dev] [PATCH] ovn-controller: Remove flows created for now deleted SB database rows.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 07:54:30PM +, Ryan Moats wrote: > Ensure that rows created for deleted port binding and > multicast group rows are cleared when doing full processing. > > Signed-off-by: Ryan Moats I'm choosing to overlook storing UUIDs as strings in a set of

[ovs-dev] [PATCH] ovn-controller: Remove old values from local_ids.

2016-07-28 Thread Russell Bryant
local_ids is supposed to be the set of interface iface-id values from this chassis that correspond to OVN logical ports. We use this for detecting when an interface has been removed as well as if child-ports should be bound to this chassis. Old values were not being removed from local_ids. The

Re: [ovs-dev] [PATCH 2/2] README: add referente to DPDK installation

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 10:49:26PM +0200, Mauricio Vasquez B wrote: > there was not any reference to the DPDK installation in the main README file. > > Signed-off-by: Mauricio Vasquez B Both applied, thanks!

Re: [ovs-dev] [PATCH v2] ovn-controller: Persist desired conntrack groups.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 02:18:45PM +, Ryan Moats wrote: > With incremental processing of logical flows desired conntrack groups > are not being persisted. This patch adds this capability, with the > side effect of adding a ds_clone method that this capability leverages. > > Signed-off-by:

Re: [ovs-dev] [PATCH v4] ovn-northd, tests: Adding IPAM to ovn-northd.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 01:29:42PM -0700, Guru Shetty wrote: > On 28 July 2016 at 11:37, Ben Pfaff wrote: > > > On Wed, Jul 27, 2016 at 11:28:24AM -0700, Nimay Desai wrote: > > > Added an IPv4 and MAC addresses management system to ovn-northd. When a > > logical > > > switch's

Re: [ovs-dev] [PATCH v1] Enable manager_option configuation for NB and SB

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 01:14:37PM -0700, Amitabha Biswas wrote: > So v2 of this patch will contain Manager Table in the NB and SB > database. Does that sounds reasonable? Yes, that sounds OK to me. ___ dev mailing list dev@openvswitch.org

[ovs-dev] [PATCH 1/2] README: add missing reference to INSTALL.SELinux.md

2016-07-28 Thread Mauricio Vasquez B
Signed-off-by: Mauricio Vasquez B --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 69c4912..13a132a 100644 --- a/README.md +++ b/README.md @@ -120,6 +120,7 @@ b...@openvswitch.org

[ovs-dev] [PATCH 2/2] README: add referente to DPDK installation

2016-07-28 Thread Mauricio Vasquez B
there was not any reference to the DPDK installation in the main README file. Signed-off-by: Mauricio Vasquez B --- README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/README.md b/README.md index 13a132a..cf53437 100644 --- a/README.md +++

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Add Flow Control support.

2016-07-28 Thread Chandran, Sugesh
Thank you Bhanu for reviewing and testing it. Regards _Sugesh > -Original Message- > From: Bodireddy, Bhanuprakash > Sent: Thursday, July 28, 2016 4:54 PM > To: Chandran, Sugesh ; diproiet...@ovn.org; > dev@openvswitch.org > Subject: RE: [PATCH v2]

Re: [ovs-dev] [PATCH v4] ovn-northd, tests: Adding IPAM to ovn-northd.

2016-07-28 Thread Guru Shetty
On 28 July 2016 at 11:37, Ben Pfaff wrote: > On Wed, Jul 27, 2016 at 11:28:24AM -0700, Nimay Desai wrote: > > Added an IPv4 and MAC addresses management system to ovn-northd. When a > logical > > switch's other_config:subnet field is set, logical ports attached to that > > switch

Re: [ovs-dev] [PATCH v1] Enable manager_option configuation for NB and SB

2016-07-28 Thread Amitabha Biswas
Hi Ben, No there is no advantage for having a separate database, we can incorporate a Manager Table into the Northbound and Southbound database. This was an initial hack (with minimal code and schema change) to verify the efficacy of disabling the probe timer on our cloud setups and get some

Re: [ovs-dev] [PATCH 1/2] rhel: Fix ifup-ovs to delete ports first.

2016-07-28 Thread Joe Stringer
On 25 July 2016 at 18:16, Flavio Leitner wrote: > When ifdown isn't executed (system didn't shut down properly), > ports remain in the openvswitch's database. In that case, an > inconsitency is left behind when the ifcfg was modified because > ovs-vsctl won't do anything to

Re: [ovs-dev] [PATCH] ovn: Rename "gateway" to "l3gateway".

2016-07-28 Thread Russell Bryant
On Thu, Jul 28, 2016 at 9:45 AM, Guru Shetty wrote: > On 26 July 2016 at 13:49, Russell Bryant wrote: > >> When L3 gateway support was added, it introduced a port type called >> "gateway" and a corresponding option called "gateway-chassis". Since >> that time, we

Re: [ovs-dev] [PATCH 2/2] rhel: Allow openvswitch to get parent information

2016-07-28 Thread Joe Stringer
On 28 July 2016 at 06:43, Flavio Leitner wrote: > > Adding William since he is the author of commit 484371776e > > On Wed, Jul 27, 2016 at 01:54:45PM -0700, Joe Stringer wrote: >> On 26 July 2016 at 14:10, Flavio Leitner wrote: >> > On Tue, Jul 26, 2016 at

Re: [ovs-dev] [PATCH] netdev-provider: fix comments for netdev_rxq_recv

2016-07-28 Thread Flavio Leitner
On Tue, Jul 26, 2016 at 02:19:17PM +0100, Mark Kavanagh wrote: > Commit 64839cf43 applies batch objects to netdev-providers, but > some comments were not updated accordingly. Fix these: >- replace 'pkts' with 'batch' >- replace '*cnt' with 'batch->count' >- replace MAX_RX_BATCH with

Re: [ovs-dev] [PATCH v2] ovn: Add ovn-controller-vtep debian package

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 04:53:03PM +, Ryan Moats wrote: > Having a separate debian package for deploying > the ovn-controller-vtep binary enables the ability > to assign specific nodes the role of communicating > with VTEP enabled TORs. > > Change-Id: Ia36aea7d89bd011a57918820b2a9f6e3469b3e04

[ovs-dev] [PATCH] ovn-controller: Remove flows created for now deleted SB database rows.

2016-07-28 Thread Ryan Moats
Ensure that rows created for deleted port binding and multicast group rows are cleared when doing full processing. Signed-off-by: Ryan Moats --- ovn/controller/physical.c | 39 +++ 1 file changed, 39 insertions(+) diff --git

Re: [ovs-dev] [PATCH] ovn-controller: Clean up cases that lead to duplicate OF flows.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 02:11:52PM -0500, Ryan Moats wrote: > Ben Pfaff wrote on 07/28/2016 01:39:53 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: dev@openvswitch.org > > Date: 07/28/2016 01:40 PM > > Subject: Re: [ovs-dev] [PATCH]

Re: [ovs-dev] Mea culpa - rewound master branch

2016-07-28 Thread Flavio Leitner
On Thu, Jul 28, 2016 at 10:58:25AM -0700, Daniele Di Proietto wrote: > 2016-07-28 10:52 GMT-07:00 Flavio Leitner : > > > On Thu, Jul 28, 2016 at 09:32:54AM -0700, Ben Pfaff wrote: > > > On Thu, Jul 28, 2016 at 12:49:37PM -0300, Flavio Leitner wrote: > > > > On Wed, Jul 27, 2016

Re: [ovs-dev] [PATCH] ovn-controller: Add datapath-type in chassis:external_ids

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 02:07:35PM -0400, Russell Bryant wrote: > On Thu, Jul 28, 2016 at 1:40 PM, Numan Siddique wrote: > > > On Thu, Jul 28, 2016 at 10:28 PM, Ben Pfaff wrote: > > > > > On Thu, Jul 28, 2016 at 08:05:20PM +0530, Numan Siddique wrote: > > > >

Re: [ovs-dev] [PATCH v5] netdev-dpdk: Set pmd thread priority

2016-07-28 Thread Flavio Leitner
On Thu, Jul 28, 2016 at 03:39:58PM +, Bodireddy, Bhanuprakash wrote: > >-Original Message- > >From: Daniele Di Proietto [mailto:diproiet...@ovn.org] > >Sent: Wednesday, July 27, 2016 10:10 PM > >To: Kavanagh, Mark B > >Cc: Bodireddy, Bhanuprakash

Re: [ovs-dev] [PATCH 2/2] ovs-dev.py: Update for python3.

2016-07-28 Thread Russell Bryant
On Thu, Jul 28, 2016 at 2:11 PM, Joe Stringer wrote: > On 28 July 2016 at 11:02, Russell Bryant wrote: > > > > > > On Mon, May 16, 2016 at 5:56 PM, Joe Stringer wrote: > >> > >> Adapt to python-2.6+, including support for 3. > >> > >> Signed-off-by:

Re: [ovs-dev] [PATCH] ovn-controller: Clean up cases that lead to duplicate OF flows.

2016-07-28 Thread Ryan Moats
Ben Pfaff wrote on 07/28/2016 01:39:53 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: dev@openvswitch.org > Date: 07/28/2016 01:40 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: Clean up cases that > lead to duplicate OF flows. > > On Thu, Jul 28,

Re: [ovs-dev] [PATCH] ovn-controller: Clean up cases that lead to duplicate OF flows.

2016-07-28 Thread Ben Pfaff
On Thu, Jul 28, 2016 at 06:10:16PM +, Ryan Moats wrote: > In physical_run, there are multiple places where OF flows can be > produced each cycle. Because the desired flow table may not have > been completely cleared first, remove flows created during previous > runs before creating new flows.

Re: [ovs-dev] [PATCH] system-ovn.at: Fix ICMP conntrack output.

2016-07-28 Thread Joe Stringer
On 28 July 2016 at 11:19, Guru Shetty wrote: > > > On 28 July 2016 at 10:48, Joe Stringer wrote: >> >> Recent changes to the dump-conntrack command provide more info >> (type,code), but the system-ovn tests weren't updated for this. >> Update the tests. >> >>

Re: [ovs-dev] [PATCH v4] ovn-northd, tests: Adding IPAM to ovn-northd.

2016-07-28 Thread Ben Pfaff
On Wed, Jul 27, 2016 at 11:28:24AM -0700, Nimay Desai wrote: > Added an IPv4 and MAC addresses management system to ovn-northd. When a > logical > switch's other_config:subnet field is set, logical ports attached to that > switch that have the keyword "dynamic" in their addresses column will >

Re: [ovs-dev] [PATCH] system-ovn.at: Fix ICMP conntrack output.

2016-07-28 Thread Guru Shetty
On 28 July 2016 at 10:48, Joe Stringer wrote: > Recent changes to the dump-conntrack command provide more info > (type,code), but the system-ovn tests weren't updated for this. > Update the tests. > > Signed-off-by: Joe Stringer > Acked-by: Gurucharan Shetty

Re: [ovs-dev] [PATCH 2/2] ovs-dev.py: Update for python3.

2016-07-28 Thread Joe Stringer
On 28 July 2016 at 11:02, Russell Bryant wrote: > > > On Mon, May 16, 2016 at 5:56 PM, Joe Stringer wrote: >> >> Adapt to python-2.6+, including support for 3. >> >> Signed-off-by: Joe Stringer > > > Acked-by: Russell Bryant Thanks

[ovs-dev] [PATCH] ovn-controller: Clean up cases that lead to duplicate OF flows.

2016-07-28 Thread Ryan Moats
In physical_run, there are multiple places where OF flows can be produced each cycle. Because the desired flow table may not have been completely cleared first, remove flows created during previous runs before creating new flows. This avoid collisions. Signed-off-by: Ryan Moats

Re: [ovs-dev] [PATCH] ovn-controller: Add datapath-type in chassis:external_ids

2016-07-28 Thread Russell Bryant
On Thu, Jul 28, 2016 at 1:40 PM, Numan Siddique wrote: > On Thu, Jul 28, 2016 at 10:28 PM, Ben Pfaff wrote: > > > On Thu, Jul 28, 2016 at 08:05:20PM +0530, Numan Siddique wrote: > > > This patch reads the external_ids:datapath-type value from the > > >

Re: [ovs-dev] [PATCH 2/2] ovs-dev.py: Update for python3.

2016-07-28 Thread Russell Bryant
On Mon, May 16, 2016 at 5:56 PM, Joe Stringer wrote: > Adapt to python-2.6+, including support for 3. > > Signed-off-by: Joe Stringer > Acked-by: Russell Bryant -- Russell Bryant ___ dev mailing list

Re: [ovs-dev] [PATCH v5 00/16] Userspace (DPDK) connection tracker

2016-07-28 Thread Daniele Di Proietto
I pushed the intended version except that I forgot to squash that commit with the previous one. Sorry about this On 28/07/2016 00:40, "Ilya Maximets" wrote: >Sorry. >TO: Daniele Di Proietto > >On 28.07.2016 09:27, Ilya Maximets wrote: >> I

Re: [ovs-dev] Mea culpa - rewound master branch

2016-07-28 Thread Daniele Di Proietto
2016-07-28 10:52 GMT-07:00 Flavio Leitner : > On Thu, Jul 28, 2016 at 09:32:54AM -0700, Ben Pfaff wrote: > > On Thu, Jul 28, 2016 at 12:49:37PM -0300, Flavio Leitner wrote: > > > On Wed, Jul 27, 2016 at 11:49:18AM -0700, Ben Pfaff wrote: > > > > Some time ago this morning, I

  1   2   >