Re: [ovs-dev] [PATCH] ovn pacemaker: Provide the option to configure inactivity probe value

, Oct 12, 2017 at 11:08 AM, Andy Zhou <az...@ovn.org> wrote: > Sure, I will take a look. > > On Thu, Oct 12, 2017 at 10:49 AM, Ben Pfaff <b...@ovn.org> wrote: >> Hi Andy. In the IRC meeting today, Numan suggested that you might be an >> appropriate reviewer for th

Re: [ovs-dev] [PATCH] vswitch.xml: Better document patch ports.

On Thu, Oct 12, 2017 at 9:09 AM, Ben Pfaff <b...@ovn.org> wrote: > Reported-by: Hui Xiang <xiangh...@gmail.com> > Signed-off-by: Ben Pfaff <b...@ovn.org> > --- Looks good. Acked-by: Andy Zhou <az...@ovn.org> ___ dev

Re: [ovs-dev] [PATCH] ovn pacemaker: Provide the option to configure inactivity probe value

activity probe interval is not enough and ovsdb-servers >> time out. >> This patch >>- providdes an option to configure this value. >>- creates a connection row in NB/SB dbs and sets the target and >> inactivity_probe values when the node is promoted to mast

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Remove assertion for truncated

On Tue, Oct 10, 2017 at 12:28 AM, Iwase Yusuke wrote: > Hi Andy, > > Thank you for your quick response. > > Your patch looks good to me. > I couldn't judge whether we can "truncate" completely or not, that sounds > great! > > Thanks, > Iwase > Thanks. I have pushed the

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Remove assertion for truncated

On Mon, Oct 9, 2017 at 8:18 PM, Iwase Yusuke wrote: > Hi Ben and Andy, > > Thank you very much! > I'm looking forward to review comments. > > Hi, Iwase, I miss interpreted max_len in the spec, and thought (wrongly) that only the output controller action should have a

Re: [ovs-dev] [PATCH] dpif-netdev: Use portable error code for zero rate meter band

On Thu, Sep 28, 2017 at 7:31 PM, Joe Stringer <j...@ovn.org> wrote: > On 28 September 2017 at 12:39, Andy Zhou <az...@ovn.org> wrote: >> 'EBADRQC' is only defined on the Linux platform. Without this fix, >> The travis MacOS build fails. Switching to using EDO

[ovs-dev] [PATCH] dpif-netdev: Use portable error code for zero rate meter band

'EBADRQC' is only defined on the Linux platform. Without this fix, The travis MacOS build fails. Switching to using EDOM which is more portable. Fixes: 2029ce9ac3a601 (dpif-netdev: Fix a zero-rate bug for meter) CC: Ali Volkan ATLI <volkan.a...@argela.com.tr> Signed-off-by: Andy Zh

Re: [ovs-dev] [PATCH] dpif-netdev: Fix a zero-rate bug for meter

On Wed, Sep 27, 2017 at 9:23 AM, Ali Volkan Atli wrote: > From 23bc166eecd6e4db7b55720cdd780012df62a0cc Mon Sep 17 00:00:00 2001 > From: Ali Volkan ATLI > Date: Wed, 27 Sep 2017 18:33:57 +0300 > Subject: [PATCH] dpif-netdev: Fix a zero-rate

Re: [ovs-dev] [merge native tunneling and patch port 1/7] ofproto-dpif: Unfreeze within clone

On Thu, Sep 21, 2017 at 9:44 AM, Greg Rose <gvrose8...@gmail.com> wrote: > On 09/12/2017 12:49 PM, Andy Zhou wrote: >> >> When translating actions within open flow clone, actions generated >> by finish_freezeing() should also be enclosed within the datapath >> clo

Re: [ovs-dev] [PATCH 1/2] datapath: Optimize updating for OvS flow_stats.

On Sun, Sep 10, 2017 at 6:00 PM, Tonghao Zhang wrote: > Upstream commit: > commit c57c054eb5b1ccf230c49f736f7a018fcbc3e952 > Author: Tonghao Zhang > Date: Mon Jul 17 23:28:05 2017 -0700 > > openvswitch:

Re: [ovs-dev] [PATCH 01/15] acinclude: Check for SKB_GSO_UDP

On Mon, Sep 11, 2017 at 10:55 AM, Greg Rose wrote: > Removed in kernel 4.13 > > Signed-off-by: Greg Rose Pushed the series to master with some minor edits. Patch 2 and 3 of the series are dropped in favor of Tonghao's patch as per mailing list

Re: [ovs-dev] [PATCH 14/15] Documentation: Update NEWS and FAQ.

On Fri, Sep 22, 2017 at 8:02 AM, Greg Rose <gvrose8...@gmail.com> wrote: > On 09/20/2017 03:18 PM, Andy Zhou wrote: >> >> On Mon, Sep 11, 2017 at 10:56 AM, Greg Rose <gvrose8...@gmail.com> wrote: >>> >>> Document Open vSwitch Linux kernel support for th

Re: [ovs-dev] [PATCH 14/15] Documentation: Update NEWS and FAQ.

On Mon, Sep 11, 2017 at 10:56 AM, Greg Rose wrote: > Document Open vSwitch Linux kernel support for the 4.13 kernel > release. > > Signed-off-by: Greg Rose > --- > Documentation/faq/releases.rst | 2 +- > NEWS | 2 ++ > 2

Re: [ovs-dev] [merge native tunneling and patch port 1/7] ofproto-dpif: Unfreeze within clone

On Tue, Sep 19, 2017 at 1:56 PM, Greg Rose <gvrose8...@gmail.com> wrote: > On 09/19/2017 01:26 PM, Andy Zhou wrote: >> >> On Tue, Sep 19, 2017 at 9:55 AM, Greg Rose <gvrose8...@gmail.com> wrote: >>> >>> On 09/12/2017 12:49 PM, Andy Zhou wrote: >&g

Re: [ovs-dev] [merge native tunneling and patch port 1/7] ofproto-dpif: Unfreeze within clone

On Tue, Sep 19, 2017 at 9:55 AM, Greg Rose <gvrose8...@gmail.com> wrote: > On 09/12/2017 12:49 PM, Andy Zhou wrote: >> >> When translating actions within open flow clone, actions generated >> by finish_freezeing() should also be enclosed within the datapath >> clo

Re: [ovs-dev] [v2] bridge: Fix controller status update to passive connections

On Wed, Sep 13, 2017 at 8:30 PM, Joe Stringer <j...@ovn.org> wrote: > On 13 September 2017 at 13:05, Andy Zhou <az...@ovn.org> wrote: >> The bug can cause ovs-vswitchd to crash (due to assert) when it is >> set up with a passive controller connection. Since only act

[ovs-dev] [v2] bridge: Fix controller status update to passive connections

pdate") Reported-by: Josh Bailey <j...@faucet.nz> Signed-off-by: Andy Zhou <az...@ovn.org> --- v1->v2: Set defaults when cinfo is NULL. --- AUTHORS.rst | 1 + vswitchd/bridge.c | 16 +++- 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/AUTHOR

[ovs-dev] [merge native tunneling and patch port 7/7] ofproto-dpif-xlate: Refactor native tunnel handling logic

the 'truncate' boolean argument into compose_output_action(). Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 243 +-- 1 file changed, 95 insertions(+), 148 deletions(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/o

[ovs-dev] [merge native tunneling and patch port 6/7] ofproto-dpif-xlate: Rename apply_nested_clone_actions()

To patch_port_output(). The original function name does not make much sense. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/o

[ovs-dev] [merge native tunneling and patch port 5/7] ofproto-dpif-xlate: Refactor xlate_table_actions()

Allow xlate_table_actions() to generate actions with or without enclosed in clone(). Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/ofproto/ofproto-dpif-xla

[ovs-dev] [merge native tunneling and patch port 4/7] ofproto-dpif-xlate: Keep track of the last action

When Openflow clone is last action of an action list, it does not make sense for xlated actions to generate datapath clone action. This patch attemps to Keep track of last clone action, but not necessarily for every case. Signed-off-by: Andy Zhou <az...@ovn.org> --- include/openvswit

[ovs-dev] [merge native tunneling and patch port 2/7] ofproto-dpif-xlate: Remove uncessary assignment

Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index e5ad832d7c47..d5b47666e974 100644 --- a/ofproto/ofproto-dpif-xlate.c +++ b/ofproto/ofproto-dpif-x

[ovs-dev] [merge native tunneling and patch port 1/7] ofproto-dpif: Unfreeze within clone

When translating actions within open flow clone, actions generated by finish_freezeing() should also be enclosed within the datapath clone netlink encoding. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 9 + 1 file changed, 9 insertions(+) diff

Re: [ovs-dev] [branch-2.8] Prepare for 2.8.1.

On Fri, Sep 1, 2017 at 11:50 AM, Justin Pettit <jpet...@ovn.org> wrote: > Signed-off-by: Justin Pettit <jpet...@ovn.org> Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] bridge: Fix controller status update to passive connections

On Wed, Sep 6, 2017 at 11:59 PM, Joe Stringer <j...@ovn.org> wrote: > On 6 September 2017 at 15:24, Andy Zhou <az...@ovn.org> wrote: >> The bug can cause ovs-vswitchd to crash (due to assert) when it is >> set up with a passive controller connection. Since only act

[ovs-dev] [PATCH] bridge: Fix controller status update to passive connections

The bug can cause ovs-vswitchd to crash (due to assert) when it is set up with a passive controller connection. Since only active connections are kept, the passive connection status update should be ignored and not trigger asserts. Reported-by: Josh Bailey <j...@faucet.nz> Signed-off-by

Re: [ovs-dev] [PATCH 1/2] monitor: Fix bad caching of conditional monitor_cond requests.

t for the unconditional one. > This commit fixes the problem. > > Signed-off-by: Ben Pfaff <b...@ovn.org> I think the first paragraph of the commit message can be useful as comments in the code as well. Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 2/2] monitor: Simplify calculation of cond->conditional.

en Pfaff <b...@ovn.org> Thanks for the simplification. Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH/RFC] bond: add enable-recirc configuration for bond.

On Wed, Aug 16, 2017 at 7:59 AM, Simon Horman <simon.hor...@netronome.com> wrote: > Hi Andy, > > On Tue, Aug 15, 2017 at 01:31:36PM -0700, Andy Zhou wrote: >> On Tue, Aug 15, 2017 at 9:13 AM, Simon Horman >> <simon.hor...@netronome.com> wrote: &g

Re: [ovs-dev] [PATCH] dp-packet: Introduce dp_packet_batch_add_unsafe().

On Fri, Aug 11, 2017 at 7:41 AM, Ilya Maximets wrote: > > Could you suggest another dp_packet_batch_XXX() name (which can be exposed > to the end user) for the function that doesn't check the boundaries instead > of 'add_unsafe', if you think it is not accurate? How about

Re: [ovs-dev] [PATCH] dp-packet: Introduce dp_packet_batch_add_unsafe().

> Maybe I don't fully understand what you're trying to say, but I want to use > unsafe function in dpif-netdev for per-flow packet batching (see the patch) > and it should not be internal for that case. > (It's safe to use unsafe function there because per-flow batches are > guaranteed to be less

Re: [ovs-dev] [PATCHv3 2/2] dpif: Clean up netdev_ports map on dpif_close().

> Balance the referencing of netdevs by clearing these during dpif_close(). > > Fixes: 32b77c316d9982("dpif: Save added ports in a port map.") > Signed-off-by: Joe Stringer <j...@ovn.org> A minor comment below. Acked-by: Andy Zhou <az...@ovn.org> > --- > v3: Rather than

Re: [ovs-dev] [PATCHv3 1/2] netdev: Free ifidx mapping in netdev_ports_remove().

hese up. > > Fixes: 32b77c316d9982("dpif: Save added ports in a port map.") > Reported-by: Andy Zhou <az...@ovn.org> > Signed-off-by: Joe Stringer <j...@ovn.org> A few minor comments inline. Otherwise, Acked-by: Andy Zhou <az...@ovn.org> > --- > v3: First po

Re: [ovs-dev] [PATCHv2 2/2] dpif: Fix clean up of dpif_ports on dpif_close().

On Tue, Aug 8, 2017 at 11:23 AM, Joe Stringer wrote: > Commit 32b77c316d9982("dpif: Save added ports in a port map.") > introduced tracking of all dpif ports by taking a reference on each > available netdev when the dpif is opened, but it failed to clear out and > release references

Re: [ovs-dev] [PATCH] dp-packet: Introduce dp_packet_batch_add_unsafe().

On Mon, Aug 7, 2017 at 11:01 PM, Ilya Maximets <i.maxim...@samsung.com> wrote: > On 07.08.2017 23:24, Andy Zhou wrote: >> On Mon, Aug 7, 2017 at 8:50 AM, Ilya Maximets <i.maxim...@samsung.com> wrote: >>> Almost all batch usecases covered by the new API introduced &

Re: [ovs-dev] [PATCH] system-kmod-macros: Load TFTP module.

ystem tests: Add 4 new ftp and tftp tests.") > Signed-off-by: Joe Stringer <j...@ovn.org> Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH] system-traffic: Fix TFTP NAT skip check.

e Stringer <j...@ovn.org> Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-ipfix: Use common OVS functions for getting current time.

On Mon, Jun 5, 2017 at 6:04 PM, Ben Pfaff <b...@ovn.org> wrote: > OVS has common infrastructure functions for getting the current time, but > this code was not using them. It is not clear why, so this commit changes > it to use them. > > Signed-off-by: Ben Pfaff <b...@

Re: [ovs-dev] [PATCH] dp-packet: Introduce dp_packet_batch_add_unsafe().

On Mon, Aug 7, 2017 at 8:50 AM, Ilya Maximets wrote: > Almost all batch usecases covered by the new API introduced > in commit 72c84bc2db23 ("dp-packet: Enhance packet batch APIs.") > except unsafe batch addition. It used in dpif-netdev for fast > per-flow batches filling.

Re: [ovs-dev] [PATCH] debian.rst: Clarify that "dpkg" needs manual help with dependencies.

On Thu, Jul 6, 2017 at 4:47 PM, Ben Pfaff <b...@ovn.org> wrote: > On Mon, May 29, 2017 at 11:40:51AM -0700, Ben Pfaff wrote: >> Reported-by: Mircea Ulinic <p...@mirceaulinic.net> >> Signed-off-by: Ben Pfaff <b...@ovn.org> A

Re: [ovs-dev] [PATCH] ovsdb-server: Document clarification for some bad wording in RFC 7047.

On Thu, Jul 27, 2017 at 4:20 PM, Ben Pfaff <b...@ovn.org> wrote: > Reported-by: Harish Kanakaraju <hkanakar...@vmware.com> > Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing l

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: Add OFPACT_ENCAP, OFPACT_DECAP to reversible_actions().

On Thu, Aug 3, 2017 at 1:20 PM, Ben Pfaff <b...@ovn.org> wrote: > Fixes a broken build when building with --enable-Werror. > > I guess that encap and decap are often reversible, but it's safe to > consider them irreversible. > > CC: Andy Zhou <az...@ovn.org> >

Re: [ovs-dev] [PATCH] ovs-ofctl: Avoid unnecessary flow replacement in "replace-flows" command.

the >> flow's duration, so it's better to avoid it. >> >> This commit fixes the problem using the same trick previously used for a >> similar problem with the "diff-flows" command, which was fixed in commit >> 98f7f427bf8

Re: [ovs-dev] [PATCH] bridge: Avoid read of uninitialized data configuring Auto-Attach.

.openvswitch.org/pipermail/ovs-discuss/2017-April/044309.html >> Signed-off-by: Ben Pfaff <b...@ovn.org> Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [clone optmization v2 0/7] Clone optimization

On Thu, Aug 3, 2017 at 11:27 AM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, Jul 21, 2017 at 03:46:26PM -0700, Andy Zhou wrote: >> I respined the patches based on review feedback at: >> >> http://mail.openvswitch.org/pipermail/ovs-dev/2017-June/333502.html >> &

Re: [ovs-dev] [PATCH 2/2] Eliminate most shadowing for local variable names.

it > eliminates most of it. > > Found with -Wshadow=local in GCC 7. The repo is not really ready to enable > this option by default because of a few cases that are harder to fix, and > harmless, such as nested use of CMAP_FOR_EACH. > > Signed-off-by: Ben Pfaff <b...@ovn.o

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-xlate: Eliminate duplicate read of xcfgp.

aff <b...@ovn.org> Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH 1/2] bond: Fix broken rebalancing after link state changes.

On Thu, Jul 20, 2017 at 10:21 AM, Ilya Maximets wrote: > There are 3 constraints for moving hashes from one slave to another: > > 1. The load difference is larger than ~3% of one slave's load. > 2. The load difference between slaves exceeds 10 bytes. >

Re: [ovs-dev] [PATCH 0/6] Fix build breakage due to uninitalized data

ATTR_TUNNEL for exact mask > checks. > util: New function is_all_byte(). > odp-util: Make checks for exact or wildcard masks more precise. Thanks for fixing the travis build and for improve the readability of those functions. For the

Re: [ovs-dev] flow: Refactor flow_compose() API.

> > I think, it's better to use 'dp_packet_delete(packet)' instead of two > lines above. 'delete' is the better pair for 'new'. 'uninit' is mostly > for packets allocated statically and initialized by 'dp_packet_init()'. > > Additionally this will help to avoid issues if 'dp_packet_new' will > be

Re: [ovs-dev] [PATCH] system-userspace-macros: Fix ethtool with new kernels.

ise, we will not > fail the test due to the above. > > Signed-off-by: Joe Stringer <j...@ovn.org> LGTM. Acked-by: Andy Zhou <az...@ovn.org> ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2 1/3] vswitch.xml: Fix L2 balancing mentioning for balance-tcp bond.

On Tue, Jul 25, 2017 at 11:44 AM, Andy Zhou <az...@ovn.org> wrote: > Thanks. I have pushed the series to master. > > While applying the patches. I noticed a minor issue and sent a follow > up patch at: > > https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336231.htm

Re: [ovs-dev] [PATCH] bond: Adjust bond hash masks

On Wed, Jul 26, 2017 at 12:06 AM, Ilya Maximets <i.maxim...@samsung.com> wrote: > On 25.07.2017 21:39, Andy Zhou wrote: >> Commit 42781e77035d (bond: Unify hash functions in hash action and entry >> lookup.) changed the BM_TCP's hash function, but did not update >> h

Re: [ovs-dev] [PATCH v2 1/3] flow: Add flow_compose_size().

. > > Will be used in netdev-dummy to properly handle '--len' option. > > Suggested-by: Andy Zhou <az...@ovn.org> > Signed-off-by: Ilya Maximets <i.maxim...@samsung.com> > --- Thanks for the bug fixes. I have pushed this series to master. I think the readability can be furth

[ovs-dev] [PATCH] flow: Refactor flow_compose() API.

when 'size' is unreasonably small. Signed-off-by: Andy Zhou <az...@ovn.org> --- lib/flow.c | 53 ++-- lib/flow.h | 3 +-- lib/netdev-dummy.c | 7 -- ofproto/ofproto-dpif-trace.c | 2 +- ofproto/o

Re: [ovs-dev] [PATCH v2 1/3] vswitch.xml: Fix L2 balancing mentioning for balance-tcp bond.

Thanks. I have pushed the series to master. While applying the patches. I noticed a minor issue and sent a follow up patch at: https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336231.html Will consider back porting after this patch is reviewed. On Tue, Jul 25, 2017 at 3:46 AM, Ilya

[ovs-dev] [PATCH] bond: Adjust bond hash masks

Commit 42781e77035d (bond: Unify hash functions in hash action and entry lookup.) changed the BM_TCP's hash function, but did not update hash mask fields accordingly. Found by inspection. CC: Ilya Maximets <i.maxim...@samsung.com> Signed-off-by: Andy Zhou <az...@ovn.org> --- ofprot

Re: [ovs-dev] Fwd: [PATCH] bond: Unify hash functions in hash action and entry lookup.

On Sat, Jul 22, 2017 at 2:02 PM, Darrell Ball <db...@vmware.com> wrote: > > > -Original Message- > From: <ovs-dev-boun...@openvswitch.org> on behalf of Andy Zhou <az...@ovn.org> > Date: Friday, July 21, 2017 at 2:17 PM > To: "<d...@openvswitch.

Re: [ovs-dev] [PATCH 1/3] flow: Add packet_size option to flow_compose.

On Mon, Jul 24, 2017 at 6:33 AM, Ilya Maximets <i.maxim...@samsung.com> wrote: > On 22.07.2017 01:38, Andy Zhou wrote: >> On Wed, Jul 19, 2017 at 7:51 AM, Ilya Maximets <i.maxim...@samsung.com> >> wrote: >>> This allows to compose packets with different real le

[ovs-dev] [clone optmization v2 7/7] xlate: Emit datapath clone only when necessary.

the layering boundary is not obvious. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 169 --- tests/ofproto-dpif.at| 39 +- 2 files changed, 164 insertions(+), 44 deletions(-) diff --git a/ofproto/ofprot

[ovs-dev] [clone optmization v2 6/7] xlate: Refactor compose_clone() API

Create a new function that hides the details of netlink encoding for the translated clone action. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 76 +++- tests/ofproto-dpif.at| 7 2 files changed, 39 inse

[ovs-dev] [clone optmization v2 5/7] ofproto-dpif: Remove ofprto/tnl-push-pop command.

Use dpif/set-dp-features command instead. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif.c | 34 -- tests/ofproto-macros.at | 5 ++--- 2 files changed, 2 insertions(+), 37 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/o

[ovs-dev] [clone optmization v2 4/7] ofproto-dpif: Remove dpif/disable-truncate command.

Use 'dpif/set-dp-features' command instead. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif.c | 21 - tests/system-traffic.at | 8 ++-- 2 files changed, 2 insertions(+), 27 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-

[ovs-dev] [clone optmization v2 2/7] ofproto-dpif: Add boottime support field.

support fields are the same as boot time support fields at the startup time, but can be changed via the 'ovs-appctl' command. However, each change will be checked against the corresponding boot time support field. Only feature reduction from the boot time support is allowed. Signed-off-by: Andy Zhou

[ovs-dev] [clone optmization v2 3/7] ofproto-dpif: Remove dpif/disable-dp-clone command.

Use 'dpif/set-dp-features' command instead. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 11 --- ofproto/ofproto-dpif-xlate.h | 1 - ofproto/ofproto-dpif.c | 24 tests/ofproto-dpif.at| 4 +--- 4 files chan

[ovs-dev] [clone optmization v2 1/7] ofproto-dpif: A new command for changing dpif support fields

. The new command also allow the support fields to be changed multiple times. Currently defeature commands does not allow the support level to be restored. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif.c | 134 + 1 file change

[ovs-dev] [clone optmization v2 0/7] Clone optimization

on as part of the native tunneling work. I plan to work on it after this series has been reviewed, and after the dust settles with the native tunneling patch series. --- V1->V2: Fixed system test failures notice by Joe. Andy Zhou (7): ofproto-dpif: A new command for changing dpif support fie

Re: [ovs-dev] [PATCH 1/3] flow: Add packet_size option to flow_compose.

On Wed, Jul 19, 2017 at 7:51 AM, Ilya Maximets wrote: > This allows to compose packets with different real lenghts from > odp flows i.e. memory will be allocated for requested packet > size and all required headers like ip->tot_len filled correctly. > > Will be used in

[ovs-dev] Fwd: [PATCH] bond: Unify hash functions in hash action and entry lookup.

Add dev mailing list. It got dropped by accident. -- Forwarded message -- From: Andy Zhou <az...@ovn.org> Date: Fri, Jul 21, 2017 at 2:14 PM Subject: Re: [PATCH] bond: Unify hash functions in hash action and entry lookup. To: Ilya Maximets <i.maxim...@samsung.com>

Re: [ovs-dev] [PATCH v2] odp-execute: Reuse rss hash in OVS_ACTION_ATTR_HASH.

> Acked-by: Darrell Ball Thanks llya for the patch and Darrell for the review! Pushed to master. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [clone optmization 6/7] xlate: Refactor compose_clone() API

Create a new function that hides the details of netlink encoding for the translated clone action. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif-xlate.c | 76 +++- tests/ofproto-dpif.at| 7 2 files changed, 39 inse

[ovs-dev] [clone optmization 5/7] ofproto-dpif: Remove ofprto/tnl-push-pop command.

Use dpif/set-dp-features command instead. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif.c | 34 -- tests/ofproto-macros.at | 5 ++--- 2 files changed, 2 insertions(+), 37 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/o

[ovs-dev] [clone optmization 4/7] ofproto-dpif: Remove dpif/disable-truncate command.

Use 'dpif/set-dp-features' command instead. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif.c | 21 - tests/system-traffic.at | 8 ++-- 2 files changed, 2 insertions(+), 27 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-

[ovs-dev] [clone optmization 2/7] ofproto-dpif: Add boottime support field.

support fields are the same as boot time support fields at the startup time, but can be changed via the 'ovs-appctl' command. However, each change will be checked against the corresponding boot time support field. Only feature reduction from the boot time support is allowed. Signed-off-by: Andy Zhou

[ovs-dev] [clone optmization 1/7] ofproto-dpif: A new command for changing dpif support fields

. The new command also allow the support fields to be changed multiple times. Currently defeature commands does not allow the support level to be restored. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif.c | 133 + 1 file change

[ovs-dev] [clone optmization 0/7] Clone optimization

on as part of the native tunneling work. I plan to work on it after this series has been reviewed, and after the dust settles with the native tunneling patch series. Andy Zhou (7): ofproto-dpif: A new command for changing dpif support fields ofproto-dpif: Add boottime support field. ofproto-dpif

Re: [ovs-dev] OVSDB Replication: Clarifications required

On Sat, Jul 15, 2017 at 10:58 PM, Arunkumar Rg <arunkumar...@gmail.com> wrote: > Hi Andy Zhou, > > Thanks for looking into this! > > Please find my replies inline: > > On Tue, Jul 11, 2017 at 1:30 AM, Andy Zhou <az...@ovn.org> wrote: >> >> On Tue, Jul

Re: [ovs-dev] [PATCH] dp-packet: Remove misleading comment for refill init function.

t style changed > to be consistent with other comments in the same file. > > CC: Andy Zhou <az...@ovn.org> > Fixes: 72c84bc2db23 ("dp-packet: Enhance packet batch APIs.") > Signed-off-by: Ilya Maximets <i.maxim...@samsung.com> Thanks. Applied. _

Re: [ovs-dev] [PATCH v2] odp-execute: Reuse rss hash in OVS_ACTION_ATTR_HASH.

On Thu, Jul 13, 2017 at 8:07 AM, Ilya Maximets wrote: > If RSS hash exists in a packet it can be reused instead of > 5 tuple hash re-calculation in OVS_ACTION_ATTR_HASH. This > leads to increasing the performance of sending packets to > the OVS bonding in userspace

Re: [ovs-dev] [PATCH 5/6] test-conntrack: Fix dead store reported by clang.

, it looks like you made the previous change here, does this make > sense? I think this version is closer to the original intent of the test interface than what I have changed. Here is my Ack for this change. I have a minor comment below. Acked-by: Andy Zhou <az...@ovn.org> > > Thanks

Re: [ovs-dev] [PATCH] odp-execute: Reuse rss hash in OVS_ACTION_ATTR_HASH.

On Tue, Jul 11, 2017 at 7:30 AM, Ilya Maximets wrote: > If RSS hash exists in a packet it can be reused instead of > 5 tuple hash re-calculation in OVS_ACTION_ATTR_HASH. This > leads to increasing the performance of sending packets to > the OVS bonding in userspace

Re: [ovs-dev] OVSDB Replication: Clarifications required

On Tue, Jul 4, 2017 at 10:52 PM, Arunkumar Rg wrote: > Hi, > > Got few clarifications on OVSDB replication. Please let me know your inputs > on it. > > 1. From the ovsdb-server code(main_loop()), it seems that the standby > ovsdb-server becomes 'Active' if the JSONRPC

Re: [ovs-dev] [PATCH v2] dp-packet: Copy trunc flag on batch clone.

t; Cutlen action doesn't work for dpdk ports in case batch clone > occured because invoked by the 'dp_packet_batch_apply_cutlen()'. > > CC: Andy Zhou <az...@ovn.org> > Fixes: 72c84bc2db23 ("dp-packet: Enhance packet batch APIs.") > Signed-off-by: Ilya Maximets <i

Re: [ovs-dev] [PATCH 2/2] xlate: Use datapath clone action for patch port translation

On Tue, Jun 6, 2017 at 5:01 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, May 26, 2017 at 08:47:45PM -0700, Andy Zhou wrote: >> When available, use datapath 'clone' for patch port translation. >> Clone provides a stronger guarantee that packet will be restored >> after

Re: [ovs-dev] [PATCH 1/2] xlate: Add datapath clone generation API

On Tue, Jun 6, 2017 at 4:55 PM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, May 26, 2017 at 08:47:44PM -0700, Andy Zhou wrote: >> There are three methods of translating openflow layer clone action. >> Using datapath clone action, datapath sample action or using actions >>

[ovs-dev] [PATCH 2/2] xlate: Use datapath clone action for patch port translation

When available, use datapath 'clone' for patch port translation. Clone provides a stronger guarantee that packet will be restored after going through a patch port, Even in case the packet is NAT'd by the bridge behind the patch port. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/o

[ovs-dev] [PATCH 1/2] xlate: Add datapath clone generation API

xlate_clone() implements the selection logic since it is the solo user, but patches will add more users. Introduce new APIs that hide the details of generating datapath clone action. Signed-off-by: Andy Zhou <az...@ovn.org> --- ofproto/ofproto-dpif-xlate.c

Re: [ovs-dev] [PATCH 2/2] faq: Expand on answer about OVS meter action support

On Fri, May 26, 2017 at 11:41 AM, Ben Pfaff <b...@ovn.org> wrote: > On Fri, May 26, 2017 at 11:36:53AM -0700, Andy Zhou wrote: >> Signed-off-by: Andy Zhou <az...@ovn.org> > > For both: > Acked-by: Ben Pfaff <b...@ovn.org> > >

[ovs-dev] [PATCH 2/2] faq: Expand on answer about OVS meter action support

Signed-off-by: Andy Zhou <az...@ovn.org> --- Documentation/faq/qos.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/faq/qos.rst b/Documentation/faq/qos.rst index 65a14eb9f3b2..ad3d95bf4fc0 100644 --- a/Documentation/faq/qos.rst +++ b/Documentati

[ovs-dev] [PATCH 1/2] news: Add userspace meter action support.

Signed-off-by: Andy Zhou <az...@ovn.org> --- NEWS | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS b/NEWS index 25eb477a8910..1c3035145724 100644 --- a/NEWS +++ b/NEWS @@ -94,6 +94,7 @@ v2.7.0 - 21 Feb 2017 * The "sample" action now supports "ingress&

Re: [ovs-dev] [PATCH] ovn-ctl: Add commands to manage OVN DB ovsdb-servers individually

On Fri, May 26, 2017 at 4:48 AM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Fri, May 26, 2017 at 3:30 AM, Andy Zhou <az...@ovn.org> wrote: >> >> On Thu, May 25, 2017 at 1:55 AM, <nusid...@redhat.com> wrote: >> > From: Numan Siddique

Re: [ovs-dev] [PATCH] ovn-ctl: Add commands to manage OVN DB ovsdb-servers individually

ovsdb-server independently. > - start_sb_ovsdb, stop_sb_ovsdb, restart_sb_ovsdb to start, stop and > restart the OVN SB DB ovsdb-server independently. > > These commands can be used to run ovsdb-server for each DB in a separate > container. > > Signed-off-by: Numan Siddique <nusid...@re

Re: [ovs-dev] [PATCH v2] tests: fix hanging test on windows

en the test has finished) > > Introduce a pidfile to 'ovs-testcontroller' and end it on exit based on > the pidfile. > > Signed-off-by: Alin Gabriel Serdean <aserd...@cloudbasesolutions.com> Thanks Alin for the fix and Joe for the review. It looks good to me. Acked-by: Andy Zhou <

Re: [ovs-dev] [PATCH 1/2] ovn pacemaker: Fix return code errors in start/stop action

On Mon, May 22, 2017 at 9:12 PM, Numan Siddique <nusid...@redhat.com> wrote: > > > On Tue, May 23, 2017 at 5:21 AM, Andy Zhou <az...@ovn.org> wrote: >> >> On Sun, May 21, 2017 at 6:35 PM, <nusid...@redhat.com> wrote: >> > From: Numan Siddique <

Re: [ovs-dev] [PATCH 1/2] ovn pacemaker: Fix return code errors in start/stop action

when they > are running as masters (which is the expected case) and returns > OCF_SUCCESS. > > [1] - > http://www.linux-ha.org/doc/dev-guides/_literal_ocf_running_master_literal_8.html > [2] - http://www.linux-ha.org/doc/dev-guides/_literal_stop_literal_action.html > > CC:

Re: [ovs-dev] Fwd: [PATCH] bfd: Fix signs in ovs-appctl bfd/show Detect Time, Next Tx Time, Last TX Time

On Thu, May 18, 2017 at 6:39 AM, Gabor Szucs wrote: > Hi, > This is a fix for ovs-appctl bfd/show printout that looks partly incorrect. > > ovs-appctl bfd/show command printout > shows negative time lag from now for upcoming events: > Detect Time: now -2632ms >

Re: [ovs-dev] [PATCH] tests: Fix timing dependency bridge - multiple bridges share a controller

On Wed, May 17, 2017 at 1:43 PM, Joe Stringer <j...@ovn.org> wrote: > On 17 May 2017 at 13:16, Andy Zhou <az...@ovn.org> wrote: >> On Wed, May 17, 2017 at 12:33 PM, Joe Stringer <j...@ovn.org> wrote: >>> On 17 May 2017 at 11:37, Andy Zhou <az...@ovn.org&

[ovs-dev] [PATCH] tests: Fix timing dependency bridge - multiple bridges share a controller

controller status update) Signed-off-by: Andy Zhou <az...@ovn.org> --- tests/bridge.at | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/tests/bridge.at b/tests/bridge.at index 58b27d445062..cc7619d3f035 100644 --- a/tests/bridge.at +++ b/tests/bri

Re: [ovs-dev] [PATCH] bridge: Fix controller status update

On Fri, May 12, 2017 at 12:07 PM, Andy Zhou <az...@ovn.org> wrote: > On Thu, May 11, 2017 at 8:35 PM, Greg Rose <gvrose8...@gmail.com> wrote: >> On Thu, 2017-05-11 at 16:16 -0700, Andy Zhou wrote: >>> When multiple bridges connects to the same controller, th

Re: [ovs-dev] [PATCH] bridge: Fix controller status update

On Thu, May 11, 2017 at 8:35 PM, Greg Rose <gvrose8...@gmail.com> wrote: > On Thu, 2017-05-11 at 16:16 -0700, Andy Zhou wrote: >> When multiple bridges connects to the same controller, the controller >> status should be maintained separately for each bridge. Current >>

  1   2   3   4   5   6   7   8   9   10   >