it seems that the plugin upgrade went as smoothly as it could have... i
still have a bunch of stack traces to filter through and see if anything is
really broken but it's looking pretty good and things are building.
if you see any bad behavior from jenkins, don't hesitate to file a jira and
ping
Thank you, Shane!
On Mon, Nov 23, 2020 at 2:12 PM shane knapp ☠ wrote:
> the third most terrifying event in the world, a massive jenkins plugin
> update is happening in a couple of hours. i'm going to restart jenkins and
> start working out any bugs/issues that pop up.
>
> this could be short,
the third most terrifying event in the world, a massive jenkins plugin
update is happening in a couple of hours. i'm going to restart jenkins and
start working out any bugs/issues that pop up.
this could be short, or quite long. i'm guessing somewhere in the middle.
no new builds will be kicked
Yes, agree, and that time limit is probably a lot shorter than 1.5 years.
I think these ultimately come down to judgment, and am affirming the
judgment that this amounts to 'reviewed'.
On Mon, Nov 23, 2020 at 11:40 AM Ryan Blue wrote:
> I'll go take a look.
>
> While I would generally agree
I'll go take a look.
While I would generally agree with Sean that it would be appropriate in
this case to commit, I'm very hesitant to set that precedent. I'd prefer to
stick with "review then commit" and, if needed, relax that constraint for
parts of the project that can't get reviewers for a
I don't see any objections on that thread. You're a committer and have
reviews from other knowledgeable people in this area. Do you have any
reason to believe it's controversial, like, changes semantics or APIs? Were
there related discussions elsewhere that expressed any concern?
>From a glance,
