Re: -1s on committed but not released code?

2021-08-19 Thread Hyukjin Kwon
Yeah, I think we can discuss and revert it (or fix it) per the veto set. Often problems are found later after codes are merged. 2021년 8월 20일 (금) 오전 4:08, Mridul Muralidharan 님이 작성: > Hi Holden, > > In the past, I have seen discussions on the merged pr to thrash out the > details. > Usually it

Re: -1s on committed but not released code?

2021-08-19 Thread Mridul Muralidharan
Hi Holden, In the past, I have seen discussions on the merged pr to thrash out the details. Usually it would be clear whether to revert and reformulate the change or concerns get addressed and possibly result in follow up work. This is usually helped by the fact that we typically are

-1s on committed but not released code?

2021-08-19 Thread Holden Karau
Hi Y'all, This just recently came up but I'm not super sure on how we want to handle this in general. If code was committed under the lazy consensus model and then a committer or PMC -1s it post merge, what do we want to do? I know we had some previous discussion around -1s, but that was largely