Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-29 Thread L . C . Hsieh
>>>>> > >>>>>> +1 for this. This is exciting movement to efficiently read bucketed > >>>>>> table from other systems (Hive, Trino & Presto)! > >>>>>> > >>>>>> > >>>>>> > >>

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-28 Thread Wenchen Fan
gt;>>>1. Is migrating Hive table read path to data source v2, being a >>>>>>prerequisite of this SPIP? >>>>>> >>>>>> >>>>>> >>>>>> Hive table read path is currently a mix of data source v1 (for >

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-27 Thread Ryan Blue
ntly a mix of data source v1 (for Parquet >>>>> & ORC file format only), and legacy Hive code path (HiveTableScanExec). In >>>>> the SPIP, I am seeing we only make change for data source v2, so wondering >>>>> how this would work with exist

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-27 Thread Chao Sun
rrently a mix of data source v1 (for Parquet >>>>> & ORC file format only), and legacy Hive code path (HiveTableScanExec). In >>>>> the SPIP, I am seeing we only make change for data source v2, so wondering >>>>> how this would work with

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-27 Thread L . C . Hsieh
gt; > > > > > Just curious if there’s any other use cases we are targeting as part of > > SPIP. > > > > > > > > Thanks, > > > > Cheng Su > > > > > > > > > > > > > > > > *From: *Ryan Blue >

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-27 Thread Wenchen Fan
master recently ( >>>> SPARK-19256 <https://issues.apache.org/jira/browse/SPARK-19256> has >>>> details). >>>> >>>> >>>> >>>> 1. Would aggregate work automatically after the SPIP? >>>> >>>> >>&g

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-27 Thread Ryan Blue
regate. Just want to bring to our attention that it would be >>> great to consider aggregate as well when doing this proposal. >>> >>> >>> >>>1. Any major use cases in mind except Hive bucketed table? >>> >>> >>> >>&

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-27 Thread Wenchen Fan
e cases in mind except Hive bucketed table? >> >> >> >> Just curious if there’s any other use cases we are targeting as part of >> SPIP. >> >> >> >> Thanks, >> >> Cheng Su >> >> >> >> >> >

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Chao Sun
ng Su > > > > > > > > *From: *Ryan Blue > *Date: *Tuesday, October 26, 2021 at 9:39 AM > *To: *John Zhuge > *Cc: *Chao Sun , Wenchen Fan , > Cheng Su , DB Tsai , Dongjoon Hyun < > dongjoon.h...@gmail.com>, Hyukjin Kwon , Wenchen Fan > , angers zhu , dev

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Erik Krogen
her use cases we are targeting as part of > SPIP. > > > > Thanks, > > Cheng Su > > > > > > > > *From: *Ryan Blue > *Date: *Tuesday, October 26, 2021 at 9:39 AM > *To: *John Zhuge > *Cc: *Chao Sun , Wenchen Fan , > Cheng Su , DB Tsai , Dongjoon

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Cheng Su
Date: Tuesday, October 26, 2021 at 9:39 AM To: John Zhuge Cc: Chao Sun , Wenchen Fan , Cheng Su , DB Tsai , Dongjoon Hyun , Hyukjin Kwon , Wenchen Fan , angers zhu , dev , huaxin gao Subject: Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2 Instead of commenting on the doc,

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Ryan Blue
Instead of commenting on the doc, could we keep discussion here on the dev list please? That way more people can follow it and there is more room for discussion. Comment threads have a very small area and easily become hard to follow. Ryan On Tue, Oct 26, 2021 at 9:32 AM John Zhuge wrote: > +1

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread John Zhuge
+1 Nicely done! On Tue, Oct 26, 2021 at 8:08 AM Chao Sun wrote: > Oops, sorry. I just fixed the permission setting. > > Thanks everyone for the positive support! > > On Tue, Oct 26, 2021 at 7:30 AM Wenchen Fan wrote: > >> +1 to this SPIP and nice writeup of the design doc! >> >> Can we open

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Chao Sun
Oops, sorry. I just fixed the permission setting. Thanks everyone for the positive support! On Tue, Oct 26, 2021 at 7:30 AM Wenchen Fan wrote: > +1 to this SPIP and nice writeup of the design doc! > > Can we open comment permission in the doc so that we can discuss details > there? > > On Tue,

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread angers zhu
+1 on this, Wenchen Fan 于2021年10月26日周二 下午10:29写道: > +1 to this SPIP and nice writeup of the design doc! > > Can we open comment permission in the doc so that we can discuss details > there? > > On Tue, Oct 26, 2021 at 8:29 PM Hyukjin Kwon wrote: > >> Seems making sense to me. >> >> Would be

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Wenchen Fan
+1 to this SPIP and nice writeup of the design doc! Can we open comment permission in the doc so that we can discuss details there? On Tue, Oct 26, 2021 at 8:29 PM Hyukjin Kwon wrote: > Seems making sense to me. > > Would be great to have some feedback from people such as @Wenchen Fan >

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Hyukjin Kwon
Seems making sense to me. Would be great to have some feedback from people such as @Wenchen Fan @Cheng Su @angers zhu . On Tue, 26 Oct 2021 at 17:25, Dongjoon Hyun wrote: > +1 for this SPIP. > > On Sun, Oct 24, 2021 at 9:59 AM huaxin gao wrote: > >> +1. Thanks for lifting the current

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-26 Thread Dongjoon Hyun
+1 for this SPIP. On Sun, Oct 24, 2021 at 9:59 AM huaxin gao wrote: > +1. Thanks for lifting the current restrictions on bucket join and making > this more generalized. > > On Sun, Oct 24, 2021 at 9:33 AM Ryan Blue wrote: > >> +1 from me as well. Thanks Chao for doing so much to get it to this

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-24 Thread huaxin gao
+1. Thanks for lifting the current restrictions on bucket join and making this more generalized. On Sun, Oct 24, 2021 at 9:33 AM Ryan Blue wrote: > +1 from me as well. Thanks Chao for doing so much to get it to this point! > > On Sat, Oct 23, 2021 at 11:29 PM DB Tsai wrote: > >> +1 on this

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-24 Thread Ryan Blue
+1 from me as well. Thanks Chao for doing so much to get it to this point! On Sat, Oct 23, 2021 at 11:29 PM DB Tsai wrote: > +1 on this SPIP. > > This is a more generalized version of bucketed tables and bucketed > joins which can eliminate very expensive data shuffles when joins, and > many

Re: [DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-24 Thread DB Tsai
+1 on this SPIP. This is a more generalized version of bucketed tables and bucketed joins which can eliminate very expensive data shuffles when joins, and many users in the Apache Spark community have wanted this feature for a long time! Thank you, Ryan and Chao, for working on this, and I look

[DISCUSS] SPIP: Storage Partitioned Join for Data Source V2

2021-10-22 Thread Chao Sun
Hi, Ryan and I drafted a design doc to support a new type of join: storage partitioned join which covers bucket join support for DataSourceV2 but is more general. The goal is to let Spark leverage distribution properties reported by data sources and eliminate shuffle whenever possible. Design