Re: BytesToBytes and unaligned memory

2016-04-18 Thread Ted Yu
Yu <yuzhih...@gmail.com> > To:Adam Roberts/UK/IBM@IBMGB > Cc: "dev@spark.apache.org" <dev@spark.apache.org> > Date:15/04/2016 17:35 > Subject:Re: BytesToBytes and unaligned memory > -- > > >

Re: BytesToBytes and unaligned memory

2016-04-18 Thread Adam Roberts
/04/2016 17:35 Subject: Re: BytesToBytes and unaligned memory I am curious if all Spark unit tests pass with the forced true value for unaligned. If that is the case, it seems we can add s390x to the known architectures. It would also give us some more background if you can describe how j

Re: BytesToBytes and unaligned memory

2016-04-15 Thread Ted Yu
ks to prints I've added > > Cheers, > > > > > From:Ted Yu <yuzhih...@gmail.com> > To:Adam Roberts/UK/IBM@IBMGB > Cc:"dev@spark.apache.org" <dev@spark.apache.org> > Date:15/04/20

Re: BytesToBytes and unaligned memory

2016-04-15 Thread Ted Yu
turning: " + unaligned);* > } > } > > Output is, as you'd expect, "used reflection and _unaligned is false, > setting to true anyway for experimenting", and the tests pass. > > No other problems on the platform (pending a different pull request). > &g

Re: BytesToBytes and unaligned memory

2016-04-15 Thread Ted Yu
I assume you tested 2.0 with SPARK-12181 . Related code from Platform.java if java.nio.Bits#unaligned() throws exception: // We at least know x86 and x64 support unaligned access. String arch = System.getProperty("os.arch", ""); //noinspection

BytesToBytes and unaligned memory

2016-04-15 Thread Adam Roberts
Hi, I'm testing Spark 2.0.0 on various architectures and have a question, are we sure if core/src/test/java/org/apache/spark/unsafe/map/AbstractBytesToBytesMapSuite.java really is attempting to use unaligned memory access (for the BytesToBytesMapOffHeapSuite tests specifically)? Our JDKs on