Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-20 Thread Jungtaek Lim
Heads-up: It's addressed via https://issues.apache.org/jira/browse/SPARK-42075. We just marked deprecation in the entry point of DStream, StreamContext. Marking all classes in the DStream module is not pragmatic and users would see the warning message anyway. On Mon, Jan 16, 2023 at 8:26 AM

Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-15 Thread Jungtaek Lim
Given that I got more than 3 PMC members' positive votes as well as several active contributors' positive votes as well, I will proceed with the actual work. (It may take a couple of more days as folk in US will help me and there's a holiday in US.) Please let me know if we want to have an

Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-15 Thread Jungtaek Lim
I described it in the thread - I had to add it in the reply so it's not easy to find. Sorry for the inconvenience. https://lists.apache.org/thread/d9yg7w9pnb9rw7c2yglp4qk6jt43y0kw On Sat, Jan 14, 2023 at 3:46 AM Jerry Peng wrote: > +1 in general for marking the DStreams API as deprecated > >

Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-13 Thread Anish Shrigondekar
+1 on the Dstreams deprecation proposal On Fri, Jan 13, 2023 at 10:47 AM Jerry Peng wrote: > +1 in general for marking the DStreams API as deprecated > > Jungtaek, can you please provide / elaborate on the concrete actions you > intend on taking for the depreciation process? > > Best, > > Jerry

Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-13 Thread Jerry Peng
+1 in general for marking the DStreams API as deprecated Jungtaek, can you please provide / elaborate on the concrete actions you intend on taking for the depreciation process? Best, Jerry On Thu, Jan 12, 2023 at 11:16 PM L. C. Hsieh wrote: > +1 > > On Thu, Jan 12, 2023 at 10:39 PM Jungtaek

Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-12 Thread L. C. Hsieh
+1 On Thu, Jan 12, 2023 at 10:39 PM Jungtaek Lim wrote: > > Yes, exactly. I'm sorry to bring confusion - should have clarified action > items on the proposal. > > On Fri, Jan 13, 2023 at 3:31 PM Dongjoon Hyun wrote: >> >> Then, could you elaborate `the proposed code change` specifically? >>

Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-12 Thread Jungtaek Lim
Yes, exactly. I'm sorry to bring confusion - should have clarified action items on the proposal. On Fri, Jan 13, 2023 at 3:31 PM Dongjoon Hyun wrote: > Then, could you elaborate `the proposed code change` specifically? > Maybe, usual deprecation warning logs and annotation on the API? > > > On

Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-12 Thread Dongjoon Hyun
Then, could you elaborate `the proposed code change` specifically? Maybe, usual deprecation warning logs and annotation on the API? On Thu, Jan 12, 2023 at 10:05 PM Jungtaek Lim wrote: > Maybe I need to clarify - my proposal is "explicitly" deprecating it, > which incurs code change for sure.

Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-12 Thread Jungtaek Lim
There might be possible terminology differences, so let me elaborate the action item from the proposal explicitly: - Add "deprecation" annotation to the user-facing public API in streaming directory (DStream) - Write a release note to explicitly mention the deprecation. (Maybe promote again that

Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-12 Thread Jungtaek Lim
Maybe I need to clarify - my proposal is "explicitly" deprecating it, which incurs code change for sure. Guidance on the Spark website is done already as I mentioned - we updated the DStream doc page to mention that DStream is a "legacy" project and users should move to SS. I don't feel this is

Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-12 Thread Reynold Xin
+1 On Thu, Jan 12, 2023 at 9:46 PM, Dongjoon Hyun < dongjoon.h...@gmail.com > wrote: > > +1 for the proposal (guiding only without any code change). > > > Thanks, > Dongjoon. > > On Thu, Jan 12, 2023 at 9:33 PM Shixiong Zhu < zsxwing@ gmail. com ( > zsxw...@gmail.com ) > wrote: > > >> +1

Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-12 Thread Dongjoon Hyun
+1 for the proposal (guiding only without any code change). Thanks, Dongjoon. On Thu, Jan 12, 2023 at 9:33 PM Shixiong Zhu wrote: > +1 > > > On Thu, Jan 12, 2023 at 5:08 PM Tathagata Das > wrote: > >> +1 >> >> On Thu, Jan 12, 2023 at 7:46 PM Hyukjin Kwon wrote: >> >>> +1 >>> >>> On Fri, 13

Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-12 Thread Shixiong Zhu
+1 On Thu, Jan 12, 2023 at 5:08 PM Tathagata Das wrote: > +1 > > On Thu, Jan 12, 2023 at 7:46 PM Hyukjin Kwon wrote: > >> +1 >> >> On Fri, 13 Jan 2023 at 08:51, Jungtaek Lim >> wrote: >> >>> bump for more visibility. >>> >>> On Wed, Jan 11, 2023 at 12:20 PM Jungtaek Lim < >>>

Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-12 Thread Tathagata Das
+1 On Thu, Jan 12, 2023 at 7:46 PM Hyukjin Kwon wrote: > +1 > > On Fri, 13 Jan 2023 at 08:51, Jungtaek Lim > wrote: > >> bump for more visibility. >> >> On Wed, Jan 11, 2023 at 12:20 PM Jungtaek Lim < >> kabhwan.opensou...@gmail.com> wrote: >> >>> Hi dev, >>> >>> I'd like to propose the

Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-12 Thread Hyukjin Kwon
+1 On Fri, 13 Jan 2023 at 08:51, Jungtaek Lim wrote: > bump for more visibility. > > On Wed, Jan 11, 2023 at 12:20 PM Jungtaek Lim < > kabhwan.opensou...@gmail.com> wrote: > >> Hi dev, >> >> I'd like to propose the deprecation of DStream in Spark 3.4, in favor of >> promoting Structured

Re: [DISCUSS] Deprecate DStream in 3.4

2023-01-12 Thread Jungtaek Lim
bump for more visibility. On Wed, Jan 11, 2023 at 12:20 PM Jungtaek Lim wrote: > Hi dev, > > I'd like to propose the deprecation of DStream in Spark 3.4, in favor of > promoting Structured Streaming. > (Sorry for the late proposal, if we don't make the change in 3.4, we will > have to wait for