Just want to say thank you to all the active SS contributors. I saw many
great features/improvements in Streaming have been merged and will be
available in the upcoming 3.1 release.
- Cache fetched list of files beyond maxFilesPerTrigger as unread file
(SPARK-32568)
- Streamline the
Jungtaek,
If there are contributors that you trust for reviews, then please let PMC
members know so they can be considered. I agree that is the best solution.
If there aren't contributors that the PMC wants to add as committers, then
I suggest agreeing on a temporary exception to help make
I don't know the code well, but those look minor and straightforward. They
have reviews from the two most knowledgeable people in this area. I don't
think you need to block for 6 months after proactively seeking all likely
reviewers - I'm saying that's the resolution to this type of situation
Btw, there are two more PRs which got LGTM by a SS contributor but fail to
get attention from committers. They're 6+ months old. Could you help
reviewing this as well, or do you all think 6 months of time range + LGTM
from an SS contributor is enough to go ahead?
Thanks for providing valuable feedback. Appreciate it. Sorry I haven't had
time to reply to this in time (was OoO this week).
I'm also in favor of "review then commit", I haven't been a "perfect" guy
making no mistake (probably that justifies me as a human being), hence the
review process is a
Yes, agree, and that time limit is probably a lot shorter than 1.5 years.
I think these ultimately come down to judgment, and am affirming the
judgment that this amounts to 'reviewed'.
On Mon, Nov 23, 2020 at 11:40 AM Ryan Blue wrote:
> I'll go take a look.
>
> While I would generally agree
I'll go take a look.
While I would generally agree with Sean that it would be appropriate in
this case to commit, I'm very hesitant to set that precedent. I'd prefer to
stick with "review then commit" and, if needed, relax that constraint for
parts of the project that can't get reviewers for a
I don't see any objections on that thread. You're a committer and have
reviews from other knowledgeable people in this area. Do you have any
reason to believe it's controversial, like, changes semantics or APIs? Were
there related discussions elsewhere that expressed any concern?
>From a glance,
Hi devs,
I have been struggling to find reviewers who are committers, to get my PR
[1] for SPARK-27237 [2] reviewed. The PR was submitted on Mar. 2019 (1.5
years ago), and somehow it got two approvals from contributors working on
the SS area, but still doesn't get any committers' traction to
