Re: Porting or explicitly linking project style in Apache Spark based on https://github.com/databricks/scala-style-guide
Will make a fix to the site. Thanks all. 2018년 8월 24일 (금) 오전 9:41, Reynold Xin 님이 작성: > I wrote both the Spark one and later the Databricks one. The latter had a > lot more work put into it and is consistent with the Spark style. I'd just > use the second one and link to it, if possible. > > > > On Thu, Aug 23, 2018 at 6:38 PM Hyukjin Kwon wrote: > >> If you meant "Code Style Guide", many of them are missing and it refers >> https://docs.scala-lang.org/style/ not >> https://github.com/databricks/scala-style-guide (please correct me if I >> misunderstood). >> For instance, I lately guided 2 indents for line continuation but I found >> it's actually not in the official guide (which is rather usual in Spark's >> code base as far as I can tell FWIW). >> >> Can we just simply leave a link there instead? >> >> >> 2018년 8월 24일 (금) 오전 9:35, Matei Zaharia 님이 작성: >> >>> There’s already a code style guide listed on >>> http://spark.apache.org/contributing.html. Maybe it’s the same? We >>> should decide which one we actually want and update this page if it’s wrong. >>> >>> Matei >>> >>> > On Aug 23, 2018, at 6:33 PM, Sean Owen wrote: >>> > >>> > Seems OK to me. The style is pretty standard Scala style anyway. My >>> guidance is always to follow the code around the code you're changing. >>> > >>> > On Thu, Aug 23, 2018 at 8:14 PM Hyukjin Kwon >>> wrote: >>> > Hi all, >>> > >>> > I usually follow https://github.com/databricks/scala-style-guide for >>> Apache Spark's style, which is usually generally the same with the Spark's >>> code base in practice. >>> > Thing is, we don't explicitly mention this within Apache Spark as far >>> as I can tell. >>> > >>> > Can we explicitly mention this or port this style guide? It doesn't >>> necessarily mean hard requirements for PRs or code changes but we could at >>> least encourage people to read it. >>> > >>> >>>
Re: Porting or explicitly linking project style in Apache Spark based on https://github.com/databricks/scala-style-guide
I wrote both the Spark one and later the Databricks one. The latter had a lot more work put into it and is consistent with the Spark style. I'd just use the second one and link to it, if possible. On Thu, Aug 23, 2018 at 6:38 PM Hyukjin Kwon wrote: > If you meant "Code Style Guide", many of them are missing and it refers > https://docs.scala-lang.org/style/ not > https://github.com/databricks/scala-style-guide (please correct me if I > misunderstood). > For instance, I lately guided 2 indents for line continuation but I found > it's actually not in the official guide (which is rather usual in Spark's > code base as far as I can tell FWIW). > > Can we just simply leave a link there instead? > > > 2018년 8월 24일 (금) 오전 9:35, Matei Zaharia 님이 작성: > >> There’s already a code style guide listed on >> http://spark.apache.org/contributing.html. Maybe it’s the same? We >> should decide which one we actually want and update this page if it’s wrong. >> >> Matei >> >> > On Aug 23, 2018, at 6:33 PM, Sean Owen wrote: >> > >> > Seems OK to me. The style is pretty standard Scala style anyway. My >> guidance is always to follow the code around the code you're changing. >> > >> > On Thu, Aug 23, 2018 at 8:14 PM Hyukjin Kwon >> wrote: >> > Hi all, >> > >> > I usually follow https://github.com/databricks/scala-style-guide for >> Apache Spark's style, which is usually generally the same with the Spark's >> code base in practice. >> > Thing is, we don't explicitly mention this within Apache Spark as far >> as I can tell. >> > >> > Can we explicitly mention this or port this style guide? It doesn't >> necessarily mean hard requirements for PRs or code changes but we could at >> least encourage people to read it. >> > >> >>
Re: Porting or explicitly linking project style in Apache Spark based on https://github.com/databricks/scala-style-guide
If you meant "Code Style Guide", many of them are missing and it refers https://docs.scala-lang.org/style/ not https://github.com/databricks/scala-style-guide (please correct me if I misunderstood). For instance, I lately guided 2 indents for line continuation but I found it's actually not in the official guide (which is rather usual in Spark's code base as far as I can tell FWIW). Can we just simply leave a link there instead? 2018년 8월 24일 (금) 오전 9:35, Matei Zaharia 님이 작성: > There’s already a code style guide listed on > http://spark.apache.org/contributing.html. Maybe it’s the same? We should > decide which one we actually want and update this page if it’s wrong. > > Matei > > > On Aug 23, 2018, at 6:33 PM, Sean Owen wrote: > > > > Seems OK to me. The style is pretty standard Scala style anyway. My > guidance is always to follow the code around the code you're changing. > > > > On Thu, Aug 23, 2018 at 8:14 PM Hyukjin Kwon > wrote: > > Hi all, > > > > I usually follow https://github.com/databricks/scala-style-guide for > Apache Spark's style, which is usually generally the same with the Spark's > code base in practice. > > Thing is, we don't explicitly mention this within Apache Spark as far as > I can tell. > > > > Can we explicitly mention this or port this style guide? It doesn't > necessarily mean hard requirements for PRs or code changes but we could at > least encourage people to read it. > > > >
Re: Porting or explicitly linking project style in Apache Spark based on https://github.com/databricks/scala-style-guide
Seems OK to me. The style is pretty standard Scala style anyway. My guidance is always to follow the code around the code you're changing. On Thu, Aug 23, 2018 at 8:14 PM Hyukjin Kwon wrote: > Hi all, > > I usually follow https://github.com/databricks/scala-style-guide for > Apache Spark's style, which is usually generally the same with the Spark's > code base in practice. > Thing is, we don't explicitly mention this within Apache Spark as far as I > can tell. > > Can we explicitly mention this or port this style guide? It doesn't > necessarily mean hard requirements for PRs or code changes but we could at > least encourage people to read it. > >
Re: Porting or explicitly linking project style in Apache Spark based on https://github.com/databricks/scala-style-guide
There’s already a code style guide listed on http://spark.apache.org/contributing.html. Maybe it’s the same? We should decide which one we actually want and update this page if it’s wrong. Matei > On Aug 23, 2018, at 6:33 PM, Sean Owen wrote: > > Seems OK to me. The style is pretty standard Scala style anyway. My guidance > is always to follow the code around the code you're changing. > > On Thu, Aug 23, 2018 at 8:14 PM Hyukjin Kwon wrote: > Hi all, > > I usually follow https://github.com/databricks/scala-style-guide for Apache > Spark's style, which is usually generally the same with the Spark's code base > in practice. > Thing is, we don't explicitly mention this within Apache Spark as far as I > can tell. > > Can we explicitly mention this or port this style guide? It doesn't > necessarily mean hard requirements for PRs or code changes but we could at > least encourage people to read it. > - To unsubscribe e-mail: dev-unsubscr...@spark.apache.org
Porting or explicitly linking project style in Apache Spark based on https://github.com/databricks/scala-style-guide
Hi all, I usually follow https://github.com/databricks/scala-style-guide for Apache Spark's style, which is usually generally the same with the Spark's code base in practice. Thing is, we don't explicitly mention this within Apache Spark as far as I can tell. Can we explicitly mention this or port this style guide? It doesn't necessarily mean hard requirements for PRs or code changes but we could at least encourage people to read it.
