Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-25 Thread Xiao Li
you make anther PR against branch-2.4 so we > can > > > >> > > > include the ORC fix in 2.4.1? > > > >> > > > > > > >> > > > Thanks. > > > >> > > > > > > >> > > > Sincerely, > &

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-25 Thread Reynold Xin
8, how >>>>>>>> about we >>>>>>>> give it couple days, and have another vote on March 25, Monday? In this >>>>>>>> case, I will cut another rc9 in the Monday morning. >>>>>>>> >>>>>>>

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-25 Thread DB Tsai
; > Sincerely, > > >> > > > > > >> > > > DB Tsai > > >> > > > -- > > >> > > > Web: https://www.dbtsai.com > > >> > > > PGP Key

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-25 Thread Sean Owen
gt; > >> > > > DB Tsai > >> > > > -- > >> > > > Web: https://www.dbtsai.com > >> > > > PGP Key ID: 42E5B25A8F7A82C1 > >> > > > >

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-25 Thread Sean Owen
This last test failed again, but, I claim we've actually seen it pass: https://github.com/apache/spark/pull/24126#issuecomment-476410462 Would anybody else endorse merging it into 2.4 to proceed? I'll kick of one more test for good measure. On Mon, Mar 25, 2019 at 4:33 PM Sean Owen wrote: > >

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-25 Thread Sean Owen
> >> > > > Web: https://www.dbtsai.com > >> > > > PGP Key ID: 42E5B25A8F7A82C1 > >> > > > > >> > > > On Wed, Mar 20, 2019 at 9:11 PM Felix Cheung > >> > > > wrote: > >

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-25 Thread DB Tsai
ww.dbtsai.com >> > > > PGP Key ID: 42E5B25A8F7A82C1 >> > > > >> > > > On Wed, Mar 20, 2019 at 9:11 PM Felix Cheung >> > > > wrote: >> > > > > >> > > > > Reposting for shane here >> > > >

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-24 Thread Sean Owen
gt; > > > > > > > > [SPARK-27178] > > > > > > https://github.com/apache/spark/commit/342e91fdfa4e6ce5cc3a0da085d1fe723184021b > > > > > > > > > > Is problematic too and it’s not in the rc8 cut > > > > >

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-24 Thread DB Tsai
cc3a0da085d1fe723184021b > > > > > > > > Is problematic too and it’s not in the rc8 cut > > > > > > > > https://github.com/apache/spark/commits/branch-2.4 > > > > > > > > (Personally I don’t want to delay 2.4.1 either..) > &

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-23 Thread Sean Owen
7178] > > > https://github.com/apache/spark/commit/342e91fdfa4e6ce5cc3a0da085d1fe723184021b > > > > > > Is problematic too and it’s not in the rc8 cut > > > > > > https://github.com/apache/spark/commits/branch-2.4 > > > > > > (Personally I don’t want t

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-23 Thread DB Tsai
che/spark/commit/342e91fdfa4e6ce5cc3a0da085d1fe723184021b > > > > Is problematic too and it’s not in the rc8 cut > > > > https://github.com/apache/spark/commits/branch-2.4 > > > > (Personally I don’t want to delay 2.4.1 either..) > > > > ________

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-22 Thread DB Tsai
don’t want to delay 2.4.1 either..) > > > From: Sean Owen > Sent: Wednesday, March 20, 2019 11:18 AM > To: DB Tsai > Cc: dev > Subject: Re: [VOTE] Release Apache Spark 2.4.1 (RC8) > > +1 for this RC. The tag is correct, licenses and sigs check out, tests > of

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-20 Thread Felix Cheung
..) From: Sean Owen Sent: Wednesday, March 20, 2019 11:18 AM To: DB Tsai Cc: dev Subject: Re: [VOTE] Release Apache Spark 2.4.1 (RC8) +1 for this RC. The tag is correct, licenses and sigs check out, tests of the source with most profiles enabled works for me. On Tue, Mar 19, 2019 at 5:28 PM DB

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-20 Thread Sean Owen
+1 for this RC. The tag is correct, licenses and sigs check out, tests of the source with most profiles enabled works for me. On Tue, Mar 19, 2019 at 5:28 PM DB Tsai wrote: > > Please vote on releasing the following candidate as Apache Spark version > 2.4.1. > > The vote is open until March 23

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-20 Thread DB Tsai
Unfortunately, for this 2.4.1 RC cuts, we ran into couple critical bug fixes unexpectedly just right after each RC was cut, and some of the bugs were even found after the RC cut which is hard to know there is still a blocker beforehand. How about we start to test out the RC8 now given the

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-20 Thread Imran Rashid
Even if only PMC are able to veto a release, I believe all community members are encouraged to vote, even a -1, to express their opinions, right? I am -0.5 on the release because of SPARK-27112. It is not a regression, so in that sense I don't think it must hold the release. But it is fixing a

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-20 Thread dhruve ashar
I agree with Imran on this. Since we are already on rc8, we don't want to indefinitely hold the release for one more fix, but it this one is a severe deadlock. Note to myself and other community members: May be we can be more proactive in checking and reporting inprogress PR reviews/JIRAs for any

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-20 Thread Sean Owen
Is it a regression from 2.4.0? that's not the only criteria but part of it. The version link is https://issues.apache.org/jira/projects/SPARK/versions/12344117 On Wed, Mar 20, 2019 at 10:15 AM dhruve ashar wrote: > A deadlock bug was recently fixed and backported to 2.4, but the rc was > cut

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-20 Thread dhruve ashar
A deadlock bug was recently fixed and backported to 2.4, but the rc was cut before that. I think we should include a critical bug like that in the current rc. issue: https://issues.apache.org/jira/browse/SPARK-27112 commit:

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-20 Thread Stavros Kontopoulos
+1 (non-binding) On Wed, Mar 20, 2019 at 8:33 AM Sean Owen wrote: > (Only the PMC can veto a release) > That doesn't look like a regression. I get that it's important, but I > don't see that it should block this release. > > On Tue, Mar 19, 2019 at 11:00 PM Darcy Shen > wrote: > > > > -1 > >

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-20 Thread Sean Owen
(Only the PMC can veto a release) That doesn't look like a regression. I get that it's important, but I don't see that it should block this release. On Tue, Mar 19, 2019 at 11:00 PM Darcy Shen wrote: > > -1 > > please backpoart SPARK-27160, a correctness issue about ORC native reader. > > see

Re: [VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-19 Thread Darcy Shen
-1 please backpoart SPARK-27160, a correctness issue about ORC native reader. see https://github.com/apache/spark/pull/24092 On Wed, 20 Mar 2019 06:21:29 +0800 DB Tsai wrote Please vote on releasing the following candidate as Apache Spark version 2.4.1. The vote is

[VOTE] Release Apache Spark 2.4.1 (RC8)

2019-03-19 Thread DB Tsai
Please vote on releasing the following candidate as Apache Spark version 2.4.1. The vote is open until March 23 PST and passes if a majority +1 PMC votes are cast, with a minimum of 3 +1 votes. [ ] +1 Release this package as Apache Spark 2.4.1 [ ] -1 Do not release this package because ... To