Re: ViewUtils and UtilityFactory (was Extracting taglibs)

2004-12-23 Thread Dakota Jack
What does Commons FileUpload being Filter-ized mean? Jack On Thu, 23 Dec 2004 08:37:24 -0800, Craig McClanahan [EMAIL PROTECTED] wrote: On Wed, 22 Dec 2004 23:40:33 -0800, Don Brown [EMAIL PROTECTED] wrote: The problem with putting code like that into a command, is what if someone wants

Re: ViewUtils and UtilityFactory (was Extracting taglibs)

2004-12-23 Thread Craig McClanahan
On Thu, 23 Dec 2004 10:54:31 -0800, Dakota Jack [EMAIL PROTECTED] wrote: What does Commons FileUpload being Filter-ized mean? Martin has talked (on the Commons dev list) about his plans to upgrade Commons FileUpload to use a Servlet Filter, and the request wrapper features of Servlet 2.3, in the

Re: Extracting taglibs

2004-12-22 Thread Joe Germuska
At 10:24 PM -0800 12/21/04, Don Brown wrote: FWIW, so far, I extracted tiles and taglib into their own projects, and got both core and taglib compiling (haven't tried tiles yet). It took the steps I described earlier as well as moving some methods from TagUtils back into ResponseUtils. Of

Re: Extracting taglibs

2004-12-22 Thread Vic
Joe Germuska wrote: I do think that Struts shouldn't depend on subprojects. -1. core should not depdend on any subprojects I think. Not today, 1st day or repackaging but eventualy. I also think subprojects should be set up to depend on a struts.jar ... and not the code. -- RiA-SoA w/JDNC

Re: Extracting taglibs

2004-12-22 Thread Joe Germuska
At 6:09 AM -0600 12/22/04, Vic wrote: Joe Germuska wrote: I do think that Struts shouldn't depend on subprojects. -1. core should not depdend on any subprojects I think. Not today, 1st day or repackaging but eventualy. I also think subprojects should be set up to depend on a struts.jar ... and

Re: Extracting taglibs

2004-12-22 Thread David Graham
--- Don Brown [EMAIL PROTECTED] wrote: FWIW, so far, I extracted tiles and taglib into their own projects, and got both core and taglib compiling (haven't tried tiles yet). It took the steps I described earlier as well as moving some methods from TagUtils back into ResponseUtils. Of

Re: Extracting taglibs

2004-12-22 Thread Don Brown
:) Actually, in the extraction I performed so far, I did just that and moved TilesPreProcessor into the o.a.s.tiles.commands package. There was one other class, o.a.s.actions.RedeployableActionServlet that I moved into o.a.s.tiles since it was full of references to TilesRequestProcessor.

Re: Extracting taglibs

2004-12-22 Thread Martin Cooper
On Tue, 21 Dec 2004 21:06:19 -0800, Craig McClanahan [EMAIL PROTECTED] wrote: On Tue, 21 Dec 2004 20:45:03 -0800, Don Brown [EMAIL PROTECTED] wrote: I agree as well. This lets us follow a consistent approach to subprojects, where they may (and probably should) link to Struts core, but

Re: Extracting taglibs

2004-12-22 Thread Nathan Bubna
PROTECTED] Sent: Tuesday, December 21, 2004 7:51 PM To: Struts Developers List Subject: Extracting taglibs My basic assumption in approaching taglibs extraction into its own subproject is it can reference Struts classes, but Struts classes shouldn't reference it. If that is correct, here

Re: ViewUtils and UtilityFactory (was Extracting taglibs)

2004-12-22 Thread Don Brown
coming soon? Is that an offer? :) I like the API bean aka ViewContext aka ConfigHelper and agree it is a better solution. Reading over the API bean thread, Ted has convinced me this bean would actually be created for each request probably somewhere early in the chain. While it could be

Re: ViewUtils and UtilityFactory (was Extracting taglibs)

2004-12-22 Thread Niall Pemberton
. Niall - Original Message - From: Don Brown [EMAIL PROTECTED] To: Joe Germuska [EMAIL PROTECTED] Cc: Struts Developers List dev@struts.apache.org Sent: Wednesday, December 22, 2004 9:17 PM Subject: Re: ViewUtils and UtilityFactory (was Extracting taglibs) coming soon

Re: ViewUtils and UtilityFactory (was Extracting taglibs)

2004-12-22 Thread Don Brown
and UtilityFactory (was Extracting taglibs) coming soon? Is that an offer? :) I like the API bean aka ViewContext aka ConfigHelper and agree it is a better solution. Reading over the API bean thread, Ted has convinced me this bean would actually be created for each request probably somewhere

Extracting taglibs

2004-12-21 Thread Don Brown
My basic assumption in approaching taglibs extraction into its own subproject is it can reference Struts classes, but Struts classes shouldn't reference it. If that is correct, here are the changes I see happening to extract taglibs: 1. Move o.a.s.taglib out into its own subproject src tree 2.

RE: Extracting taglibs

2004-12-21 Thread Deadman, Hal
PROTECTED] Sent: Tuesday, December 21, 2004 7:51 PM To: Struts Developers List Subject: Extracting taglibs My basic assumption in approaching taglibs extraction into its own subproject is it can reference Struts classes, but Struts classes shouldn't reference it. If that is correct, here

Re: Extracting taglibs

2004-12-21 Thread Eddie Bush
, December 21, 2004 7:51 PM To: Struts Developers List Subject: Extracting taglibs My basic assumption in approaching taglibs extraction into its own subproject is it can reference Struts classes, but Struts classes shouldn't reference it. If that is correct, here are the changes I see

Re: Extracting taglibs

2004-12-21 Thread Don Brown
Developers List Subject: Extracting taglibs My basic assumption in approaching taglibs extraction into its own subproject is it can reference Struts classes, but Struts classes shouldn't reference it. If that is correct, here are the changes I see happening to extract taglibs: 1. Move o.a.s.taglib out

Re: Extracting taglibs

2004-12-21 Thread Craig McClanahan
? -Original Message- From: Don Brown [mailto:[EMAIL PROTECTED] Sent: Tuesday, December 21, 2004 7:51 PM To: Struts Developers List Subject: Extracting taglibs My basic assumption in approaching taglibs extraction into its own subproject is it can reference Struts classes, but Struts

Re: Extracting taglibs

2004-12-21 Thread Martin Cooper
To: Struts Developers List Subject: Extracting taglibs My basic assumption in approaching taglibs extraction into its own subproject is it can reference Struts classes, but Struts classes shouldn't reference it. If that is correct, here are the changes I see happening to extract taglibs

Re: Extracting taglibs

2004-12-21 Thread Don Brown
To: Struts Developers List Subject: Extracting taglibs My basic assumption in approaching taglibs extraction into its own subproject is it can reference Struts classes, but Struts classes shouldn't reference it. If that is correct, here are the changes I see happening to extract taglibs: 1. Move

Re: Extracting taglibs

2004-12-21 Thread Craig McClanahan
On Tue, 21 Dec 2004 20:45:03 -0800, Don Brown [EMAIL PROTECTED] wrote: I agree as well. This lets us follow a consistent approach to subprojects, where they may (and probably should) link to Struts core, but Struts core should not depend on them. I hope this can actually be accomplished ...

Re: Extracting taglibs

2004-12-21 Thread Dakota Jack
This would be Tony the Tiger GRRREeattt! Jack On Tue, 21 Dec 2004 21:06:19 -0800, Craig McClanahan [EMAIL PROTECTED] wrote: On Tue, 21 Dec 2004 20:45:03 -0800, Don Brown [EMAIL PROTECTED] wrote: I agree as well. This lets us follow a consistent approach to subprojects, where

Re: Extracting taglibs

2004-12-21 Thread Don Brown
FWIW, so far, I extracted tiles and taglib into their own projects, and got both core and taglib compiling (haven't tried tiles yet). It took the steps I described earlier as well as moving some methods from TagUtils back into ResponseUtils. Of course, if ResponseUtils has been dreprecated