[GitHub] thrift issue #1527: Merge pull request #1 from apache/master

2018-03-30 Thread lovepoem
Github user lovepoem commented on the issue: https://github.com/apache/thrift/pull/1527 No file changed ---

[GitHub] thrift pull request #1527: Merge pull request #1 from apache/master

2018-03-30 Thread zengqinglong
GitHub user zengqinglong opened a pull request: https://github.com/apache/thrift/pull/1527 Merge pull request #1 from apache/master update 2018/3/31 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zengqinglong/thrift master

[GitHub] thrift issue #1526: Merge pull request #1 from apache/master

2018-03-30 Thread allengeorge
Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1526 Did you mean to make this PR? If so, why? ---

[GitHub] thrift pull request #1526: Merge pull request #1 from apache/master

2018-03-30 Thread zengqinglong
Github user zengqinglong closed the pull request at: https://github.com/apache/thrift/pull/1526 ---

[GitHub] thrift issue #1526: Merge pull request #1 from apache/master

2018-03-30 Thread zengqinglong
Github user zengqinglong commented on the issue: https://github.com/apache/thrift/pull/1526 2018/3/31 ---

[GitHub] thrift issue #1526: Merge pull request #1 from apache/master

2018-03-30 Thread zengqinglong
Github user zengqinglong commented on the issue: https://github.com/apache/thrift/pull/1526 2018/3/31 ---

[GitHub] thrift pull request #1526: Merge pull request #1 from apache/master

2018-03-30 Thread zengqinglong
GitHub user zengqinglong opened a pull request: https://github.com/apache/thrift/pull/1526 Merge pull request #1 from apache/master update 2018/3/31 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zengqinglong/thrift master

[GitHub] thrift pull request #1525: Merge pull request #1 from apache/master

2018-03-30 Thread zengqinglong
Github user zengqinglong closed the pull request at: https://github.com/apache/thrift/pull/1525 ---

[GitHub] thrift issue #1525: Merge pull request #1 from apache/master

2018-03-30 Thread zengqinglong
Github user zengqinglong commented on the issue: https://github.com/apache/thrift/pull/1525 2018/3/31 ---

[GitHub] thrift pull request #1525: Merge pull request #1 from apache/master

2018-03-30 Thread zengqinglong
GitHub user zengqinglong opened a pull request: https://github.com/apache/thrift/pull/1525 Merge pull request #1 from apache/master update 2018/3/28 You can merge this pull request into a Git repository by running: $ git pull https://github.com/zengqinglong/thrift master

[jira] [Commented] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")?

2018-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420863#comment-16420863 ] ASF GitHub Bot commented on THRIFT-4535: GitHub user cwe1ss opened a pull request:

[GitHub] thrift pull request #1524: THRIFT-4535: XML docs; code cleanup (tabs->spaces...

2018-03-30 Thread cwe1ss
GitHub user cwe1ss opened a pull request: https://github.com/apache/thrift/pull/1524 THRIFT-4535: XML docs; code cleanup (tabs->spaces; String->string) As discussed in [THRIFT-4535](https://issues.apache.org/jira/browse/THRIFT-4535) we'd like to go back to just one .NET library

[jira] [Commented] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")?

2018-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420779#comment-16420779 ] James E. King, III commented on THRIFT-4535: These all sound good to me. > Current state and

[jira] [Commented] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")?

2018-03-30 Thread Christian Weiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420621#comment-16420621 ] Christian Weiss commented on THRIFT-4535: - Thanks again for the quick response! I've had a

[jira] [Commented] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")?

2018-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420612#comment-16420612 ] James E. King, III commented on THRIFT-4535: I would agree that netcore came into play

[jira] [Commented] (THRIFT-3773) Swift Library

2018-03-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420599#comment-16420599 ] ASF GitHub Bot commented on THRIFT-3773: Github user yurikoles commented on the issue:

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2018-03-30 Thread yurikoles
Github user yurikoles commented on the issue: https://github.com/apache/thrift/pull/1084 Hi @apocolipse, Please consider taking into account usage of reserved keywords in *.thrift files. For example back end developers may use field with name `description` in their structures.

[jira] [Comment Edited] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")?

2018-03-30 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420573#comment-16420573 ] Jens Geyer edited comment on THRIFT-4535 at 3/30/18 2:50 PM: - {code} Folks

[jira] [Comment Edited] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")?

2018-03-30 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420573#comment-16420573 ] Jens Geyer edited comment on THRIFT-4535 at 3/30/18 2:49 PM: - {code} Folks

[jira] [Commented] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")?

2018-03-30 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420573#comment-16420573 ] Jens Geyer commented on THRIFT-4535: {code} Folks stuck needing to support older frameworks like .NET

[jira] [Commented] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")?

2018-03-30 Thread Christian Weiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420469#comment-16420469 ] Christian Weiss commented on THRIFT-4535: - Edit:  {quote}I don't know your user base but

[jira] [Commented] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")?

2018-03-30 Thread Christian Weiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420458#comment-16420458 ] Christian Weiss commented on THRIFT-4535: - {quote}As long as we can have a single set of project

[jira] [Commented] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")?

2018-03-30 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420427#comment-16420427 ] James E. King, III commented on THRIFT-4535: Folks stuck needing to support older frameworks

[GitHub] thrift issue #1523: Fix condition where TSimpleServer could exit AcceptLoop(...

2018-03-30 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1523 Thanks for checking, we need to stabilize these CI builds so less effort is spent figuring out if a change is at least somewhat ok. ---

[jira] [Comment Edited] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")?

2018-03-30 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420417#comment-16420417 ] Jens Geyer edited comment on THRIFT-4535 at 3/30/18 11:44 AM: -- {quote} We

[jira] [Comment Edited] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")?

2018-03-30 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420417#comment-16420417 ] Jens Geyer edited comment on THRIFT-4535 at 3/30/18 11:44 AM: -- {quote} We

[jira] [Commented] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")?

2018-03-30 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420417#comment-16420417 ] Jens Geyer commented on THRIFT-4535: {quote} We should identify what, if anything, is in the csharp

[jira] [Commented] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")?

2018-03-30 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420415#comment-16420415 ] Jens Geyer commented on THRIFT-4535: {quote} This sounds like a good plan! What is your policy on

[jira] [Resolved] (THRIFT-4537) TSimpleServer can exit Accept loop with lock still acquired

2018-03-30 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun resolved THRIFT-4537. - Resolution: Fixed Fix Version/s: 0.12.0 > TSimpleServer can exit Accept loop with lock

[GitHub] thrift issue #1523: Fix condition where TSimpleServer could exit AcceptLoop(...

2018-03-30 Thread dcelasun
Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1523 Travis failures are unrelated flaky tests (my own Travis build is fine). ---

[GitHub] thrift pull request #1523: Fix condition where TSimpleServer could exit Acce...

2018-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1523 ---

[jira] [Commented] (THRIFT-4535) Current state and future of .NET libraries ("csharp" and "netcore")?

2018-03-30 Thread Christian Weiss (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420278#comment-16420278 ] Christian Weiss commented on THRIFT-4535: - Thank you for your quick responses! {quote}Why don't