Re: Broken build

2019-06-22 Thread Enrico Olivelli
Il sab 22 giu 2019, 01:05 Brian Nixon ha scritto: > Finally got around to looking at this issue. > > https://github.com/apache/zookeeper/pull/996 may suffice to address the > breaking test. > Awesome I left just a comment, then I will be happy to commit Enrico > > On Wed, Jan 30, 2019 at

Re: Broken build

2019-06-21 Thread Brian Nixon
Finally got around to looking at this issue. https://github.com/apache/zookeeper/pull/996 may suffice to address the breaking test. On Wed, Jan 30, 2019 at 2:39 PM Brian Nixon wrote: > ZOOKEEPER-3240 is my patch - I'll see if I can figure out what the problem > is. > > > On Wed, Jan 30, 2019

Re: Broken build

2019-01-30 Thread Brian Nixon
ZOOKEEPER-3240 is my patch - I'll see if I can figure out what the problem is. On Wed, Jan 30, 2019 at 7:54 AM Andor Molnar wrote: > This doesn't look good yet. > Let's give it some time (til tomorrow) to recover. > > Andor > > > > On Wed, Jan 30, 2019 at 12:08 PM Andor Molnar wrote: > > >

Re: Broken build

2019-01-30 Thread Andor Molnar
This doesn't look good yet. Let's give it some time (til tomorrow) to recover. Andor On Wed, Jan 30, 2019 at 12:08 PM Andor Molnar wrote: > Done. I reverted the patch on 3.5 and master branches. > Hopefully builds will soon become green again. > > Andor > > > > On Wed, Jan 30, 2019 at 11:45

Re: Broken build

2019-01-30 Thread Andor Molnar
Done. I reverted the patch on 3.5 and master branches. Hopefully builds will soon become green again. Andor On Wed, Jan 30, 2019 at 11:45 AM Andor Molnar wrote: > 2 tests are failing constantly: > > > org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss > >

Re: Broken build

2019-01-30 Thread Andor Molnar
2 tests are failing constantly: org.apache.zookeeper.server.quorum.QuorumPeerMainTest.testFailedTxnAsPartOfQuorumLoss org.apache.zookeeper.server.quorum.ReconfigFailureCasesTest.testLeaderTimesoutOnNewQuorum I reverted "ZOOKEEPER-3240: Close socket on Learner shutdown to avoid dangling socket"

Re: Broken build

2019-01-30 Thread Enrico Olivelli
Do you have failing tests or code does not compile at all? (I don't have my laptop at the moment) Enrico Il giorno mer 30 gen 2019, 11:31 Andor Molnar ha scritto: > Hi team, > > Looks like one of these changes have broken the build: > > >1. ZOOKEEPER-3250

Broken build

2019-01-30 Thread Andor Molnar
Hi team, Looks like one of these changes have broken the build: 1. ZOOKEEPER-3250 : typo in doc - zookeeperInternals (detail )