Re: fedora-review workarounds for dnf5

2023-07-26 Thread Sandro
On 26-07-2023 17:36, Jakub Kadlcik wrote: Hello Sandro, I noticed that in f39 builds in Copr the directory containing the results is now named after the package. Comparing that to the "traditional" fedora-review directory in f38 builds, I miss the `licensecheck.txt` file. It suddenly started

Re: fedora-review workarounds for dnf5

2023-07-26 Thread Michel Alexandre Salim
On Wed, Jul 26, 2023 at 05:36:04PM +0200, Jakub Kadlcik wrote: > Hello Sandro, > > > I noticed that in f39 builds in Copr the directory containing the > > results is now named after the package. Comparing that to the > > "traditional" fedora-review directory in f38 builds, I miss the > >

Re: fedora-review workarounds for dnf5

2023-07-26 Thread Michel Alexandre Salim
On Mon, Jul 24, 2023 at 09:47:32PM -0500, Michel Alexandre Salim wrote: > Hi all, > > On Mon, Jul 17, 2023 at 10:54:43AM -0600, Jerry James wrote: > > Like many of you, I have been quite inconvenienced because of > > dnf5-related breakage of fedora-review. I've been monkeying with it > > today

Re: fedora-review workarounds for dnf5

2023-07-26 Thread Jakub Kadlcik
Hello Sandro, > I noticed that in f39 builds in Copr the directory containing the > results is now named after the package. Comparing that to the > "traditional" fedora-review directory in f38 builds, I miss the > `licensecheck.txt` file. It suddenly started happening and I don't know what is to

Re: fedora-review workarounds for dnf5

2023-07-25 Thread Sandro
On 25-07-2023 04:47, Michel Alexandre Salim wrote: Once this lands in F38, Fedora Review Service should be fixed, unless I'm missing something. First of all, thanks for bringing fedora-review back. I rely on it quite a bit reviewing my own packages as well as for official reviews. I noticed

Re: fedora-review workarounds for dnf5

2023-07-25 Thread Jakub Kadlcik
Thank you very much Michel for going through the release. It couldn't be easy. There is a reported bug in Bodhi, so it will need some minor fixups but we are close. Really looking forward to it. Jakub On Tue, Jul 25, 2023 at 4:48 AM Michel Alexandre Salim wrote: > > Hi all, > > On Mon, Jul 17,

Re: fedora-review workarounds for dnf5

2023-07-24 Thread Michel Alexandre Salim
Hi all, On Mon, Jul 17, 2023 at 10:54:43AM -0600, Jerry James wrote: > Like many of you, I have been quite inconvenienced because of > dnf5-related breakage of fedora-review. I've been monkeying with it > today and finally got a successful run of fedora-review after making > the following

Re: fedora-review workarounds for dnf5

2023-07-19 Thread Paul Howarth
On Tue, 18 Jul 2023 15:27:01 +0200 Fabio Valentini wrote: > On Tue, Jul 18, 2023, 15:22 Maxwell G wrote: > > > On Tue Jul 18, 2023 at 12:38 +0200, Jakub Kadlcik wrote: > > > Hello Jerry, > > > I proposed a workaround a few days ago > > > https://pagure.io/FedoraReview/pull-request/485 > > >

Re: fedora-review workarounds for dnf5

2023-07-19 Thread Pavel Raiskup
On pondělí 17. července 2023 20:39:11 CEST Jerry James wrote: > On Mon, Jul 17, 2023 at 10:54 AM Jerry James wrote: > > Like many of you, I have been quite inconvenienced because of > > dnf5-related breakage of fedora-review. I've been monkeying with it > > today and finally got a successful run

Re: fedora-review workarounds for dnf5

2023-07-18 Thread Jerry James
On Tue, Jul 18, 2023 at 7:28 AM Fabio Valentini wrote: > On Tue, Jul 18, 2023, 15:22 Maxwell G wrote: >> --requires --resolve resolves the entire dependency tree of a package. >> --requires just prints the direct dependencies that are specified in the >> RPM metadata. >> I don't know what this

Re: fedora-review workarounds for dnf5

2023-07-18 Thread Maxwell G
On Tue Jul 18, 2023 at 15:27 +0200, Fabio Valentini wrote: > On Tue, Jul 18, 2023, 15:22 Maxwell G wrote: > > > On Tue Jul 18, 2023 at 12:38 +0200, Jakub Kadlcik wrote: > > > Hello Jerry, > > > I proposed a workaround a few days ago > > > https://pagure.io/FedoraReview/pull-request/485 > > > > >

Re: fedora-review workarounds for dnf5

2023-07-18 Thread Fabio Valentini
On Tue, Jul 18, 2023, 15:22 Maxwell G wrote: > On Tue Jul 18, 2023 at 12:38 +0200, Jakub Kadlcik wrote: > > Hello Jerry, > > I proposed a workaround a few days ago > > https://pagure.io/FedoraReview/pull-request/485 > > > > but your patch looks like a proper fix. I'll try it and merge to the > >

Re: fedora-review workarounds for dnf5

2023-07-18 Thread Maxwell G
On Tue Jul 18, 2023 at 12:38 +0200, Jakub Kadlcik wrote: > Hello Jerry, > I proposed a workaround a few days ago > https://pagure.io/FedoraReview/pull-request/485 > > but your patch looks like a proper fix. I'll try it and merge to the > fedora-review codebase. > > Does anybody know what was the

Re: fedora-review workarounds for dnf5

2023-07-18 Thread Jakub Kadlcik
Hello Jerry, I proposed a workaround a few days ago https://pagure.io/FedoraReview/pull-request/485 but your patch looks like a proper fix. I'll try it and merge to the fedora-review codebase. Does anybody know what was the purpose of --resolve and if it will be no problem when we remove it?

Re: fedora-review workarounds for dnf5

2023-07-17 Thread Sandro
On 17-07-2023 20:39, Jerry James wrote: On Mon, Jul 17, 2023 at 10:54 AM Jerry James wrote: Like many of you, I have been quite inconvenienced because of dnf5-related breakage of fedora-review. I've been monkeying with it today and finally got a successful run of fedora-review after making

Re: fedora-review workarounds for dnf5

2023-07-17 Thread Jerry James
On Mon, Jul 17, 2023 at 10:54 AM Jerry James wrote: > Like many of you, I have been quite inconvenienced because of > dnf5-related breakage of fedora-review. I've been monkeying with it > today and finally got a successful run of fedora-review after making > the following changes [*]. > > 1.

fedora-review workarounds for dnf5

2023-07-17 Thread Jerry James
Like many of you, I have been quite inconvenienced because of dnf5-related breakage of fedora-review. I've been monkeying with it today and finally got a successful run of fedora-review after making the following changes [*]. 1. Edit /etc/mock/templates/fedora-rawhide.tpl. Change: