Re: Backporting ticket 25548 into 1.9.x

Agreed the reasoning is sound. This is a major bug as far as I'm concerned and I'd like to see it backported. Thanks for bringing it up. Marc On 6 Dec 2015 1:05 p.m., "Shai Berger" wrote: > On Sunday 06 December 2015 14:52:08 Aymeric Augustin wrote: > > > On 6 déc. 2015, at

Re: Proposal to merge django-csp into contrib

Yeah this makes a lot more sense in SecurityMiddleware On Sunday, 6 December 2015 10:01:54 UTC, Florian Apolloner wrote: > > > > On Sunday, December 6, 2015 at 10:13:46 AM UTC+1, Aymeric Augustin wrote: >> >> I understand that the “just merge django-csp” approach minimizes effort. >> However the

Re: Backporting ticket 25548 into 1.9.x

On Sunday 06 December 2015 14:52:08 Aymeric Augustin wrote: > > On 6 déc. 2015, at 10:49, James Bennett wrote: > > > > Thoughts? > > I don’t think anyone ever prevented a core dev who wanted to backport a > commit from doing so — unless it carried a risk of backwards >

Re: Backporting ticket 25548 into 1.9.x

> On 6 déc. 2015, at 10:49, James Bennett wrote: > > Thoughts? I don’t think anyone ever prevented a core dev who wanted to backport a commit from doing so — unless it carried a risk of backwards incompatibility, which doesn’t appear to be the case here. -- Aymeric.

Re: Proposal to merge django-csp into contrib

On Sunday, December 6, 2015 at 10:13:46 AM UTC+1, Aymeric Augustin wrote: > > I understand that the “just merge django-csp” approach minimizes effort. > However the result doesn’t feel well integrated with Django. I left a few > comments that all boil down to “this isn’t how we would have done

Backporting ticket 25548 into 1.9.x

About two months ago, ticket #25548[1] was opened, pointing out that on an invalid form submission, FormView was calling form validation methods twice (what was actually happening was that the original form instance was discarded, a new one constructed with the same data, and the first access to

Re: Proposal to merge django-csp into contrib

Hello Thomas, > On 5 déc. 2015, at 23:23, Thomas Grainger wrote: > > I think merging django-csp into contrib would be a good fix for > https://code.djangoproject.com/ticket/15727 > I took a look at the pull request. I