Re: [PATCH] dt-bindings: display: msm: sm8650-mdss: Add missing explicit "additionalProperties"

2024-02-02 Thread Dmitry Baryshkov
On Fri, 2 Feb 2024 at 23:23, Rob Herring wrote: > > In order to check schemas for missing additionalProperties or > unevaluatedProperties, cases allowing extra properties must be explicit. > > Signed-off-by: Rob Herring Reviewed-by: Dmitry Baryshkov Rob, if you need it for some rework, please

Re: [PATCH 3/3] drm/amdgpu: wire up the can_remove() callback

2024-02-02 Thread Greg Kroah-Hartman
On Fri, Feb 02, 2024 at 05:25:56PM -0500, Hamza Mahfooz wrote: > Removing an amdgpu device that still has user space references allocated > to it causes undefined behaviour. So, implement amdgpu_pci_can_remove() > and disallow devices that still have files allocated to them from being > unbound. >

Re: [PATCH 3/3] drm/amdgpu: wire up the can_remove() callback

2024-02-02 Thread Greg Kroah-Hartman
On Fri, Feb 02, 2024 at 05:25:56PM -0500, Hamza Mahfooz wrote: > Removing an amdgpu device that still has user space references allocated > to it causes undefined behaviour. Then fix that please. There should not be anything special about your hardware that all of the tens of thousands of other

Re: [PATCH 2/3] PCI: introduce can_remove()

2024-02-02 Thread Greg Kroah-Hartman
On Fri, Feb 02, 2024 at 05:25:55PM -0500, Hamza Mahfooz wrote: > Wire up the can_remove() callback, such that pci drivers can implement > their own version of it. > > Cc: sta...@vger.kernel.org > Signed-off-by: Hamza Mahfooz > --- Again, sorry, nope, not allowed.

Re: [PATCH 1/3] driver core: bus: introduce can_remove()

2024-02-02 Thread Greg Kroah-Hartman
On Fri, Feb 02, 2024 at 05:25:54PM -0500, Hamza Mahfooz wrote: > Currently, drivers have no mechanism to block requests to unbind > devices. And that is by design. > However, this can cause resource leaks and leave the device in > an inconsistent state, such that rebinding the device may cause a

Re: [PATCH 3/3] drm/amdgpu: wire up the can_remove() callback

2024-02-02 Thread Bjorn Helgaas
[+cc Bartosz] On Fri, Feb 02, 2024 at 05:25:56PM -0500, Hamza Mahfooz wrote: > Removing an amdgpu device that still has user space references allocated > to it causes undefined behaviour. So, implement amdgpu_pci_can_remove() > and disallow devices that still have files allocated to them from

[PATCH 3/3] drm/amdgpu: wire up the can_remove() callback

2024-02-02 Thread Hamza Mahfooz
Removing an amdgpu device that still has user space references allocated to it causes undefined behaviour. So, implement amdgpu_pci_can_remove() and disallow devices that still have files allocated to them from being unbound. Cc: sta...@vger.kernel.org Signed-off-by: Hamza Mahfooz ---

[PATCH 2/3] PCI: introduce can_remove()

2024-02-02 Thread Hamza Mahfooz
Wire up the can_remove() callback, such that pci drivers can implement their own version of it. Cc: sta...@vger.kernel.org Signed-off-by: Hamza Mahfooz --- drivers/pci/pci-driver.c | 12 include/linux/pci.h | 5 + 2 files changed, 17 insertions(+) diff --git

[PATCH 1/3] driver core: bus: introduce can_remove()

2024-02-02 Thread Hamza Mahfooz
Currently, drivers have no mechanism to block requests to unbind devices. However, this can cause resource leaks and leave the device in an inconsistent state, such that rebinding the device may cause a hang or otherwise prevent the device from being rebound. So, introduce the can_remove()

[PATCH] dt-bindings: display: msm: sm8650-mdss: Add missing explicit "additionalProperties"

2024-02-02 Thread Rob Herring
In order to check schemas for missing additionalProperties or unevaluatedProperties, cases allowing extra properties must be explicit. Signed-off-by: Rob Herring --- .../devicetree/bindings/display/msm/qcom,sm8650-mdss.yaml | 4 1 file changed, 4 insertions(+) diff --git

[PATCH] drm/dp: Don't attempt AUX transfers when eDP panels are not powered

2024-02-02 Thread Douglas Anderson
If an eDP panel is not powered on then any attempts to talk to it over the DP AUX channel will timeout. Unfortunately these attempts may be quite slow. Userspace can initiate these attempts either via a /dev/drm_dp_auxN device or via the created i2c device. Making the DP AUX drivers timeout

Re: [PATCH] drm/xe: circumvent bogus stringop-overflow warning

2024-02-02 Thread Lucas De Marchi
On Wed, Jan 03, 2024 at 12:48:02PM +0100, Arnd Bergmann wrote: From: Arnd Bergmann gcc-13 warns about an array overflow that it sees but that is prevented by the "asid % NUM_PF_QUEUE" calculation: drivers/gpu/drm/xe/xe_gt_pagefault.c: In function 'xe_guc_pagefault_handler':

Re: [PATCH] drm/sched: Re-queue run job worker when drm_sched_entity_pop_job() returns NULL

2024-02-02 Thread Rodrigo Vivi
On Tue, Jan 30, 2024 at 08:05:29AM +0100, Christian König wrote: > Am 30.01.24 um 04:04 schrieb Matthew Brost: > > Rather then loop over entities until one with a ready job is found, > > re-queue the run job worker when drm_sched_entity_pop_job() returns NULL. > > > > Fixes: 6dbd9004a55

[PATCH] drm/panel: visionox-r66451: Set prepare_prev_first flag

2024-02-02 Thread Jessica Zhang
The DSI host needs to be enabled for the panel to be initialized in prepare(). Ensure this happens by setting prepare_prev_first. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/panel/panel-visionox-r66451.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] dt-bindings: drm/bridge: ti-sn65dsi86: Fix bouncing @codeaurora address

2024-02-02 Thread Abhinav Kumar
On 2/2/2024 12:23 PM, Jeffrey Hugo wrote: The servers for the @codeaurora domain are long retired and any messages sent there bounce. Sandeep Panda's email address is no longer valid and should be repleaced. However Sandeep has left the company and has not been active sice, therefore it

Re: [PATCH] dt-bindings: visionox-rm69299: Update maintainers

2024-02-02 Thread Neil Armstrong
Hi, On Fri, 02 Feb 2024 10:03:11 -0800, Jessica Zhang wrote: > The current maintainer (Harigovindan P) is no longer reachable through > the listed email. Update maintainers list to be Abhinav and I. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)

Re: [PATCH] drm/panel: novatek-nt36523: Set prepare_prev_first

2024-02-02 Thread Neil Armstrong
Hi, On Thu, 01 Feb 2024 23:17:40 +0100, Konrad Dybcio wrote: > The .prepare callback contains the init sequence, so the DSI host *must* > be enabled at that point. Set the prepare_prev_first flag to ensure that. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git

Re: [PATCH v2] drm/panel: visionox-vtdr6130: Set prepare_prev_first flag

2024-02-02 Thread Neil Armstrong
Hi, On Thu, 01 Feb 2024 16:10:15 -0800, Jessica Zhang wrote: > The DSI host must be enabled for the panel to be initialized in > prepare(). Set the prepare_prev_first flag to guarantee this. > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1]

Re: [PATCH] dt-bindings: drm/bridge: ti-sn65dsi86: Fix bouncing @codeaurora address

2024-02-02 Thread neil . armstrong
On 02/02/2024 21:23, Jeffrey Hugo wrote: The servers for the @codeaurora domain are long retired and any messages sent there bounce. Sandeep Panda's email address is no longer valid and should be repleaced. However Sandeep has left the company and has not been active sice, therefore it looks

Re: [PATCH] dt-bindings: visionox-rm69299: Update maintainers

2024-02-02 Thread Neil Armstrong
description: | This binding is for display panels using a Visionox RM692999 panel. --- base-commit: 51b70ff55ed88edd19b080a524063446bcc34b62 change-id: 20240202-rm69299-maintainers-7e069f78334f Best regards, Reviewed-by: Neil Armstrong

Re: [PATCH v2] drm/panel: visionox-vtdr6130: Set prepare_prev_first flag

2024-02-02 Thread Neil Armstrong
On 02/02/2024 01:10, Jessica Zhang wrote: The DSI host must be enabled for the panel to be initialized in prepare(). Set the prepare_prev_first flag to guarantee this. Signed-off-by: Jessica Zhang --- To: Neil Armstrong To: Sam Ravnborg To: David Airlie To: Daniel Vetter To: Jessica Zhang

[syzbot] Monthly dri report (Feb 2024)

2024-02-02 Thread syzbot
Hello dri maintainers/developers, This is a 31-day syzbot report for the dri subsystem. All related reports/information can be found at: https://syzkaller.appspot.com/upstream/s/dri During the period, 1 new issues were detected and 0 were fixed. In total, 17 issues are still open and 31 have

Re: [git pull] drm fixes for 6.8-rc3

2024-02-02 Thread pr-tracker-bot
The pull request you sent on Sat, 3 Feb 2024 05:46:00 +1000: > git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2024-02-03 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/9c2f0338bbd132a4b12b988004d796798609d297 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH 1/2] drm/vkms: Create a type to check a function pointer validity

2024-02-02 Thread Arthur Grillo
On 01/02/24 14:31, Louis Chauvet wrote: > Add the pixel_read_t type to check function prototype in structures > and functions. > It avoids casting to (void *) and at the same occasion allows the > compiler to check the type properly. > > Signed-off-by: Louis Chauvet > --- >

Re: [PATCH] dt-bindings: drm/bridge: ti-sn65dsi86: Fix bouncing @codeaurora address

2024-02-02 Thread Doug Anderson
Hi, On Fri, Feb 2, 2024 at 12:25 PM Jeffrey Hugo wrote: > > The servers for the @codeaurora domain are long retired and any messages > sent there bounce. Sandeep Panda's email address is no longer valid and > should be repleaced. However Sandeep has left the company and has not > been active

[PATCH] dt-bindings: drm/bridge: ti-sn65dsi86: Fix bouncing @codeaurora address

2024-02-02 Thread Jeffrey Hugo
The servers for the @codeaurora domain are long retired and any messages sent there bounce. Sandeep Panda's email address is no longer valid and should be repleaced. However Sandeep has left the company and has not been active sice, therefore it looks like this binding is orphaned. Doug is

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-02 Thread Arthur Grillo
On 02/02/24 12:49, Pekka Paalanen wrote: > On Fri, 2 Feb 2024 13:13:22 +0100 > Miquel Raynal wrote: > >> Hello Maxime, >> >> + Arthur >> >> mrip...@kernel.org wrote on Fri, 2 Feb 2024 10:53:37 +0100: >> >>> Hi Miquel, >>> >>> On Fri, Feb 02, 2024 at 10:26:01AM +0100, Miquel Raynal wrote:

Re: TI SN65DSI86 bridge chip DT binding maintainer

2024-02-02 Thread Jeffrey Hugo
On 2/2/2024 12:03 PM, Doug Anderson wrote: Hi, On Fri, Feb 2, 2024 at 10:29 AM Jeffrey Hugo wrote: Hi Doug, The DT binding for the TI SN65DSI86 [1] lists Sandeep Panda as the maintainer within the file. This is no longer valid because the @codeaurora domain bounces, and Sandeep appears to

Re: [PATCH 2/2] fbcon: Defer console takeover for splash screens to first switch

2024-02-02 Thread Mario Limonciello
On 2/2/2024 02:53, Daniel van Vugt wrote: Until now, deferred console takeover only meant defer until there is output. But that risks stepping on the toes of userspace splash screens, as console messages may appear before the splash screen. So check for the "splash" parameter (as used by

[git pull] drm fixes for 6.8-rc3

2024-02-02 Thread Dave Airlie
Hey Linus, Regular weekly fixes, mostly amdgpu and xe. One nouveau fix is a better fix for the deadlock and also helps with a sync race we were seeing. Dave. drm-fixes-2024-02-03: drm fixes for 6.8-rc3 dma-buf: - heaps CMA page accounting fix virtio-gpu: - fix segment size xe: - A crash fix

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-02 Thread Pekka Paalanen
On Fri, 2 Feb 2024 17:07:34 +0100 Miquel Raynal wrote: > Hi Pekka, Hi Miquel, I'm happy to see no hard feelings below. I know I may be blunt at times. Another thing coming to my mind is that I suppose there is no agreed standard benchmark for VKMS performance, is there? I recall people

Re: [PATCH v2] drm/vmwgfx: Filter modes which exceed 3/4 of graphics memory.

2024-02-02 Thread Zack Rusin
On Fri, Feb 2, 2024 at 11:58 AM Ian Forbes wrote: > > SVGA requires surfaces to fit within graphics memory (max_mob_pages) which > means that modes with a final buffer size that would exceed graphics memory > must be pruned otherwise creation will fail. Sorry, I didn't notice this originally but

Re: TI SN65DSI86 bridge chip DT binding maintainer

2024-02-02 Thread Doug Anderson
Hi, On Fri, Feb 2, 2024 at 10:29 AM Jeffrey Hugo wrote: > > Hi Doug, > > The DT binding for the TI SN65DSI86 [1] lists Sandeep Panda > as the maintainer within the file. This is no > longer valid because the @codeaurora domain bounces, and Sandeep appears > to have left the company. As such

Re: [PATCH v2 2/7] drm/vkms: Add support for multy-planar framebuffers

2024-02-02 Thread Arthur Grillo
On 01/02/24 14:38, Louis Chauvet wrote: >> >> /* >> @@ -23,27 +23,25 @@ static size_t pixel_offset(const struct vkms_frame_info >> *frame_info, int x, int >> * @frame_info: Buffer metadata >> * @x: The x(width) coordinate of the 2D buffer >> * @y: The y(Heigth) coordinate of the 2D

[PATCH AUTOSEL 4.19 4/5] fbdev: sis: Error out if pixclock equals zero

2024-02-02 Thread Sasha Levin
From: Fullway Wang [ Upstream commit e421946be7d9bf545147bea8419ef8239cb7ca52 ] The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of pixclock, it may cause divide-by-zero error. In sisfb_check_var(), var->pixclock is used

[PATCH AUTOSEL 4.19 3/5] fbdev: savage: Error out if pixclock equals zero

2024-02-02 Thread Sasha Levin
From: Fullway Wang [ Upstream commit 04e5eac8f3ab2ff52fa191c187a46d4fdbc1e288 ] The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of pixclock, it may cause divide-by-zero error. Although pixclock is checked in

[PATCH AUTOSEL 5.4 4/6] fbdev: sis: Error out if pixclock equals zero

2024-02-02 Thread Sasha Levin
From: Fullway Wang [ Upstream commit e421946be7d9bf545147bea8419ef8239cb7ca52 ] The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of pixclock, it may cause divide-by-zero error. In sisfb_check_var(), var->pixclock is used

[PATCH AUTOSEL 5.4 3/6] fbdev: savage: Error out if pixclock equals zero

2024-02-02 Thread Sasha Levin
From: Fullway Wang [ Upstream commit 04e5eac8f3ab2ff52fa191c187a46d4fdbc1e288 ] The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of pixclock, it may cause divide-by-zero error. Although pixclock is checked in

[PATCH AUTOSEL 5.10 4/8] fbdev: sis: Error out if pixclock equals zero

2024-02-02 Thread Sasha Levin
From: Fullway Wang [ Upstream commit e421946be7d9bf545147bea8419ef8239cb7ca52 ] The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of pixclock, it may cause divide-by-zero error. In sisfb_check_var(), var->pixclock is used

[PATCH AUTOSEL 5.10 3/8] fbdev: savage: Error out if pixclock equals zero

2024-02-02 Thread Sasha Levin
From: Fullway Wang [ Upstream commit 04e5eac8f3ab2ff52fa191c187a46d4fdbc1e288 ] The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of pixclock, it may cause divide-by-zero error. Although pixclock is checked in

[PATCH AUTOSEL 5.15 04/11] fbdev: sis: Error out if pixclock equals zero

2024-02-02 Thread Sasha Levin
From: Fullway Wang [ Upstream commit e421946be7d9bf545147bea8419ef8239cb7ca52 ] The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of pixclock, it may cause divide-by-zero error. In sisfb_check_var(), var->pixclock is used

[PATCH AUTOSEL 5.15 03/11] fbdev: savage: Error out if pixclock equals zero

2024-02-02 Thread Sasha Levin
From: Fullway Wang [ Upstream commit 04e5eac8f3ab2ff52fa191c187a46d4fdbc1e288 ] The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of pixclock, it may cause divide-by-zero error. Although pixclock is checked in

[PATCH AUTOSEL 6.1 04/15] fbdev: sis: Error out if pixclock equals zero

2024-02-02 Thread Sasha Levin
From: Fullway Wang [ Upstream commit e421946be7d9bf545147bea8419ef8239cb7ca52 ] The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of pixclock, it may cause divide-by-zero error. In sisfb_check_var(), var->pixclock is used

[PATCH AUTOSEL 6.1 03/15] fbdev: savage: Error out if pixclock equals zero

2024-02-02 Thread Sasha Levin
From: Fullway Wang [ Upstream commit 04e5eac8f3ab2ff52fa191c187a46d4fdbc1e288 ] The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of pixclock, it may cause divide-by-zero error. Although pixclock is checked in

[PATCH AUTOSEL 6.6 04/21] fbdev: sis: Error out if pixclock equals zero

2024-02-02 Thread Sasha Levin
From: Fullway Wang [ Upstream commit e421946be7d9bf545147bea8419ef8239cb7ca52 ] The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of pixclock, it may cause divide-by-zero error. In sisfb_check_var(), var->pixclock is used

[PATCH AUTOSEL 6.6 03/21] fbdev: savage: Error out if pixclock equals zero

2024-02-02 Thread Sasha Levin
From: Fullway Wang [ Upstream commit 04e5eac8f3ab2ff52fa191c187a46d4fdbc1e288 ] The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of pixclock, it may cause divide-by-zero error. Although pixclock is checked in

[PATCH AUTOSEL 6.7 21/23] drm/amd/display: Disable ips before dc interrupt setting

2024-02-02 Thread Sasha Levin
From: Roman Li [ Upstream commit 8894b9283afd35b8d22ae07a0c118eb5f7d2e78b ] [Why] While in IPS2 an access to dcn registers is not allowed. If interrupt results in dc call, we should disable IPS. [How] Safeguard register access in IPS2 by disabling idle optimization before calling dc interrupt

[PATCH AUTOSEL 6.7 04/23] fbdev: sis: Error out if pixclock equals zero

2024-02-02 Thread Sasha Levin
From: Fullway Wang [ Upstream commit e421946be7d9bf545147bea8419ef8239cb7ca52 ] The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of pixclock, it may cause divide-by-zero error. In sisfb_check_var(), var->pixclock is used

[PATCH AUTOSEL 6.7 03/23] fbdev: savage: Error out if pixclock equals zero

2024-02-02 Thread Sasha Levin
From: Fullway Wang [ Upstream commit 04e5eac8f3ab2ff52fa191c187a46d4fdbc1e288 ] The userspace program could pass any values to the driver through ioctl() interface. If the driver doesn't check the value of pixclock, it may cause divide-by-zero error. Although pixclock is checked in

Re: [PATCH v3 08/24] hwtracing: switch to use of_graph_get_next_device_endpoint()

2024-02-02 Thread Suzuki K Poulose
On 31/01/2024 05:05, Kuninori Morimoto wrote: of_graph_get_next_endpoint() is now renamed to of_graph_get_next_device_endpoint(). Switch to it. Signed-off-by: Kuninori Morimoto --- drivers/hwtracing/coresight/coresight-platform.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH v3 06/24] media: platform: switch to use of_graph_get_next_device_endpoint()

2024-02-02 Thread Rob Herring
On Wed, Jan 31, 2024 at 05:05:34AM +, Kuninori Morimoto wrote: > of_graph_get_next_endpoint() is now renamed to > of_graph_get_next_device_endpoint(). Switch to it. > > Signed-off-by: Kuninori Morimoto > --- > drivers/media/platform/atmel/atmel-isi.c | 4 ++-- >

Re: [PATCH v3 05/24] media: i2c: switch to use of_graph_get_next_device_endpoint()

2024-02-02 Thread Rob Herring
On Wed, Jan 31, 2024 at 05:05:27AM +, Kuninori Morimoto wrote: > of_graph_get_next_endpoint() is now renamed to > of_graph_get_next_device_endpoint(). Switch to it. > > Signed-off-by: Kuninori Morimoto > --- > drivers/media/i2c/adv7343.c | 2 +- >

TI SN65DSI86 bridge chip DT binding maintainer

2024-02-02 Thread Jeffrey Hugo
Hi Doug, The DT binding for the TI SN65DSI86 [1] lists Sandeep Panda as the maintainer within the file. This is no longer valid because the @codeaurora domain bounces, and Sandeep appears to have left the company. As such the binding appears to be orphaned, although the file itself is

Re: [v2,8/8] fbdev/efifb: Remove framebuffer relocation tracking

2024-02-02 Thread Sui Jingfeng
Hi, Nice job, well done! Because this the fix the problem at the root level, I appreciate this solution. On 2024/2/2 19:58, Thomas Zimmermann wrote: If the firmware framebuffer has been reloacted, the sysfb code fixes the screen_info state before it creates the framebuffer's platform

[PATCH] dt-bindings: visionox-rm69299: Update maintainers

2024-02-02 Thread Jessica Zhang
a Visionox RM692999 panel. --- base-commit: 51b70ff55ed88edd19b080a524063446bcc34b62 change-id: 20240202-rm69299-maintainers-7e069f78334f Best regards, -- Jessica Zhang

[PATCH] dt-bindings: backlight: qcom-wled: Fix bouncing email addresses

2024-02-02 Thread Jeffrey Hugo
Bjorn is no longer at Linaro. Update his email address to @kernel to match the .mailmap entry. The servers for @codeaurora are long retired and messages sent there will bounce. Update Kiran's email address to match the .mailmap entry. This will help anyone that is looking to reach out about

Re: [v2,7/8] firmware/sysfb: Update screen_info for relocated EFI framebuffers

2024-02-02 Thread Sui Jingfeng
Hi, On 2024/2/2 19:58, Thomas Zimmermann wrote: +static inline void __screen_info_set_lfb_base(struct screen_info *si, u64 lfb_base) +{ + si->lfb_base = lfb_base & GENMASK_ULL(31, 0); + si->ext_lfb_base = (lfb_base & GENMASK_ULL(63, 32)) >> 32; I want to ask a trivial question:

Re: [v2,7/8] firmware/sysfb: Update screen_info for relocated EFI framebuffers

2024-02-02 Thread Sui Jingfeng
Hi, On 2024/2/2 19:58, Thomas Zimmermann wrote: +static inline void __screen_info_set_lfb_base(struct screen_info *si, u64 lfb_base) +{ + si->lfb_base = lfb_base & GENMASK_ULL(31, 0); + si->ext_lfb_base = (lfb_base & GENMASK_ULL(63, 32)) >> 32; + + if (si->ext_lfb_base) +

Re: [v2, 5/8] firmware/sysfb: Create firmware device only for enabled PCI devices

2024-02-02 Thread Sui Jingfeng
HI, On 2024/2/2 19:58, Thomas Zimmermann wrote: Test if the firmware framebuffer's parent PCI device, if any, has been enabled. If not, the firmware framebuffer is most likely not working. Hence, do not create a device for the firmware framebuffer on disabled PCI devices. So far, efifb

Re: [PATCH 1/2] drm/nouveau: don't fini scheduler if not initialized

2024-02-02 Thread Danilo Krummrich
On 2/2/24 18:14, Timur Tabi wrote: On Fri, 2024-02-02 at 01:05 +0100, Danilo Krummrich wrote: nouveau_abi16_ioctl_channel_alloc() and nouveau_cli_init() simply call their corresponding *_fini() counterpart. This can lead to nouveau_sched_fini() being called without struct nouveau_sched ever

Re: drm/loongson: Error out if no VRAM detected

2024-02-02 Thread Sui Jingfeng
On 2024/1/19 18:40, Huacai Chen wrote: If there is no VRAM (it is true if there is a discreted card), we get such an error and Xorg fails to start: [ 136.401131] loongson :00:06.1: [drm] *ERROR* Requesting(0MiB) failed [ 137.444342] loongson :00:06.1: [drm] *ERROR* Requesting(0MiB)

Re: [PATCH 1/2] drm/nouveau: don't fini scheduler if not initialized

2024-02-02 Thread Timur Tabi
On Fri, 2024-02-02 at 01:05 +0100, Danilo Krummrich wrote: > nouveau_abi16_ioctl_channel_alloc() and nouveau_cli_init() simply call > their corresponding *_fini() counterpart. This can lead to > nouveau_sched_fini() being called without struct nouveau_sched ever > being initialized in the first

Re: [v2,2/8] video: Provide screen_info_get_pci_dev() to find screen_info's PCI device

2024-02-02 Thread Sui Jingfeng
Hi, On 2024/2/2 19:58, Thomas Zimmermann wrote: + +/** + * screen_info_pci_dev() - Return PCI parent device that contains screen_info's framebuffer + * @si: the screen_info + * + * Returns: + * The screen_info's parent device on success, or NULL otherwise. + */ +struct pci_dev

[PATCH v2] drm/vmwgfx: Filter modes which exceed 3/4 of graphics memory.

2024-02-02 Thread Ian Forbes
SVGA requires surfaces to fit within graphics memory (max_mob_pages) which means that modes with a final buffer size that would exceed graphics memory must be pruned otherwise creation will fail. Additionally, device commands which use multiple graphics resources must have all their resources fit

Re: Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-02 Thread Ville Syrjälä
On Fri, Feb 02, 2024 at 04:59:30PM +0100, Maxime Ripard wrote: > On Fri, Feb 02, 2024 at 05:40:47PM +0200, Ville Syrjälä wrote: > > On Fri, Feb 02, 2024 at 02:01:39PM +0100, Maxime Ripard wrote: > > > Hi, > > > > > > On Mon, Jan 15, 2024 at 03:37:20PM +0100, Sebastian Wick wrote: > > > > > > /**

Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-02 Thread Ville Syrjälä
On Fri, Feb 02, 2024 at 12:20:21PM +0100, Hans Verkuil wrote: > On 02/02/2024 12:04, Jani Nikula wrote: > > On Mon, 15 Jan 2024, Sebastian Wick wrote: > >> On Thu, Dec 07, 2023 at 04:49:31PM +0100, Maxime Ripard wrote: > >>> The i915 driver has a property to force the RGB range of an HDMI output.

Re: [v2,2/8] video: Provide screen_info_get_pci_dev() to find screen_info's PCI device

2024-02-02 Thread Sui Jingfeng
Hi, On 2024/2/2 19:58, Thomas Zimmermann wrote: diff --git a/drivers/video/screen_info_pci.c b/drivers/video/screen_info_pci.c new file mode 100644 index 0..d959a4c6ba3d5 --- /dev/null +++ b/drivers/video/screen_info_pci.c @@ -0,0 +1,52 @@ +// SPDX-License-Identifier: GPL-2.0 +

[drm-misc:drm-misc-next 1/1] drivers/gpu/drm/xe/xe_bo.c:41:24: error: initializer overrides prior initialization of this subobject

2024-02-02 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next head: 2bb98fc1d4a7715da3cb429d77731b0d1d2d3903 commit: 4db102dcb0396a4ccf89b1eac0f4eb3fd167a080 [1/1] Merge drm/drm-next into drm-misc-next config: x86_64-randconfig-076-20240202 (https://download.01.org/0day-ci/archive/20240203

Re: [PATCH] drm/amd/display: Simplify the calculation of variables

2024-02-02 Thread Alex Deucher
On Fri, Feb 2, 2024 at 10:13 AM Jiapeng Chong wrote: > > ./drivers/gpu/drm/amd/display/dc/dml2/dml2_utils.c:236:49-51: WARNING !A || A > && B is equivalent to !A || B. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8169 > Signed-off-by: Jiapeng Chong

Re: [PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-02 Thread Mario Limonciello
On 2/2/2024 09:28, Hamza Mahfooz wrote: We want programs besides the compositor to be able to enable or disable panel power saving features. However, since they are currently only configurable through DRM properties, that isn't possible. So, to remedy that issue introduce a new

Re: [PATCH 40/46] dma-buf: move dma-buf symbols into the DMA_BUF module namespace.

2024-02-02 Thread Greg Kroah-Hartman
On Fri, Feb 02, 2024 at 02:01:47PM +0530, Kolanupaka Naveena wrote: > +#ifdef BPM_MODULE_IMPORT_NS_SUPPORT > +#include > +#endif No #ifdef in .c files please, this should not be an issue, just include the .h file. > #include > > #include "gem/i915_gem_dmabuf.h" > @@ -23,6 +26,10 @@ >

Re: [PATCH] drm/tegra: Remove of_dma_configure() from host1x_device_add()

2024-02-02 Thread Jason Gunthorpe
On Fri, Feb 02, 2024 at 03:56:52PM +, Jon Hunter wrote: > > On 02/02/2024 14:35, Jason Gunthorpe wrote: > > On Fri, Feb 02, 2024 at 10:40:36AM +, Jon Hunter wrote: > > > > > > But, what is the actual log output you see, is it -EEXIST? > > > > > > I see ... > > > > > > ERR KERN host1x

Re: [PATCH v3 1/5] ACPI: video: Handle fetching EDID that is longer than 256 bytes

2024-02-02 Thread Mario Limonciello
On 2/2/2024 10:07, Rafael J. Wysocki wrote: On Thu, Feb 1, 2024 at 11:11 PM Mario Limonciello wrote: The ACPI specification allows for an EDID to be up to 512 bytes but the _DDC EDID fetching code will only try up to 256 bytes. Modify the code to instead start at 512 bytes and work it's way

Re: [PATCH v3 1/5] ACPI: video: Handle fetching EDID that is longer than 256 bytes

2024-02-02 Thread Rafael J. Wysocki
On Thu, Feb 1, 2024 at 11:11 PM Mario Limonciello wrote: > > The ACPI specification allows for an EDID to be up to 512 bytes but > the _DDC EDID fetching code will only try up to 256 bytes. > > Modify the code to instead start at 512 bytes and work it's way > down instead. > > As _DDC is now

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-02 Thread Miquel Raynal
Hi Pekka, pekka.paala...@haloniitty.fi wrote on Fri, 2 Feb 2024 17:49:13 +0200: > On Fri, 2 Feb 2024 13:13:22 +0100 > Miquel Raynal wrote: > > > Hello Maxime, > > > > + Arthur > > > > mrip...@kernel.org wrote on Fri, 2 Feb 2024 10:53:37 +0100: > > > > > Hi Miquel, > > > > > > On Fri, Feb

Re: [PATCH] gpu: drm: display: indent fix in comment

2024-02-02 Thread Kousik Sanagavarapu
On Thu, Jan 25, 2024 at 12:05:56AM +0530, Kousik Sanagavarapu wrote: > The comments explaining the function "drm_dp_mst_atom_check_mgr()" had > uneven indentation which made "make htmldocs" complain: > > Documentation/gpu/drm-kms-helpers:296: >

Re: Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-02 Thread Maxime Ripard
On Fri, Feb 02, 2024 at 05:40:47PM +0200, Ville Syrjälä wrote: > On Fri, Feb 02, 2024 at 02:01:39PM +0100, Maxime Ripard wrote: > > Hi, > > > > On Mon, Jan 15, 2024 at 03:37:20PM +0100, Sebastian Wick wrote: > > > > > /** > > > > > * DOC: HDMI connector properties > > > > > * > > > > > + *

Re: [PATCH] drm/tegra: Remove of_dma_configure() from host1x_device_add()

2024-02-02 Thread Jon Hunter
On 02/02/2024 14:35, Jason Gunthorpe wrote: On Fri, Feb 02, 2024 at 10:40:36AM +, Jon Hunter wrote: But, what is the actual log output you see, is it -EEXIST? I see ... ERR KERN host1x drm: iommu configuration for device failed with -ENOENT So that shouldn't happen in you case as

Re: [RFC 4/4] drm/i915/mst: enable MST mode for 128b/132b single-stream sideband

2024-02-02 Thread Ville Syrjälä
On Fri, Feb 02, 2024 at 04:05:34PM +0200, Jani Nikula wrote: > If the sink supports 128b/132b and single-stream sideband messaging, > enable MST mode. > > With this, the topology manager will still write DP_MSTM_CTRL, which > should be ignored by the sink. In the future, >

Re: [RFC 2/4] drm/i915/dp: refactor DP MST detection and configuration

2024-02-02 Thread Ville Syrjälä
On Fri, Feb 02, 2024 at 04:05:32PM +0200, Jani Nikula wrote: > Currently we've split MST capability detection in two places, > intel_dp_can_mst() and intel_dp_configure_mst(). They check essentially > the same things. > > Move bulk of the work, including logging, to intel_dp_can_mst() and >

Re: [PATCH 2/2] drm/vkms: Use a simpler composition function

2024-02-02 Thread Pekka Paalanen
On Fri, 2 Feb 2024 13:13:22 +0100 Miquel Raynal wrote: > Hello Maxime, > > + Arthur > > mrip...@kernel.org wrote on Fri, 2 Feb 2024 10:53:37 +0100: > > > Hi Miquel, > > > > On Fri, Feb 02, 2024 at 10:26:01AM +0100, Miquel Raynal wrote: > > > pekka.paala...@haloniitty.fi wrote on Fri, 2 Feb

Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-02 Thread Maxime Ripard
Hi Sebastian, On Mon, Jan 15, 2024 at 03:33:08PM +0100, Sebastian Wick wrote: > > /** > > * DOC: HDMI connector properties > > * > > + * Broadcast RGB > > + * Indicates the RGB Quantization Range (Full vs Limited) used. > > + * Infoframes will be generated according to that value.

Re: Re: [PATCH v5 08/44] drm/connector: hdmi: Add Broadcast RGB property

2024-02-02 Thread Ville Syrjälä
On Fri, Feb 02, 2024 at 02:01:39PM +0100, Maxime Ripard wrote: > Hi, > > On Mon, Jan 15, 2024 at 03:37:20PM +0100, Sebastian Wick wrote: > > > > /** > > > > * DOC: HDMI connector properties > > > > * > > > > + * Broadcast RGB > > > > + * Indicates the RGB Quantization Range (Full vs

Re: [RFC 1/4] drm/mst: read sideband messaging cap

2024-02-02 Thread Ville Syrjälä
On Fri, Feb 02, 2024 at 04:05:31PM +0200, Jani Nikula wrote: > Amend drm_dp_read_mst_cap() to return an enum, indicating "none", > "sideband messaging", or "mst". Modify all call sites to take the new > return value into account. > > Cc: Arun R Murthy > Cc: Ville Syrjälä > Signed-off-by: Jani

Re: [PATCHv2 2/2] drm/i915/display/dp: 128/132b DP-capable with SST

2024-02-02 Thread Jani Nikula
On Wed, 31 Jan 2024, Arun R Murthy wrote: > With a value of '0' read from MSTM_CAP register MST to be enabled. > DP2.1 SCR updates the spec for 128/132b DP capable supporting only one > stream and not supporting single stream sideband MSG. > The underlying protocol will be MST to enable use of

[PATCH v2] drm/amd/display: add panel_power_savings sysfs entry to eDP connectors

2024-02-02 Thread Hamza Mahfooz
We want programs besides the compositor to be able to enable or disable panel power saving features. However, since they are currently only configurable through DRM properties, that isn't possible. So, to remedy that issue introduce a new "panel_power_savings" sysfs attribute. Cc: Mario

Re: [v2,3/8] firmware/sysfb: Set firmware-framebuffer parent device

2024-02-02 Thread Sui Jingfeng
Hi, On 2024/2/2 19:58, Thomas Zimmermann wrote: Set the firmware framebuffer's parent device, which usually is the graphics hardware's physical device. Integrates the framebuffer in the Linux device hierarchy and lets Linux handle dependencies among devices. For example, the graphics hardware

Re: [PATCH v3 2/5] drm: Add drm_get_acpi_edid() helper

2024-02-02 Thread Mario Limonciello
On 2/2/2024 04:29, Jani Nikula wrote: On Thu, 01 Feb 2024, Mario Limonciello wrote: Some manufacturers have intentionally put an EDID that differs from the EDID on the internal panel on laptops. Drivers can call this helper to attempt to fetch the EDID from the BIOS's ACPI _DDC method. I'm

Re: [v2,3/8] firmware/sysfb: Set firmware-framebuffer parent device

2024-02-02 Thread Sui Jingfeng
Hi, Thomas: I love your patch, yet it can cause the linux kernel fail to compile if the CONFIG_SYSFB_SIMPLEFB option is not selected. I paste the log at below for easier to read and debug. Please fix this. :-) drivers/firmware/sysfb.c: In function ‘sysfb_init’: drivers/firmware/sysfb.c:134:22:

Re: [PATCH] drm/tegra: Remove of_dma_configure() from host1x_device_add()

2024-02-02 Thread Jason Gunthorpe
On Fri, Feb 02, 2024 at 10:40:36AM +, Jon Hunter wrote: > > But, what is the actual log output you see, is it -EEXIST? > > I see ... > > ERR KERN host1x drm: iommu configuration for device failed with -ENOENT So that shouldn't happen in you case as far as I can tell, the device is

Re: [PATCH v2 0/3] backlight: mp3309c: Allow to use on non-OF platforms

2024-02-02 Thread Andy Shevchenko
On Fri, Feb 02, 2024 at 10:52:32AM +, Flavio Suligoi wrote: > > Andy Shevchenko (3): > > backlight: mp3309c: Make use of device properties > > backlight: mp3309c: use dev_err_probe() instead of dev_err() > > backlight: mp3309c: Utilise temporary variable for struct device > I've just

[RFC 4/4] drm/i915/mst: enable MST mode for 128b/132b single-stream sideband

2024-02-02 Thread Jani Nikula
If the sink supports 128b/132b and single-stream sideband messaging, enable MST mode. With this, the topology manager will still write DP_MSTM_CTRL, which should be ignored by the sink. In the future, drm_dp_mst_topology_mgr_set_mst() bool mst_state parameter should probably be turned into an

[RFC 3/4] drm/i915/mst: improve debug logging of DP MST mode detect

2024-02-02 Thread Jani Nikula
Debug log the sink's MST capability, including single-stream sideband messaging support, and the decision whether to enable MST mode or not. Cc: Arun R Murthy Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dp.c | 19 ++- 1 file changed, 14

[RFC 2/4] drm/i915/dp: refactor DP MST detection and configuration

2024-02-02 Thread Jani Nikula
Currently we've split MST capability detection in two places, intel_dp_can_mst() and intel_dp_configure_mst(). They check essentially the same things. Move bulk of the work, including logging, to intel_dp_can_mst() and rename it intel_dp_mst_detect(). Set intel_dp->is_mst there to avoid duplicate

[RFC 1/4] drm/mst: read sideband messaging cap

2024-02-02 Thread Jani Nikula
Amend drm_dp_read_mst_cap() to return an enum, indicating "none", "sideband messaging", or "mst". Modify all call sites to take the new return value into account. Cc: Arun R Murthy Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/display/drm_dp_mst_topology.c | 20

[RFC 0/4] drm/i915/mst: enable MST mode for 128b/132b single-stream sideband

2024-02-02 Thread Jani Nikula
Draft for comments. BR, Jani. Cc: Arun R Murthy Cc: Ville Syrjälä Jani Nikula (4): drm/mst: read sideband messaging cap drm/i915/dp: refactor DP MST detection and configuration drm/i915/mst: improve debug logging of DP MST mode detect drm/i915/mst: enable MST mode for 128b/132b

Re: Re: Re: [PATCH v5 15/44] drm/connector: hdmi: Compute bpc and format automatically

2024-02-02 Thread Jani Nikula
On Thu, 01 Feb 2024, Maxime Ripard wrote: > We've discussed that on IRC today. I'm not sure there was a conclusion > other than "well this doesn't seem right". I think we should at least > provide different EDIDs depending on the connector type indeed, but > there was also a few discussions that

Re: [PATCH v4 0/2] drm/imx/dcss: implement region request and devres

2024-02-02 Thread Laurentiu Palcu
Hi Philipp, Applied series to drm-misc-next. Thanks, Laurentiu On Wed, Jan 24, 2024 at 12:19:03PM +0100, Philipp Stanner wrote: > @Laurentiu: > Thank you very much for the review. I was indeed on an older branch. As > Linus's master is currently broken for ARM64 [1], unfortunately, I built > it

Re: [PATCH v4 2/2] drm/imx/dcss: have all init functions use devres

2024-02-02 Thread Laurentiu Palcu
Hi Philipp, On Wed, Jan 24, 2024 at 12:19:05PM +0100, Philipp Stanner wrote: > dcss currently allocates and ioremaps quite a few resources in its probe > function's call graph. Devres now provides convenient functions which > perform the same task but do the cleanup automatically. > > Port all

Re: [PATCH V2 2/2] phy: freescale: add Samsung HDMI PHY

2024-02-02 Thread Adam Ford
On Fri, Feb 2, 2024 at 5:20 AM Luca Ceresoli wrote: > > Hello Adam, > > On Sat, 6 Jan 2024 16:19:05 -0600 > Adam Ford wrote: > > > From: Lucas Stach > > > > This adds the driver for the Samsung HDMI PHY found on the > > i.MX8MP SoC. > > > > Signed-off-by: Lucas Stach > > Signed-off-by: Adam

  1   2   >