[PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree.

2016-03-08 Thread Stephen Warren
On 03/08/2016 11:04 AM, Eric Anholt wrote: > Stephen Warren writes: > >> On 03/04/2016 01:32 PM, Eric Anholt wrote: >>> VC4 is the GPU (display and 3D) present on the 283x. >> >>> diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts >>&g

[PATCH 3/3] ARM: bcm2835: Add VC4 to the device tree.

2016-03-07 Thread Stephen Warren
On 03/04/2016 01:32 PM, Eric Anholt wrote: > VC4 is the GPU (display and 3D) present on the 283x. > diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts > b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts > + { > + hpd-gpios = < 46 GPIO_ACTIVE_LOW>; > +}; Isn't that the same everywhere? If so,

bcm2835 (Raspberry Pi) KMS driver

2015-10-12 Thread Stephen Warren
On 10/11/2015 06:39 AM, Stefan Wahren wrote: > Am 09.10.2015 um 23:27 schrieb Eric Anholt: >> This is a respin of the Raspberry Pi KMS series. Now that we've got a >> real clock driver, I can actually set new video modes. Also in this >> version, most of the custom DT stuff from before is gone,

[PATCH v2 7/7] ARM: bcm2835: Add VC4 to the device tree.

2015-08-25 Thread Stephen Warren
On 08/18/2015 03:54 PM, Eric Anholt wrote: > VC4 is the GPU (display and 3D) present on the 2835. This patch and patch 1 seem OK to me, although I'll withhold any ack until the DT binding design discussion with Rob has been resolved. I haven't looked at the OF graph bindings he mentioned so have

[PATCH v2 6/7] ARM: bcm2835: Add the DDC I2C controller to the device tree.

2015-08-25 Thread Stephen Warren
On 08/18/2015 03:54 PM, Eric Anholt wrote: > We need to use it for getting video modes over HDMI. This patch, Acked-by: Stephen Warren

[PATCH 7/7] ARM: bcm2835: Add VC4 to the device tree.

2015-08-14 Thread Stephen Warren
On 08/12/2015 06:56 PM, Eric Anholt wrote: > Signed-off-by: Eric Anholt Patch description? > diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi > arm-pmu { > compatible = "arm,arm1176-pmu"; > }; > + > +

[PATCH 6/7] ARM: bcm2835: Add the DDC I2C controller to the device tree.

2015-08-14 Thread Stephen Warren
On 08/12/2015 06:56 PM, Eric Anholt wrote: > We need to use it for getting video modes over HDMI. > diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi > + i2c2: i2c at 7e805000 { > + compatible = "brcm,bcm2835-i2c"; > +

[PATCH 3/7] drm/vc4: Add KMS support for Raspberry Pi.

2015-08-14 Thread Stephen Warren
On 08/12/2015 06:56 PM, Eric Anholt wrote: > This is the start of a full VC4 driver. Right now this just supports > configuring the display using a pre-existing video mode (because > changing the pixel clock isn't available yet, and doesn't work when it > is). However, this is enough for fbcon

[PATCH 2/7] MAINTAINERS: Add myself for the new VC4 (RPi GPU) graphics driver.

2015-08-14 Thread Stephen Warren
On 08/12/2015 06:56 PM, Eric Anholt wrote: > diff --git a/MAINTAINERS b/MAINTAINERS > +DRM DRIVERS FOR VC4 > +M: Eric Anholt > +T: git git://github.com/anholt/linux > +S: Maintained > +F: drivers/gpu/drm/vc4/* S: Supported ?

[PATCH 1/7] drm/vc4: Add devicetree bindings for VC4.

2015-08-14 Thread Stephen Warren
On 08/12/2015 06:56 PM, Eric Anholt wrote: > Signed-off-by: Eric Anholt This one definitely needs a patch description, since someone might not know what a VC4 is, and "git log" won't show the text from the binding doc itself. I'd suggest adding the initial paragraph of the binding doc as the

[PATCH v5 00/11] Improvements to Tegra-based Chromebook support

2015-02-17 Thread Stephen Warren
n dtsi so we can paste the output as is and be sure that the kernel > doesn't diverge from the canonical data. At a quick glance this series looks OK, Acked-by: Stephen Warren

[5/5] ARM: tegra: jetson-tk1: enable GK20A GPU

2014-09-25 Thread Stephen Warren
On 09/25/2014 10:41 AM, Thierry Reding wrote: > On Thu, Sep 25, 2014 at 09:48:01AM -0600, Stephen Warren wrote: >> On 09/25/2014 07:27 AM, Sjoerd Simons wrote: >>> Playing a bit with todays linux-next on my jetson, it seems this patch is >>> still required for enabling

[5/5] ARM: tegra: jetson-tk1: enable GK20A GPU

2014-09-25 Thread Stephen Warren
On 09/25/2014 07:27 AM, Sjoerd Simons wrote: > Playing a bit with todays linux-next on my jetson, it seems this patch is > still required for enabling the GPU. Is there anything blocking it (firmware > not available yet in liux-firmware?) I think initially I was waiting for the DRM patch

[PATCH V2] drm/tegra: add MODULE_DEVICE_TABLEs

2014-07-23 Thread Stephen Warren
On 06/18/2014 04:21 PM, Stephen Warren wrote: > From: Stephen Warren > > When tegra-drm.ko is built as a module, these MODULE_DEVICE_TABLEs allow > the module to be auto-loaded since the module will match the devices > instantiated from device tree. > > (Notes for stable:

[PATCH 4/4] ARM: tegra: roth: add display DT node

2014-07-21 Thread Stephen Warren
On 07/02/2014 09:10 PM, Alexandre Courbot wrote: > On 07/03/2014 12:55 AM, Stephen Warren wrote: >> On 07/02/2014 06:19 AM, Alexandre Courbot wrote: >>> DSI support has been fixed to support continuous clock behavior that the >>> panel used on SHIELD requires, so final

[PATCH v3 0/3] drm/nouveau: support for probing platform devices

2014-07-02 Thread Stephen Warren
On 07/02/2014 03:09 AM, Alexandre Courbot wrote: > On Thu, Jun 26, 2014 at 2:33 PM, Alexandre Courbot > wrote: >> This series adds support for probing platform devices on Nouveau, as well as >> the DT bindings for GK20A. It doesn't enable the GPU yet on Tegra boards >> since >> a few extra

[PATCH 4/4] ARM: tegra: roth: add display DT node

2014-07-02 Thread Stephen Warren
On 07/02/2014 06:19 AM, Alexandre Courbot wrote: > DSI support has been fixed to support continuous clock behavior that the > panel used on SHIELD requires, so finally add its device tree node since > it is functional. > diff --git a/arch/arm/boot/dts/tegra114-roth.dts >

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

2014-06-18 Thread Stephen Warren
On 06/18/2014 05:14 PM, Thierry Reding wrote: > On Wed, Jun 18, 2014 at 04:09:06PM -0600, Stephen Warren wrote: >> On 06/18/2014 04:03 PM, Thierry Reding wrote: ... >>> From what I remember, Mike was fairly strongly opposing the idea of >>> virtual clocks, but what y

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

2014-06-18 Thread Stephen Warren
On 06/18/2014 04:19 PM, St?phane Marchesin wrote: > On Wed, Jun 18, 2014 at 3:00 PM, Thierry Reding > wrote: >> On Wed, Jun 18, 2014 at 07:23:47PM +0200, Tomeu Vizoso wrote: >>> On 06/17/2014 06:15 PM, Stephen Warren wrote: >>>> On 06/17/2014 06:16 AM, Tomeu Viz

[PATCH V2] drm/tegra: add MODULE_DEVICE_TABLEs

2014-06-18 Thread Stephen Warren
From: Stephen Warren <swar...@nvidia.com> When tegra-drm.ko is built as a module, these MODULE_DEVICE_TABLEs allow the module to be auto-loaded since the module will match the devices instantiated from device tree. (Notes for stable: in 3.14+, just git rm any conflicting file,

[PATCH] drm/tegra: add MODULE_DEVICE_TABLEs

2014-06-18 Thread Stephen Warren
On 06/18/2014 03:51 PM, Thierry Reding wrote: > On Wed, Jun 18, 2014 at 03:19:15PM -0600, Stephen Warren wrote: >> From: Stephen Warren >> >> When tegra-drm.ko is built as a module, these MODULE_DEVICE_TABLEs allow >> the module to be auto-loaded since the mo

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

2014-06-18 Thread Stephen Warren
On 06/18/2014 04:03 PM, Thierry Reding wrote: > On Wed, Jun 18, 2014 at 11:46:49AM -0600, Stephen Warren wrote: >> On 06/18/2014 11:23 AM, Tomeu Vizoso wrote: >>> On 06/17/2014 06:15 PM, Stephen Warren wrote: >>>> On 06/17/2014 06:16 AM, Tomeu Vizoso wrote: >>

[PATCH] drm/tegra: add MODULE_DEVICE_TABLEs

2014-06-18 Thread Stephen Warren
From: Stephen Warren <swar...@nvidia.com> When tegra-drm.ko is built as a module, these MODULE_DEVICE_TABLEs allow the module to be auto-loaded since the module will match the devices instantiated from device tree. (Notes for stable: in 3.14+, just git rm any conflicting file,

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

2014-06-18 Thread Stephen Warren
On 06/18/2014 11:23 AM, Tomeu Vizoso wrote: > On 06/17/2014 06:15 PM, Stephen Warren wrote: >> On 06/17/2014 06:16 AM, Tomeu Vizoso wrote: >>> On 06/16/2014 10:02 PM, Stephen Warren wrote: >>>> On 06/16/2014 07:35 AM, Tomeu Vizoso wrote: >>>&g

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

2014-06-17 Thread Stephen Warren
On 06/17/2014 06:16 AM, Tomeu Vizoso wrote: > On 06/16/2014 10:02 PM, Stephen Warren wrote: >> On 06/16/2014 07:35 AM, Tomeu Vizoso wrote: >> This binding looks quite anaemic vs. >> Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-emc.txt; I >> would expect

[RFC PATCH 3/4] drm/tegra: Request memory bandwidth for the display controller

2014-06-16 Thread Stephen Warren
On 06/16/2014 07:35 AM, Tomeu Vizoso wrote: > Request it based solely on the current mode's refresh rate. More > accurate requirements can be requested in future patches. > diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c > + bandwidth = mode->clock *

[RFC PATCH 1/4] memory: tegra124-emc: Add EMC driver

2014-06-16 Thread Stephen Warren
On 06/16/2014 07:35 AM, Tomeu Vizoso wrote: > Adds functionality for registering memory bandwidth needs and setting > the EMC clock rate based on that. > > Also adds API for setting floor and ceiling frequency rates. > diff --git >

[PATCH 3/5] ARM: tegra: add GK20A GPU to Tegra124 DT

2014-05-19 Thread Stephen Warren
On 05/19/2014 03:24 AM, Alexandre Courbot wrote: > From: Thierry Reding > > Add the GK20A device node to Tegra124's device tree. At a quick glance, patches 3-5 look fine too. I'll hold off on applying them until patches 1-2 have been applied to the DRM/... tree.

[PATCH 2/5] ARM: tegra: of: add GK20A device tree binding

2014-05-19 Thread Stephen Warren
On 05/19/2014 03:24 AM, Alexandre Courbot wrote: > Add the device tree binding documentation for the GK20A GPU used in > Tegra K1 SoCs. A few minor nits, but otherwise, Acked-by: Stephen Warren > diff --git a/Documentation/devicetree/bindings/gpu/nvidia,gk20a.txt > b/Documentatio

[PATCH v3] drm/panel: Add support for EDT ETM0700G0DH6 and ET070080DH6 panels

2014-05-15 Thread Stephen Warren
On 05/15/2014 03:41 PM, Thierry Reding wrote: > On Thu, May 15, 2014 at 09:54:07AM -0600, Stephen Warren wrote: >> On 05/15/2014 04:54 AM, Thierry Reding wrote: >>> On Thu, May 15, 2014 at 12:25:47PM +0200, Philipp Zabel wrote: >>>> The EDT ETM0700G0DH6 and ET0

[PATCH v3] drm/panel: Add support for EDT ETM0700G0DH6 and ET070080DH6 panels

2014-05-15 Thread Stephen Warren
On 05/15/2014 04:54 AM, Thierry Reding wrote: > On Thu, May 15, 2014 at 12:25:47PM +0200, Philipp Zabel wrote: >> The EDT ETM0700G0DH6 and ET070080DH6 are 7" 800x480 panels, >> which can be supported by the simple panel driver. >> >> Signed-off-by: Philipp Zabel >> --- >> Changes since v2: >> -

[PATCH 1/3] drm/dsi: Support device shutdown

2014-04-29 Thread Stephen Warren
On 04/29/2014 09:28 AM, Thierry Reding wrote: > From: Thierry Reding > > Hook up the MIPI DSI bus's .shutdown() function to allow drivers to > implement code that should be run when a device is shut down. The series, Tested-by: Stephen Warren (On an NVIDIA Tegra Dalmor

[PATCH 1/3] ARM: tegra: Deprecate nvidia,hpd-gpio property

2014-04-21 Thread Stephen Warren
On 04/17/2014 06:02 AM, Thierry Reding wrote: > From: Thierry Reding > > Properties referencing GPIOs should use the plural suffix -gpios. This > convention is encoded in the device tree backend of gpiod_get(), which > we'll eventually want to migrate to. Wouldn't it be simpler to fix the GPIO

[PATCH V2] gpu: host1x: handle the correct # of syncpt regs

2014-04-14 Thread Stephen Warren
On 04/04/2014 04:31 PM, Stephen Warren wrote: > From: Stephen Warren > > BIT_WORD() truncates rather than rounds, so the loops in > syncpt_thresh_isr() and _host1x_intr_disable_all_syncpt_intrs() use <= > rather than < in an attempt to process the correct number of regi

[PATCH] drm/tegra: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

2014-04-11 Thread Stephen Warren
On 04/11/2014 02:36 AM, Duan Jiong wrote: > This patch fixes coccinelle error regarding usage of IS_ERR and > PTR_ERR instead of PTR_ERR_OR_ZERO. Same comment as the other patch; I prefer the existing code (although I'll defer to Thierry as maintainer of both these pieces of code). It would help

[PATCH V2] gpu: host1x: handle the correct # of syncpt regs

2014-04-07 Thread Stephen Warren
On 04/07/2014 02:18 AM, Thierry Reding wrote: > On Fri, Apr 04, 2014 at 04:31:05PM -0600, Stephen Warren wrote: >> From: Stephen Warren >> >> BIT_WORD() truncates rather than rounds, so the loops in >> syncpt_thresh_isr() and _host1x_intr_disable_all_syncpt_in

[PATCH V2] gpu: host1x: handle the correct # of syncpt regs

2014-04-04 Thread Stephen Warren
From: Stephen Warren <swar...@nvidia.com> BIT_WORD() truncates rather than rounds, so the loops in syncpt_thresh_isr() and _host1x_intr_disable_all_syncpt_intrs() use <= rather than < in an attempt to process the correct number of registers when rounding of the conversion of c

[PATCH] gpu: host1x: handle the correct # of syncpt regs

2014-04-01 Thread Stephen Warren
From: Stephen Warren <swar...@nvidia.com> BIT_WORD() truncates rather than rounds, so the loops in syncpt_thresh_isr() and _host1x_intr_disable_all_syncpt_intrs() use <= rather than < in an attempt to process the correct number of registers when rounding of the conversion of c

[PATCH] host1x: export host1x_syncpt_incr_max function

2014-02-19 Thread Stephen Warren
On 02/19/2014 03:23 PM, Bryan Wu wrote: > Tegra V4L2 camera driver needs this function to do frame capture. Does it need to be EXPORT_SYMBOL()d too, in case things are modules?

[PATCH 0/3] drm/tegra: Restore licensing consistency

2014-02-12 Thread Stephen Warren
On 02/12/2014 12:13 PM, Thierry Reding wrote: > On Wed, Feb 12, 2014 at 09:46:57AM -0700, Stephen Warren wrote: >> On 02/12/2014 12:30 AM, Thierry Reding wrote: >>> The bulk of the Tegra DRM driver is GPL v2 licensed, but some of the new >>> subdrivers were li

[PATCH 0/3] drm/tegra: Restore licensing consistency

2014-02-12 Thread Stephen Warren
ually be > used within libdrm. Since all the other headers in libdrm use the MIT > license, do the same for Tegra. The series, Acked-by: Stephen Warren I guess this needs explicit acks from the following people outside NVIDIA who touched these files:? Wei Yongjun (dsi.c) Emil Goode (tegra_drm.h)

[RFC 10/16] drm/nouveau/timer: skip calibration on GK20A

2014-02-05 Thread Stephen Warren
On 02/04/2014 01:39 AM, Alexandre Courbot wrote: > On 02/04/2014 12:55 PM, Ben Skeggs wrote: >> On Sat, Feb 1, 2014 at 1:16 PM, Alexandre Courbot >> wrote: >>> GK20A's timer is directly attached to the system timer and cannot be >>> calibrated. Skip the calibration phase on that chip since the

[PATCH v4 5/5] drm/tegra: Add eDP support

2014-01-22 Thread Stephen Warren
On 01/21/2014 12:24 PM, Thierry Reding wrote: > Add support for eDP functionality found on Tegra124 and later SoCs. Only > fast link training is currently supported. > > Signed-off-by: Thierry Reding > --- > .../bindings/gpu/nvidia,tegra20-host1x.txt | 42 + This part should go to the

[PATCH v2 2/2] drm/tegra: Obtain head number from DT

2014-01-15 Thread Stephen Warren
On 01/15/2014 02:06 AM, Thierry Reding wrote: > On Tue, Jan 14, 2014 at 10:53:19AM -0700, Stephen Warren wrote: >> On 01/14/2014 07:45 AM, Thierry Reding wrote: >>> The head number of a given display controller is fixed in hardware and >>> required to program out

[PATCH v2 2/2] drm/tegra: Obtain head number from DT

2014-01-14 Thread Stephen Warren
om the display > controller node's position in the device tree. That's somewhat more > reliable than the previous default but not a proper solution. The series, Tested-by: Stephen Warren This patch should really have been sent to the DT maintainers and list since it changes a DT binding... >

[PATCH 2/2] drm/tegra: Obtain head number from DT

2014-01-14 Thread Stephen Warren
On 01/14/2014 07:14 AM, Thierry Reding wrote: > On Mon, Jan 13, 2014 at 10:46:45AM -0700, Stephen Warren wrote: >> On 01/13/2014 07:21 AM, Thierry Reding wrote: >>> The head number of a given display controller is fixed in hardware and >>> required to program out

[PATCH 2/2] drm/tegra: Obtain head number from DT

2014-01-13 Thread Stephen Warren
On 01/13/2014 07:21 AM, Thierry Reding wrote: > The head number of a given display controller is fixed in hardware and > required to program outputs appropriately. Relying on the driver probe > order to determine this number will not work, since that could yield a > situation where the second head

[PATCH 1/2] drm/tegra: Fix possible CRTC mask for RGB outputs

2014-01-13 Thread Stephen Warren
On 01/13/2014 07:21 AM, Thierry Reding wrote: > The mask of possible CRTCs that an output (DRM encoder) can be attached > to is relative to the position within the DRM device's list of CRTCs. > Deferred probing can cause this to not match the pipe number associated > with a CRTC. Use the newly

[PATCH] drm/panel: update EDID BLOB in panel_simple_get_modes()

2014-01-09 Thread Stephen Warren
From: Stephen Warren <swar...@nvidia.com> This stashes away the EDID data so that the sysfs per-connector file "edid" can display it. Without this change, the "edid" file is always empty. Signed-off-by: Stephen Warren --- drivers/gpu/drm/panel/panel-simple.c | 1 + 1

[PATCH] drm/panel: Add support for Chungwa CLAA101WA01A panel

2014-01-07 Thread Stephen Warren
From: Stephen Warren <swar...@nvidia.com> The Chungwa CLAA101WA01A is a 10.1" 1366x768 panel, which can be supported by the simple panel driver. Signed-off-by: Stephen Warren --- .../bindings/panel/chunghwa,claa101wa01a.txt | 7 ++ drivers/gpu/drm/panel/pan

[PATCH 1/2] drm/panel: Add support for Samsung LTN101NT05 panel

2014-01-06 Thread Stephen Warren
On 12/21/2013 01:40 PM, Marc Dietrich wrote: > The Samsung LNT101NT05 10.1" WXVGA panel can be supported by the simple panel > driver. Thierry, I assume you'll take patch 1/2 throught the appropriate DRM tree.

[PATCH] drm/tegra: fix compile w/ CONFIG_DYNAMIC_DEBUG

2013-12-18 Thread Stephen Warren
From: Stephen Warren <swar...@nvidia.com> With CONFIG_DYNAMIC_DEBUG=y, the followin compile error occurs: drivers/gpu/drm/tegra/mipi-phy.c: In function ?mipi_dphy_timing_validate?: drivers/gpu/drm/tegra/mipi-phy.c:69:11: error: ?EINVAL? undeclared (first use in this function) drivers/g

[PATCH 00/31] ARM: tegra: use common reset and DMA bindings

2013-12-11 Thread Stephen Warren
On 11/15/2013 01:53 PM, Stephen Warren wrote: > From: Stephen Warren > > This series implements a common reset framework driver for Tegra, and > updates all relevant Tegra drivers to use it. It also removes the custom > DMA bindings and replaced them with the standard

[PATCH 00/31] ARM: tegra: use common reset and DMA bindings

2013-11-20 Thread Stephen Warren
On 11/20/2013 10:03 AM, Arnd Bergmann wrote: > On Wednesday 20 November 2013, Stephen Warren wrote: >>> +- #iommu-cells : Must be <1>. This dictates the length of DMA specifiers in >>> + client nodes' dmas properties. The specifier represents the DMA request >>>

[PATCH 00/31] ARM: tegra: use common reset and DMA bindings

2013-11-20 Thread Stephen Warren
On 11/20/2013 08:37 AM, Arnd Bergmann wrote: > On Friday 15 November 2013, Stephen Warren wrote: >> This series implements a common reset framework driver for Tegra, and >> updates all relevant Tegra drivers to use it. It also removes the custom >> DMA bindings and replaced t

[PATCH 10/31] ARM: tegra: pass reset to tegra_powergate_sequence_power_up()

2013-11-15 Thread Stephen Warren
From: Stephen Warren <swar...@nvidia.com> Tegra's clock driver now provides an implementation of the common reset API (include/linux/reset.h). Use this instead of the old Tegra- specific API; that will soon be removed. Cc: treding at nvidia.com Cc: pdeschrijver at nvidia.com Cc: linux

[PATCH 09/31] drm/tegra: use reset framework

2013-11-15 Thread Stephen Warren
From: Stephen Warren <swar...@nvidia.com> Tegra's clock driver now provides an implementation of the common reset API (include/linux/reset.h). Use this instead of the old Tegra- specific API; that will soon be removed. Cc: treding at nvidia.com Cc: pdeschrijver at nvidia.com Cc: linux

[PATCH 00/31] ARM: tegra: use common reset and DMA bindings

2013-11-15 Thread Stephen Warren
From: Stephen Warren <swar...@nvidia.com> This series implements a common reset framework driver for Tegra, and updates all relevant Tegra drivers to use it. It also removes the custom DMA bindings and replaced them with the standard DMA DT bindings. Historically, the Tegra clock driv

[PATCH] drm/tegra: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

2013-11-06 Thread Stephen Warren
On 11/06/2013 12:53 AM, Duan Jiong wrote: > This patch fixes coccinelle error regarding usage of IS_ERR and > PTR_ERR instead of PTR_ERR_OR_ZERO. > diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c > @@ -199,10 +199,7 @@ int tegra_bo_dumb_create(struct drm_file *file, struct

[PATCH -next] drm/tegra: fix return value check

2013-10-28 Thread Stephen Warren
On 10/28/2013 04:38 PM, Thierry Reding wrote: > On Mon, Oct 28, 2013 at 03:51:32PM -0600, Stephen Warren wrote: >> On 10/28/2013 02:53 AM, Thierry Reding wrote: >>> On Mon, Oct 21, 2013 at 11:34:07AM +0800, Wei Yongjun wrote: >>>> From: Wei Yongjun >>>

[PATCH -next] drm/tegra: fix return value check

2013-10-28 Thread Stephen Warren
On 10/28/2013 02:53 AM, Thierry Reding wrote: > On Mon, Oct 21, 2013 at 11:34:07AM +0800, Wei Yongjun wrote: >> From: Wei Yongjun >> >> In case of error, the function clk_get_parent() and >> devm_ioremap_resource() returns ERR_PTR() and never returns NULL. >> The NULL test in the return value

[PATCH v2 27/27] drm/tegra: Add Tegra114 gr2d support

2013-10-16 Thread Stephen Warren
On 10/16/2013 02:48 AM, Thierry Reding wrote: > On Tue, Oct 15, 2013 at 09:19:18AM -0600, Stephen Warren wrote: >> On 10/15/2013 02:37 AM, Thierry Reding wrote: >>> On Mon, Oct 14, 2013 at 12:14:47PM -0600, Stephen Warren >>> wrote: >>>> On 10/14/2013 08:00

[PATCH v2 26/27] drm/tegra: Add DSI support

2013-10-16 Thread Stephen Warren
On 10/16/2013 02:40 AM, Thierry Reding wrote: ... > Just to follow up with what we've discussed on IRC: I'll take a > stab at refactoring the debugfs file output into something more > generic that can possibly be leveraged by regmap as well. That > should provide a somewhat more lightweight

[PATCH v2 26/27] drm/tegra: Add DSI support

2013-10-15 Thread Stephen Warren
On 10/15/2013 02:33 AM, Thierry Reding wrote: > On Mon, Oct 14, 2013 at 12:16:48PM -0600, Stephen Warren wrote: >> On 10/14/2013 07:55 AM, Thierry Reding wrote: >>> On Fri, Oct 11, 2013 at 04:43:35PM -0600, Stephen Warren >>> wrote: >>>> On 10

[PATCH v2 27/27] drm/tegra: Add Tegra114 gr2d support

2013-10-15 Thread Stephen Warren
On 10/15/2013 02:37 AM, Thierry Reding wrote: > On Mon, Oct 14, 2013 at 12:14:47PM -0600, Stephen Warren wrote: >> On 10/14/2013 08:00 AM, Thierry Reding wrote: >>> On Mon, Oct 14, 2013 at 08:58:34AM +0300, Terje Bergstr?m >>> wrote: >>>> On 12.10.2013 01:4

[PATCH v2 17/27] drm/tegra: Add Tegra114 HDMI support

2013-10-15 Thread Stephen Warren
On 10/15/2013 02:13 AM, Thierry Reding wrote: > On Mon, Oct 14, 2013 at 12:10:21PM -0600, Stephen Warren wrote: >> On 10/12/2013 05:41 AM, Thierry Reding wrote: >>> On Fri, Oct 11, 2013 at 04:19:19PM -0600, Stephen Warren >>> wrote: >>>> On 10/07/2013 02:

[PATCH v2 27/27] drm/tegra: Add Tegra114 gr2d support

2013-10-15 Thread Stephen Warren
On 10/14/2013 11:51 PM, Terje Bergstr?m wrote: > On 14.10.2013 21:14, Stephen Warren wrote: >> On 10/14/2013 08:00 AM, Thierry Reding wrote: >>> Yes, as long as the device tree files includes the most specific >>> value in the compatible this should stil

Re: [PATCH v2 16/27] drm/tegra: Add Tegra114 display controller support

2013-10-14 Thread Stephen Warren
On 10/12/2013 05:32 AM, Thierry Reding wrote: On Fri, Oct 11, 2013 at 04:14:27PM -0600, Stephen Warren wrote: On 10/07/2013 02:34 AM, Thierry Reding wrote: From: Mikko Perttunen mperttu...@nvidia.com The Tegra114 display controller is backwards-compatible with previous generations

Re: [PATCH v2 15/27] gpu: host1x: Add support for Tegra114

2013-10-14 Thread Stephen Warren
On 10/12/2013 05:24 AM, Thierry Reding wrote: On Fri, Oct 11, 2013 at 04:13:07PM -0600, Stephen Warren wrote: On 10/07/2013 02:34 AM, Thierry Reding wrote: Tegra114 uses a slightly updated version of host1x with an additional syncpoint. drivers/gpu/host1x/hw/host1x02.c| 42

Re: [PATCH v2 17/27] drm/tegra: Add Tegra114 HDMI support

2013-10-14 Thread Stephen Warren
On 10/12/2013 05:41 AM, Thierry Reding wrote: On Fri, Oct 11, 2013 at 04:19:19PM -0600, Stephen Warren wrote: On 10/07/2013 02:34 AM, Thierry Reding wrote: From: Mikko Perttunen mperttu...@nvidia.com Tegra114 TMDS configuration requires a new peak_current field and the driver current

Re: [PATCH v2 27/27] drm/tegra: Add Tegra114 gr2d support

2013-10-14 Thread Stephen Warren
On 10/13/2013 11:58 PM, Terje Bergström wrote: On 12.10.2013 01:43, Stephen Warren wrote: On 10/07/2013 02:34 AM, Thierry Reding wrote: The gr2d hardware in Tegra114 is compatible with that of Tegra20 and Tegra30. No functionaly changes are required. Similarly here, if the HW is 100

Re: [PATCH v2 27/27] drm/tegra: Add Tegra114 gr2d support

2013-10-14 Thread Stephen Warren
On 10/14/2013 08:00 AM, Thierry Reding wrote: On Mon, Oct 14, 2013 at 08:58:34AM +0300, Terje Bergström wrote: On 12.10.2013 01:43, Stephen Warren wrote: On 10/07/2013 02:34 AM, Thierry Reding wrote: The gr2d hardware in Tegra114 is compatible with that of Tegra20 and Tegra30. No functionaly

Re: [PATCH v2 26/27] drm/tegra: Add DSI support

2013-10-14 Thread Stephen Warren
On 10/14/2013 07:55 AM, Thierry Reding wrote: On Fri, Oct 11, 2013 at 04:43:35PM -0600, Stephen Warren wrote: On 10/07/2013 02:34 AM, Thierry Reding wrote: This commit adds support for both DSI outputs found on Tegra. Only very minimal functionality is implemented, so advanced features like

Re: [PATCH v2 14/27] drm/tegra: Move driver to DRM tree

2013-10-11 Thread Stephen Warren
On 10/07/2013 02:34 AM, Thierry Reding wrote: In order to subsystem-wide changes easier, move the Tegra DRM driver ^^ make ? ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 15/27] gpu: host1x: Add support for Tegra114

2013-10-11 Thread Stephen Warren
On 10/07/2013 02:34 AM, Thierry Reding wrote: Tegra114 uses a slightly updated version of host1x with an additional syncpoint. drivers/gpu/host1x/hw/host1x02.c| 42 + drivers/gpu/host1x/hw/host1x02.h| 26 +++ drivers/gpu/host1x/hw/hw_host1x02_channel.h | 121

Re: [PATCH v2 16/27] drm/tegra: Add Tegra114 display controller support

2013-10-11 Thread Stephen Warren
On 10/07/2013 02:34 AM, Thierry Reding wrote: From: Mikko Perttunen mperttu...@nvidia.com The Tegra114 display controller is backwards-compatible with previous generations of the Tegra SoC. No code changes are required. If the HW is backwards-compatible, then there's no need to add extra

Re: [PATCH v2 17/27] drm/tegra: Add Tegra114 HDMI support

2013-10-11 Thread Stephen Warren
On 10/07/2013 02:34 AM, Thierry Reding wrote: From: Mikko Perttunen mperttu...@nvidia.com Tegra114 TMDS configuration requires a new peak_current field and the driver current override bit has changed position. diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c

Re: [PATCH v2 17/27] drm/tegra: Add Tegra114 HDMI support

2013-10-11 Thread Stephen Warren
On 10/11/2013 04:19 PM, Stephen Warren wrote: On 10/07/2013 02:34 AM, Thierry Reding wrote: From: Mikko Perttunen mperttu...@nvidia.com Tegra114 TMDS configuration requires a new peak_current field and the driver current override bit has changed position. diff --git a/drivers/gpu/drm/tegra

Re: [PATCH v2 22/27] drm/panel: Add simple panel support

2013-10-11 Thread Stephen Warren
On 10/07/2013 02:34 AM, Thierry Reding wrote: Add a driver for simple panels. Such panels can have a regulator that provides the supply voltage and a separate GPIO to enable the panel. Optionally the panels can have a backlight associated with them so it can be enabled or disabled according to

Re: [PATCH v2 25/27] gpu: host1x: Add MIPI pad calibration support

2013-10-11 Thread Stephen Warren
On 10/07/2013 02:34 AM, Thierry Reding wrote: This driver adds support to perform calibration of the MIPI pads for CSI and DSI. diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c +int tegra_mipi_calibrate(struct device *device) ... + err =

Re: [PATCH v2 26/27] drm/tegra: Add DSI support

2013-10-11 Thread Stephen Warren
On 10/07/2013 02:34 AM, Thierry Reding wrote: This commit adds support for both DSI outputs found on Tegra. Only very minimal functionality is implemented, so advanced features like ganged mode won't work. Due to the lack of other test hardware, some sections of the driver are hardcoded to

Re: [PATCH v2 27/27] drm/tegra: Add Tegra114 gr2d support

2013-10-11 Thread Stephen Warren
On 10/07/2013 02:34 AM, Thierry Reding wrote: The gr2d hardware in Tegra114 is compatible with that of Tegra20 and Tegra30. No functionaly changes are required. Similarly here, if the HW is 100% backwards-compatible, there's no need to add compatible values to the driver.

Re: [PATCHv4 0/5] gpu: host1x: Add runtime pm support

2013-10-08 Thread Stephen Warren
on the patches. The series, briefly, Reviewed-by: Stephen Warren swar...@nvidia.com ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] simplefb: fix unmapping fb during destruction

2013-10-02 Thread Stephen Warren
the device's remove, yet after .fb_destroy, the memory is unmapped, which would be dangerous if the FB can be re-started. If that's not an issue, this patch seems fine, so Acked-by: Stephen Warren swar...@nvidia.com I know that simplefb was supposed to stay as simple as possible but I really think

Re: [PATCHv3 2/4] drm/tegra: Add runtime pm support for gr2d

2013-10-01 Thread Stephen Warren
On 09/24/2013 06:05 AM, Arto Merilainen wrote: From: Mayuresh Kulkarni mkulka...@nvidia.com This far we have enabled gr2d clock on device probe and disabled it on device deinitialisation. This patch adds runtime pm support for the hardware unit allowing dynamic power management. If pm

Re: [PATCHv3 4/4] gpu: host1x: Add runtime pm support for host1x

2013-10-01 Thread Stephen Warren
On 09/24/2013 06:05 AM, Arto Merilainen wrote: From: Mayuresh Kulkarni mkulka...@nvidia.com This patch adds runtime pm support for host1x hardware unit. This allows host1x clock to be turned off when it is idle. If pm runtime is not configured, we enable host1x clock in device probe and

Re: [PATCH v2 1/6] host1x: hdmi: Add Tegra114 support

2013-09-04 Thread Stephen Warren
On 08/28/2013 09:48 AM, Mikko Perttunen wrote: Add Tegra114 TMDS configuration, add new peak_current field and use new place for drive current override bit on Tegra114 platform. diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c static struct of_device_id host1x_of_match[] = {

Re: [PATCH v2 2/6] host1x: hdmi: Detect whether display is connected with HDMI or DVI

2013-09-04 Thread Stephen Warren
On 08/28/2013 09:48 AM, Mikko Perttunen wrote: Use EDID data to determine whether the display supports HDMI or just DVI. This used to be hardcoded to be HDMI, which broke support for DVI displays that couldn't understand the interspersed audio/other data. If the EDID data isn't available,

Re: [PATCH v2 3/6] host1x: hdmi: Enable Vdd earlier for hotplug/DDC

2013-09-04 Thread Stephen Warren
On 08/28/2013 09:48 AM, Mikko Perttunen wrote: The Vdd regulator used to be enabled only at tegra_output_hdmi_enable, which is called after a sink is detected. However, the HDMI hotplug pin works by returning the voltage supplied by the Vdd pin, so this meant that the hotplug pin was never

Re: [PATCH v2 4/6] clk: tegra114: Initialize clocks needed for HDMI

2013-09-04 Thread Stephen Warren
On 08/28/2013 09:48 AM, Mikko Perttunen wrote: Add host1x, disp1 and disp2 clocks to the clock initialization table. These clocks are required for HDMI support. This patch should be sent to Mike Turquette so it can be taken through the clock tree. ___

Re: [PATCH v2 5/6] ARM: tegra: Add host1x, DC and HDMI to Tegra114 device tree

2013-09-04 Thread Stephen Warren
On 08/28/2013 09:48 AM, Mikko Perttunen wrote: Add host1x, DC (display controller) and HDMI devices to Tegra114 device tree. Patches 5 and 6 should be sent separately to the Tegra maintainer (me) to be taken through the Tegra tree. ___ dri-devel

Re: [PATCH v2 3/6] host1x: hdmi: Enable Vdd earlier for hotplug/DDC

2013-09-04 Thread Stephen Warren
On 09/04/2013 04:03 PM, Mikko Perttunen wrote: On 09/04/2013 09:44 PM, Stephen Warren wrote: On 08/28/2013 09:48 AM, Mikko Perttunen wrote: The Vdd regulator used to be enabled only at tegra_output_hdmi_enable, which is called after a sink is detected. However, the HDMI hotplug pin works

Re: [RFC 2/3] drm/panel: Add simple panel support

2013-09-03 Thread Stephen Warren
On 08/30/2013 09:25 AM, Thierry Reding wrote: Add a driver for simple panels. Such panels can have a regulator that provides the supply voltage and a separate GPIO to enable the panel. Optionally the panels can have a backlight associated with them so it can be enabled or disabled according to

Re: [RFC 2/3] drm/panel: Add simple panel support

2013-09-03 Thread Stephen Warren
On 08/30/2013 01:24 PM, Kumar Gala wrote: On Aug 30, 2013, at 10:25 AM, Thierry Reding wrote: Add a driver for simple panels. Such panels can have a regulator that provides the supply voltage and a separate GPIO to enable the panel. Optionally the panels can have a backlight associated

[patch 2/2] gpu: host1x: returning success instead of -ENOMEM

2013-08-23 Thread Stephen Warren
On 08/23/2013 04:19 AM, Dan Carpenter wrote: > There is a mistake here so it returns PTR_ERR(NULL) which is success > instead of -ENOMEM. > > Signed-off-by: Dan Carpenter > --- > I can't compile this. For the record, just do: export CROSS_COMPILE=xxx make ARCH=arm tegra_defconfig make ARCH=arm

Re: [patch 2/2] gpu: host1x: returning success instead of -ENOMEM

2013-08-23 Thread Stephen Warren
On 08/23/2013 04:19 AM, Dan Carpenter wrote: There is a mistake here so it returns PTR_ERR(NULL) which is success instead of -ENOMEM. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com --- I can't compile this. For the record, just do: export CROSS_COMPILE=xxx make ARCH=arm

[PATCHv2 5/5] ARM: dts: Add dt binding documentation for exynos rotator

2013-08-09 Thread Stephen Warren
On 08/09/2013 07:15 AM, Tomasz Figa wrote: > Hi Chanho, > > On Friday 09 of August 2013 16:40:53 Chanho Park wrote: >> This patch describes each nodes of rotator and specifies a example how to >> bind it. >> diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt >> +* Samsung

Re: [PATCHv2 5/5] ARM: dts: Add dt binding documentation for exynos rotator

2013-08-09 Thread Stephen Warren
On 08/09/2013 07:15 AM, Tomasz Figa wrote: Hi Chanho, On Friday 09 of August 2013 16:40:53 Chanho Park wrote: This patch describes each nodes of rotator and specifies a example how to bind it. diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt +* Samsung Image Rotator

[PATCH v2] drm: provide agp dummies for CONFIG_AGP=n

2013-08-08 Thread Stephen Warren
Fixes a build-regression introduced by: > > commit 28ec711cd427f8b61f73712a43b8100ba8ca933b > Author: David Herrmann > Date: Sat Jul 27 16:37:00 2013 +0200 > > drm/agp: move AGP cleanup paths to drm_agpsupport.c Tested-by: Stephen Warren

Build break due to 28ec711 "drm/agp: move AGP cleanup paths to drm_agpsupport.c"

2013-08-08 Thread Stephen Warren
On 08/08/2013 12:13 PM, David Herrmann wrote: > Hi > > On Thu, Aug 8, 2013 at 8:00 PM, Stephen Warren > wrote: >> In next-20130808, building tegra_defconfig for ARM yields: >> >>> drivers/built-in.o: In function `drm_lastclose': >>> /home/swarren/share

  1   2   3   4   >