[RISC-V] [SIG-toolchain] Meeting cancelled (Dec 14, 2023)

2023-12-14 Thread jiawei
Hi all, Today's meeting will be cancelled. The next RISC-V GNU Toolchain meeting will be held on Jan 11: https://docs.google.com/document/d/1JSs-BSlPJ3QYbAb-Add1TlbYx0nOT1ur3jcsITIJ01U/edit?usp=sharing Please let me know if you have topics want to discuss in the meeting. BR,

Re: Discussion about arm/aarch64 testcase failures seen with patch for PR111673

2023-12-14 Thread Richard Earnshaw (lists) via Gcc
On 14/12/2023 07:17, Surya Kumari Jangala via Gcc wrote: > Hi Richard, > Thanks a lot for your response! > > Another failure reported by the Linaro CI is as follows: > > Running gcc:gcc.dg/dg.exp ... > FAIL: gcc.dg/ira-shrinkwrap-prep-1.c scan-rtl-dump pro_and_epilogue > "Performing

Re: Deprecating nds32-*-linux-* target for GCC 14 (and removing it for GCC 15)

2023-12-14 Thread Jeff Law via Gcc
On 12/13/23 23:25, Chung-Ju Wu wrote: As for gdbsim/openocd, I remember that we did have nds32 contributions previously:   - gdb: http://sourceware.org/ml/gdb-patches/2013-07/msg00223.html   - openocd: http://openocd.zylin.com/1259 I suppose they have recently been dropped from the

Re: issue: unexpected results in optimizations

2023-12-14 Thread James K. Lowden
On Tue, 12 Dec 2023 09:39:58 +0100 David Brown via Gcc wrote: > If you have fixed the immediate problems in the code, add the > "-fsanitize=undefined" flag before running it. That will do run-time > undefined behaviour checks. I would like to understand that better, for reasons you might

gcc-11-20231214 is now available

2023-12-14 Thread GCC Administrator via Gcc
Snapshot gcc-11-20231214 is now available on https://gcc.gnu.org/pub/gcc/snapshots/11-20231214/ and on various mirrors, see https://gcc.gnu.org/mirrors.html for details. This snapshot has been generated from the GCC 11 git branch with the following options: git://gcc.gnu.org/git/gcc.git branch

Re: [PATCH] i386: Remove RAO-INT from Grand Ridge

2023-12-14 Thread Hongtao Liu
On Thu, Dec 14, 2023 at 10:55 AM Haochen Jiang wrote: > > Hi all, > > According to ISE050 published at the end of September, RAO-INT will not > be in Grand Ridge anymore. This patch aims to remove it. > > The documentation comes following: > > https://cdrdv2.intel.com/v1/dl/getContent/671368 > >

[Bug rtl-optimization/113017] New: ICE in delete_unmarked_insns, at dce.cc:653

2023-12-14 Thread fkastl at suse dot cz via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113017 Bug ID: 113017 Summary: ICE in delete_unmarked_insns, at dce.cc:653 Product: gcc Version: 14.0 Status: UNCONFIRMED Keywords: ice-on-valid-code, needs-bisection

Re: [PATCH v4] A new copy propagation and PHI elimination pass

2023-12-14 Thread Filip Kastl
Successfully bootstrapped and regtested on x86_64-linux. Will push to master. Filip

Re: [PATCH] RISC-V: fix scalar crypto pattern

2023-12-14 Thread Christoph Müllner
On Thu, Dec 14, 2023 at 1:40 AM Jeff Law wrote: > On 12/13/23 02:03, Christoph Müllner wrote: > > On Wed, Dec 13, 2023 at 9:22 AM Liao Shihua wrote: > >> > >> In Scalar Crypto Built-In functions, some require immediate parameters, > >> But register_operand are incorrectly used in the pattern. >

Re: [PATCH] expmed: Get vec_extract element mode from insn_data, [PR112999]

2023-12-14 Thread Richard Sandiford
Robin Dapp writes: > Hi, > > this is a bit of a follow up of the latest expmed change. > > In extract_bit_field_1 we try to get a better vector mode before > extracting from it. Better refers to the case when the requested target > mode does not equal the inner mode of the vector to extract from

[Bug rtl-optimization/113019] New: [NOT A BUG] Multi-architecture binaries for Linux

2023-12-14 Thread aros at gmx dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113019 Bug ID: 113019 Summary: [NOT A BUG] Multi-architecture binaries for Linux Product: gcc Version: unknown Status: UNCONFIRMED Severity: normal Priority: P3

[Bug target/113014] RISC-V: Redundant zeroing instructions in reduction due to r14-3998-g6223ea766daf7c

2023-12-14 Thread rdapp at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113014 --- Comment #4 from Robin Dapp --- Richard has posted it and asked for reviews. I have tested it and we have several testsuite regressions with it but no severe ones. Most or all of them are dump fails because we combine into vx variants that

Re: [PATCH] match.pd: Simplify (t * u) / (t * v) [PR112994]

2023-12-14 Thread Richard Biener
> Am 14.12.2023 um 08:37 schrieb Jakub Jelinek : > > Hi! > > On top of the previously posted patch, this simplifies say (x * 16) / (x * 4) > into 4. Unlike the previous pattern, this is something we didn't fold > previously on GENERIC, so I think it shouldn't be all wrapped with #if >

[PATCH] LoongArch: Fix incorrect code generation for sad pattern

2023-12-14 Thread Jiahao Xu
When I attempt to enable vect_usad_char effective target for LoongArch, some tests fail. These tests fail because the sad pattern generates bad code. This patch to fixed them, for sad patterns, use zero expansion instead of sign expansion for reduction. Currently, we are fixing failed vectorized

[Bug rtl-optimization/113003] ICE: in expand_mult, at expmed.cc:3603 at -O with __builtin_mul_overflow_p() and _BitInt()

2023-12-14 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113003 --- Comment #1 from Jakub Jelinek --- Slightly reduced: int foo (_BitInt(7) x) { return __builtin_mul_overflow_p (x, 1046555807606105294475452482332716433408wb, 0); } Ugh, another special case where we don't detect the need to lower, next to

[Bug target/113014] RISC-V: Redundant zeroing instructions in reduction due to r14-3998-g6223ea766daf7c

2023-12-14 Thread juzhe.zhong at rivai dot ai via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113014 --- Comment #3 from JuzheZhong --- (In reply to Robin Dapp from comment #2) > Yes, that's right. It seems that I don't need to optimize it since we will eventually have late-combine. Could you tell what status of late-combine PASS ? Will it

[Bug target/112986] s390x gcc O2, O3: Incorrect logic operation in < comparison with the same values

2023-12-14 Thread xry111 at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112986 --- Comment #9 from Xi Ruoyao --- *** Bug 112329 has been marked as a duplicate of this bug. ***

[Bug target/112992] Inefficient vector initialization using vec_duplicate/broadcast

2023-12-14 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112992 --- Comment #8 from GCC Commits --- The master branch has been updated by hongtao Liu : https://gcc.gnu.org/g:be0ff0866a6f072ccfbbb3a3c2079adf1db51aa1 commit r14-6534-gbe0ff0866a6f072ccfbbb3a3c2079adf1db51aa1 Author: liuhongt Date: Wed Dec

[Bug target/112998] s390x: Incorrect code generation

2023-12-14 Thread xry111 at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112998 Xi Ruoyao changed: What|Removed |Added Resolution|--- |DUPLICATE CC|

[Bug target/112329] Faulty arithmetic comparison in O2, O3 of s390x-gcc with -march=z13

2023-12-14 Thread xry111 at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112329 Xi Ruoyao changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[Bug target/112986] s390x gcc O2, O3: Incorrect logic operation in < comparison with the same values

2023-12-14 Thread xry111 at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112986 --- Comment #8 from Xi Ruoyao --- *** Bug 112998 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/113018] New: ICE in gimple_convert, gimple-fold.cc during the SLP pass

2023-12-14 Thread fkastl at suse dot cz via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113018 Bug ID: 113018 Summary: ICE in gimple_convert, gimple-fold.cc during the SLP pass Product: gcc Version: 14.0 Status: UNCONFIRMED Keywords: ice-on-valid-code,

[Bug middle-end/80283] [11/12/13/14 Regression] bad SIMD register allocation

2023-12-14 Thread rsandifo at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80283 --- Comment #39 from Richard Sandiford --- (In reply to Andrew Pinski from comment #38) > For aarch64, the test from comment #11 is so much worse on the trunk than in > GCC 13.2.0. I've been working on a fix for that. I'm hoping to post it

Re: [PATCH] Middle-end: Adjust decrement IV style partial vectorization COST model

2023-12-14 Thread Richard Biener
Am 14.12.2023 um 09:28 schrieb juzhe.zh...@rivai.ai: Hi, Richard.I have a question about the decrement IV costing since I find the reduction case is generating inferior codegen.reduc_plus_int: mv a3,a0 ble a1,zero,.L7 addiw a5,a1,-1 li a4,2 bleu a5,a4,.L8 vsetivli zero,4,e32,m1,ta,ma srliw

[Bug libstdc++/113007] `std::variant` converting constructor and `operator=` compile while the C++ Standard says they must not

2023-12-14 Thread paul.skeptic at yandex dot ru via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113007 --- Comment #4 from Pavel Novikov --- Interesting. Thank you for explanation. Indeed the standard says all over that narrowing conversion in initialization is prohibited, though this code compiles: int i = 42; bool b[] = {i}; //

[Bug tree-optimization/112994] [12/13/14 Regression] Missed optimization for redundancy computation elimination because pattern is broken

2023-12-14 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112994 --- Comment #8 from GCC Commits --- The master branch has been updated by Jakub Jelinek : https://gcc.gnu.org/g:90c9403f89d3c55512ae83dd20e2023c2e4430f4 commit r14-6537-g90c9403f89d3c55512ae83dd20e2023c2e4430f4 Author: Jakub Jelinek Date:

[Bug tree-optimization/112994] [12/13/14 Regression] Missed optimization for redundancy computation elimination because pattern is broken

2023-12-14 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112994 --- Comment #9 from GCC Commits --- The master branch has been updated by Jakub Jelinek : https://gcc.gnu.org/g:2c92551405bc8616f456e5cbc696ab0292c7ff00 commit r14-6538-g2c92551405bc8616f456e5cbc696ab0292c7ff00 Author: Jakub Jelinek Date:

[PATCH] Revert "RISC-V: Add avail interface into function_group_info"

2023-12-14 Thread Feng Wang
This reverts commit ce7e66787b5b4ad385b21756da5a89171d233ddc. Will refactor this part in the same way as aarch64 sve. gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (DEF_RVV_FUNCTION): Revert changes.

[Bug rtl-optimization/113002] ICE in commit_one_edge_insertion, at cfgrtl.cc:2095 with new -finline-stringops

2023-12-14 Thread fkastl at suse dot cz via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113002 Filip Kastl changed: What|Removed |Added CC||fkastl at suse dot cz --- Comment #1

[Bug tree-optimization/111807] [14 Regression] ice in verify_sra_access_forest with -O1 and bitfields in some cases

2023-12-14 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111807 --- Comment #10 from GCC Commits --- The master branch has been updated by Martin Jambor : https://gcc.gnu.org/g:96e1978b213482fc4c25693b91ae2ead481af620 commit r14-6535-g96e1978b213482fc4c25693b91ae2ead481af620 Author: Martin Jambor Date:

[Bug tree-optimization/112678] [14 regression] Massive slowdown of compilation time with PGO since r14-5579-g20a3c74c347429

2023-12-14 Thread fkastl at suse dot cz via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112678 Filip Kastl changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

Re: Re: [PATCH] Middle-end: Adjust decrement IV style partial vectorization COST model

2023-12-14 Thread juzhe.zh...@rivai.ai
Thanks Richard. Let me clarify again to make sure I understand your comments correctly: Do you suggest not to model address cost here like other partial vectorization style (while_ult, avx512...etc). Then set COST = 1 since we only have SELECT_VL since beginning. At various cases we saw, COST=1

Re: [PATCH] RISC-V: fix scalar crypto pattern

2023-12-14 Thread Liao Shihua
Sorry, I was not aware of this patch. Since Jeff's patch was here first and also includes more tests, I propose to move forward with his patch (but I'm not a maintainer!). Therefore, I've reviewed Jeff's patch and replied to his email. FWIW: Jeff's patch can be found here:

[Bug target/113014] RISC-V: Redundant zeroing instructions in reduction due to r14-3998-g6223ea766daf7c

2023-12-14 Thread rdapp at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113014 --- Comment #2 from Robin Dapp --- Yes, that's right.

[Bug libstdc++/112997] _Unwind_Exception conflicts with void*. failed to build with clang

2023-12-14 Thread arsen at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112997 Arsen Arsenović changed: What|Removed |Added CC||arsen at gcc dot gnu.org --- Comment

Re: Re: [PATCH] Middle-end: Adjust decrement IV style partial vectorization COST model

2023-12-14 Thread juzhe.zh...@rivai.ai
Hi, Richard. I have a question about the decrement IV costing since I find the reduction case is generating inferior codegen. reduc_plus_int: mv a3,a0 ble a1,zero,.L7 addiw a5,a1,-1 li a4,2 bleu a5,a4,.L8 vsetivli zero,4,e32,m1,ta,ma srliw a4,a1,2 vmv.v.i v1,0 slli a4,a4,4 add a4,a4,a0 mv a5,a0

Re: [PR target/110201] Fix operand types for various scalar crypto insns

2023-12-14 Thread Christoph Müllner
On Tue, Jun 20, 2023 at 12:34 AM Jeff Law via Gcc-patches wrote: > > > A handful of the scalar crypto instructions are supposed to take a > constant integer argument 0..3 inclusive. A suitable constraint was > created and used for this purpose (D03), but the operand's predicate is >

Re: [PATCH] match.pd: Simplify (t * u) / v -> t * (u / v) [PR112994]

2023-12-14 Thread Richard Biener
> Am 14.12.2023 um 08:35 schrieb Jakub Jelinek : > > Hi! > > The following testcase is optimized just on GENERIC (using > strict_overflow_p = false; > if (TREE_CODE (arg1) == INTEGER_CST > && (tem = extract_muldiv (op0, arg1, code, NULL_TREE, >

[Bug rtl-optimization/113003] ICE: in expand_mult, at expmed.cc:3603 at -O with __builtin_mul_overflow_p() and _BitInt()

2023-12-14 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113003 --- Comment #2 from Jakub Jelinek --- int bar (unsigned __int128 x) { return __builtin_sub_overflow_p (340282366920938463463374607431768211457uwb, x, 0); } while it doesn't ICE is also something that has to be lowered and not left until

Re: [PATCH] LoongArch: Use the movcf2gr instruction to implement cstore4

2023-12-14 Thread Xi Ruoyao
On Thu, 2023-12-14 at 15:44 +0800, Jiahao Xu wrote: > The implementation of this patch has some issues. When I compile 521.wrf with > -Ofast -mlasx -flto -muse-movcf2gr, it results in an ICE: Indeed, creating CCCmode pseudos without a complete movfcc implementation is buggy. This patch needs a

[PATCH] expmed: Get vec_extract element mode from insn_data, [PR112999]

2023-12-14 Thread Robin Dapp
Hi, this is a bit of a follow up of the latest expmed change. In extract_bit_field_1 we try to get a better vector mode before extracting from it. Better refers to the case when the requested target mode does not equal the inner mode of the vector to extract from and we have an equivalent

Re: Re: [PATCH 4/5] [ifcvt] optimize x=c ? (y op const_int) : y by RISC-V Zicond like insns

2023-12-14 Thread Fei Gao
On 2023-12-11 13:38  Jeff Law wrote: > > > >On 12/5/23 01:12, Fei Gao wrote: >> op=[PLUS, MINUS, IOR, XOR, ASHIFT, ASHIFTRT, LSHIFTRT, ROTATE, ROTATERT, AND] >> >> Co-authored-by: Xiao Zeng >> >> gcc/ChangeLog: >> >>  * ifcvt.cc (noce_cond_zero_shift_op_supported): check if OP is >>shift

[Bug target/112112] Improper Arithmetic Type Conversion in s390x-linux-gnu-gcc

2023-12-14 Thread xry111 at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112112 Xi Ruoyao changed: What|Removed |Added CC||xry111 at gcc dot gnu.org

[Bug target/112986] s390x gcc O2, O3: Incorrect logic operation in < comparison with the same values

2023-12-14 Thread xry111 at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112986 --- Comment #10 from Xi Ruoyao --- *** Bug 112112 has been marked as a duplicate of this bug. ***

Re: Re: [PATCH 5/5] [ifcvt] optimize extension for x=c ? (y op z) : y by RISC-V Zicond like insns

2023-12-14 Thread Fei Gao
On 2023-12-11 13:46  Jeff Law wrote: > > > >On 12/5/23 01:12, Fei Gao wrote: >> SIGN_EXTEND, ZERO_EXTEND and SUBREG has been considered >> to support SImode in 64-bit machine. >> >> Co-authored-by: Xiao Zeng >> >> gcc/ChangeLog: >> >> * ifcvt.cc (noce_cond_zero_binary_op_supported): add support

Re: [committed] testsuite: Fix up target-enter-data-1.c on 32-bit targets

2023-12-14 Thread Julian Brown
On Thu, 14 Dec 2023 08:14:56 +0100 Jakub Jelinek wrote: > On Wed, Nov 29, 2023 at 11:43:05AM +, Julian Brown wrote: > > * c-c++-common/gomp/target-enter-data-1.c: Adjust scan > > output. > > struct bar { int num_vectors; double *vectors; }; > > is 16 bytes only on 64-bit targets, on

[Bug rtl-optimization/113019] [NOT A BUG] Multi-architecture binaries for Linux

2023-12-14 Thread ktkachov at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113019 ktkachov at gcc dot gnu.org changed: What|Removed |Added CC||ktkachov at gcc dot

Re: [PATCH] Revert "RISC-V: Add avail interface into function_group_info"

2023-12-14 Thread Kito Cheng
ok On Thu, Dec 14, 2023 at 8:08 PM Feng Wang wrote: > > This reverts commit ce7e66787b5b4ad385b21756da5a89171d233ddc. > Will refactor this part in the same way as aarch64 sve. > > gcc/ChangeLog: > > * config/riscv/riscv-vector-builtins-functions.def (DEF_RVV_FUNCTION): >

[Bug middle-end/112938] ice with -fstrub=internal

2023-12-14 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112938 --- Comment #5 from GCC Commits --- The master branch has been updated by Alexandre Oliva : https://gcc.gnu.org/g:37afeec8a635153ccd4e91bd686c93217706894d commit r14-6546-g37afeec8a635153ccd4e91bd686c93217706894d Author: Alexandre Oliva

[Bug middle-end/112938] ice with -fstrub=internal

2023-12-14 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112938 --- Comment #6 from GCC Commits --- The master branch has been updated by Alexandre Oliva : https://gcc.gnu.org/g:e1e71b4e0681974b3db41afa7fc18720a30d6848 commit r14-6547-ge1e71b4e0681974b3db41afa7fc18720a30d6848 Author: Alexandre Oliva

[Bug target/113001] [14 Regression] RISCV Zicond ICE: in extract_insn, at recog.cc:2812 with -O2 rv64gcv_zicond

2023-12-14 Thread rguenth at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113001 Richard Biener changed: What|Removed |Added Target Milestone|--- |14.0

[Bug tree-optimization/113018] ICE in gimple_convert, gimple-fold.cc during the SLP pass

2023-12-14 Thread rguenth at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113018 Richard Biener changed: What|Removed |Added Last reconfirmed||2023-12-14

[Bug c++/113021] New: [constexpr] gcc rejects initializing struct containing vector during constant evaluation depending if the struct also contains other member

2023-12-14 Thread miro.palmu at helsinki dot fi via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113021 Bug ID: 113021 Summary: [constexpr] gcc rejects initializing struct containing vector during constant evaluation depending if the struct also contains other member

Invitation: gccrs community call @ lun. 18 déc. 2023 11am - 11:30am (CET) (gcc-rust@gcc.gnu.org)

2023-12-14 Thread Arthur Cohen
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VTIMEZONE TZID:Europe/Paris X-LIC-LOCATION:Europe/Paris BEGIN:DAYLIGHT TZOFFSETFROM:+0100 TZOFFSETTO:+0200 TZNAME:CEST DTSTART:19700329T02

[Bug tree-optimization/112793] [11/12/13 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

2023-12-14 Thread rguenth at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793 Richard Biener changed: What|Removed |Added Target Milestone|14.0|11.5 Summary|[14

[Bug tree-optimization/111515] [14 Regression] Missed Dead Code Elimination since r14-4089-gd45ddc2c04e

2023-12-14 Thread rguenth at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111515 --- Comment #7 from Richard Biener --- So like the following which disables threading ending in a if (..) __builtin_unreachable (); branch when we thread to the _reachable_ side of it. We keep threading to the __builtin_unreachable ()

Re: Re: [PATCH] Middle-end: Adjust decrement IV style partial vectorization COST model

2023-12-14 Thread 钟居哲
Thanks a lot for the clarification. I send a patch to remove address memory cost: https://gcc.gnu.org/pipermail/gcc-patches/2023-December/640595.html for decremnt IV/SELECT_VL. And I have tested various cases that are all get better codegen in RVV. juzhe.zh...@rivai.ai From: Richard Biener

[Bug debug/113000] Generate BTF always in early-finish regardless of CO-RE

2023-12-14 Thread rguenth at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113000 --- Comment #1 from Richard Biener --- Note you then need a way to cope with LTO.

[Bug analyzer/112655] analyzer/infinite-loop.cc:75: Possible performance problem ?

2023-12-14 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112655 --- Comment #2 from GCC Commits --- The master branch has been updated by David Malcolm : https://gcc.gnu.org/g:8cf5afba5dc482fe7063654720bfb0c45354998c commit r14-6549-g8cf5afba5dc482fe7063654720bfb0c45354998c Author: David Malcolm Date:

[PATCH] tree-optimization/112793 - SLP of constant/external code-generated twice

2023-12-14 Thread Richard Biener
The following makes the attempt at code-generating a constant/external SLP node twice well-formed as that can happen when partitioning BB vectorization attempts where we keep constants/externals unpartitioned. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR

[Bug tree-optimization/112793] [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

2023-12-14 Thread cvs-commit at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793 --- Comment #13 from GCC Commits --- The master branch has been updated by Richard Biener : https://gcc.gnu.org/g:d782ec8362eadc3169286eb1e39c631effd02323 commit r14-6550-gd782ec8362eadc3169286eb1e39c631effd02323 Author: Richard Biener Date:

Re: [PATCH v7] libgfortran: Replace mutex with rwlock

2023-12-14 Thread Richard Earnshaw (lists)
On 09/12/2023 15:39, Lipeng Zhu wrote: > This patch try to introduce the rwlock and split the read/write to > unit_root tree and unit_cache with rwlock instead of the mutex to > increase CPU efficiency. In the get_gfc_unit function, the percentage > to step into the insert_unit function is around

Re: [PATCH] expmed: Get vec_extract element mode from insn_data, [PR112999]

2023-12-14 Thread Richard Sandiford
Robin Dapp writes: >> It looks like: >> >> FOR_EACH_MODE_FROM (new_mode, new_mode) >> if (known_eq (GET_MODE_SIZE (new_mode), GET_MODE_SIZE (GET_MODE (op0))) >> && known_eq (GET_MODE_UNIT_SIZE (new_mode), GET_MODE_SIZE (tmode)) >> && targetm.vector_mode_supported_p

[Bug sanitizer/113012] [13/14 regression] ICE when building xorg-server with -fsanitize=undefined

2023-12-14 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113012 --- Comment #5 from Jakub Jelinek --- (In reply to Andrew Pinski from comment #3) > Note I am not shocked that xorg has undefined code in it too. Do you know about any large package which doesn't have any undefined code in it? Anyway, this is

RE: [PATCH 9/21]middle-end: implement vectorizable_early_exit for codegen of exit code

2023-12-14 Thread Richard Biener
On Wed, 13 Dec 2023, Tamar Christina wrote: > > > > else if (vect_use_mask_type_p (stmt_info)) > > > > { > > > > unsigned int precision = stmt_info->mask_precision; > > > > scalar_type = build_nonstandard_integer_type (precision, 1); > > > > vectype =

In 'gcc/gimple-ssa-sccopy.cc', '#define INCLUDE_ALGORITHM' instead of '#include ' (was: [PATCH v4] A new copy propagation and PHI elimination pass)

2023-12-14 Thread Thomas Schwinge
Hi! On 2023-12-13T17:12:11+0100, Filip Kastl wrote: > --- /dev/null > +++ b/gcc/gimple-ssa-sccopy.cc > +#include Pushed to master branch commit 65e41f4fbfc539c5cc429c684176f8ea39f4b8f2 "In 'gcc/gimple-ssa-sccopy.cc', '#define INCLUDE_ALGORITHM' instead of '#include '", see attached. Grüße

Re: [PATCH] middle-end: Fix up constant handling in emit_conditional_move [PR111260]

2023-12-14 Thread Richard Biener
On Wed, Dec 13, 2023 at 5:51 PM Andrew Pinski wrote: > > After r14-2667-gceae1400cf24f329393e96dd9720, we force a constant to a > register > if it is shared with one of the other operands. The problem is used the > comparison > mode for the register but that could be different from the operand

Re: [PATCH v3 4/5] Add support for target_version attribute

2023-12-14 Thread Richard Sandiford
Andrew Carlotti writes: > This patch adds support for the "target_version" attribute to the middle > end and the C++ frontend, which will be used to implement function > multiversioning in the aarch64 backend. > > On targets that don't use the "target" attribute for multiversioning, > there is no

Re: [PATCH] RISC-V: fix scalar crypto pattern

2023-12-14 Thread Jeff Law
On 12/14/23 02:48, Christoph Müllner wrote: On Thu, Dec 14, 2023 at 1:40 AM Jeff Law wrote: On 12/13/23 02:03, Christoph Müllner wrote: On Wed, Dec 13, 2023 at 9:22 AM Liao Shihua wrote: In Scalar Crypto Built-In functions, some require immediate parameters, But register_operand are

[Bug target/113022] New: GCN offloading bricked by "amdgcn: Work around XNACK register allocation problem"

2023-12-14 Thread tschwinge at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113022 Bug ID: 113022 Summary: GCN offloading bricked by "amdgcn: Work around XNACK register allocation problem" Product: gcc Version: 14.0 Status: UNCONFIRMED

[PATCH 1/4; v3] options: add gcc/regenerate-opt-urls.py

2023-12-14 Thread David Malcolm
Changed in v3: - Makefile.in: added OPT_URLS_HTML_DEPS and a comment Changed in v2: - added convenience targets to Makefile for regenerating the .opt.urls files, and for running unit tests for the generation code - parse gdc and gfortran documentation, and create LangUrlSuffix_{lang} directives

[COMMITTED 2/4] libgrust: Add entry for maintainers

2023-12-14 Thread Arthur Cohen
From: Pierre-Emmanuel Patry ChangeLog: * MAINTAINERS: Add maintainers for libgrust. contrib/ChangeLog: * gcc-changelog/git_commit.py: Add libgrust. Co-authored-by: Arthur Cohen Signed-off-by: Pierre-Emmanuel Patry --- MAINTAINERS | 1 +

[COMMITTED 2/4] libgrust: Add entry for maintainers

2023-12-14 Thread Arthur Cohen
From: Pierre-Emmanuel Patry ChangeLog: * MAINTAINERS: Add maintainers for libgrust. contrib/ChangeLog: * gcc-changelog/git_commit.py: Add libgrust. Co-authored-by: Arthur Cohen Signed-off-by: Pierre-Emmanuel Patry --- MAINTAINERS | 1 +

[COMMITTED 4/4] build: Add libgrust as compilation modules

2023-12-14 Thread Arthur Cohen
From: Pierre-Emmanuel Patry Define the libgrust directory as a host compilation module as well as for targets. Disable target libgrust if we're not building target libstdc++. ChangeLog: * Makefile.def: Add libgrust as host & target module. * configure.ac: Add libgrust to host

[COMMITTED 4/4] build: Add libgrust as compilation modules

2023-12-14 Thread Arthur Cohen
From: Pierre-Emmanuel Patry Define the libgrust directory as a host compilation module as well as for targets. Disable target libgrust if we're not building target libstdc++. ChangeLog: * Makefile.def: Add libgrust as host & target module. * configure.ac: Add libgrust to host

Re: [PATCH] expmed: Get vec_extract element mode from insn_data, [PR112999]

2023-12-14 Thread Robin Dapp
> It looks like: > > FOR_EACH_MODE_FROM (new_mode, new_mode) > if (known_eq (GET_MODE_SIZE (new_mode), GET_MODE_SIZE (GET_MODE (op0))) > && known_eq (GET_MODE_UNIT_SIZE (new_mode), GET_MODE_SIZE (tmode)) > && targetm.vector_mode_supported_p (new_mode) >

[Bug rtl-optimization/113019] [NOT A BUG] Multi-architecture binaries for Linux

2023-12-14 Thread arsen at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113019 Arsen Arsenović changed: What|Removed |Added CC||arsen at gcc dot gnu.org --- Comment

Re: [PATCH v7] libgfortran: Replace mutex with rwlock

2023-12-14 Thread Jakub Jelinek
On Thu, Dec 14, 2023 at 01:29:01PM +0100, Thomas Schwinge wrote: > > Sure, I will look into that. > > > > BTW, I didn’t have the PowerPC in hands, do you mind granting the access of > > your > > test environment to me to help reproduce the issue? > > That's unfortunately not possible: it's

Re: Re: [PATCH] Middle-end: Adjust decrement IV style partial vectorization COST model

2023-12-14 Thread Richard Biener
On Thu, 14 Dec 2023, juzhe.zh...@rivai.ai wrote: > Thanks Richard. > > Let me clarify again to make sure I understand your comments correctly: > > Do you suggest not to model address cost here like other partial > vectorization style (while_ult, avx512...etc). Then set COST = 1 since > we

[Bug tree-optimization/113013] [12/13/14 regression] ICE in fold_convert_loc with -fsanitize=undefined

2023-12-14 Thread siddhesh at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113013 Siddhesh Poyarekar changed: What|Removed |Added Keywords|ice-on-valid-code |ice-on-invalid-code

[PATCH] aarch64: Improve handling of accumulators in early-ra

2023-12-14 Thread Richard Sandiford
Being very simplistic, early-ra just models an allocno's live range as a single interval. This doesn't work well for single-register accumulators that are updated multiple times in a loop, since in SSA form, each intermediate result will be a separate SSA name and will remain separate from the

[Bug c++/113020] New: Explicit template instantiation of template specialization using a template base class fails after extern template declaration with linker error

2023-12-14 Thread adrian at woeltche dot de via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113020 Bug ID: 113020 Summary: Explicit template instantiation of template specialization using a template base class fails after extern template declaration with linker error

[Bug libstdc++/113007] `std::variant` converting constructor and `operator=` compile while the C++ Standard says they must not

2023-12-14 Thread redi at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113007 --- Comment #5 from Jonathan Wakely --- (In reply to Pavel Novikov from comment #4) > Indeed the standard says all over that narrowing conversion in > initialization is prohibited, though this code compiles: > > int i = 42; > bool b[]

[Bug rtl-optimization/113019] [NOT A BUG] Multi-architecture binaries for Linux

2023-12-14 Thread aros at gmx dot com via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113019 --- Comment #5 from Artem S. Tashkinov --- (In reply to ktkachov from comment #1) > GCC provides the Function Multiversioning feature that's supported on some > architectures: > https://gcc.gnu.org/onlinedocs/gcc/Function-Multiversioning.html >

[PATCH v2] LoongArch: Fix incorrect code generation for sad pattern

2023-12-14 Thread Jiahao Xu
When I attempt to enable vect_usad_char effective target for LoongArch, slp-reduc-sad.c and vect-reduc-sad*.c tests fail. These tests fail because the sad pattern generates bad code. This patch to fixed them, for sad patterns, use zero expansion instead of sign expansion for reduction.

[Bug tree-optimization/113013] [12/13/14 regression] ICE in fold_convert_loc with -fsanitize=undefined

2023-12-14 Thread rguenth at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113013 Richard Biener changed: What|Removed |Added Priority|P3 |P2

[Bug sanitizer/113012] [13/14 regression] ICE when building xorg-server with -fsanitize=undefined

2023-12-14 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113012 --- Comment #8 from Jakub Jelinek --- Slightly more readable testcase: int * foo (int x, int y, int z, int w) { int *p = __builtin_malloc (z * sizeof (int)); int *q = p - 1; while (--x > 0) { if (w + 1 > y) q = p - 1;

[PATCH 3/4; v2] opts: add logic to generate options-urls.cc

2023-12-14 Thread David Malcolm
Changed in v2: - split out from the code that uses this - now handles lang-specific URLs, as well as generic URLs - the generated options-urls.cc now contains a function with a switch statement, rather than an array, to support lang-specific URLs: const char * get_opt_url_suffix (int

[PATCH 4/4; v2] options: wire up options-urls.cc into gcc_urlifier

2023-12-14 Thread David Malcolm
Changed in v2: - split out from the code that generates options-urls.cc - call the generated function, rather than use a generated array - pass around lang_mask gcc/ChangeLog: * diagnostic.h (diagnostic_make_option_url_cb): Add lang_mask param.

[PATCH 0/4] v3 of: Option handling: add documentation URLs

2023-12-14 Thread David Malcolm
> Hi David, > > On Fri, Dec 08, 2023 at 06:35:56PM -0500, David Malcolm wrote: > > On Tue, 2023-11-21 at 23:43 +, Joseph Myers wrote: > > > On Tue, 21 Nov 2023, Tobias Burnus wrote: > > > > > > > On 21.11.23 14:57, David Malcolm wrote: > > > > > On Tue, 2023-11-21 at 02:09 +0100, Hans-Peter

[COMMITTED 1/4] libgrust: Add ChangeLog file

2023-12-14 Thread Arthur Cohen
From: Pierre-Emmanuel Patry libgrust/ChangeLog: * ChangeLog: New file. Signed-off-by: Pierre-Emmanuel Patry --- libgrust/ChangeLog | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 libgrust/ChangeLog diff --git a/libgrust/ChangeLog b/libgrust/ChangeLog new file mode

[COMMITTED 1/4] libgrust: Add ChangeLog file

2023-12-14 Thread Arthur Cohen
From: Pierre-Emmanuel Patry libgrust/ChangeLog: * ChangeLog: New file. Signed-off-by: Pierre-Emmanuel Patry --- libgrust/ChangeLog | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 libgrust/ChangeLog diff --git a/libgrust/ChangeLog b/libgrust/ChangeLog new file mode

[COMMITTED] Initial libgrust build patches

2023-12-14 Thread Arthur Cohen
Hi, This patchset contains the initial changes to add the libgrust folder to gcc, which will later contain libraries used by our Rust frontend. This work was done by Pierre-Emmanuel Patry as part of his work on supporting procedural macros in our frontend. It was then tested by Thomas Schwinge,

[COMMITTED] Initial libgrust build patches

2023-12-14 Thread Arthur Cohen
Hi, This patchset contains the initial changes to add the libgrust folder to gcc, which will later contain libraries used by our Rust frontend. This work was done by Pierre-Emmanuel Patry as part of his work on supporting procedural macros in our frontend. It was then tested by Thomas Schwinge,

Re: [PATCH] Middle-end: Do not model address cost for SELECT_VL style vectorization

2023-12-14 Thread Richard Biener
On Thu, 14 Dec 2023, Juzhe-Zhong wrote: > Follow Richard's suggestions, we should not model address cost in the loop > vectorizer for select_vl or decrement IV since other style vectorization > doesn't > do that. > > To make cost model comparison apple to apple. > This patch set COST from 2 to

[Bug tree-optimization/112941] during GIMPLE pass: bitintlower ICE: in handle_operand_addr, at gimple-lower-bitint.cc:2126 (gimple-lower-bitint.cc:2134) at -O with _BitInt()

2023-12-14 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112941 --- Comment #3 from Jakub Jelinek --- Simplified: unsigned _BitInt(2049) foo (unsigned _BitInt(6384) x, _BitInt(8) y) { return x * y; } _BitInt(2049) bar (unsigned _BitInt(6384) x, _BitInt(1023) y) { return x * y; }

[PATCH] tree-optimization/113018 - ICE with BB reduction vectorization

2023-12-14 Thread Richard Biener
When BB reduction vectorization picks up a chain with an ASM def in it and that's inside the vectorized region we fail to get its LHS. Instead of trying to get the correct def the following avoids vectorizing such def and instead keeps it as def to add in the epilog. Bootstrapped and tested on

[committed] Revert "RISC-V: Add avail interface into function_group_info"

2023-12-14 Thread Feng Wang
This reverts commit ce7e66787b5b4ad385b21756da5a89171d233ddc. Will refactor this part in the same way as aarch64 sve. gcc/ChangeLog: * config/riscv/riscv-vector-builtins-functions.def (DEF_RVV_FUNCTION): Revert changes.

[PATCH] Middle-end: Do not model address cost for SELECT_VL style vectorization

2023-12-14 Thread Juzhe-Zhong
Follow Richard's suggestions, we should not model address cost in the loop vectorizer for select_vl or decrement IV since other style vectorization doesn't do that. To make cost model comparison apple to apple. This patch set COST from 2 to 1 which turns out have better codegen in various codegen

[Bug sanitizer/113012] [13/14 regression] ICE when building xorg-server with -fsanitize=undefined

2023-12-14 Thread jakub at gcc dot gnu.org via Gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113012 --- Comment #7 from Jakub Jelinek --- Obviously we shouldn't ICE on this. But, saying 0 as usable size on such UB pointer is I think completely valid (making it clear that you can't really dereference such pointer nor anything derived from it,

  1   2   3   >