Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-25 Thread Yingchun Lai
The vote is now closed. It passes with 4 binding +1s and 1 binding -1, and I have fixed the issue of -1. I will work on the release steps next and send out the announcement after the site and mirrors are updated. Best regards, Yingchun Lai Yingchun Lai 于2021年6月12日周六 下午7:38写道: > Hi, all > >

Re:[VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-23 Thread Juan Pan
Hi +1 binding, due to DISCLAIMER-WIP. Looks front page issue has been fixed. Here is my check list, [x] Download links are valid. [x] Checksums and PGP signatures are valid. [x] LICENSE, NOTICE and DISCLAIMER-WIP exist. (NOTICE needs updating). [ ] All files have license headers if

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-22 Thread Yingchun Lai
I've removed these links from the front page, you can refresh your browser to check the latest version. Thanks, Yingchun Lai Justin Mclean 于2021年6月22日周二 下午1:42写道: > Hi, > > I’m not talking about the web site repo I’m talking about the code for the > Pegasus Java client [1] that is linked to

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-21 Thread Duo Zhang
Yes, the java client code has not been donated to ASF yet, as I mentioned above. The migration is expected to be done during incubation. Justin Mclean 于2021年6月22日周二 下午1:41写道: > Hi, > > I’m not talking about the web site repo I’m talking about the code for the > Pegasus Java client [1] that is

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-21 Thread Justin Mclean
Hi, I’m not talking about the web site repo I’m talking about the code for the Pegasus Java client [1] that is linked to from the front page. This particular issue is probably not a backer for this release but it would IMO be something that may stop the project from graduating. Thanks, Justin

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-21 Thread Yingchun Lai
> > Why is this being developed outside of the ASF? > Pegasus website is developed by this repo[1], we will fix these issues later, and the website's code isn't inclueded in this release source package. I‘m not sure if it is a blocker for this release? 1.

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-21 Thread Justin Mclean
Hi, Looking at the people involved there seems to be some overlap. Why is this being developed outside of the ASF? Kind Regards, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands,

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-21 Thread Justin Mclean
Hi, >> The hover text on the star icon still references https:// htts:// >> github.com/XiaoMi/pegasus, consider also changing it? >> > > Does the start icon matter? I thought only the releases matter. Yes it matters, you are linking to a non ASF product from the front page of an ASF site. [1]

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-21 Thread Yingchun Lai
> > The hover text on the star icon still references https:// htts:// > github.com/XiaoMi/pegasus, consider also changing it? > Does the start icon matter? I thought only the releases matter. 张铎(Duo Zhang) 于2021年6月22日周二 上午10:06写道: > The hover text on the star icon still references https://

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-21 Thread Duo Zhang
The hover text on the star icon still references https:// htts:// github.com/XiaoMi/pegasus, consider also changing it? Yingchun Lai 于2021年6月22日周二 上午9:56写道: > > > > I did actually. ASF release policy requires releases to be distributed > via > > dist.Apache.org . This

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-21 Thread Yingchun Lai
> > I did actually. ASF release policy requires releases to be distributed via > dist.Apache.org . This doesn’t matter if it’s on > the downloads page or the > landing page. You should not be distributing via GitHub > > Until that’s resolved here’s my -1 > Hi, John It has

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-21 Thread Yingchun Lai
> I was checking your vote on your dev list. It lists 4 binding votes, but I > can't find the listed voters on the Incubator PMC. For reference, only > IPMC votes are binding for releases, regardless of list they are voted on > (see [1] for reference). > > Did any of your mentors review this

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-20 Thread Liang Chen
Hi +1(binding). I checked: - incubating in name, all source files have ASF headers - signatures and hashes are ok - LICENSE and NOTICE are ok, the 'year' info of NOTICE need to update. - No binary files Regards Liang On 2021/06/12 11:38:22, Yingchun Lai wrote: > Hi, all > > This is a call

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-20 Thread Justin Mclean
Hi, +1 but only because of WIP disclaimer Only IPMC votes are binding on releases, projects often like to get 3+ PPMC votes on their releases on their dev list first, but you still need 3 IPMC +1 votes (and more +1s than -1s) to make a release. I’m also concerned about linking to a non ASF

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-20 Thread John D. Ament
On Sun, Jun 20, 2021 at 12:25 张铎(Duo Zhang) wrote: > You could try clicking the links, they will be redirected to the repo under > apache. Could file an issue to change the link on the homepage. The only > exception is for the Java client, it has not been donated to ASF yet, for > me I think the

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-20 Thread Duo Zhang
OK, the docker error is because of my env. After restarting the problem is gone. I could successfully build from source, and pack server, client and tools. Thanks. 张铎(Duo Zhang) 于2021年6月20日周日 下午10:56写道: > +1(binding) > > Checked sigs and sums: matched > LICENSE and NOTICE: in place >

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-20 Thread Duo Zhang
You could try clicking the links, they will be redirected to the repo under apache. Could file an issue to change the link on the homepage. The only exception is for the Java client, it has not been donated to ASF yet, for me I think the donation should be done during the incubation time. Thanks

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-20 Thread John D. Ament
On Sun, Jun 20, 2021 at 11:11 张铎(Duo Zhang) wrote: > For the 'binding' votes, we IPMC should have a formal statement then. > > > https://lists.apache.org/thread.html/r3ce608fdf36ba873154b6103739f9ad83b0d983de6a10a0fb329bff9%40%3Cgeneral.incubator.apache.org%3E > > See here, for the NuttX release

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-20 Thread Duo Zhang
For the 'binding' votes, we IPMC should have a formal statement then. https://lists.apache.org/thread.html/r3ce608fdf36ba873154b6103739f9ad83b0d983de6a10a0fb329bff9%40%3Cgeneral.incubator.apache.org%3E See here, for the NuttX release vote, an IPMC member challenged why the PPMC votes are not

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-20 Thread Duo Zhang
+1(binding) Checked sigs and sums: matched LICENSE and NOTICE: in place DISCLAIMER-WIP: in place Tried to build with docker: failed. Can not resolve any hostnames inside the container, not sure what is the problem and there is even no nslookup command. I just use the

Re: [VOTE] Release Apache Pegasus (Incubating) 2.2.0-RC0

2021-06-20 Thread John D. Ament
Hi I was checking your vote on your dev list. It lists 4 binding votes, but I can't find the listed voters on the Incubator PMC. For reference, only IPMC votes are binding for releases, regardless of list they are voted on (see [1] for reference). Did any of your mentors review this release?