Re: [Gluster-devel] NetBSD autobuild and cmockery2

2014-07-24 Thread Harshavardhana
This is The Right Way in my opinion. I think the current implementation should not have been merged, but I do not track changes close enough to had the opportunity to cast a -2 code review in time. Note that a voting NetBSD build would have catched it. This changes restores the build, we

Re: [Gluster-devel] NetBSD autobuild and cmockery2

2014-07-24 Thread Xavier Hernandez
Hi, On Thursday 24 July 2014 07:04:11 Justin Clift wrote: On 24/07/2014, at 5:05 AM, Emmanuel Dreyfus wrote: Harshavardhana har...@harshavardhana.net wrote: The change just disable cluster/ec when MMX is not there. If you have MMX you have cluster/ec. Unsure - there is assembly code

Re: [Gluster-devel] NetBSD autobuild and cmockery2

2014-07-24 Thread Justin Clift
On Thursday 24 July 2014 07:04:11 Justin Clift wrote: snip Surely there's some way we can make this work, such that the optimised assembler code is only used for cpu's the support it. With non-optimised C or something used for the others. I'm just working on it. The use of intel's SSE2

Re: [Gluster-devel] NetBSD autobuild and cmockery2

2014-07-24 Thread Emmanuel Dreyfus
Justin Clift jcl...@redhat.com wrote: As a thought is this hours or days or etc away? As we way in french Un tiens vaut mieux que deux tu l'auras, which translated into less now is better than perhaps more later -- Emmanuel Dreyfus http://hcpnet.free.fr/pubz m...@netbsd.org

[Gluster-devel] NetBSD autobuild and cmockery2

2014-07-23 Thread Emmanuel Dreyfus
Hi I am a bit furstrated by the status of NetBSD autobuilds: failures are ignored for now, which makes me wonder why I spent time setting it up :-) And ignoring it lets bugs pass through. Consider cmockery2 build: it does not work if cmockery headers and libraries and installed outside of

Re: [Gluster-devel] NetBSD autobuild and cmockery2

2014-07-23 Thread Justin Clift
On 23/07/2014, at 2:09 PM, Emmanuel Dreyfus wrote: snip I am a bit furstrated by the status of NetBSD autobuilds: failures are ignored for now, which makes me wonder why I spent time setting it up :-) Sorry about that Manu. :( The NetBSD autobuild has been configured to not vote so far, so

Re: [Gluster-devel] NetBSD autobuild and cmockery2

2014-07-23 Thread Emmanuel Dreyfus
On Wed, Jul 23, 2014 at 01:09:57PM +, Emmanuel Dreyfus wrote: I need help here: that restores the build, but I also had to fiddle with CFLAGS and LIBS, and I am not sure I did it it in the intended way. I am probbaly wrong since now glusterd breaks on startup because of cmockery2: Guard

Re: [Gluster-devel] NetBSD autobuild and cmockery2

2014-07-23 Thread Emmanuel Dreyfus
Harshavardhana har...@harshavardhana.net wrote: http://review.gluster.org/8366 Dependence on MMX instruction set It passes autobuild and alread +1, it should be easy to merge: Much needed, but i have NetBSD 6.0 still it compiles fine in a VM? don't you think enabling MMX would be

Re: [Gluster-devel] NetBSD autobuild and cmockery2

2014-07-23 Thread Luis Pabón
Hi Emmanuel. I have a bug and a fix where cmockery2 was being linked with all glusterfs applications. Maybe this fixes your issue: http://review.gluster.org/#/c/8340/ - Luis On 07/23/2014 11:47 AM, Emmanuel Dreyfus wrote: On Wed, Jul 23, 2014 at 01:09:57PM +, Emmanuel Dreyfus wrote: I

Re: [Gluster-devel] NetBSD autobuild and cmockery2

2014-07-23 Thread Emmanuel Dreyfus
Harshavardhana har...@harshavardhana.net wrote: The change just disable cluster/ec when MMX is not there. If you have MMX you have cluster/ec. Unsure - there is assembly code which depends on it but really not sure why! I understand this is an optimized computation: * Multiplications in a

Re: [Gluster-devel] NetBSD autobuild and cmockery2

2014-07-23 Thread Emmanuel Dreyfus
Luis Pabón lpa...@redhat.com wrote: Hi Emmanuel. I have a bug and a fix where cmockery2 was being linked with all glusterfs applications. Maybe this fixes your issue: http://review.gluster.org/#/c/8340/ I merged there my changes for cmockery outside of default search path, Let us see if