Re: [GNC-dev] Bug 796778 Feature Request Multiple Selection in Import- matcher

2018-08-22 Thread David Cousens
Forgot Link to Bug report and patch file https://bugs.gnucash.org/show_bug.cgi?id=796778 David - David Cousens -- Sent from: http://gnucash.1415818.n4.nabble.com/GnuCash-Dev-f1435356.html ___ gnucash-devel mailing list gnucash-devel@gnucash.org

Re: [GNC-dev] Bug 796778 Feature Request Multiple Selection in Import- matcher

2018-08-22 Thread David Cousens
Hi, I have attached a patch file with changes to gnucash/import-export/import-main-matcher.c and gnucash/gtkbuilder/dialog-import.glade for adding multiple selection capability to the import-matcher with the ability to assign a single transfer account to the selected transactions.

Re: [GNC-dev] Bug 796778 Feature Request Multiple Selection in Import- matcher

2018-08-13 Thread Geert Janssens
David Cousens schreef op 12 augustus 2018 23:53:09 CEST: > The barrier up to now has always been >finding my way round the code base but I found a program called >SourceTrail which is great for locating all the places a particular >variable structure or function is used. making tracking down

Re: [GNC-dev] Bug 796778 Feature Request Multiple Selection in Import- matcher

2018-08-12 Thread David Cousens
Rob, I think it was I who was missing something. I would have expected the Ctrl-click behaviour to be built in to the GTkTreeView and the dGTK developers obviously thought it was so obvious they didn't have to mention it. The pointers John gave me should help me sort it out. Thanks David

Re: [GNC-dev] Bug 796778 Feature Request Multiple Selection in Import- matcher

2018-08-12 Thread David Cousens
Thanks John,That cleared a few issues up for me. I'll have a look at the gnc- tree- view-account code to get some pointers. I have programmed before in C ,only a very little in C++, but I am fairly rusty . I was surprised to get a few things wokring without any problems so far. I am not sure

Re: [GNC-dev] Bug 796778 Feature Request Multiple Selection in Import- matcher

2018-08-12 Thread John Ralls
> On Aug 12, 2018, at 12:22 AM, David Cousens wrote: > > Hi, > > I raised the above bug as a feature request then I decided to try and tackle > it myself. My concept was to have a popup menu activated by a right click in > the matcher window area from which the user could enable and disable >

Re: [GNC-dev] Bug 796778 Feature Request Multiple Selection in Import- matcher

2018-08-12 Thread John Ralls
> On Aug 12, 2018, at 3:47 AM, David Cousens wrote: > > I am assuming here that the python GTK > implementation is an exact parallel of the C++ implementation. I would > expect it to be pretty similar and possibly just the C++ code in Python > wrappers. David, Gtk+ is written in C, not C++,

Re: [GNC-dev] Bug 796778 Feature Request Multiple Selection in Import- matcher

2018-08-12 Thread Robert Fewell
David, I may be missing some thing but you should be able to select lines by control, shift or by individual. I think what you are after can be shown in the reconcile view, multiple lines can be selected and then right moused to a menu. Anyway, enjoy your holiday... Bob On 12 August 2018 at

Re: [GNC-dev] Bug 796778 Feature Request Multiple Selection in Import- matcher

2018-08-12 Thread David Cousens
Bob, >From what I've read in the GtkTreeView documentation, the rubber-banding mode only seems to support selection by dragging the mouse so one is only able to select consecutive rows, not a group of single non-contiguous rows. I could of course be wrong on that. It obviously sets the

Re: [GNC-dev] Bug 796778 Feature Request Multiple Selection in Import- matcher

2018-08-12 Thread Robert Fewell
David, Why do you not as a start change the tree view selection from single to multiple, you will see that in the dialog-import.glade file, that way you can select multiple lines. You will need to alter the selection call back as you need different functions that use a list of selected rows. Bob

[GNC-dev] Bug 796778 Feature Request Multiple Selection in Import- matcher

2018-08-12 Thread David Cousens
Hi, I raised the above bug as a feature request then I decided to try and tackle it myself. My concept was to have a popup menu activated by a right click in the matcher window area from which the user could enable and disable multiple selection of transactions in the window and elect to assign a