Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

On Thu, May 19, 2016 at 11:15:51AM +0200, Vincent Bernat wrote: (...) > This is a backport for 1.5 of 3baab74e32ceec987e7ff3db1627b760bbac3027. Thank you Vincent. I merged the BUG/MINOR patch into 1.7 and 1.6, merged this one into 1.5 after fixing the commit ID above and adding a reference to the

Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

❦ 19 mai 2016 11:23 +0200, Cyril Bonté  : >> De: "Vincent Bernat" >> for (; port <= end; port++) { >> l = (struct listener *)calloc(1, sizeof(struct >> listener)); >> @@ -291,7 +291,7 @@ int str2listener(char *str, struct

Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

❦ 19 mai 2016 11:15 +0200, Vincent Bernat  : > This is a backport for 1.5 of > 3baab74e32ceec987e7ff3db1627b760bbac3027. Wrong commit number. This should be 6e6158. -- Keep it simple to make it faster. - The Elements of Programming Style (Kernighan & Plauger)

Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

Hi Vincent, > De: "Vincent Bernat" > for (; port <= end; port++) { > l = (struct listener *)calloc(1, sizeof(struct > listener)); > @@ -291,7 +291,7 @@ int str2listener(char *str, struct proxy > *curproxy, struct bind_conf *bind_conf, >

[PATCH] BUG/MAJOR: fix listening IP address storage for frontends

From: Vincent Bernat When compiled with GCC 6, the IP address specified for a frontend was ignored and HAProxy was listening on all addresses instead. This is caused by an incomplete copy of a "struct sockaddr_storage". With the GNU Libc, "struct sockaddr_storage" is defined

Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

On Thu, May 19, 2016 at 11:10:09AM +0200, Vincent Bernat wrote: > ??? 19 mai 2016 10:54 +0200, Willy Tarreau  : > > >> >> When compiled with GCC 6, the IP address specified for a frontend was > >> >> ignored and HAProxy was listening on all addresses instead. This is > >> >> caused

Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

❦ 19 mai 2016 10:54 +0200, Willy Tarreau  : >> >> When compiled with GCC 6, the IP address specified for a frontend was >> >> ignored and HAProxy was listening on all addresses instead. This is >> >> caused by an incomplete copy of a "struct sockaddr_storage". >> > >> > Patch

Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

On Thu, May 19, 2016 at 10:49:46AM +0200, Vincent Bernat wrote: > ??? 19 mai 2016 10:46 +0200, Willy Tarreau  : > > >> When compiled with GCC 6, the IP address specified for a frontend was > >> ignored and HAProxy was listening on all addresses instead. This is > >> caused by an

Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

❦ 19 mai 2016 10:46 +0200, Willy Tarreau  : >> When compiled with GCC 6, the IP address specified for a frontend was >> ignored and HAProxy was listening on all addresses instead. This is >> caused by an incomplete copy of a "struct sockaddr_storage". > > Patch applied to both

Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

On Wed, May 18, 2016 at 04:17:44PM +0200, Vincent Bernat wrote: > When compiled with GCC 6, the IP address specified for a frontend was > ignored and HAProxy was listening on all addresses instead. This is > caused by an incomplete copy of a "struct sockaddr_storage". (...) Patch applied to both

Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

Hi Arthur, On Thu, May 19, 2016 at 11:06:06AM +0300, Arthur ??i??eic?? wrote: > I tried again this morning with fresh eyes so this time a was able to > discover > the horror of web interfaces [1] that make "helpful" transformations like > > for @ together with random spaces around. Wow I

Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

Hi, În ziua de miercuri, 18 mai 2016, la 22:58:06 EEST, Cyril Bonté a scris: > Le 18/05/2016 22:52, Arthur Țițeică a écrit : > > În ziua de miercuri, 18 mai 2016, la 22:38:45 EEST, Cyril Bonté a scris: > >> It looks like you didn't recompile with USE_OPENSSL=1 > >> haproxy -vv should give some

Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

Le 18/05/2016 22:52, Arthur Țițeică a écrit : În ziua de miercuri, 18 mai 2016, la 22:38:45 EEST, Cyril Bonté a scris: It looks like you didn't recompile with USE_OPENSSL=1 haproxy -vv should give some hints. Indeed, sorry about that. And error on my build script. I fixed that, haproxy

Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

În ziua de miercuri, 18 mai 2016, la 22:38:45 EEST, Cyril Bonté a scris: > It looks like you didn't recompile with USE_OPENSSL=1 > haproxy -vv should give some hints. Indeed, sorry about that. And error on my build script. I fixed that, haproxy starts successfully but the issue remains, it still

Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

Hi, Le 18/05/2016 22:36, Arthur Țițeică a écrit : Hi all, În ziua de miercuri, 18 mai 2016, la 20:51:13 EEST, Willy Tarreau a scris: Thanks Vincent! It looks pretty good and very clean in the end. Arthur, as soon as you confirm it works for you I'll merge it. I'm keeping it untouched below

Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

Hi all, În ziua de miercuri, 18 mai 2016, la 20:51:13 EEST, Willy Tarreau a scris: > Thanks Vincent! > > It looks pretty good and very clean in the end. > Arthur, as soon as you confirm it works for you I'll merge it. I'm keeping > it untouched below in case you missed it. Something seems a bit

Re: [PATCH] BUG/MAJOR: fix listening IP address storage for frontends

Thanks Vincent! It looks pretty good and very clean in the end. Arthur, as soon as you confirm it works for you I'll merge it. I'm keeping it untouched below in case you missed it. Thanks, Willy On Wed, May 18, 2016 at 04:17:44PM +0200, Vincent Bernat wrote: > From: Vincent Bernat

[PATCH] BUG/MAJOR: fix listening IP address storage for frontends

From: Vincent Bernat When compiled with GCC 6, the IP address specified for a frontend was ignored and HAProxy was listening on all addresses instead. This is caused by an incomplete copy of a "struct sockaddr_storage". With the GNU Libc, "struct sockaddr_storage" is defined