Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2211
Hi,
There were a number of bugs and painful parts in the code, and
unfortunately I'm not really sure whether they are major blockers or easily
fixable. It surely wouldn't be an 1-2 day work
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/5479
Sure, I've added a test.
---
GitHub user ggevay opened a pull request:
https://github.com/apache/flink/pull/5479
[FLINK-8649] [scala api] Pass on TypeInfo in
StreamExecutionEnvironment.createInput
## What is the purpose of the change
In the Scala API, modify `StreamExecutionEnvironment.createInput
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/5121#discussion_r155927615
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/SourceFunction.java
---
@@ -34,17 +34,17 @@
* The run
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/5121#discussion_r154906923
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/SourceFunction.java
---
@@ -34,17 +34,17 @@
* The run
GitHub user ggevay opened a pull request:
https://github.com/apache/flink/pull/5041
[FLINK-8117] [runtime] [streaming] Eliminate modulo operation from round
robin partitioners
## What is the purpose of the change
This PR changes `RebalancePartitioner
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/5039
The Travis test fail is obviously unrelated. (It is FLINK-7431.)
---
GitHub user ggevay opened a pull request:
https://github.com/apache/flink/pull/5039
[hotfix][docs] Fix some typos in the documentation.
Just some trivial typo fixes in the documentation.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/3511
The `WeakHashMap` with the `WeakReferences` seem to be working correctly.
I've checked that the generated classes are reused from the cache inside a
single job, but are not reused across jobs
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r142032957
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MultipleProgramsTestBase.java
---
@@ -146,6 +151,7 @@ public
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/3511
> Can we simplify it to the code below?
> So, we don't need to introduce cacheHit variable.
Thanks @heytitle , done in ff3a35e93e858e30debcb1e85cc056045c1fe2a0 .
---
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r142032016
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MultipleProgramsTestBase.java
---
@@ -146,6 +151,7 @@ public
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/3511
> IMHO, in addition to these changes, there are still some potential
improvements we can do about the sorter, like deserialization when comparing
the real records.
Do you m
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/3511
Thanks @fhueske and @heytitle!
Most of the comments have been addressed. The two outstanding issues are
1. Addressing
https://github.com/apache/flink/pull/3511#discussion_r139933797
2
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140664772
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/3511
Oh, you are right @heytitle, thanks! Fixed in
9016cce503b4d471b5a49f0abccc196945ada97e
These `WeakReferences` are scary :)
---
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663665
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663639
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterTemplateModel.java
---
@@ -0,0 +1,424 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663635
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterTemplateModel.java
---
@@ -0,0 +1,424 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663591
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663593
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/NormalizedKeySorter.java
---
@@ -309,7 +309,7 @@ public boolean write(T record
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663604
--- Diff: flink-runtime/pom.xml ---
@@ -204,6 +204,18 @@ under the License.
reflections
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663599
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/TemplateManager.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663596
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
@@ -127,6 +127,12 @@
private long autoWatermarkInterval = 0
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663603
--- Diff: flink-runtime/pom.xml ---
@@ -204,6 +204,18 @@ under the License.
reflections
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140663585
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140662898
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,198 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140660299
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,198 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140660095
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -81,6 +81,7 @@
*/
private
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140659933
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed
GitHub user ggevay opened a pull request:
https://github.com/apache/flink/pull/4680
[FLINK-7629] [scala] Fix KeyedStream.aggregate for nested field expressions
## What is the purpose of the change
Make `KeyedStream.aggregate` (and `sum`, `maxBy`, etc.) able to handle
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r138905728
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/LargeRecordHandler.java
---
@@ -218,7 +221,7 @@ public long addRecord(T record
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r138904204
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerConfiguration.java
---
@@ -115,6 +115,13 @@ public Configuration
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r138899420
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/LargeRecordHandler.java
---
@@ -218,7 +221,7 @@ public long addRecord(T record
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/3511
I pushed some more commits to
[https://github.com/ggevay/flink/tree/sorter-codegen](https://github.com/ggevay/flink/tree/sorter-codegen).
@heytitle , could you please push them here? (Or you could
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/3511
Actually, now I'm thinking we should defer implementing code generation for
`FixedLengthRecordSorter` to after https://github.com/apache/flink/pull/2617 is
merged. What do you think @greghogan
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/3511
I'm not exactly sure how to do `FixedLengthRecordSorter`.
@greghogan , could you please clarify what you meant in the following?
> Rather than extending NormalizedKeySorter, we could p
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/3511
I pushed some commits here:
[https://github.com/ggevay/flink/tree/sorter-codegen](https://github.com/ggevay/flink/tree/sorter-codegen)
I fixed one issue by adding
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/3511
Thank @heytitle , I'll try to do the code generation for
`FixedLengthRecordSorter` tomorrow, and I will also take a look at the failing
tests.
Btw. you can force push (`git push -f
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/3511
Hi @heytitle,
What is the status here? I will be on vacation next week, so I would have
some time to work on this. Should I work on finishing this, or are you also
working on it? I would
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/4574
I agree with @zjureel . Even though I know the POJO rules well, it still
happened to me more than once that I accidentally had a non-POJO, and I only
noticed this because of these log messages, so I
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2628
> I transcribed Quicksort so as to remove considerations of Java
performance and inlining. It was not clear to me that if we encapsulated the
index, page number, and page offset into an obj
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2628#discussion_r84248344
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/QuickSort.java
---
@@ -49,20 +49,40 @@ protected static int getMaxDepth(int x
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2642
OK, I see your point now @StephanEwen.
@nssalian, I'm sorry for opening the jira; I didn't think it through from
this perspective at the time.
---
If your project is set up for it, you can reply
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2510
Sorry, I'm extremely busy these days. I'm not sure when will I have time,
unfortunately.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2642
Could you please explain why are the first and last commit
(65b3ff78f100ed1b13ec2fcc727f4869823b5918 and
ba4f429043f3985db5ab37a3902a6fee15a7440e) necessary? Are they related to
FLINK-3999
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
I have rebased now to the current master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2510#discussion_r79376690
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/JoinDriver.java
---
@@ -128,17 +130,22 @@ public void prepare() throws Exception
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2510#discussion_r79375332
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/AbstractIterativeTask.java
---
@@ -125,6 +125,16 @@ protected void initialize
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2510#discussion_r79373063
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/resettable/AbstractBlockResettableIterator.java
---
@@ -183,4 +183,24 @@ protected T
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2510#discussion_r79370262
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/JoinTaskIterator.java
---
@@ -68,4 +72,9 @@
* method signals
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2496#discussion_r79347709
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java ---
@@ -87,4 +87,6 @@
* @throws Exception Exceptions may
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2495
Btw. before submitting a pull request, it is good practice to run `mvn
clean verify` locally (or do a Travis build), and make sure that there are no
test failures (or, at least no test failures
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2495
The tests that are failing are in `flink-gelly-examples`, for example
`SingleSourceShortestPathsITCase`. They have error msgs that indicate memory
management errors, e.g.
`Caused
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2496#discussion_r79040795
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java ---
@@ -87,4 +87,6 @@
* @throws Exception Exceptions may
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2496#discussion_r79038567
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java ---
@@ -87,4 +87,6 @@
* @throws Exception Exceptions may
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2496#discussion_r79010283
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java ---
@@ -87,4 +87,6 @@
* @throws Exception Exceptions may
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2496#discussion_r79005879
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/Driver.java ---
@@ -87,4 +87,6 @@
* @throws Exception Exceptions may
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2496#discussion_r79003843
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/iterative/task/IterationIntermediateTask.java
---
@@ -82,43 +82,46 @@ protected void
Github user ggevay commented on the issue:
https://github.com/apache/flink/pull/2094
> As for this pull request I suggest to update the false Javadoc from the
streaming API and document in the concepts that the aggregation field accessors
and the keyselectors are slightly differ
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78775276
--- Diff: flink-core/src/main/resources/PojoSerializerTemplate.ftl ---
@@ -0,0 +1,445 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78750651
--- Diff: flink-examples/flink-examples-streaming/pom.xml ---
@@ -84,6 +84,11 @@ under the License.
test
test
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78708846
--- Diff: flink-core/pom.xml ---
@@ -76,6 +76,18 @@ under the License.
commons-collections
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78154021
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoComparatorGenerator.java
---
@@ -0,0 +1,191 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78153259
--- Diff:
flink-core/src/main/java/org/apache/flink/util/InstantiationUtil.java ---
@@ -71,13 +139,18 @@ public ClassLoaderObjectInputStream(InputStream
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78153106
--- Diff: flink-core/src/main/resources/PojoComparatorTemplate.ftl ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78151473
--- Diff: flink-examples/flink-examples-streaming/pom.xml ---
@@ -84,6 +84,11 @@ under the License.
test
test
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78149877
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/runtime/PojoSubclassSerializerTest.java
---
@@ -41,7 +41,6
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78149815
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerTest.java
---
@@ -50,7 +50,6 @@
@Override
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78138683
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerGenerator.java
---
@@ -0,0 +1,242 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78138160
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerGenerator.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78136985
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerGenerator.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78003840
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerGenerator.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78003691
--- Diff: flink-core/src/main/resources/PojoSerializerTemplate.ftl ---
@@ -0,0 +1,372 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78002589
--- Diff: flink-core/src/main/resources/PojoSerializerTemplate.ftl ---
@@ -0,0 +1,372 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78001809
--- Diff: flink-core/src/main/resources/PojoSerializerTemplate.ftl ---
@@ -0,0 +1,372 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r78000250
--- Diff: flink-core/src/main/resources/PojoComparatorTemplate.ftl ---
@@ -0,0 +1,195 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77999725
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoComparatorGenerator.java
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77996133
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerGenerator.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77995790
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/GenTypeSerializerProxy.java
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77995491
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/GenTypeComparatorProxy.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77995157
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/GenTypeComparatorProxy.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r7799
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -419,4 +481,61 @@ public String toString
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77993831
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -419,4 +481,61 @@ public String toString
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77993022
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -419,4 +481,61 @@ public String toString
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77993053
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -419,4 +481,61 @@ public String toString
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77992481
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -419,4 +481,61 @@ public String toString
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77992416
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -419,4 +481,61 @@ public String toString
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77992445
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -419,4 +481,61 @@ public String toString
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77991234
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +77,41 @@
private static final Pattern
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77990530
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -377,9 +425,11 @@ public void initializeTypeComparatorBuilder
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77990329
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerGenerator.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77990262
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoComparatorGenerator.java
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77990200
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/GenTypeSerializerProxy.java
---
@@ -0,0 +1,148 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77990034
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/GenTypeComparatorProxy.java
---
@@ -0,0 +1,174 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77989471
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoComparatorGenerator.java
---
@@ -0,0 +1,207 @@
+/*
+ * Licensed
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77988402
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -393,6 +443,18 @@ public void addComparatorField(int fieldId
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77987928
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +77,41 @@
private static final Pattern
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77987318
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +77,41 @@
private static final Pattern
Github user ggevay commented on a diff in the pull request:
https://github.com/apache/flink/pull/2211#discussion_r77987122
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/PojoTypeInfo.java
---
@@ -70,10 +77,41 @@
private static final Pattern
1 - 100 of 293 matches
Mail list logo
