[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-10-01 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r142032957 --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MultipleProgramsTestBase.java --- @@ -146,6 +151,7 @@ public

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-10-01 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r142032016 --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MultipleProgramsTestBase.java --- @@ -146,6 +151,7 @@ public

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140664772 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread heytitle
Github user heytitle commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140664033 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java --- @@ -0,0 +1,198 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140663665 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140663639 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterTemplateModel.java --- @@ -0,0 +1,424 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140663635 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterTemplateModel.java --- @@ -0,0 +1,424 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140663591 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140663593 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/NormalizedKeySorter.java --- @@ -309,7 +309,7 @@ public boolean write(T

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140663604 --- Diff: flink-runtime/pom.xml --- @@ -204,6 +204,18 @@ under the License. reflections + +

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140663599 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/TemplateManager.java --- @@ -0,0 +1,108 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140663596 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java --- @@ -127,6 +127,12 @@ private long autoWatermarkInterval = 0;

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140663603 --- Diff: flink-runtime/pom.xml --- @@ -204,6 +204,18 @@ under the License. reflections + +

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140663585 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140662898 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java --- @@ -0,0 +1,198 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread heytitle
Github user heytitle commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140662538 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java --- @@ -0,0 +1,198 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140660299 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java --- @@ -0,0 +1,198 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140660095 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java --- @@ -81,6 +81,7 @@ */ private

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140659933 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-24 Thread heytitle
Github user heytitle commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140659544 --- Diff: flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/drivers/DriverBaseITCase.java --- @@ -190,6 +190,7 @@ private String

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-21 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140258895 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/NormalizedKeySorter.java --- @@ -309,7 +309,7 @@ public boolean write(T

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-21 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140258675 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/NormalizedKeySorter.java --- @@ -47,61 +47,61 @@ public

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r139923767 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r139929372 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterTemplateModel.java --- @@ -0,0 +1,424 @@ +/* + * Licensed to

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r139918960 --- Diff: flink-runtime/pom.xml --- @@ -204,6 +204,18 @@ under the License. reflections + +

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r139911414 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/TemplateManager.java --- @@ -0,0 +1,108 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r139917275 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java --- @@ -127,6 +127,12 @@ private long autoWatermarkInterval = 0;

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r139927199 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r139906497 --- Diff: flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/drivers/DriverBaseITCase.java --- @@ -190,6 +190,7 @@ private String

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r139920526 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/NormalizedKeySorter.java --- @@ -309,7 +309,7 @@ public boolean write(T

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r139926078 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r139928885 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterTemplateModel.java --- @@ -0,0 +1,424 @@ +/* + * Licensed to

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r139910959 --- Diff: flink-runtime/pom.xml --- @@ -204,6 +204,18 @@ under the License. reflections + +

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r139933797 --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MultipleProgramsTestBase.java --- @@ -146,6 +151,7 @@ public

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-20 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r139926965 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java --- @@ -0,0 +1,174 @@ +/* + * Licensed to the

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-15 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r139186699 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerConfiguration.java --- @@ -115,6 +115,13 @@ public Configuration

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-14 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r138905728 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/LargeRecordHandler.java --- @@ -218,7 +221,7 @@ public long addRecord(T

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-14 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r138904204 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerConfiguration.java --- @@ -115,6 +115,13 @@ public Configuration

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-14 Thread ggevay
Github user ggevay commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r138899420 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/LargeRecordHandler.java --- @@ -218,7 +221,7 @@ public long addRecord(T

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-05-06 Thread heytitle
Github user heytitle commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r115130267 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/NormalizedKeySorter.java --- @@ -47,61 +47,61 @@ public