Github user GJL closed the pull request at:
https://github.com/apache/flink/pull/4980
---
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149993559
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -277,8 +287,12 @@ public void invoke() throws
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149985097
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -277,8 +287,12 @@ public void invoke() throws
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149984491
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -277,8 +287,12 @@ public void invoke() throws
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149983878
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -277,8 +287,12 @@ public void invoke() throws
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149982812
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -277,8 +287,12 @@ public void invoke() throws
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149955008
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -254,12 +300,10 @@ else if (this.error == null) {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149954849
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -254,12 +300,10 @@ else if (this.error == null) {
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149954606
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/DispatcherThreadFactory.java
---
@@ -29,21 +31,41 @@
private final
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149954576
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -58,99 +59,144 @@
import org.junit.Before;
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149947069
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -254,12 +300,10 @@ else if (this.error == null) {
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149947094
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -254,12 +300,10 @@ else if (this.error == null) {
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149949202
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -58,99 +59,144 @@
import org.junit.Before;
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149946930
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/DispatcherThreadFactory.java
---
@@ -29,21 +31,41 @@
private final
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149926517
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -58,99 +59,144 @@
import org.junit.Before;
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149703888
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -58,99 +59,144 @@
import org.junit.Before;
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149703482
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskStopTest.java
---
@@ -1,157 +0,0 @@
-/*
- * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149703349
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskStopTest.java
---
@@ -1,157 +0,0 @@
-/*
- * Licensed to the Apache
GitHub user GJL reopened a pull request:
https://github.com/apache/flink/pull/4980
[FLINK-8005] [runtime] Set user code class loader before snapshot
## What is the purpose of the change
*During checkpointing, user code may dynamically load classes from the user
code
Github user GJL closed the pull request at:
https://github.com/apache/flink/pull/4980
---
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149637696
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -58,99 +58,119 @@
import org.junit.Before;
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4980#discussion_r149637566
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -58,99 +58,119 @@
import org.junit.Before;
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/4980
[FLINK-8005] [runtime] Set user code class loader before snapshot
## What is the purpose of the change
*During checkpointing, user code may dynamically load classes from the user
code
jar.
23 matches
Mail list logo
