reswqa merged PR #24541:
URL: https://github.com/apache/flink/pull/24541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Sxnan commented on PR #24541:
URL: https://github.com/apache/flink/pull/24541#issuecomment-2123797964
@reswqa Thanks for the update! LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
reswqa commented on PR #24541:
URL: https://github.com/apache/flink/pull/24541#issuecomment-2123714167
Thanks @Sxnan for the review! I have updated this PR according to your
comments, PTAL again.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Sxnan commented on code in PR #24541:
URL: https://github.com/apache/flink/pull/24541#discussion_r1608053758
##
flink-datastream/src/main/java/org/apache/flink/datastream/impl/context/DefaultNonPartitionedContext.java:
##
@@ -18,23 +18,61 @@
package
reswqa commented on code in PR #24541:
URL: https://github.com/apache/flink/pull/24541#discussion_r1608050941
##
flink-datastream/src/main/java/org/apache/flink/datastream/impl/context/DefaultNonPartitionedContext.java:
##
@@ -18,23 +18,61 @@
package
Sxnan commented on code in PR #24541:
URL: https://github.com/apache/flink/pull/24541#discussion_r1608022155
##
flink-datastream/src/main/java/org/apache/flink/datastream/impl/context/DefaultNonPartitionedContext.java:
##
@@ -18,23 +18,61 @@
package
reswqa commented on code in PR #24541:
URL: https://github.com/apache/flink/pull/24541#discussion_r1607875012
##
flink-datastream/src/main/java/org/apache/flink/datastream/impl/context/DefaultNonPartitionedContext.java:
##
@@ -18,23 +18,61 @@
package
Sxnan commented on code in PR #24541:
URL: https://github.com/apache/flink/pull/24541#discussion_r1607724484
##
flink-datastream/src/main/java/org/apache/flink/datastream/impl/context/DefaultJobInfo.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation
reswqa commented on code in PR #24541:
URL: https://github.com/apache/flink/pull/24541#discussion_r1599450119
##
flink-core/src/main/java/org/apache/flink/api/common/operators/SlotSharingGroup.java:
##
@@ -137,6 +137,37 @@ public int hashCode() {
return result;
}
reswqa commented on code in PR #24541:
URL: https://github.com/apache/flink/pull/24541#discussion_r1599437315
##
flink-core-api/src/main/java/org/apache/flink/api/common/operators/SlotSharingGroupDescriptor.java:
##
@@ -0,0 +1,238 @@
+/*
+ * Licensed to the Apache Software
xintongsong commented on code in PR #24541:
URL: https://github.com/apache/flink/pull/24541#discussion_r1593914163
##
flink-datastream-api/src/main/java/org/apache/flink/datastream/api/context/NonPartitionedRuntimeContext.java:
##
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache
jeyhunkarimov commented on code in PR #24541:
URL: https://github.com/apache/flink/pull/24541#discussion_r1583695410
##
flink-core-api/src/main/java/org/apache/flink/api/common/operators/SlotSharingGroupDescriptor.java:
##
@@ -0,0 +1,238 @@
+/*
+ * Licensed to the Apache
reswqa commented on PR #24541:
URL: https://github.com/apache/flink/pull/24541#issuecomment-2062837816
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
reswqa commented on code in PR #24541:
URL: https://github.com/apache/flink/pull/24541#discussion_r1566991099
##
flink-datastream-api/src/main/java/org/apache/flink/datastream/api/context/TimestampManager.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software
reswqa commented on code in PR #24541:
URL: https://github.com/apache/flink/pull/24541#discussion_r1566988135
##
flink-datastream-api/src/main/java/org/apache/flink/datastream/api/context/StateManager.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation
reswqa commented on code in PR #24541:
URL: https://github.com/apache/flink/pull/24541#discussion_r1566978504
##
flink-datastream/src/main/java/org/apache/flink/datastream/impl/stream/ProcessConfigurableDataStream.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache
reswqa commented on code in PR #24541:
URL: https://github.com/apache/flink/pull/24541#discussion_r1566976014
##
flink-datastream-api/src/main/java/org/apache/flink/datastream/api/context/ProcessingTimeManager.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software
xintongsong commented on code in PR #24541:
URL: https://github.com/apache/flink/pull/24541#discussion_r1560578842
##
flink-core-api/src/main/java/org/apache/flink/api/common/operators/SlotSharingGroup.java:
##
Review Comment:
Resource, CPUResource, ExternalResource,
reswqa commented on PR #24541:
URL: https://github.com/apache/flink/pull/24541#issuecomment-2045077406
I have rebased this on master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
reswqa opened a new pull request, #24541:
URL: https://github.com/apache/flink/pull/24541
## What is the purpose of the change
*Implementation of FLIP-410. This PR will Introduce config, context and
processingTimerService for DataStream API V2.*
## Brief change log
flinkbot commented on PR #24541:
URL: https://github.com/apache/flink/pull/24541#issuecomment-2009426855
## CI report:
* 08547b7fa9baa619ec7b62bc893ccc6abcc86bb3 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
21 matches
Mail list logo
