Re: [PR] [FLINK-35128][cdc-connector][cdc-base] Re-calculate the starting changelog offset after the new table added [flink-cdc]

2024-04-25 Thread via GitHub
PatrickRen merged PR #3230: URL: https://github.com/apache/flink-cdc/pull/3230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-35128][cdc-connector][cdc-base] Re-calculate the starting changelog offset after the new table added [flink-cdc]

2024-04-17 Thread via GitHub
morazow commented on code in PR #3230: URL: https://github.com/apache/flink-cdc/pull/3230#discussion_r1569863282 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/meta/split/StreamSplit.java: ## @@ -163,10

Re: [PR] [FLINK-35128][cdc-connector][cdc-base] Re-calculate the starting changelog offset after the new table added [flink-cdc]

2024-04-17 Thread via GitHub
morazow commented on code in PR #3230: URL: https://github.com/apache/flink-cdc/pull/3230#discussion_r1569850914 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/meta/split/StreamSplit.java: ## @@ -163,10

Re: [PR] [FLINK-35128][cdc-connector][cdc-base] Re-calculate the starting changelog offset after the new table added [flink-cdc]

2024-04-17 Thread via GitHub
loserwang1024 commented on code in PR #3230: URL: https://github.com/apache/flink-cdc/pull/3230#discussion_r1569794515 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/meta/split/StreamSplit.java: ## @@

Re: [PR] [FLINK-35128][cdc-connector][cdc-base] Re-calculate the starting changelog offset after the new table added [flink-cdc]

2024-04-17 Thread via GitHub
yuxiqian commented on code in PR #3230: URL: https://github.com/apache/flink-cdc/pull/3230#discussion_r1568608219 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/meta/split/StreamSplit.java: ## @@ -159,7

Re: [PR] [FLINK-35128][cdc-connector][cdc-base] Re-calculate the starting changelog offset after the new table added [flink-cdc]

2024-04-17 Thread via GitHub
loserwang1024 commented on code in PR #3230: URL: https://github.com/apache/flink-cdc/pull/3230#discussion_r1568614060 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/meta/split/StreamSplit.java: ## @@

Re: [PR] [FLINK-35128][cdc-connector][cdc-base] Re-calculate the starting changelog offset after the new table added [flink-cdc]

2024-04-16 Thread via GitHub
loserwang1024 commented on PR #3230: URL: https://github.com/apache/flink-cdc/pull/3230#issuecomment-2060235695 @PatrickRen , @morazow , CC -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [FLINK-35128][cdc-connector][cdc-base] Re-calculate the starting changelog offset after the new table added [flink-cdc]

2024-04-16 Thread via GitHub
loserwang1024 opened a new pull request, #3230: URL: https://github.com/apache/flink-cdc/pull/3230 In mysql cdc, re-calculate the starting binlog offset after the new table added in MySqlBinlogSplit#appendFinishedSplitInfos, while there lack of same action in