[GitHub] [nifi] mcgilman commented on a diff in pull request #5671: NIFI-9514 NIFI-9515: Add UI support for Parameter Providers in Controller Services

2022-09-23 Thread GitBox
mcgilman commented on code in PR #5671: URL: https://github.com/apache/nifi/pull/5671#discussion_r968676295 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-parameter-provider.js: ## @@ -0,0 +1,2778 @@ +/* + *

[GitHub] [nifi] exceptionfactory commented on pull request #6445: NIFI-10532 ensuring client gets reset if any of the key values host/p…

2022-09-23 Thread GitBox
exceptionfactory commented on PR #6445: URL: https://github.com/apache/nifi/pull/6445#issuecomment-1256821855 Thanks @joewitt, agreed, re-evaluating the approach at a higher level sounds like a good topic for a separate issue. -- This is an automated message from the Apache Git Service.

[GitHub] [nifi] joewitt commented on pull request #6445: NIFI-10532 ensuring client gets reset if any of the key values host/p…

2022-09-23 Thread GitBox
joewitt commented on PR #6445: URL: https://github.com/apache/nifi/pull/6445#issuecomment-1256821429 haha - yeah already pushed (force) the PORT PORT PORT thing. I also thought about the hashing which would be a fine approach. But I'd do that as part of what appears to be a lot of

[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6445: NIFI-10532 ensuring client gets reset if any of the key values host/p…

2022-09-23 Thread GitBox
exceptionfactory commented on code in PR #6445: URL: https://github.com/apache/nifi/pull/6445#discussion_r979130928 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java: ## @@ -580,12 +587,23

[jira] [Created] (NIFI-10541) PutSFTP listing logic fails when credentials/location come from flow file attributes

2022-09-23 Thread Joe Witt (Jira)
Joe Witt created NIFI-10541: --- Summary: PutSFTP listing logic fails when credentials/location come from flow file attributes Key: NIFI-10541 URL: https://issues.apache.org/jira/browse/NIFI-10541 Project:

[GitHub] [nifi] joewitt commented on pull request #6445: NIFI-10532 ensuring client gets reset if any of the key values host/p…

2022-09-23 Thread GitBox
joewitt commented on PR #6445: URL: https://github.com/apache/nifi/pull/6445#issuecomment-1256818257 The issue doesnt appear to occur on the previous version though the change should close the risk and also tests to work well. Testing did reveal that file listing logic doesn't work

[GitHub] [nifi] joewitt commented on pull request #6445: NIFI-10532 ensuring client gets reset if any of the key values host/p…

2022-09-23 Thread GitBox
joewitt commented on PR #6445: URL: https://github.com/apache/nifi/pull/6445#issuecomment-1256803484 Verified behavior before was not correct. Verified behavior after is working as expected. Verified logic in provided example from NII-10532 before/after specifically for FTP processors.

[GitHub] [nifi] joewitt commented on pull request #6445: NIFI-10532 ensuring client gets reset if any of the key values host/p…

2022-09-23 Thread GitBox
joewitt commented on PR #6445: URL: https://github.com/apache/nifi/pull/6445#issuecomment-1256603422 need to do some manual testing now on before/after. Have only walked through the code and made suggeste change. Will share details soon -- This is an automated message from the Apache

[GitHub] [nifi] joewitt opened a new pull request, #6445: NIFI-10532 ensuring client gets reset if any of the key values host/p…

2022-09-23 Thread GitBox
joewitt opened a new pull request, #6445: URL: https://github.com/apache/nifi/pull/6445 …ort/user/pw change on a per ff basis # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking

[jira] [Updated] (NIFI-10540) Use single Checkstyle configuration file to configure Maven and Intellij Checkstyle plugins

2022-09-23 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-10540: Description: In the [Contributor

[jira] [Updated] (NIFI-10540) Use single Checkstyle configuration file to configure Maven and Intellij Checkstyle plugins

2022-09-23 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-10540: Summary: Use single Checkstyle configuration file to configure Maven and Intellij

[jira] [Updated] (NIFI-10540) Use single Checkstyle configuration file to configure Maven and Intellij Checkstyle plugins

2022-09-23 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-10540: Priority: Trivial (was: Minor) > Use single Checkstyle configuration file to configure

[jira] [Updated] (NIFI-10540) Use Checkstyle configuration file to allow configuring Maven and Intellij Checkstyle plugins

2022-09-23 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-10540: Priority: Minor (was: Major) > Use Checkstyle configuration file to allow configuring

[jira] [Assigned] (NIFI-10540) Use Checkstyle configuration file to allow configuring Maven and Intellij Checkstyle plugins

2022-09-23 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz reassigned NIFI-10540: --- Assignee: Daniel Stieglitz > Use Checkstyle configuration file to allow configuring

[jira] [Created] (NIFI-10540) Use Checkstyle configuration file to allow configuring Maven and Intellij Checkstyle plugins

2022-09-23 Thread Daniel Stieglitz (Jira)
Daniel Stieglitz created NIFI-10540: --- Summary: Use Checkstyle configuration file to allow configuring Maven and Intellij Checkstyle plugins Key: NIFI-10540 URL: https://issues.apache.org/jira/browse/NIFI-10540

[jira] [Commented] (NIFI-10532) PutFTP does not group the batch by user name

2022-09-23 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608864#comment-17608864 ] Joe Witt commented on NIFI-10532: - If hostname, port, username, or password as evaluated against each

[jira] [Resolved] (NIFI-5717) FTPTransfer can't connect to different users in a same host

2022-09-23 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt resolved NIFI-5717. Resolution: Duplicate > FTPTransfer can't connect to different users in a same host >

[jira] [Commented] (NIFI-10473) Parameter Provider Fetch REST call authorization check is too restrictive

2022-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608863#comment-17608863 ] ASF subversion and git services commented on NIFI-10473: Commit

[GitHub] [nifi] mcgilman merged pull request #6388: NIFI-10473: Removing referencing components check on param provider f…

2022-09-23 Thread GitBox
mcgilman merged PR #6388: URL: https://github.com/apache/nifi/pull/6388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [nifi] markobean commented on pull request #6254: NIFI-10287 ExecuteScript - Allow python scripts to use external modules

2022-09-23 Thread GitBox
markobean commented on PR #6254: URL: https://github.com/apache/nifi/pull/6254#issuecomment-1256482258 Unit test looks good. I built the code (including -Pcontrib-check), and all looks good. I tested by instantiating an ExecuteScript processor. It was configured with a module directory

[jira] [Updated] (NIFI-10532) PutFTP does not group the batch by user name

2022-09-23 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-10532: Priority: Critical (was: Major) > PutFTP does not group the batch by user name >

[jira] [Updated] (NIFI-10532) PutFTP does not group the batch by user name

2022-09-23 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-10532: Fix Version/s: 1.18.0 > PutFTP does not group the batch by user name >

[jira] [Assigned] (NIFI-10532) PutFTP does not group the batch by user name

2022-09-23 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt reassigned NIFI-10532: --- Assignee: Joe Witt > PutFTP does not group the batch by user name >

[jira] [Commented] (NIFI-10532) PutFTP does not group the batch by user name

2022-09-23 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608850#comment-17608850 ] Joe Witt commented on NIFI-10532: - likely impacts PutFTP, PutSFTP, FetchFTP, FetchSFTP. > PutFTP does

[jira] [Created] (NIFI-10539) PutEmail with chinese characters has erroneous values in attachment when using Big5 character set

2022-09-23 Thread Emilio Setiadarma (Jira)
Emilio Setiadarma created NIFI-10539: Summary: PutEmail with chinese characters has erroneous values in attachment when using Big5 character set Key: NIFI-10539 URL:

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1391: MINIFICPP-1846 - Json configuration support part 1

2022-09-23 Thread GitBox
fgerlits commented on code in PR #1391: URL: https://github.com/apache/nifi-minifi-cpp/pull/1391#discussion_r976409031 ## libminifi/include/Defaults.h: ## @@ -19,12 +19,14 @@ #ifdef WIN32 #define DEFAULT_NIFI_CONFIG_YML "\\conf\\config.yml" +#define DEFAULT_NIFI_CONFIG_JSON

[jira] [Commented] (NIFI-10532) PutFTP does not group the batch by user name

2022-09-23 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608844#comment-17608844 ] Joe Witt commented on NIFI-10532: - Hello it would never group them by their values. As a flowfile comes

[jira] [Created] (NIFI-10538) UI changes to support RegsitryClient as an extension point

2022-09-23 Thread Shane Ardell (Jira)
Shane Ardell created NIFI-10538: --- Summary: UI changes to support RegsitryClient as an extension point Key: NIFI-10538 URL: https://issues.apache.org/jira/browse/NIFI-10538 Project: Apache NiFi

[jira] [Commented] (NIFI-10526) NiFi 1.15.2 -- GUI freezing when remote process group loses connection

2022-09-23 Thread Evan Falkenstine (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608810#comment-17608810 ] Evan Falkenstine commented on NIFI-10526: - Roger that. A newer version isn't necessarily an

[GitHub] [nifi] tpalfy commented on pull request #6435: NIFI-10528 Extrat JSON record readers to util module for use in Salesforce NAR

2022-09-23 Thread GitBox
tpalfy commented on PR #6435: URL: https://github.com/apache/nifi/pull/6435#issuecomment-1256343815 LGTM Thanks for the improvement @bbende! Merged to main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (NIFI-10528) Extract JSON readers to util module for use in Salesforce NAR

2022-09-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17608800#comment-17608800 ] ASF subversion and git services commented on NIFI-10528: Commit

[GitHub] [nifi] asfgit closed pull request #6435: NIFI-10528 Extrat JSON record readers to util module for use in Salesforce NAR

2022-09-23 Thread GitBox
asfgit closed pull request #6435: NIFI-10528 Extrat JSON record readers to util module for use in Salesforce NAR URL: https://github.com/apache/nifi/pull/6435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (NIFI-10532) PutFTP does not group the batch by user name

2022-09-23 Thread Christoph Langheld (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christoph Langheld updated NIFI-10532: -- Affects Version/s: 1.17.0 > PutFTP does not group the batch by user name >

[jira] [Created] (NIFI-10537) "Summary bar" does not compute remote processor connections

2022-09-23 Thread Jira
Michal Šunka created NIFI-10537: --- Summary: "Summary bar" does not compute remote processor connections Key: NIFI-10537 URL: https://issues.apache.org/jira/browse/NIFI-10537 Project: Apache NiFi

[GitHub] [nifi] turcsanyip commented on a diff in pull request #6158: NIFI-10152 Storage client caching in Azure ADLS processors

2022-09-23 Thread GitBox
turcsanyip commented on code in PR #6158: URL: https://github.com/apache/nifi/pull/6158#discussion_r978594087 ## nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/utils/DataLakeServiceClientFactory.java: ## @@ -0,0

[jira] [Resolved] (NIFI-10530) MiNiFi C2 Request Compression

2022-09-23 Thread Ferenc Kis (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Kis resolved NIFI-10530. --- Resolution: Fixed > MiNiFi C2 Request Compression > - > >

[jira] [Resolved] (NIFI-10536) Getting java.lang.LinkageError when integrating Nifi with Hashicorp Vault

2022-09-23 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-10536. --- Fix Version/s: 1.18.0 Assignee: David Handermann Resolution: Duplicate >

[jira] [Created] (NIFI-10536) Getting java.lang.LinkageError when integrating Nifi with Hashicorp Vault

2022-09-23 Thread Ruchit Mathur (Jira)
Ruchit Mathur created NIFI-10536: Summary: Getting java.lang.LinkageError when integrating Nifi with Hashicorp Vault Key: NIFI-10536 URL: https://issues.apache.org/jira/browse/NIFI-10536 Project:

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1417: MINIFICPP-1834 Add VERSIONINFO resource file

2022-09-23 Thread GitBox
fgerlits commented on code in PR #1417: URL: https://github.com/apache/nifi-minifi-cpp/pull/1417#discussion_r978522773 ## versioninfo.rc.in: ## @@ -0,0 +1,44 @@ +#include + +#define VER_FILEVERSION

[GitHub] [nifi] Lehel44 commented on a diff in pull request #6379: NIFI-10463: Fix GetHubSpot incremental loading

2022-09-23 Thread GitBox
Lehel44 commented on code in PR #6379: URL: https://github.com/apache/nifi/pull/6379#discussion_r978444386 ## nifi-nar-bundles/nifi-hubspot-bundle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java: ## @@ -187,61 +243,122 @@ private String

[GitHub] [nifi] Lehel44 commented on a diff in pull request #6379: NIFI-10463: Fix GetHubSpot incremental loading

2022-09-23 Thread GitBox
Lehel44 commented on code in PR #6379: URL: https://github.com/apache/nifi/pull/6379#discussion_r978438425 ## nifi-nar-bundles/nifi-hubspot-bundle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java: ## @@ -187,61 +243,122 @@ private String

[GitHub] [nifi] Lehel44 commented on a diff in pull request #6379: NIFI-10463: Fix GetHubSpot incremental loading

2022-09-23 Thread GitBox
Lehel44 commented on code in PR #6379: URL: https://github.com/apache/nifi/pull/6379#discussion_r978434795 ## nifi-nar-bundles/nifi-hubspot-bundle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/GetHubSpot.java: ## @@ -187,61 +243,122 @@ private String

[GitHub] [nifi] ferencerdei commented on a diff in pull request #6434: NIFI-10493 MiNiFi: Add C2 handler for Transfer/Debug operation

2022-09-23 Thread GitBox
ferencerdei commented on code in PR #6434: URL: https://github.com/apache/nifi/pull/6434#discussion_r978388502 ## c2/c2-client-bundle/c2-client-service/src/main/java/org/apache/nifi/c2/client/service/operation/DebugOperationHandler.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1412: MINIFICPP-1923 Refactor PutUDP to use asio

2022-09-23 Thread GitBox
martinzink commented on code in PR #1412: URL: https://github.com/apache/nifi-minifi-cpp/pull/1412#discussion_r978385514 ## extensions/standard-processors/processors/PutUDP.cpp: ## @@ -107,48 +98,48 @@ void PutUDP::onTrigger(core::ProcessContext* context, core::ProcessSession*

[GitHub] [nifi-minifi-cpp] martinzink commented on pull request #1412: MINIFICPP-1923 Refactor PutUDP to use asio

2022-09-23 Thread GitBox
martinzink commented on PR #1412: URL: https://github.com/apache/nifi-minifi-cpp/pull/1412#issuecomment-1255926012 I've moved from only IPv4 only mode to IPv6, I also modified ListenTCP and ListenSyslog processors aswell. This is effectively fixes a separate ticket aswell. So could you

[jira] [Created] (NIFI-10535) MiNiFi C2 Service - Remove heartbeat, config request content type restriction

2022-09-23 Thread Ferenc Erdei (Jira)
Ferenc Erdei created NIFI-10535: --- Summary: MiNiFi C2 Service - Remove heartbeat, config request content type restriction Key: NIFI-10535 URL: https://issues.apache.org/jira/browse/NIFI-10535 Project:

[GitHub] [nifi] turcsanyip commented on a diff in pull request #6379: NIFI-10463: Fix GetHubSpot incremental loading

2022-09-23 Thread GitBox
turcsanyip commented on code in PR #6379: URL: https://github.com/apache/nifi/pull/6379#discussion_r977962708 ## nifi-nar-bundles/nifi-hubspot-bundle/nifi-hubspot-processors/src/main/java/org/apache/nifi/processors/hubspot/HubSpotObjectType.java: ## @@ -18,97 +18,107 @@