Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v3]

2023-11-07 Thread Joe Darcy
On Thu, 2 Nov 2023 11:58:23 GMT, Jim Laskey wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove .orig files > > Re .orig. Thank you Alan. @JimLaskey , please "/issue add JDK-8319133" to include the annotation

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v15]

2023-11-07 Thread Mandy Chung
On Tue, 7 Nov 2023 16:19:33 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v14]

2023-11-07 Thread Jim Laskey
On Tue, 7 Nov 2023 15:51:22 GMT, Alan Bateman wrote: >> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 899: >> >>> 897: /* >>> 898: * Return type so that launcher invokes the correct main >>> 899: */ >> >> If you are doing anymore edits then I think this method

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v15]

2023-11-07 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v14]

2023-11-07 Thread Alan Bateman
On Tue, 7 Nov 2023 15:45:02 GMT, Alan Bateman wrote: >> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 14 additional >> commits

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v14]

2023-11-07 Thread Alan Bateman
On Tue, 7 Nov 2023 12:29:12 GMT, Jim Laskey wrote: >> Address changes from JEP 445 to JEP 463. >> >> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. >> >> - Don't mark class on read. >> >> - Remove reflection and annotation processing related to unnamed classes. >> >> -

Integrated: 8317937: @sealedGraph: Links to inner classes fails in links

2023-11-07 Thread Chen Liang
On Fri, 20 Oct 2023 17:22:10 GMT, Chen Liang wrote: > This fixes the links to nested classes like `ValueLayout.OfLong` in the > rendered sealed class hierarchy graph. > > A similar problem with nested classes exist for `@sealedGraph` on them, where > their graphs will be generated to a wrong

Re: RFR: JDK-8315458 Implementation of Implicitly Declared Classes and Instance Main Method (Second Preview) [v14]

2023-11-07 Thread Jim Laskey
> Address changes from JEP 445 to JEP 463. > > - Move from a SYNTHETIC unnamed class to a MANDATED implicit class. > > - Don't mark class on read. > > - Remove reflection and annotation processing related to unnamed classes. > > - Simplify main method search. Jim Laskey has updated the pull